- 22 Jun, 2020 40 commits
-
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: Iac915ebeb50c6f6acd96934605151b3aaace5f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255647Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#780916}
-
Xi Han authored
Bug: 1094417 Change-Id: Ieb212577bff0654bf23d1f84214a4b347ff3a6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257271Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780915}
-
Andrey Kosyakov authored
This reverts commit 6cd73389. Reason for revert: re-landing as this was a wrong suspect. Original change's description: > Revert "Remove/replace unnecessary includes of logging.h (ipc/)" > > This reverts commit 26d83272. > > Reason for revert: suspected cause of build failure on linux (https://ci.chromium.org/p/chromium/builders/ci/linux-ozone-rel/124191) > > Original change's description: > > Remove/replace unnecessary includes of logging.h (ipc/) > > > > If the file just needs the CHECK/CHECK_OP/NOTREACHED > > macros, use the appropriate header for that instead. > > Or if logging.h is not needed at all, remove it. > > > > This is both a nice cleanup (logging.h is a big header, > > and including it unnecessarily has compile-time costs), > > and part of the final step towards making logging.h no > > longer include check.h and the others. > > > > Bug: 1031540 > > Change-Id: Ic0d59407e28200355332852d290f18441d6f678e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253980 > > Auto-Submit: Hans Wennborg <hans@chromium.org> > > Commit-Queue: Tom Sepez <tsepez@chromium.org> > > Reviewed-by: Tom Sepez <tsepez@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780828} > > TBR=hans@chromium.org,tsepez@chromium.org > > Change-Id: I780f92bca95aabcc845393ed4635e837e47aeb50 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1031540 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257738 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780846} TBR=hans@chromium.org,caseq@chromium.org,tsepez@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1031540 Change-Id: Ifd1f23d43442644071f610e9a1432d97714779e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257565Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780914}
-
Ben Pastene authored
It's failing on all *-full builders: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/27044 https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/44138 Bug: 1097630 Change-Id: I0196d510c55a78991c1ee02a8e9347077d3c63bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256847 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Ali Juma authored
This moves a helper method for checking the name of the currently running test method to ChromeTestCase, removing duplication in GoogleServicesSettingsTestCase and DemographicsTestCase. Bug: None Change-Id: Iadb41ad7dc31156f0da8a7c9481f032eca5fbe2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257260 Auto-Submit: Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#780912}
-
Ben Pastene authored
The devices they run on are continuously flashed to CrOS ToT, so running branched Chrome on ToT CrOS can cause issues. So this removes all CrOS HW tests from the branch builders. VM tests will still run, and CrOS CI will still have CrOS-branch testing done. Bug: 1097132 Change-Id: Ica19d0180baff979ac82fc68ad8947e94d0aee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254703Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#780911}
-
Behdad Bakhshinategh authored
This reverts commit 1ea229b3. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1097957 Original change's description: > Update device directories to allow gtests to run on R > > The external storage root path is currently used as the location to > write test runner output, but this path is no longer writable by apps > on Android R. Update to use DeviceUtils' GetAppWritablePath() instead > of GetExternalStoragePath() to support test execution on this version. > > Bug: 1094062 > Change-Id: Ie90c46d4ed0c3e421d83c8d0ae8edee047f2dcac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242845 > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780836} TBR=wittman@chromium.org,torne@chromium.org,jbudorick@chromium.org,hypan@google.com Change-Id: I39e2858ca7932ff5d79b6ed45391564410caa437 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258118Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#780910}
-
James Cook authored
This allows working on mojo connections without deploying both binaries to a device. * Avoid DCHECK when calling lacros_process_.Pid() on a null process handle * Forward ash-chrome's XDG_RUNTIME_DIR because on linux we can't write to /run/chrome * Use a subdir of the ash-chrome user-data-dir instead of a hard-coded path You can now launch lacros-chrome via the shelf icon if you run ash-chrome like this: XDG_RUNTIME_DIR=/tmp/ash_chrome_xdg_runtime ./out/Default/chrome --user-data-dir=/tmp/chrome --enable-wayland-server --no-startup-window --login-manager --enable-features=LacrosSupport --lacros-chrome-path=/w/chrome/src/out/LacrosDesktop Bug: none Change-Id: I94a5319174b5952cb6605bf2243821e51ae30ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255032 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#780909}
-
Henrique Nakashima authored
The shortener is Chrome-specific. It replaces: "org.chromium.chrome.browser.foo" with ".c.b.foo" Also git ignore json_graph.txt Bug: 1093962 Change-Id: Id1d84f7b2478672c7db6ef6370bb86654687cdc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254096 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#780908}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b93c9d1a5342..026624613287 2020-06-22 fmayer@google.com Do not revisit nodes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:159602022 Tbr: perfetto-bugs@google.com Change-Id: I261332aa1b2d07c2e8b59fa12e865da859a3db63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780907}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fbd2c6337c39..3dfa4226ce8e 2020-06-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I85d3b9092ca773d94e868ef9d342559d371a8267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257250Reviewed-by:
-
Scott Violet authored
The TtsEngineDelegate can easily be saved in content. No need to require the delegate to do it. BUG=1025626 TEST=none Change-Id: Iab9c63a5a1d66a0545453066ada57f644375d15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255220 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780905}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592830246-d0465e2a89f6ad20ad72129fb481528f24bd31c6.profdata to chrome-win32-master-1592837653-5b7e97ced591379a1b30497a668a8e346b61359c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I81257de5ecf0ed3e4858b0816d8d0ef075d430c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257248Reviewed-by:
-
Brandon Mousseau authored
Cast & AndroidTV requires an implementation of PlaybackEventsRecorder. The existing Fuchsia implementation has no platform specific code, so this change refactors the implementation to be included on Cast for AndroidTV. Aside from updating class locations and names, the only change to the PlaybackEventRecorder is replacing a Sprintf that was using a format specifier string to print an int64_t incompatible on 32 bit builds. This has been replaced with base::StrCat and base::NumberToString. Bug: 1094550 Test: media_unittests Change-Id: Id05df5b051a1146d68649d17047eec232806e810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244121Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Brandon Mousseau <bmoose@google.com> Cr-Commit-Position: refs/heads/master@{#780903}
-
Takumi Fujimoto authored
Accept media status current_time and duration values that are ints. Bug: 10962766, b/159253654 Change-Id: I3ca514b91e3f0c7e1ac6c2178d81cc68de55ae22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253279Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#780902}
-
Bo Liu authored
Fixed: 1096736 Change-Id: I18f84514dafc627b728c1665b2888b492f3eaf65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254080Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780901}
-
Alison Maher authored
This is a reland of d877aabe Original change : https://chromium-review.googlesource.com/c/chromium/src/+/2213727 Revert of original change : https://chromium-review.googlesource.com/c/chromium/src/+/2245593 ----- The original change was reverted due to web test crashes observed on linux-webkit-msan-rel. The reason for these crashes was that default_containing_block_.direction was not initialized, and yet was used by LayoutFragmentainerDescendant(). To fix this, use the TextDirection of the containing_block_fragment as the default direction in this case rather than default_containing_block_.direction. This also required updating GetContainingBlockInfo() to use the TextDirection of containing_block_fragment, as well. A follow-up change is in-progress to complete the rest of logic needed to get the correct ContainingBlockInfo: https://chromium-review.googlesource.com/c/chromium/src/+/2248619/2. ----- Original change's description: > [LayoutNG] Delay layout of positioned nodes during fragmentation > > When fragmenting positioned nodes, instead of placing them as soon as > they reach their containing block, continue to bubble the positioned > nodes up to the fragmentation context root. There, they will be placed > and properly fragmented. > > This change does not implement the actual layout algorithm for > fragmented positioned nodes. As a result, this will cause test > failures. > > Bug: 1079031 > Change-Id: I3ca2f3fb669c8463ab1fc877ad510ff62526ecbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213727 > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778177} Bug: 1079031 Change-Id: Id0cccfbf471ae78073feb57e8dd1dd1390979b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246550Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780900}
-
Darin Fisher authored
In debug builds, mojo::Remote<T>::Bind(..) asserts that it is not already bound. In release builds, it just carries forward and re-binds without complaining. It turns out that the Hangouts extension can trigger this assertion in the WebRTC logging code. The fix is pretty simple. Just reset() the mojo::Remote<T> before calling Bind. This CL also includes a similar fix for the renderer- side code. Bug: 992329 Change-Id: I60d1af701248c0af2b36625c0b53d103088d1c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244119 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch addresses a situations we can get into if our contain-intrinsic-size is significantly different from the actual size of content. We basically can get the element into the viewport when locked and out of the viewport when unlocked. In that situation, we may start alternating locking and unlocking the same element _unless_ we have a good scroll anchor which breaks the cycle. On a scrollbar scroll though, we can get into a situations where we select a bad anchor that does not shift any content. The workaround proposed here is to select a new anchor when an 'auto' element gets locked. Note that the user can also get out of the cycle by scrolling which causes us to select a new anchor. R=chrishtr@chromium.org Change-Id: I1d9c6de665b606a88e54d8bf8f163cef1808547e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249725Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780898}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/09867d37ed3c..30a3e787948d 2020-06-22 kwiberg@webrtc.org iSAC encoder: Make it possible to change target bitrate at any time If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2f19ca89cb057a47811a4d581974007be86a7662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257736Reviewed-by:
-
Tina Wang authored
- Added PopupMenuTextItem.h/mm for a general textual TableViewItem in the menu. - Created a PopupMenuTextItem for enterprise information in popup_menu_mediator. - Added a section to the popupToolsMenu when: - Settings UI flag is enabled - One or more prefs is managed by policy. - Added the action to the enterprise info item. The action will be: doing nothing. Bug: 1084692 Change-Id: I25158a432b0b319b7f9a2c298e7ab05692fbff63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250661 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#780896}
-
Liquan (Max) Gu authored
Before: PaymentHandler components' internal callbacks were wired through view's constructors After: PaymentHandler components' internal callbacks were wired through callbacks in their model. Change: * Remove the listeners that passed through PaymentHandlerToolbarView and PaymentHandlerView's constructors. * Add the listeners into PaymentHandlerProperties, PaymentHandlerToolbarProperties. * Set these listeners in either coordinators or mediators. Change-Id: I40309f7c22ef9e7a3d95bb47efdcc096bd4575f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255398Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#780895}
-
Bailey Berro authored
Change-Id: I2b127a634d658393ba51ad366ca3ff51611c3c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255178 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#780894}
-
Peter Kasting authored
* Make more things const. * Remove |starting_drag_| member by making |drag_start_point_| an Optional. * Reduce nesting by reordering conditionals. Bug: none Change-Id: I1910ddf86af8d1545095f7b9a7e3d5c7c8ad6653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255386Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#780893}
-
Jack Lynch authored
This CL enables a browser test that was added to the DevTools frontend here: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2244468/ Bug: 174309 Change-Id: I728e0ccaf368c65cb7814c1d71ae16426d307f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246552 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780892}
-
Kyle Horimoto authored
Applies to connected Wi-Fi and Cellular networks. Fixed: 1096893 Change-Id: I3bb4880d791f352ddf468aaeeabc362669d8aac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255129 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Katie D authored
This extension will be used by any ash accessibility feature which wants some information about the accessibility tree. This is a pure rename with no functional changes. AX-Relnotes: n/a Bug: 960373 Change-Id: I2ca9db321fce6c44dfb374ca3c690986591acd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252037Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#780890}
-
Hans Wennborg authored
This reverts commit 1359efcc. Reason for revert: It broke angle_deqp tests on Linux, see second bug. Original change's description: > Roll clang n356902-4e813bbd-1 : n357772-7f0d7f32-1. > > Ran `./tools/clang/scripts/upload_revision.py 7f0d7f32631648acf48bc23047635ab5e2058a1a`. > > Bug: 1094943 > Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng > Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng > Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan > Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel > Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng > Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 > Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 > Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel > Cq-Include-Trybots: chrome/try:iphone-device,ipad-device > Cq-Include-Trybots: chrome/try:linux-chromeos-chrome > Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome > Change-Id: Ie5f06745147ec69033616b4ef8a7ee2dc8ca8d2b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252882 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780681} TBR=hans@chromium.org,thakis@chromium.org Change-Id: I53030baae6b5040062b37ec2bd8abefcb79511fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094943, 1097758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258013 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
(1) The correct verb is "add" in this context. (2) This setting is available on the "Wi-Fi networks" subpage, not the Wi-Fi details page. Additionally, it's always available when Wi-Fi is on, but this was previously only shown when connected to Wi-Fi. These issues have been fixed. Fixed: 1096878 Change-Id: Iced6e1aeca811948ee04b3068f0d03a9aaeb8af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255665 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: -
Eric Seckler authored
crrev.com/c/2245906 introduced a bug that effectively disabled all CPU time UMA collection, because the "collection_in_progress_" flag was set but never cleared (doh). This patch moves the setting of the flag to the correct place, just before the collection task is posted. Bug: 1081760 Test: Run chrome_public_apk locally & check chrome://histograms. Change-Id: Iee1f4ebdf7cf179b6662c2d9225a215ede062119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257972 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780887}
-
Antonio Gomes authored
... until it is actually needed. This CL changes MediaStreamVideoWebRtcSink to operate over MediaStreamComponent, but can not completely get rid of the use of WebMediaStreamTrack. It mainly delays convert from the former to the later, until the Blink API boundary is crossed. BUG=704136 R=guidou@chromium.org Change-Id: I6a33cc7f0b2c9191d4e5e21947577997d992b659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257539Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/956ec8a8bcdd..0f396991929a 2020-06-22 bsalomon@google.com Reland "Make it easier to test rectangle textures by using createBackendTexture." 2020-06-22 jvanverth@google.com Revert "Fill in GrD3DGpu::onUpdateBackendTexture" 2020-06-22 jlavrova@google.com Fixing line metrics (baseline) - de-coupled from ICU CL 2020-06-22 michaelludwig@google.com Reland "Centralize geometry processor vertex shader transform code" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I8b6cc45048ea32c4eb011a43a80e27b3762e91dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257241Reviewed-by:
-
Efi Mavroudi authored
This adds histograms Printing.CUPS.TotalNetworkPrintersCount and Printing.CUPS.NearbyNetworkPrintersCount which will record the number of detected network printers in a user's network and the number of them that are not already saved, respectively. Histograms will be recorded when the user navigates to the OS Settings Printing page. It extends the CupsPrintersManager API to emit the relevant histograms with public API method: RecordNearbyNetworkPrinterCounts. Bug: chromium:1012515 Test: unit tests Change-Id: Ifa5f111c3815feb81b1a07b9b6a719a8ada3c8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241029Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#780884}
-
Andrey Kosyakov authored
This reverts commit e5a8add0. Reason for revert: broke linux-builder-perf (https://ci.chromium.org/p/chrome/builders/ci/linux-builder-perf/195450) Original change's description: > Split kaleidoscope resources in two > > Split the kaleidoscope resources and strings > into two since they are going to be moved > around. > > BUG=1087037 > > Change-Id: Iee08832b837a18bbb102fcd8cc6ea98c5dbdf819 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254706 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780879} TBR=huangs@chromium.org,beccahughes@chromium.org Change-Id: I30a25492a00eee513da252d41623e95406c5185a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1087037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257996Reviewed-by:
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I14514c7113321deb5e73de77a1f7ed18b77e02a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255119 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
David Van Cleve authored
We're rolling Trust Tokens (https://bit.ly/trust-token-dd) out so we can start its origin trial. (The feature is gated behind both an origin trial and a base::Feature; see [1] for a longer description of the rollout strategy.) This CL updates the field trial testing config to enable the `TrustTokens` feature with the configuration we're using during the rollout. [1] https://groups.google.com/a/chromium.org/g/blink-api-owners-discuss/c/WY17UlZFG3g R=chromium-metrics-reviews@google.com Bug: 1036483 Change-Id: If9cb0611d0f2f236f99918326ce5ee33c991df25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255649Reviewed-by:
-
Ovidio Henriquez authored
This change adds a Site Settings entry for Web Bluetooth device permissions. The design document has screenshots of the new UX. Design doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/edit#heading=h.gnepnkwadman Bug: 659337 Change-Id: I36879ec04e1769fedc37ebc08a48f8affa432499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194722 Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#780880}
-
Becca Hughes authored
Split the kaleidoscope resources and strings into two since they are going to be moved around. BUG=1087037 Change-Id: Iee08832b837a18bbb102fcd8cc6ea98c5dbdf819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254706 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
Mark external/wpt/editing/other/white-spaces-after-execCommand-delete.tentative.html as flaky t/o on Mac10.13 Bug: 1097810 Change-Id: I0d5cc6ba6ab908968c14cd59f3e5e6a8f7570299 TBR: behdadb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257456Reviewed-by:
-
Xing Liu authored
This CL reads DownloadSchedule from in progress download db. Bug: 1078454 Change-Id: Icec7eed9edb38ce526cd60b72de90aaeac817335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253150Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780877}
-
