- 11 Aug, 2020 40 commits
-
-
Alex Turner authored
This should improve performance when fonts are quickly cycled as the repeated calls to Time::Now() were (somewhat) slow. Bug: 1110204 Change-Id: I861288f9470157cc349e41a0e124c95cba6a381a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333378 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#796986}
-
Stephen Roe authored
The standard chrome-fuchsia test scripts use "system_log" instead of "system.log". Bug: 1113982 Change-Id: I8ff7a8f1310010751c573bd452253d2d86848d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347969Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#796985}
-
Caroline Rising authored
This is hidden behind a feature flag. This change adds a new button to the bookmarks bar which opens an empty bubble containing a WebView. Create a ReadingListModelFactory for desktop use. Bug: 1109316 Change-Id: I028bf4e584b32fb532980ccfb7c5ca42d7093092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335641 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#796984}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: Icf1f7733b29d90c056435b649284c35f5a6c25f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348770 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#796983}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/21e5b4554a5f..0376edf14e58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I36cae4135135e0ba1370f399b35c657e415c0806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796982}
-
Xiqi Ruan authored
Report metrics of session engagement started event and session engagement hours, which helps us understand users' usage on chromeos, and improve family users' experience. Metrics from abnormally terminated sessions will be skipped. Bug: 1103081 Change-Id: I62a0f5f245a660e01ced68a7b6af627a18e64edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297703 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796981}
-
bttk authored
With this change StatusView.getEndPaddingPixelSizeForFocusState() can now be private. Bug: 1109369 Change-Id: Ied30cd7cadbf1d06bfd2fa1a80b01379ddff2929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335642Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#796980}
-
Livvie Lin authored
Update RecordSingleDecisionToMetrics and RecordSingleInteractionToMetrics to use a simpler API, which now supports non-constant histogram names. Change-Id: Iae63351d0ce6915841f48b614aad7a22f12839ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347319Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796979}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/49983ef4e7de..a70445f40898 2020-08-11 jmbetancourt@google.com reland: configure attributes for SkottieView to be initialized from XML layout 2020-08-11 herb@google.com use SkIPoint for positions in GrTextBlob 2020-08-11 bsalomon@google.com Remove Adreno must-do-copies-from-origin workaround 2020-08-11 robertphillips@google.com Non-substantive changes to small path rendering classes 2020-08-11 bsalomon@google.com Remove incorrect 1 pixel opt. in GrInterpretFilterQuality. 2020-08-11 johnstiles@google.com Fix implementation of SkDEBUGFAILF in SkSL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1112139,chromium:1113233 Tbr: fmalita@google.com Change-Id: Icd1cf8798ac213a6d444d66e786d1fc7a3e502ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349400Reviewed-by:
-
Gary Tong authored
This reverts commit 4421e3c9. Reason for revert: Going to try to make arm64 compile on 10.13 Original change's description: > Infra: Use Mac 10.15 machines for mac-arm64-rel tryjob > > Bug: 1106950 > Change-Id: I69a3a8df07f40d0cc24de3f85212e51d5945bd46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350149 > Auto-Submit: Gary Tong <gatong@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796959} TBR=estaab@chromium.org,gbeaty@chromium.org,gatong@chromium.org Change-Id: I3a6e9f78e3990113d3bfb059c0d2977e9d04fbac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350141Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/21e5b4554a5f..0376edf14e58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ica1ba55888d56eece5a7d4672afce451a696a7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349910Reviewed-by:
-
Sammie Quon authored
We try to update visibility in constructor which then checks for widget in GetEffectiveVisibility. The initialize local state code looks like it can be done after the shelf pod is added to a widget so move it there. Test: manual Change-Id: Ic7c2e7856ed76dce9008a6ad9f9c735ce1a05d81 Fixed: 1115191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349403Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#796975}
-
Peter Kotwicz authored
This CL: - Makes WebappLauncherActivity set the correct URI on the launch intent for WebAPKs - Renames WebappIntentUtils#getId() to make it clear that it only applies to homescreen shortcuts - Moves WebappRegistry#webApkIdForPackage() to WebappIntentUtils alongside WebappIntentUtils#getIdForHomescreenShortcut() - Adds a boolean parameter to WebApkValidator#disableValidationForTesting() for the sake of tests which need to keep validation enabled. BUG=1114560 TEST=WebappLauncherActivityTest.* R=peconn TBR=sky (For trivial change to MapsGoFirstRunTest.java ) Change-Id: I615b1aca48b4a0c626a1e02613c58e9bdebc44ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348050 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#796974}
-
Kevin Ellis authored
Per spec (https://drafts.csswg.org/css-transitions-2/#event-dispatch) a transitioncancel should be fired on the following phase change not idle and not after --> idle Previously we were only test for not idle --> idle, meaning that a finished transition could erroneously trip a transitioncancel. Bug: 979556 Change-Id: Iecd6c8d2a7ca4564925910f092fca4c78b6d79da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348416 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796973}
-
Choongwoo Han authored
This fixes build failure of `autoninja all` Bug: 1076336 Change-Id: I7c073acb2fb98a4b608768e8a862246721acbb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346649Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Choongwoo Han <choongwoo.han@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796972}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Idc48b0654294a1bd044bbfe204b9d70e5aea6f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349470Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#796971}
-
David Bokan authored
This CL begins the process of splitting input handling out of LayerTreeHostImpl. To keep things simple and easy to review, this CL is a mostly mechanical disentangling of input code into a new class, ThreadedInputHandler. The class still lives in layer_tree_host_impl.cc and is still tightly coupled with it. Future CLs will move this into a separate file and put up proper interfaces between compositing and input. For now there is no behavioral changes, the two classes delegate calls to each other as appropriate. The ThreadedInputHandler has methods shadowing the InputHandler interface, and LayerTreeHostImpl now delegates to it, but ThreadedInputHandler doesn't yet implement the interface. A future CL will make it implement InputHandler and pass it around instead of LTHI. The end state is to have ThreadedInputHandler be a standalone object used by InputHandlerProxy to affect input-related changes. This split deliberately leaves anything graphics or animation related in LTHI. Bug: 915926 Change-Id: Iabc08c03fb618b1f7e9406b5ab7fa7ab64d60913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347371Reviewed-by:
-
Becca Hughes authored
Adds empty Chrome Kaleidoscope NTP module as a placeholder. BUG=1114862 Change-Id: Iee00259b9848394ead7d6b80cb1d311f07a5abcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347909 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#796969}
-
Jesse McKenna authored
This change makes the "Open" option in the downloads bar act like "Show in Folder" for files without file extensions on Windows. This fixes an issue where Chrome could unexpectedly open the wrong file when attempting to open an extensionless file while an executable of the same name was present in the Downloads folder. For example, downloading and opening "somefile" while "somefile.exe" was already present in Downloads would result in "somefile.exe" being run. This behavior is due to Windows' shell open functionality, which appears to have special logic to interpret extensionless commands as potential executables. Prior to this change, if an extensionless file was opened without an executable of the same name present (the more common scenario), Windows would display error "No application is associated with the specified file for this operation", so this change does not remove any functionality apart from the ability to trigger this error popup. Showing the extensionless file in folder sets the user up nicely to open the file however they want from Windows Explorer via right-click > Open With. Bug: 1092518 Change-Id: I1a3bb519867548c916070cbfebd64d0017f5937b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321528 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796968}
-
Ryan Hansberry authored
Change-Id: I06270079771302e8d9542e012078e0f844d32896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349287 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#796967}
-
Dan Sanders authored
Previously we set the limit to zero, meaning no limit, but FFmpeg 4.3 will not allocate at all with that setting. Changed to std::numeric_limits<size_t>::max(). Bug: 1095962 Change-Id: I96820c21f794f2814e955ee75ff22dfd31804c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349405Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#796966}
-
Victor Costan authored
Bug: 1068710 Change-Id: Id150b86cb4532ab0d51e4a314573641d8ba2fef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348334 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#796965}
-
Sebastien Lalancette authored
Fixes the bad behavior in three components: - History - Reading List - Bookmarks Bug: 1093302 Change-Id: Ia81bfd270e898c3061eb7ad061cc5aea338dc947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349270Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#796964}
-
Liviu Tinta authored
On Mac, tiltY is positive when the pen is tilted away from the user. Based on Pointer Event spec, tiltY should be positive when the pen is tilted towards the user. On Mac, by default Y increases going up, while in Chromium Y increases going down. NSView has isFlipped property which controls if Y increases going up (false) or going down (true). In order to fix the bug, we check NSView's isFlipped flag and if it is false we reverse the sign of tiltY to accommodate the difference in the direction of Y. Bug: 1111347 Change-Id: I108ba496adc6f951277e1c9ddb7eaf6483e522f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348544Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#796963}
-
Lukasz Anforowicz authored
This CL adds a DCHECK to RenderFrameHostManager::GetFrameHostForNavigation to make sure that the |dest_site_instance| computed earlier is in the same BrowsingInstance as the frame's parent: DCHECK(!parent || dest_site_instance->IsRelatedSiteInstance( parent->GetSiteInstance())); Bug: 1107269 Change-Id: I89b79e93e8435f12a51bf3e49472a44ce7ddb47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347074 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#796962}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0376edf14e58..f07b5182eeda 2020-08-11 hjd@google.com Merge "Add cpuhp ftrace events" 2020-08-11 simonmacm@google.com We're in a for loop so don't return. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:163530191 Tbr: perfetto-bugs@google.com Change-Id: I490535d91bf44e7e31681c4dddcd9083e3def10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349404Reviewed-by:
-
James Cook authored
Also move it and AshChromeServiceImpl into namespace crosapi. This is consistent with our plan for interface names from go/lacros-main-dd. Bug: none Change-Id: Ice369bd8da4ebdc9de4de2a69ce7a457ed13968a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349888 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796960}
-
Gary Tong authored
Bug: 1106950 Change-Id: I69a3a8df07f40d0cc24de3f85212e51d5945bd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350149 Auto-Submit: Gary Tong <gatong@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#796959}
-
Yusuke Sato authored
Previously, the code had 10 boilerplate code for starting/stopping Upstart jobs for ARCVM. This CL reduce the amount of such code by allowing the adapter to pass a list of jobs to start/stop to the helper function. BUG=None TEST=try Change-Id: I3f95dcd1b482a7ae3204ed00d9644bd89f508c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343376 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#796958}
-
Chong Gu authored
Remove the need for --device arg on our FYI and CI bots. Change-Id: I8115f2d2246b1385d8695926a84a8df51c833214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277422Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#796957}
-
Piotr Bialecki authored
(potential) Fix for flakiness has already landed, but the test got disabled before that happened. This CL will reenable the test. In case the fix is not sufficient to get rid of flakiness, the test logic will have to be rewritten. Bug: 1112773 Change-Id: Ifeb07c6b9cf30e587d7804f0b3af9e345e550c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346923 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b969adbdff1..ae8f8fdcda03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC slightlyoff@google.com,ellyjones@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: slightlyoff@google.com,ellyjones@google.com Change-Id: I1b1e147930d54898ef08cced93496a30b1608132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349393Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796955}
-
Rouslan Solomakhin authored
This is a reland of b772a8f1 Original patch: https://crrev.com/c/2341163 Revert: https://crrev.com/c/2348532 Reason for revert: New WPT test revealed a memory issue in //third_party/blink/renderer/modules/payments/payments_validators.cc when serializing data larger than than 1MB into JSON. Reason for reland: Split out the large data serialization tests into a separate patches for fixing the JSON serialization issue separately: 1) https://crrev.com/c/2348411 2) https://crrev.com/c/2348540 3) https://crrev.com/c/2346973 Original change's description: > [Web Payment] Secure payment confirmation Blink parameters. > > Before this patch, requesting "secure-payment-confirmation" method in > PaymentRequest API would not validate the parameters. > > This patch adds the "secure-payment-confirmation" parameters to > PaymentRequest API and validates them, if the > "SecurePaymentConfirmation" feature is enabled. > > After this patch, PaymentRequest API validates the secure payment > confirmation parameters. > > Explainer: https://github.com/rsolomakhin/secure-payment-confirmation > Feature status: https://chromestatus.com/feature/5702310124584960 > Intent to prototype: > https://groups.google.com/a/chromium.org/g/blink-dev/c/myUR5gyd5Js/m/iELL67NQAgAJ > > Bug: 1110324 > Change-Id: I7a4b6f9da1b3e1d7604bcd9e4733dc789f77ec4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341163 > Reviewed-by: Nick Burris <nburris@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796792} TBR=ellyjones, nburris, kouhei Bug: 1110324, 1115091 Change-Id: I05ebdbfe234d3bee8ceb2016dafc5679a9a28ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348410 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#796954}
-
ckitagawa authored
This is an alternative/complimentary change to http://crrev.com/c/2346905 Using First Meaningful Paint has two benefits. 1. It waits for key content to paint. 2. It doesn't wait for total loading to stop just down to a couple network requests. This is good in that we stop showing the preview earlier (which is desirable if the page is actually painted sooner). I think both this and LoadingProgress are feasible. This one is more promising in the sense that it takes a guess as to when the painting is mostly done whereas the PageLoadProgress variant is mostly about network requests being done. One option might be to combine the two and take the later of the signals? With these changes it might be worth making the removal delay 0 ms or at least smaller. Bug: 1110360 Change-Id: I6c4400166d0bfef57160424de2238bcbe238949a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346863Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#796953}
-
Liviu Tinta authored
Intent to Ship link: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/ZRI-7X_4GwM/Sp1ZMIw5AgAJ Bug: 1069500 Change-Id: I01630006c2eebb1fdb0b09a08af59cf230ed33f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343385Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#796952}
-
Dave Tapuska authored
AutoResize only worked for the top level widget. Move the handling from RenderWidget into WebViewFrameWidget. BUG=1097816 Change-Id: I66f18640531676c688fe3ee149ed253d4f01c0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317807Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Gang Wu authored
This CL enable copy image by default before enable copy image experiment to 100%. Bug: 1043329 Change-Id: Iad07f1bf496449f8e02e24f3a3d9de8f3a8dec57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298180Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
-
Zhongyi Shi authored
Bug: 1114590, 1090532 Change-Id: Ic149aa63ee65fe2f78c4bb8f28497677ec4ac4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347325 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Content scripts can specify if they should be injected in about:-scheme frames or use the effective origin as a fallback in the case of e.g. opaque frames. Currently, these are stored in two separate booleans on the user script. Instead, use a single enum to track this behavior, with three settings: match, don't match, or match and climb the frame tree for about: frames (the latter is necessary for the current behavior of about:blank). Update UserScript and references appropriately, and add additional unit test coverage for match_about_blank and use_origin_as_fallback. This CL does not change behavior for match_about_blank. match_origin_as_fallback now matches both data: and about: schemes. Bug: 55084 Change-Id: I3a52a244a8a6b0b3535608d8a6551aa94057aa22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343312 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796948}
-
John Lee authored
Bug: 973674 Change-Id: I88427bb8259bda94af6550228e7925212df791a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341178Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#796947}
-
