GitLab

To align spec.src.json with other parts of common/security-features/
such as common.js.

Generated files will be updated after some more changes, not now.

Bug: 906850
Change-Id: I87479bcf8ec6cdbf08e10a38a79885940b51e457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716109
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681065}

This CL sets up the build flags to exclude supervised user code from
Linux/Mac/Windows platforms.

Bug: 980869
Change-Id: I25a4a64c46a0e8ac6beb4a88d144571180bdc55d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713868
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681064}

https://pdfium.googlesource.com/pdfium.git/+log/7a6d5b768672..7734ba9a7d52


git log 7a6d5b768672..7734ba9a7d52 --date=short --no-merges --format='%ad %ae %s'
2019-07-25 tsepez@chromium.org Avoid small mallocs for CPDF_Font::FormFactoryIface.
2019-07-25 tsepez@chromium.org Remove unused CFWL_WidgetTP::m_dwRefCount.
2019-07-25 tsepez@chromium.org Mark fxcrt::RetainPtr<>::m_nRefCount as mutable.


Created with:
  gclient setdep -r src/third_party/pdfium@7734ba9a7d52

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: Iea95fc25e2947341f6239b4d28f1038f57a6c368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717775Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681063}

In order to prevent corner cases/timing issue related to session state
change, adding a check when showing the opt-in dialog.

Bug: 978267
Test: Run existing tests
Change-Id: I9f84e5fc90ba8d50407fa44a29749406ae1b2db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717464Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681062}

To use common names in referrer-policy and
mixed-content tests.

The final goal is to rename all to `source_scheme` (which is done in
https://chromium-review.googlesource.com/c/chromium/src/+/1718991).
This CL renames first `source_scheme` to `source_protocol`,
just to avoid rebasing in a long chain of commits.

Generated files will be updated after some more changes, not now.

Bug: 906850
Change-Id: Ic89e60e8a5f2f2780ad416ef189cfc5d1ad1b16e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717115
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681061}

If we don't have tilings, then we will append a checkerboard quad. In
those cases, use scale 1.f to have more stable to-screen-space mapping,
eliminating error exaggeration we might get from layer size rounding.

See the referenced bug for more details.

R=enne@chromium.org

Bug: 986110
Change-Id: I8781077c81442466b0e91b71c5d8149a2d2bda79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717917Reviewed-by: enne <enne@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681060}

No change to logic, only docs.

This updates the class doc for AndroidStreamReaderURLLoader, since the
doc was written back when it only supported shouldInterceptRequest. This
adds documentation for the known subclasses of ResponseDelegate, to
clarify which production cases they actually cover.

Test: None
Change-Id: Ib04e7dc6a43b548856d5bc2d41d9addabe824029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717440Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681059}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: I4324d438bb053cadc733abe0febb645c06dc0d16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700916Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681058}

This CL rewrites `opt_in_method` so that both
mixed-content and referrer-policy tests uses
`delivery_type` and `delivery_value`.

Mapping:

| Before this CL    | After this CL                  |
| opt_in_method     | delivery_type | delivery_value |
+-------------------+---------------+----------------+
| "no-opt-in"       | "meta"        | null           |
| "meta-csp"        | "meta"        | "opt-in"       |
| "http-csp"        | "http-rp"     | "opt-in"       |
| "img-crossorigin" | Removed                        |

"img-crossorigin" was removed because it was not implemented.

Generated files will be updated after some more changes, not now.

Bug: 906850
Change-Id: I4ea4571ee1c1312fe8fbc35590548a8021141258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717107
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681057}

MEMORY_SANITIZER_INITIAL_SIZE is defined exactly if
MEMORY_TOOL_REPLACES_ALLOCATOR is defined, so just use this instead.
This reverts https://codereview.chromium.org/357603002/ which split
this for deep memory profiler, but we haven't used that in years.

While here, also change vector.h to no longer honor WTF_VECTOR_INITIAL_SIZE.
This was added in https://chromiumcodereview.appspot.com/23804003 to be able to
easily check different initial sizes back when it was difficult to change the
value because blink was still in a different repo. The initial vector
size was changed shortly after due to this experiment setup in
https://codereview.chromium.org/23453040 , but it hasn't changed in the last
6 years since then -- also blink is now in src.git and if someone wants
to change this value it's now very easy to do.

No behavior change.

Bug: 961767
Change-Id: I0e6fb5738a6f28fc833edaf90c110f4e4273e23d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718596
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681056}

To use common names in referrer-policy and
mixed-content tests.

Generated files will be updated after some more changes, not now.

Bug: 906850
Change-Id: Icdb979d429f08a908a74f7f6012b4c0b7dc50c8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717319Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681055}

Issue #1:
The "SecureContext" IDL attribute considers localhost to be secure, but
the Cookie Store API assumed that it would only be exposed on
cryptographically secure origins, so a DCHECK caused attempts to
set/delete cookies on http://localhost to crash.

This CL replaces the DCHECK with an exception that is thrown on attempts
to set/delete secure cookies on cryptographically insecure origins.

Issue #2: The "secure" cookie attribute defaulted to true.
Setting/deleting a secure cookie on a cryptographically insecure origin
is prohibited. The cookieStore.delete() API excluded the option to set
the "secure" attribute, however, so there was no way to delete an
insecure cookie.

This CL defaults the "secure" attribute to true on cryptographically
secure origins, and false otherwise.

Bug: 956641
Change-Id: Iff7c22713e8604d60b68d42199a74b2d08235712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700357
Commit-Queue: Staphany Park <staphany@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681054}

Bug: 987699

Change-Id: I31cd9181690e215ae8fa48d19901b0a5fa28cae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717441
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681053}

R=drubery, gayane

Bug: 984286
Change-Id: I0afe71b8d3f99ae15c8a2b2f61cc94daa5154617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716386
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681052}

This reverts commit c9d067e0.

Reason for revert: appears to be responsible for failures in external/wpt/webrtc/idlharness.https.window.html on: 
 - https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests starting with https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/80197
 - https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 starting with https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/38821

Original change's description:
> Reland "Add datachannel.maxPacketLifeTime"
> 
> This reverts commit 49d46905.
> 
> Reason for revert: Blame not credible - listed failures seem to be all MSAN timeouts.
> 
> All they had in common with this CL is that the tests used the "idlharness" tool.
> 
> Original change's description:
> > Revert "Add datachannel.maxPacketLifeTime"
> >
> > This reverts commit e557c49c.
> >
> > Reason for revert: I suspect this CL causes the following test failures:
> > external/wpt/xhr/idlharness.any.html
> > external/wpt/storage/idlharness.https.any.html
> > external/wpt/background-fetch/idlharness.https.any.serviceworker.html
> >
> > The first failed build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/938
> >
> > Original change's description:
> > > Add datachannel.maxPacketLifeTime
> > >
> > > Delete nonstandard attribute maxRetransmitTime, and make both
> > > maxPacketLifeTime and maxRetransmits nullable.
> > > (Usage of both attributes has been measured to be negligible.)
> > >
> > > Bug: 696681
> > > Change-Id: If37e38114d4718b868413ea8ced9527c88510c15
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710557
> > > Commit-Queue: Harald Alvestrand <hta@chromium.org>
> > > Reviewed-by: Florent Castelli <orphis@chromium.org>
> > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> > > Reviewed-by: Steve Anton <steveanton@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#679965}
> >
> Bug: 696681
> 
> Change-Id: Ic6264584cb4184f1c5acb1049fa5eb2312b41bdb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715508
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Reviewed-by: Florent Castelli <orphis@chromium.org>
> Reviewed-by: Steve Anton <steveanton@chromium.org>
> Commit-Queue: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680916}

TBR=hta@chromium.org,foolip@chromium.org,orphis@chromium.org,steveanton@chromium.org

Change-Id: I5e5cb6425eeba84cef20313672042c8a0a7893c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 696681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719574Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681051}

This patch tries to normalize some of the rects we deal with when
performing interest rect calculations. This is done by capping the
ranges of numbers that we may encounter, in order to produce more
stable results.

The upside of this is that we will paint more content that we would
otherwise erroneously assume to be not intersecting the viewport
(even after padding).

The downside of this is that we may paint more content that is properly
far off screen.

R=chrishtr@chromium.org

Bug: 986110
Change-Id: I69254d2a855e8f083406b13638741b8bc2b85b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715917Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681050}

Chrome currently does not take into account the results of shill
captive portal detection. We plan on communicating from shill the
probe URL it used to get a redirect so that Chrome can use it
instead of its own probe URL.


Bug: 903645
Change-Id: Idacf434e84c1a065969fe0520587de34dbb1c8a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659838Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681049}

https://chromium.googlesource.com/catapult.git/+log/7780205b2067..c5817614666e


git log 7780205b2067..c5817614666e --date=short --no-merges --format='%ad %ae %s'
2019-07-25 rmhasan@google.com [Typ] Modify parse_tagged_list to accept a function argument that returns true if two tags conflict


Created with:
  gclient setdep -r src/third_party/catapult@c5817614666e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=oysteine@google.com

Bug: chromium:973936,chromium:976505
Change-Id: Ib66ba1c515253728ac8d2bea9b6e25b979280be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718842Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681048}

Bug: 963304
Change-Id: If5633fcf01ffd4e74adba2d02db649d3ec1ec5a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719266
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681047}

This CL expands the schema of chrome://omnibox batch exports to
include information about version and running context. To do this
without much duplication of code, VersionUI was refactored slightly.

Bug: 964528
Change-Id: I7de7484d18497a8c5a9d6a165e0922991bf663bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713238Reviewed-by: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681046}

Change-Id: I2aad060f74c2fe687b4e7ed062b59abef7a3e977
Bug: 987722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718778
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681045}

Sync USS Password on Linux has been unblocked by recent migrations
in the PasswordManager team that are concluded in the parent CL.
This CL is enabling the about flags for Linux and it enables it by
default for all linux bots.

Change-Id: Ic94267ab0e9e4cce2ac2b02f1dfa9a0a9046e902
Bug: 902349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718332
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681044}

This CL disallows U+3099 and U+309A characters from domain names. Any IDN
containing these characters will be displayed as punycode.

As of July 2019, these characters are not used in any popular domains.

Bug: 868846
Change-Id: I7e36b30d7dcaf167fb3a6eb23b96f0aa4bd393ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717494Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681043}

Recent migrations moved all users who have been using the keying to the
LoginDatabase. This CL forces all users to using LoginDatabase
instead of native backends on Linux.

TBR=pcc@chromium.org

Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60
Bug: 950269, 950267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681042}

This reverts commit fea37126.

Reason for revert: Still breaking AR/VR tests on N+

Original change's description:
> Reland "android: Reintroduce and rework ModernLinker."
> 
> This reverts commit 5e961649.
> 
> Reason for reland: Fixed loading ChromeModern on N+.
> 
> Original change's description:
> > Revert "android: Reintroduce and rework ModernLinker."
> >
> > This reverts commit ac8fe0e9.
> >
> > Reason for revert: crbug.com/986879
> >
> > Original change's description:
> > > android: Reintroduce and rework ModernLinker.
> > >
> > > This is partially a revert of two commits:
> > > - 53a10113: "Delete unused file:
> > >    base/android/linker/android_dlext.h"
> > > - fdb31883: "Use the LegacyLinker instead of the
> > >    ModernLinker"
> > >
> > > ModernLinker has been reworked, especially the native side. Notable changes:
> > > - The library is only loaded once, not twice in the browser process
> > > - Relocations are always shared between the browser process and the other ones.
> > >
> > > This is enabled only on N+ for Chrome.apk, neither for Monochrome nor for TriChrome.
> > >
> > >              on Q, further commit will trim it as well.
> > >
> > > Binary-Size: Increase due to bringing back ModernLinker. Required to save memory
> > > Bug: 979638
> > > Change-Id: Ia76773b58a71854a36ea49ab82daef1af717b606
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683245
> > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > > Reviewed-by: Egor Pasko <pasko@chromium.org>
> > > Commit-Queue: Benoit L <lizeb@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#679535}
> >
> > TBR=pasko@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,lizeb@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 979638
> > Change-Id: I431aa2011c4a0c4b23b725099e414a52443778f0
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715745
> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > Reviewed-by: Egor Pasko <pasko@chromium.org>
> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#680141}
> 
> TBR=pasko@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,lizeb@chromium.org,bsheedy@chromium.org
> 
> Change-Id: Id43bd6f6dbae6d13f46eafd2342bc7b6cdc33e4d
> Bug: 979638, 986879
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715276
> Reviewed-by: Benoit L <lizeb@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680872}

TBR=pasko@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,lizeb@chromium.org

Change-Id: I2acf3fc3084d0519377e572c5f969fa3b2915063
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 979638, 986879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719125Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681041}

Test that front buffer has expected contents after present.

Bug: 939655
Change-Id: I5a3e89655e1ae20e04ab7463a6ad9d4040a57002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717653Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681040}

Intent to Ship: http://bit.ly/2YmJAYN

Bug: 581518
Change-Id: Ia8a0ded90e09470e019cf05e5aa2745863b2302c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719273Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681039}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d242ed7a0e0a..3a98df0bdd49


git log d242ed7a0e0a..3a98df0bdd49 --date=short --no-merges --format='%ad %ae %s'
2019-07-25 ehmaldonado@chromium.org depot_tools: Move six to depot_tools' .vpython


Created with:
  gclient setdep -r src/third_party/depot_tools@3a98df0bdd49

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=agable@chromium.org

Bug: chromium:984182
Change-Id: I9280580e23c7c517d10f306b682d5d4721694b64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718841Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681038}

This CL removes the dynamic import of APIs which are always available on
all supported platforms. It also removes the old fallback path for pre-Vista
platforms as well as a general code cleanup.

Bug: 986625
Change-Id: I123942cdec976356bf5ba2c12e0f97cbbd65dde0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715536Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681037}

TabGrid uses UIToolbar for both compact layout (Regular(V)xCompact(H))
and non-compact layout. For non-compact layout, the new tab button is
wrapped in to a container UIView with insets, then inserted into a
transparent UIToolbar so that it looks like a floating button but still
has the built-in a11y modal panel for long-press under a11y font-size.

The non-compact layout is no longer working in iOS13 and the floating
new tab button is compressed probably because the calculation of
UIToolbar's height is changed in UIKit. After a discussion with UX, we
decided to remove the transparent UIToolbar for non-compact layout and
make the new tab button a real floating button.

Bug: 971786
Change-Id: I7efddd5e044ce19a469c01ca75535a22b1b5da6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715188
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681036}

Chrome migrates pinned icons in UserPinned/Taskbar dir, but not the
subdirectories of UserPinned/ImplicitAppShortcuts. It's unclear to me why
Windows puts some pinned icons in the ImplicitAppShortcuts subdirectories,
but we should handle them.

Bug: 980239
Change-Id: Ia41c3853b2a4bb78781a39733f388915f58c02eb
TBR: 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710722
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681035}

We tear down BrowserContext-bound Service Manager services when the
BrowserContext is being torn down, but the relevant state which receives
service requests from the Service Manager is on the IO thread. This
means we can end up hitting races where some client of a service
reconnects to the service and triggers the service-startup path
immediately after BrowserContext destruction, which in turn can violate
service's expectations about shutdown behavior.

This CL fixes that by explicitly posting to disable all service request
handling prior to initiating any service instance destruction.

Bug: 987473
Change-Id: I488d8fbed19bc50efc1b8ea4eee80b0cb36d9bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717914Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#681034}

Bug: 944317, 959414
Change-Id: Icd9d51ec1e44c9d483ef921f413f0b3bf9b0fc64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717685Reviewed-by: Siyu An <siyua@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#681033}

This CL adds `delivery_key` to spec.src.json down to
the JSON objects supplied to JavaScript test runners,
to distinguish referrer-policy and mixed-content tests
explicitly by data fields.

Generated files will be updated after some more changes, not now.

Bug: 906850
Change-Id: Iedae7830cbc41eb87ab884a88aa9e667cc54f6e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717109
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681032}

This causes segfaults in client code.

Bug: 977603
Change-Id: Iee474224509c425f8747e9e4f42c253891ba16dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719328Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681031}

https://quiche.googlesource.com/quiche.git/+log/89b9af539b58..753002daef60

$ git log 89b9af539..753002dae --date=short --no-merges --format='%ad %ae %s'
2019-07-24 fayang gfe-relnote: Add NumRegisteredStreams interface to WriteScheduler and implements it in subclasses. No used in prod yet, not protected.
2019-07-24 bnc QuicSpdySession header size limit related cleanup.
2019-07-23 renjietang Simplify header lengths field.
2019-07-23 wub gfe-relnote: (n/a) In QUIC BBRv2, only update max bandwidth filter per ack event. Protected by existing flag --gfe2_reloadable_flag_quic_default_to_bbr_v2.
2019-07-23 quiche-dev gfe-relnote: Abandons HPACK decompression for overly large header blocks. Protected by default-true --gfe2_reloadable_flag_http2_reject_too_large_header_blocks.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=rch@chromium.org

Change-Id: I50464b9e661339650641a72291f65211ec6d2002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716061
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681030}

During the migration from Framework preferences to the preferences
Support Library, many methods and classes were duplicated so that the
two implementations could coexist during migration.

Now that the migration is complete, all of these duplicates can be
cleaned up.

Bug: 967022
Change-Id: I5947a92935cbdc0f200a14d9fe95f804a111f2fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709880
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681029}

This will be used by the BinaryUploadService for uploading requests. It
also encapsulates the retry logic.

Bug: 980784
Change-Id: I1b0beee83548b38b678ef6d0ae6db3130f3db05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710853
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681028}

Previously, it took a `const std::vector<base::string16>&` as
argument. It then immediately copied it into its |items_|
member. However, all callers discard their vector immediately after
constructing SimpleComboboxModel so this copy is unnecessary. Taking
it by value allows the caller to either move or copy their vector.

Change-Id: Ice6bfeafb50ba23a2a63440eb1e7a67406481368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717648Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681027}

This patch ensures that we don't DCHECK when checking positioned object's
layout state, since those objects can also be locked.

R=chrishtr@chromium.org

Bug: 987727
Change-Id: If0d92d81f6b9f47bf12b56d11dd0428f87a5e939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719272Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681026}