- 24 Feb, 2020 36 commits
-
-
Lan Wei authored
This reverts commit f88810b8. Reason for revert: <INSERT REASONING HERE> virtual/storage-access-api/external/wpt/storage-access-api/requestStorageAccess.sub.window.html external/wpt/storage-access-api/requestStorageAccess.sub.window.html are flaky on Mac 10.10 and 10.11, https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests I think the expectation files are different when running on wpt serve. Original change's description: > Enable requestStorageAccess.sub.window.html test on Mac > > Enable requestStorageAccess.sub.window.html test on Mac because two > tests virtual/storage-access-api/external/wpt/storage-access-api/requestStorageAccess.sub.window.html > external/wpt/storage-access-api/requestStorageAccess.sub.window.html > failed on > https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests, but I > reverted the expectation file change. > > TBR=brandm@microsoft.com > > Bug: 1053903 > Change-Id: I348c8a387346ee2a4e8980a2fe6d84e4e5272232 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068253 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: Lan Wei <lanwei@chromium.org> > Auto-Submit: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743697} TBR=lanwei@chromium.org,brandm@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1054577 Change-Id: I95ae362c6dd2700a1e7fa4c1611ddf28ac1adab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069848Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#743883}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/934699adfbac..d358d055a505 Created with: gclient setdep -r src-internal@d358d055a505 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I26a57eff1541ea1191485250a0e0d4bb0c930a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069904Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743882}
-
Julie Jeongeun Kim authored
This CL fixes AXPosition::IsIgnored to properly handle "after children" tree positions. It adjusts the position with the last index if |child_index_| has AnchorChildCount(). With this CL, if the position is an "after children" position, we should consider the position to be ignored if the last child is ignored. The original author of this CL is Nektarios Paisios<nektar@chromium.org> Bug: 1043769 Change-Id: I5d59d201634e1bf3366010adef6eba0d81334f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025007 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#743881}
-
Julie Jeongeun Kim authored
This CL is a precursor to converting FrameMsg_EnforceInsecureRequestPolicy to blink RemoteFrame mojom. It moves WebInsecureRequestPolicy values to mojom to use the values in content and blink and removes WebInsecureRequestPolicy. Bug: 1047284 Change-Id: If030952dbd0c9e98bb0c4a11479ea175ade91fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045293 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#743880}
-
Yuzu Saijo authored
Bug: 1052733 Change-Id: Idaf0090bd0d1fe242c0c618559a6bdee13f03ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059828Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#743879}
-
Thanh Nguyen authored
If the edit distance is big enough, the ratio could be less than 0. This CL fixes the bug. Bug: 990684 Change-Id: I61e536aff49cef3cd5e844b816f8d3e6662f0e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068228Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#743878}
-
alanlxl authored
SmartDimMlAgent is introduced to support loading model and preprocessor from either rootfs or component update service. SmartDim logic can just request decisions from SmartDimMlAgent without needing to know about it. SmartDimMlAgent is a replacement for model_impl.* and ml_serfvice_client.*, but they will coexist for a while, until the flag kSmartDimNewMlAgent rolls out to 100% of the devices. Bug: 1018065 Test: tast test power.SmartDim passes Change-Id: I6bb16c642476775d14836de27ca3a56fa98a8e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903168Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#743877}
-
Julian Watson authored
Bug: 1048962 Change-Id: I759b75b58402d8754a47dfa361c5a7918453bd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068401 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743876}
-
Eric Willigers authored
SettingsWindowManagerTest.OpenSettingsWindowOpenSettingsWindow no longer relies on the extensions function OpenApplication() to launch a web application. Instead, it uses the launch service. Bug: 1052722 Change-Id: Ib4a3bf1a8c37d17b3fcd337c98ee7b1129fbdd5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066504 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#743875}
-
Lan Wei authored
This reverts commit 9ecbfdde. Reason for revert: <INSERT REASONING HERE> fast/peerconnection/RTCPeerConnection-applyConstraints-remoteVideoTrack.html is flaky on Builder Mac10.10 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests Original change's description: > media: Makes fake video support 30 fps > > Bug: b/150004607 > Test: capture_unittests > > Change-Id: I2fd99575cb8a9b780946679ded96c10d94334370 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063617 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Auto-Submit: Wei Lee <wtlee@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743661} TBR=guidou@chromium.org,wtlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/150004607 Change-Id: I1221bc67ba695faa6313a939b8e8f1f7a6ea527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069846Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#743874}
-
Julian Watson authored
Bug: 1049453 Change-Id: I55c53beb5a8fd2eb1a61badfd98ac89cf770c4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063560 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
-
Noel Gordon authored
- move related CSS file-ng and not files-ng rules together - file-ng cr-button: no shadow, and account for 2px border Bug: 992824 Change-Id: I7d56a0e98df0384763007558e8ea15c85f5913f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069977 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#743872}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/998066127e0d..f084b8b6b6a1 git log 998066127e0d..f084b8b6b6a1 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f50cc82b3bed..214ec337a0b2 (3 commits) Created with: gclient setdep -r src/third_party/skia@f084b8b6b6a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Ifc6042a4cb5288e302fd78100159adb2c9537e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743871}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/878e5f26c327..e1d7a0fe6ffb git log 878e5f26c327..e1d7a0fe6ffb --date=short --first-parent --format='%ad %ae %s' 2020-02-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@e1d7a0fe6ffb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I135ec876e90c2f44baca89d85c6b43a3286b3a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069902Reviewed-by:
-
Eric Willigers authored
The tests BookmarkAppUninstallDialogViewBrowserTest and BookmarkAppUninstallDialogViewInteractiveBrowserTest previously relies on extensions methods to install "bookmark apps". We now refer to these as web apps, and now use web_app:: functions to install them. Bug: 1052722 Change-Id: Ie4f81682ffa4282a88f06ca89578b3f093507ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067774 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#743869}
-
nancy authored
Update related unit tests, and not call CreateBlockDialog for unit tests, because below unit tests are broken if create CreateBlockDialog due to BubbleDialogDelegateView related error. All/ArcAppModelBuilderTest.IconLoaderForSuspendedApps/* AppServiceWrapperTest.ArcAppDisabled So workaround it by not showing CreateBlockDialog. BUG=1035136 Change-Id: Id5e4af8cc575f25c1edcdce576b59d46ff1e667b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061576Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743868}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d26dd46a92a9..934699adfbac Created with: gclient setdep -r src-internal@934699adfbac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib85c9d5660099b9786190af43db886917ec256a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069899Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I7fc721982a2142a6c79d29ecc38beeeb42d553f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068730Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743866}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 02382bd2. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iec109052362a6cda92975e3779a5f2427f1069d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069861Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743865}
-
Leon Han authored
The spec changes: https://github.com/w3c/web-nfc/pull/361 https://github.com/w3c/web-nfc/pull/495 https://github.com/w3c/web-nfc/pull/536 BUG=520391 Change-Id: I00a363aba07d1f9f2f8e40212dca7650e26047a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038492 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#743864}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/672b17ee91d5..d5a5c4801756 git log 672b17ee91d5..d5a5c4801756 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 abennetts@google.com Fix TypeError in commit_cache.Get when id_string is None. Created with: gclient setdep -r src/third_party/catapult@d5a5c4801756 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050173 Tbr: crouleau@chromium.org Change-Id: Ie110cf2f4c9cfe1ab01ba01dd615155cd6241022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069900Reviewed-by:
-
Abigail Klein authored
Allow line-by-line navigation of the accessibility tree and accessibility events by splitting the output element into lines and wrapping each line as a div. Bug: 877714,785493 Change-Id: I1fe60beb8e98ea49eab6fc372c74ab131beb9772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978822 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#743862}
-
Tommy Nyquist authored
It is necessary to continue the inline update flow experiment a little bit longer, so this sets the expiry date to M83 for now. R=dtrainor@chromium.org Bug: None Change-Id: Iacfb313619defdbdfa3b5042d93dfdc3da50494c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007316Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#743861}
-
Victor Costan authored
//content/browser/appcache_response{h,cc} include classes that wrap //net/disk_cache, which are used by AppCache and Service Worker, as well as a class that is only used by AppCache. This CL breaks down the code into the following: * appcache_disk_cache_ops.{cc,h} - the classes used by AppCache and Service Worker, which are HttpResponseIOBuffer, AppCacheResponseIO, AppCacheResponseReader, AppCacheResponseWriter, and AppCacheResponseMetadataWriter * appcache_response_info.{cc,h} - the AppCache-only AppCacheResponseInfo The CL also adjusts relevant include directives in //content_browser/{appcache,service_worker}. Some includes are replaced with forward declarations, and some IWYU fixes are applied as well. The CL introduces no functional changes. Bug: 1055133 Change-Id: I06408ca0aa7347d81dd73d4644d431abc2935cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069509 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743860}
-
Nicholas Verne authored
1. Hide Cancel button as per mocks 2. Fix Upgrade complete string 3. Surface a (changing) line of output from the upgrade process above the indeterminate progress bar. 4. Indeterminate progress bar is slower moving to indicate glacial upgrade pace. Bug: 1024693 Change-Id: Ifface2a6be35ae64440993b0d58a64cce571e2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065253Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743859}
-
Frank Li authored
This CL adds MediaEngineNotifyImpl to implement IMFMediaEngineNotify required by IMFMediaEngine (https://docs.microsoft.com/en-us/windows/win32/api/mfmediaengine/nn-mfmediaengine-imfmediaengine). Explainer: https://docs.microsoft.com/en-us/windows/win32/medfound/protected-media-path Design Doc: https://docs.google.com/document/d/1kXMdmfsSKU3tcwTxG-wFU-MaEA6sN3by45PCGBV8zJU Bug: 999747 Change-Id: I082f3dd29dcfc8fb409d387af040aa1c97ff79aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064454Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Frank Li <frankli@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743858}
-
Eric Willigers authored
Many of the browser tests in web_app_browsertest.cc were calling embedded_test_server()->Start() but never using that test server. Change-Id: Ia19fcccd4fc1815fa985c8c468538aadb15b67ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063563 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#743857}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d18d90435ae..d26dd46a92a9 Created with: gclient setdep -r src-internal@d26dd46a92a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0e858b1a01b6bc584ad9d24cba2e6aaea6a7adce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069836Reviewed-by:
-
Eric Willigers authored
no longer used. HostedAppBrowserController: :GetExtensionForTesting() is Change-Id: I8c8fbd25a514b017c9cf4a842cb5bdee83269653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064166 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
...where ChromeAsyncExtensionFunction is not used. Bug: 634140 Change-Id: Idd33df8e183cb716a9c430fda1cd17f3ededbe65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067817 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743854}
-
Isabella Scalzi authored
Tests that after clicking on an image in Quick View, the user can still cycle through file list items, and also exit Quick View. Bug: 1038835 Change-Id: I375461d934d9398ca04edbb8d9f25d9503e49a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067820 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#743853}
-
Joel Hockey authored
Terminal System App uses an almost black (#101010) theme by default for the main tabbed window. However, UX have requested that the settings page always use white for the frame, similar to OS settings. Screenshots: old: crbug.com/1033339#c7 new: crbug.com/1033339#c19 Since both windows are part of the same app, and it is not possible to have a manifest with 2 different themes specified, we will control the theme for System App TYPE_APP_POPUP to always use default which is white for light-mode, and something suitable for dark-mode. Fix for BrowserNonClientFrameViewMac which had not yet been updated to support browser TYPE_APP_POPUP as revealed by the included test. Bug: 1033339 Change-Id: I7b0d7cc291e5f5895ddfda2ad384256c3519d0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066378 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743852}
-
chrome://help-appRachel Carpenter authored
This CL defines a mojom file for the mojo interface between the Browser and the chrome://help-app page and implements the relevant CPP (Page Handler) and JS (mojo_api_bootstrap.js) interfaces. This interface is leveraged to expose the native browser open feedback dialog functionality to the page via a HelpAppUIDelegate. This Cl also adds the kFeedbackSourceHelpApp constant to the chrome::FeedbackSource enum to allow feedback dialogs opened by the help app to be correctly logged. Bug: 1012578,b/149709102 Change-Id: I2f8dbeeb03eebfaf4b43e4757e3830d79943ae41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064646Reviewed-by:
-
Victor Costan authored
This CL removes the content::OnceCompletionCallback alias, and replaces it with net::CompletionOnceCallback. Explicitly referencing the net:: namespace is intended to be a readability improvement, because it makes it clear that the callback's int argument follows the //net convention, where negative values are errors, and non-negative values are byte counts. Bug: 1055133 Change-Id: Ie5057f0abe27f97620ce1897ac839e9e1d53bf82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069507 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d1c90e10f0ca..998066127e0d git log d1c90e10f0ca..998066127e0d --date=short --first-parent --format='%ad %ae %s' 2020-02-23 benjaminwagner@google.com Update XCode Created with: gclient setdep -r src/third_party/skia@998066127e0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Idcc0c198a73b31dd5146cd8a18dee270266d9ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069897Reviewed-by:
-
Eric Willigers authored
The result of GetAppLaunchURL() is no longer being used in WebAppUninstallBrowserTest::UninstallWebApp(). The call is removed. Change-Id: I39552fd7ce852fbf79a72b2559e06c8b581bae00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067772Reviewed-by:
-
- 23 Feb, 2020 4 commits
-
-
Rohit Rao authored
The policy system is initialized before about:flags or field trials, so it is not possible for either of those mechanisms to decide whether or not policy should be enabled at runtime. Instead, we will switch to looking for the presence (or absence) of a command line flag. This will allow us to easily turn policy on locally during development, and when we are ready to ship policy support, we can remove the command line flag. This partially reverts commit 8eefc0a1. BUG=1024115 Change-Id: I0839aa1ab0bd68b149d900dfe522b6d4081b5e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068681 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#743847}
-
Andreas Haas authored
ArrayPiece was only used by DOMArrayPiece, so I moved the implementation to DOMArrayPiece and deleted ArrayPiece itself. R=haraken@chromium.org CC=ulan@chromium.org Bug: chromium:1008840 Change-Id: If82cf00e2afac02d3e72882654751f596e1cd9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066792Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e891d93. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia799561f9ae0e6fcdf684df1a727aa8db170a401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069857Reviewed-by:
-
Lan Wei authored
This reverts commit 9658e86d. Reason for revert: <INSERT REASONING HERE> virtual/threaded-prefer-compositing/fast/scroll-behavior/main-frame-interrupted-scroll.html virtual/threaded-prefer-compositing/fast/scroll-behavior/subframe-interrupted-scroll.html virtual/threaded-prefer-compositing/fast/scroll-behavior/main-frame-scrollLeft.html are flaky on Builder Mac10.13 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29?limit=50 Original change's description: > Skip commits for threaded scrolls. > > Threaded scrolls unnecessarily cause commits on every change. This > patch implements an optimization from pre-BlinkGenPropertyTrees in > layer list mode to avoid these commits. > > When an impl-side scroll occurs, cc can immediately apply the scroll > before notifying blink so that the blink update only causes a commit if > needed (e.g., interest rect changed). This has been implemented in > LayerTreeHost::UpdateScrollOffsetFromImpl. A second change was needed in > PropertyTreeManager::DirectlyUpdateScrollOffsetTransform to avoid > commits if cc already matches blink. > > Bug: 1048384f > Change-Id: Iae670ce3f99e1f8da83ae46e43f38356bf39f6c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058476 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743622} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048384f Change-Id: I4ded532f492778c3603d875ec7d93218bc60bfca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069837Reviewed-by:
-
