- 02 Apr, 2018 18 commits
-
-
Manuel Rego Casasnovas authored
We were not resolving properly percentage paddings and margins for tracks that have something like minmax(auto, 100px). The reason was that while computing the minimum size of a grid item, the percentages were resolved against the inline size of the grid container. But for grid items we shouldn't never use the grid container size, but the grid area size, as that's their containing block. The patch modifies ContainingBlockLogicalWidthForContent() and ContainingBlockLogicalHeightForContent() in LayoutBox, so for grid items we return 0 if the area size hasn't been set yet. We never want to use the grid container's sizes in these cases. BUG=808758 TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-margins-* TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-paddings-* Change-Id: Ib142e51aee1fe623d38688469b179f01f82eb07b Reviewed-on: https://chromium-review.googlesource.com/980756Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#547417}
-
cathiechen authored
This patch supports image list marker in LayoutNG, including: 1. Display image list marker. 2. Switch between image and text. 3. Deal with image error. 4. Support svg image marker. This approach creates a LayoutNGListMarkerImageContent which is subclass of ListStyleImage as marker_'s child. Use ListStyleImage as its ImageResource. The reason to create a new class is that: When image error occurred, marker should display text instead which needs updating layout tree. LayoutNGListMarkerImageContent overrides ImageNotifyFinished to send NotifyOfSubtreeChange when ErrorOccurred. So that list item could update layout tree before layout. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I43d2ac80f823b603a0c52c872abb78785453450e Reviewed-on: https://chromium-review.googlesource.com/970131Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#547416}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: If828d17072875fddc12936f3f158fec380f2ea13 Reviewed-on: https://chromium-review.googlesource.com/989516 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547415}
-
tzik authored
This CL adds two rewriters to //tools/clang/base_bind_rewriters: - pass_by_value converts pass-by-cref base::Callback parameters to pass-by-value. - add_std_move inserts std::move() to pass-by-value base::Callback and local base::Callback variables where it looks relevant. add_std_move rewrites a occurrence of a reference to base::Callback if: - it's a pass-by-value parameter or non-const local variable. - the occurrence is the latest in its control flow. - no pointer is taken for the variable. - no capturing lambda exists for the variable. Change-Id: I83dfef7d8189ee43d052a203461bfb4ad1a25c1d Reviewed-on: https://chromium-review.googlesource.com/970143 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#547414}
-
Kenichi Ishibashi authored
r547407 fixed a deadlock which caused timeout in fetch-request-xhr.https.html when S13nSW is enabled. Update the expectation file as it is no longer timed out. Note that the test is failing currently (w/ or w/o S13nSW). Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If6aca08a4ee513a331772f73e3c7bc24da8114ba Reviewed-on: https://chromium-review.googlesource.com/989518 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#547413}
-
Yoshifumi Inoue authored
This patch changes "android-longtap-not-select-empty.html.html" to utilize |selection_test()| for ease of maintenance. Following patch will move "android-longtap-not-select-empty.html.html" to "mouse/" directory for test classification. Bug: 679977 Change-Id: Iebab8184db6d228320748cf0b8f3090889ba247f Reviewed-on: https://chromium-review.googlesource.com/987837 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#547412}
-
Satoshi Niwa authored
Bug: chromium:811679 Bug: chromium:816678 Bug: b:76128680 Test: Manually tested steps in b:76128680 Change-Id: Ia997588424e90af97aac2f89de1fe1e84266b6fc Reviewed-on: https://chromium-review.googlesource.com/987634Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#547411}
-
Koji Ishii authored
Following bot results are included. 4470 4474 4477 4484 4486 4487 4488 4489 4490 4491 4492 4493 4495 2 lines were removed and 4 lines were deflaked by consecutive results since 4426. ~150 image/image+text failures probably due to CL:986812, another incremental CL to change fonts on Linux in crbug.com/787020. Among them, 1 was changed from a ref test to test harness, and that text dump was removed. A few of them seem new failures and that they are not rebaselined. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I95a87e51f0fbcacbf58f0c89cce03334d0440d8d Reviewed-on: https://chromium-review.googlesource.com/988153 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547410}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I4a062ac1db4631215d1ec58bd5d79cc3acc5ba33 Reviewed-on: https://chromium-review.googlesource.com/987833Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547409}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: Id34d9b90a1e78b4cc72af1d0a0e1f6a6b009cd6b Reviewed-on: https://chromium-review.googlesource.com/989374 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547408}
-
Tsuyoshi Horo authored
Before 5e1b52dd, synchronous XHR on worker was handled by service workers. It is because the |is_sync_load| was false when the sync request is from worker thread. But after the CL, the |is_sync_load| flag for the sync request from worker became true, so the request will not go to the service worker. This CL will fix this by - Set the SkipServiceWorker flag for synchronous loads from the main thread in the renderer process. (FetchParameters.cpp) - Don't set skip_service_worker even if is_sync_load is true in the browser process. (resource_dispatcher_host_impl.cc) Bug: 706331,827473 Change-Id: I186bc97f3f8d298e0a04942d0ec4b708b3022cc1 Reviewed-on: https://chromium-review.googlesource.com/989376Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547407}
-
Satoshi Niwa authored
Background: * We are migrating callers of ConvertPathToArcUrl (sync) to using ConvertToContentUrl (async) instead. * exo_parts.cc (a caller of ConvertToContentUrl) needs to handle multiple URLs at a time, so it converts single-URL callbacks to multiple-URLs callback using BarrierClosure. * It turns out arc_file_tasks.cc (a caller of ConvertPathToArcUrl) also needs to handle multiple URLs at a time. * Moving the BarrierClosure logic from exo_parts to path_util, so we don't need to duplicate the same BarrierClosure logic in arc_file_tasks after migration. Bug: chromium:811679 Test: unit_test Change-Id: I461651bac3e5110afdd7b97d39576436cb3a92fd Reviewed-on: https://chromium-review.googlesource.com/983335Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#547406}
-
Takuto Ikuta authored
Change-Id: If199dc2b8fa924cc2299551e130925ee0eb63544 Reviewed-on: https://chromium-review.googlesource.com/987835 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547405}
-
Yoshifumi Inoue authored
Utilize selection_test() in "editing/selection/click-in-focusable-link-should-not-clear-selection.html" This patch changes "click-in-focusable-link-should-not-clear-selection.html" to utilize |selection_test()| for ease of maintenance. Following patch will move "click-in-focusable-link-should-not-clear-selection.html" to "mouse/" directory for test classification. Bug: 679977 Change-Id: I88cb017fd3fd8b983548693c1abd86f55fa672de Reviewed-on: https://chromium-review.googlesource.com/987420Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547404}
-
Gyuyoung Kim authored
This CL introduces new APIs to suspend/resume the active tasks on the page of blink. Android webview, devtools, or other projects which use the content module needs to be able to suspend current active tasks including active javascript, active timers, defer loadings, and so on. This CL supports to suspend/resume through the APIs when they want to pause current active tasks. This feature will help us to save CPU resources, and so on. Besides WebKit2 has been supporting this APIs for applications which uses WebKitWebView. TEST: WebContentsImplBrowserTest.PausePageScheduledTasks Bug: 822564 Change-Id: Icec0390c2dffd676a6079dd9e148feb8a3e859e1 Reviewed-on: https://chromium-review.googlesource.com/952642Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#547403}
-
Megumi Hattori authored
Before this CL, |password_view_| is always focused when HasAuthMethod(AUTH_PASSWORD) is true. This CL limits the timing of focusing |password_view_| to only when HasAuthMethod(AUTH_PASSWORD) is changed from false to true. This CL also fixes a bug that users cannot focus inline reply using virtual keyboard on the lock screen. BUG=825781 TEST=manual Change-Id: I7afa75af0b3c86bf0988d5cbd95edc192255785a Reviewed-on: https://chromium-review.googlesource.com/980272Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#547402}
-
Kristian H. Kristensen authored
On ChromeOS, CL:950007 changed the decoder output format to NV12 instead of RGB. This means that the color space conversion now happens when the test suite textures from the NV12 EGLImage, which accounts for small differences in the conversion. BUG=827032 TEST=video_VideoDecodeAccelerator Change-Id: Ic3f22736dae0632756a62e4b9226da30cc561e68 Reviewed-on: https://chromium-review.googlesource.com/989024Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#547401}
-
Kent Tamura authored
It's unnecessary since VS2015. Change-Id: Iba63fa152ea0fbc2f567903e21b3cba9065a746a Reviewed-on: https://chromium-review.googlesource.com/987637 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547400}
-
- 01 Apr, 2018 7 commits
-
-
https://skia.googlesource.com/skia.git/+log/5614ce189732..c6a19f1d044e $ git log 5614ce189..c6a19f1d0 --date=short --no-merges --format='%ad %ae %s' 2018-03-29 ethannicholas fix for frexp dataflow analysis Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ic360bc98b46471fab1cf748888d2bc8e820d9e14 Reviewed-on: https://chromium-review.googlesource.com/989403 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547399}
-
Klaus Weidner authored
The heuristic wasn't working right due to using the wrong frame as timing reference, resulting in overthrottling for fast applications and excessive latency for slow applications. When estimating the render time for a frame that was already complete at the time of check, it uses the time-until-copied as a lower bound, but accidentally used the copy time of the currently processing frame as opposed to the copy time of the previous rendering frame, resulting in overestimating the render time. Also, the heuristic to decide when to skip VSync also should have used the currently rendering frame (two frames back when sending a new animating frame), but was erroneously using the currently processing frame (one frame back). Fix this, and adjust the heuristic to more accurately reflect the intended scheduling. Bug: 827811 Change-Id: Ic4884ccaee6f2f6d3051ce2790132582dba6702a Reviewed-on: https://chromium-review.googlesource.com/989431 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547398}
-
https://skia.googlesource.com/skia.git/+log/0806b7ce3b59..5614ce189732 $ git log 0806b7ce3..5614ce189 --date=short --no-merges --format='%ad %ae %s' 2018-04-01 update-skps Update SKP version Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I1f7f381790b860f0b52540ea0cb293e498ff816f Reviewed-on: https://chromium-review.googlesource.com/989398Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547397}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0b3985c7b4ed93a0041caaba13308b5040020056 Reviewed-on: https://chromium-review.googlesource.com/989264Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547396}
-
Nektarios Paisios authored
Helps screen reader users navigate extensions page easily by jumping from heading to heading. As a result of direct feedback from a screen reader user. R=rdevlin.cronin@chromium.org, scottchen@chromium.org Bug: 827264 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a7a3ad3c9ea6e57d5d3eaa73a5ee9fccd35fd2a Reviewed-on: https://chromium-review.googlesource.com/981902Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#547395}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cce7668a. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15068 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I6a727f5de0b4257185767f2e0d98e64e7e8d443e Reviewed-on: https://chromium-review.googlesource.com/989240 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547394}
-
Jennifer Apacible authored
This clears the PiP video id from MediaWebContentsObserver. Future work, including completely tearing down on the PiP window side, will be added once there is messaging between the PictureInPictureWindowController and the MediaWebContentsObserver. BUG: 726619 823172 Change-Id: I923acf848e71fd43ce8c2532e25bf876836bd0d1 Reviewed-on: https://chromium-review.googlesource.com/967239 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547393}
-
- 31 Mar, 2018 15 commits
-
-
https://skia.googlesource.com/skia.git/+log/b33feaca1caa..0806b7ce3b59 $ git log b33feaca1..0806b7ce3 --date=short --no-merges --format='%ad %ae %s' 2018-03-31 rmistry Revert "Whitespace change" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I5c90ebc5504d11f64836074339a1da27d09046f8 Reviewed-on: https://chromium-review.googlesource.com/989652 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547392}
-
Robert Liao authored
Before, dismissing the ExtensionPopup when the anchor window received focus was an arbitrary decision (http://crbug.com/179786) that allowed the ExtensionPopup to dismiss at most of the right times. However, if the some other top-level window received activation, the ExtensionPopup would not dismiss, unlike a typical menu. This change adjusts the ExtensionPopup to always dismiss when it loses activation as long as devtools is not attached. When devtools is detached, activation is placed back on the ExtensionPopup so that the normal dismissal behavior can continue to work. Failure to receive activation means the ExtensionPopup will not dismiss until it receives activation at least once. BUG=825867 Change-Id: I802af281616c66013c370e892953ad2805533728 Reviewed-on: https://chromium-review.googlesource.com/984404Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#547391}
-
Jennifer Apacible authored
Currently, video playback is visible behind the Picture in Picture interstitial while in PIP mode. Ideally, only the video poster image, icon, and text of the interstitial should be visible. This change follows the pattern used for Media Remoting to disable seeing video playback in the browser tab while in PIP/MR mode. BUG: 826588 Change-Id: I1d3ba9978e0c68cfbed59618e82123a8cad876f6 Reviewed-on: https://chromium-review.googlesource.com/983055Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#547390}
-
https://chromium.googlesource.com/catapult.git/+log/e910e99d1eb3..29a751ceced1 $ git log e910e99d1..29a751cec --date=short --no-merges --format='%ad %ae %s' 2018-03-28 szager Add StartShellCommand, to hold a handle to a running process. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I9f869849b5324dc9a80b6ea577646d4a3706e2c1 Reviewed-on: https://chromium-review.googlesource.com/989430 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547389}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cb7b3f80. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15042 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: Ic3a6edee8a1eca37033f2de2887dcb406019c9cd Reviewed-on: https://chromium-review.googlesource.com/989260 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547388}
-
Fady Samuel authored
RendeWidgetHostImpl called RenderWidgetHostView*::DidNavigate on navigate in order for the view to get an opportunity to allocate a new LocalSurfaceId. Immediately afterward, RenderWidgetHostImpl::DidNavigate calls WasResized but implementations of RenderWidgetHostView* already do this, rendering this WasResized redundant and confusing. In an effort to make subframes and top level frames more symmetrical, we'd like to allocate LocalSurfaceIds on navigations of OOPIFs as we do today for top level frames. Bug: 672962 Change-Id: If4f54b9532e4c9540e4162bca4ba46e8052f7076 Reviewed-on: https://chromium-review.googlesource.com/978667 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#547387}
-
Yoshifumi Inoue authored
This patch changes "mixed-editability-9.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977 Change-Id: Icdc428ea05eb69be3b15f563cf6126f66a7a69af Reviewed-on: https://chromium-review.googlesource.com/987416Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547386}
-
Takumi Fujimoto authored
Add the ViewsCastDialog feature, which replaces the WebUI Cast dialog with a Views toolkit dialog when enabled. The feature flag is also made accessible through chrome://flags. The implementation for the feature will land in the future. Bug: 825989 Change-Id: Ib69a2a56362093d0e42e53b747ba0fdc9f0c5778 Reviewed-on: https://chromium-review.googlesource.com/982635 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#547385}
-
Balazs Engedy authored
TBR=kpaulhamus@chromium.org Bug: 827172 Change-Id: I561b891e0440d59013c7d3da1e46062e96d30a95 Reviewed-on: https://chromium-review.googlesource.com/989552Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547384}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/012013ee5940..0d466d22d8e2 $ git log 012013ee5..0d466d22d --date=short --no-merges --format='%ad %ae %s' 2018-03-23 svillar git cl believes I'm working inside GCE 2018-03-30 ehmaldonado gclient_scm: Don't try to update file_list if it's None. Created with: roll-dep src/third_party/depot_tools BUG=chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idf2a74bcbc3fcb07d9a6cbf24d3b5c8ace6441c8 Reviewed-on: https://chromium-review.googlesource.com/989412Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547383}
-
https://skia.googlesource.com/skia.git/+log/95c478fe18ca..b33feaca1caa $ git log 95c478fe1..b33feaca1 --date=short --no-merges --format='%ad %ae %s' 2018-03-31 update-docs Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Ib138ef796c7eec6eb47503ca2f64dd7cdcf5cab1 Reviewed-on: https://chromium-review.googlesource.com/989415 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547382}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c7cb8ed2a1ec..371913c4e6f0 $ git log c7cb8ed2a..371913c4e --date=short --no-merges --format='%ad %ae %s' 2018-03-29 rohitbm Kick off arc-cts-follower test suite from builders. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6f67746d6d38afe47a55bb27aaf3188e036cf4ec Reviewed-on: https://chromium-review.googlesource.com/989336Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547381}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/a6bfc45b6286e358ba83f7daa769e1e9012cc7bb..eb7c3008cc85c9cfedca7690f147f5773483f941 BUG=none Change-Id: I75b00989c8c16959def5f38c70cdf6ba0e541814 Reviewed-on: https://chromium-review.googlesource.com/988192 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547380}
-
David Tseng authored
This reverts commit bea32252. Reason for revert: various apps breaking e.g. scrolling Original change's description: > Enable ChromeVox ARC support for all apps > > Change-Id: I130db573fcc2ccbda3ce58c9d2bac845218ab1d9 > Reviewed-on: https://chromium-review.googlesource.com/961549 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Yuki Awano <yawano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544283} TBR=dtseng@chromium.org,yawano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I6a3c80ac74b3101a3ab756f4e0c5e74980019980 Reviewed-on: https://chromium-review.googlesource.com/989053 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#547379}
-
Blake O'Hare authored
Refactor direct calls into display::Screen. In the future, there will be more screen calls with regard to dragging the floating keyboard to adjacent displays, which will be added to this class. Change-Id: Ie45d5544ae4f18d98d2e54d8d634d11e38aa12ba Reviewed-on: https://chromium-review.googlesource.com/979878Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547378}
-