- 05 Aug, 2019 40 commits
-
-
Erik Chen authored
We are removing the WebLayerTreeView interface as it is redundant with WebWidgetClient now that we always composite web contents. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. This CL is mostly a refactor but has a slight behavior change. WebViewImpl::DidUpdateBrowserControls had a conditional gated on layer_tree_view_. This CL replaces the conditional with a check for local main frame. Change-Id: Iaab168eaef0aa2b396f92e9d2cd049176d4efbf9 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728339 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#684097}
-
Chris Sharp authored
TBR=estade@chromium.org Bug: 990692 Change-Id: Ia2f8b62c2e9864b34c54ec8250d1718678366e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737103Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#684096}
-
Jeffrey Kardatzke authored
This expands MAC anonymization to allow for dash and underscore separators which are generally seen in Bluetooth MACs. It also adds anonymization of 32, 40 and 64 char length hex hash values and puts the 4 char hash prefix in the redacted value. It also looks for a special case which was happening with modetest and ignores that so the data dump there is preserved. Bug: 940884 Test: Unit tests pass, uploaded feedback report redaction looks good Change-Id: I7ced3399f9387392eed24c866d6b60652762e984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733749 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#684095}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ccf805046ae3..38ee172a228d git log ccf805046ae3..38ee172a228d --date=short --no-merges --format='%ad %ae %s' 2019-08-05 enga@chromium.org Fix dynamic bind group size in Animometer example Created with: gclient setdep -r src/third_party/dawn@38ee172a228d The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I17c0011463ca186433e1c4ea9c8becc88b377e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684094}
-
Kristi Park authored
Bug: 990789 Change-Id: I6d489a1f01397cdc611911dc9c5000a244648c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737036 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#684093}
-
Erik Chen authored
The original CL was reverted because it triggered an MSAN use-after-free bug. See issue 990192 for more details. The root cause is that in the CL, the RenderView's destructor would call RenderWidget::Close, but RenderWidget is ref-counted and would not actually be closed. Subsequently, RenderWidget's delegate_ member would point to the now-destroyed RenderView, and accessing it would cause UaF. This reland makes RenderWidget have unique_ptr semantics, thereby fixing the problem. This CL generally fixes the problem of accessing RenderWidget after RenderWidget::Close. This CL removes the method DidCloseWidget, as it added an unnecessary layer of abstraction. RenderView can perform its own clean up. > Make browser process own RenderView. > > Historically, RenderView and RenderWidget were 1:1, and their lifetimes were > entwined. > 1) RenderViewHost would create the RenderView. > 2) RenderView would create a RenderWidget and pass ownership of itself to the > RenderWidget. > 3) RenderViewHost's destructor would destroy the RenderWidget, thus destroying > the RenderView > > We want the lifetime of RenderView and RenderWidget to be decoupled. The first > step of this is making RenderView explicitly owned by the browser. This means > that instead of (3), RenderViewHost's destructor will destroy the RenderView, > which will in turn destroy the RenderWidget. > > One subtlety is that prior to this CL, RenderWidget was always destroyed > asynchronously. The original reason for supporting this -- dealing with > re-entrancy from nested message loops -- is no longer applicable. The IPC that > destroys RenderWidget is asynchronous, which means it can never be called from a > re-entrant context. However, it is possible for a RenderWidget associated with a > child-frame to be synchronously destroyed by JS. This can be re-entrant. This CL > updates destruction of RenderWidget to be synchronous when called from IPC. Bug: 987731, 990192 Change-Id: I1b1f1b70cc6b8e91286712d80ab42cd507e64e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733580Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Tomasz Śniatowski authored
Make MediaCodecUtil::IsHEVCDecoderAvailable call IsDecoderSupportedByDevice instead of IsEncoderSupportedByDevice. It looks like a typo, and isn't harmless: it can cause content shell to stall at startup if built with enable_hevc_demuxing=true when the renderer tries to query the encoder. Apparently it's a case of doing something in the renderer that's not allowed, as explained in https://chromium-review.googlesource.com/c/chromium/src/+/1694241 (which happened to add this encoder/decoder typo). BUG=980091, 980682 TEST=build with enable_hevc_demuxing=true, run content shell apk R=chcunningham Change-Id: Iaadc73e6dd4301b6e300891cbb0baf7afe8f5e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730163Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#684091}
-
Jimmy Gong authored
- Flips feature flag to enable the updated Ui for settings printers. Bug: 965721 Test: End to end manual, browsertests Change-Id: I7187b4c7b05b4ae5d2a625b05b184a53909a5b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714210 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#684090}
-
Charlene Yan authored
from MenuButton. Bug: 984600 Change-Id: Ia811ef808ea9b67ee5375901384feecaf9241282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717493Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684089}
-
Rose Garcia authored
Added logic to hide the paste button when nothing has been copied to the clipboard yet. This uses the clipboard API to add an event listener. Bug: 982004 Change-Id: I6aae1d1613a9271e1f4a88bd01d1e050667b6164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730630 Commit-Queue: Rose Garcia <rosalindag@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#684088}
-
Yuchen Liu authored
In renderer process, FuchsiaCdmFactory initiates the request to Fuchsia CDM service. The request is passed to browser process via new mojo FuchsiaCdmProvider. FuchsiaCdm implements media::ContentDecryptionModule by calling Fuchsia CDM APIs directly from renderer process. In browser process, FuchsiaCdmManager will complete the provision flow (if needed) and setup the channel between Chromium and the remote CDM service. Bug: 966191 Test: Shaka Player WV audio only test (with other CLs). Change-Id: I401e581214d945a2acbefa926f73fdb2ca84d780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715908Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#684087}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4df3d5340ef3..f1138888e7ce git log 4df3d5340ef3..f1138888e7ce --date=short --no-merges --format='%ad %ae %s' 2019-08-05 halcanary@google.com experimental/editor: StringSlice::fPtr type change 2019-08-05 bsalomon@google.com Pass GrBackendFormat to GrResourceProvider and GrGpu texture create 2019-08-05 halcanary@google.com tools/gyp: deleting old file 2019-08-05 michaelludwig@google.com Update benchmarks to use new filter factories Created with: gclient setdep -r src/third_party/skia@f1138888e7ce The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: I19899bb21aed5983e8b899697c0224f0c85b415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735952Reviewed-by:
-
Becca Hughes authored
This feature is launching soon so we should add this flag to about flags so it can be tested easily. BUG=965546 Change-Id: Id569e60e609b00c9ddc410996c2cb893d4f0f5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737147Reviewed-by:
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: I95e258c66b2d79b8cb172fbae97f6716c2cf66c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736438 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#684084}
-
Ben Kelly authored
This CL also fixes a content_browsertest test case that assumed the fetch response body would be immediately drained. Bug: 954442 Change-Id: I22c41758150f427072f18c3ac79a82a1f9678f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736868Reviewed-by:
-
Clark DuVall authored
This switches to using BrowserContext instead of ResourceContext for PluginService and plugin_utils.cc. This required moving PluginRegistryImpl, PluginInfoHostImpl, and RenderFrameMessageFilter::OnGetPluginInfo to run on the UI thread. This eliminates one of the major dependencies of extensions::InfoMap. Bug: 980774 Change-Id: I7b26c5b40dc8b98c518339b771249ef16e6ec856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730093 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5861c8614d48..444cccdb2cdd git log 5861c8614d48..444cccdb2cdd --date=short --no-merges --format='%ad %ae %s' 2019-08-05 dburger@chromium.org Remove generation of master-postsubmit and its children Created with: gclient setdep -r src/third_party/chromite@444cccdb2cdd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I713ecef0dd4c8d6c663d2ff45bf12a0593e63db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735770Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I00610747dc0dc84f3c9f6b79964062f03fa3d940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737011Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#684080}
-
Aga Wronska authored
This is in line with a new design of base::Value described at https://cs.chromium.org/chromium/src/base/values.h?l=56 and also simplifies memory management in tests. Bug: 956036 Change-Id: I14a1c404567608fe1ecaa4529ef1e9f14d70f81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717780Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Switches the browser used by the Windows XR perf tests from "release" to "release_x64" since the bot was changed to 64-bit and Telemetry is now failing to find the 32-bit browser that is requested. TBR=ynovikov@chromium.org Bug: 988833 Change-Id: I498e65f1ac4182718ccf83495d6ff1eb3eacbe73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735553Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#684078}
-
Ken Rockot authored
This prevents the ModuleInspector service process connection from being too aggressively torn down, allowing for reuse of the same service process over multiple module inspection operations. Bug: 990205 Change-Id: I7c0b083141ff058b6045acf3c8d299e54f11e0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734172 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#684077}
-
Sofiya Semenova authored
Bug: 990512 Change-Id: Iac340a45ca4bccc4c08d1176bd263284b53faef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733751Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Sofiya Semenova <sofiyase@google.com> Cr-Commit-Position: refs/heads/master@{#684076}
-
Marc Treib authored
This feature only ever existed as a safeguard; it was default-enabled from the beginning. Bug: 983940 Change-Id: I2d1a7d6662853c278592a7609aa5d1267b3e2098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735155 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#684075}
-
Ben Pastene authored
vpython uses both HOME and TMPDIR as workspaces. Now that /tmp is mounted with noexec, we need to point vpython to a tmp dir without that restriction. Bug: 990859 Change-Id: I17629676abb898923658a48862a909e99d4fac1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735554Reviewed-by:
-
Jeffrey Kardatzke authored
There was a crash report indicating this was a null deref, and the code clearly shows the calling function can return a null pointer so account for that case. Bug: chromium:990507 Test: Builds Change-Id: I3b78de23dca40637661d1a9619adf9c00593c485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733739 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#684073}
-
Owen Min authored
Using ChromeTypographyProvider to set the color instead of hard coding. Normal mode keeps using kGoogleGrey700. Dark mode use kGoogleGrey500. Before: https://drive.google.com/open?id=1qGdPgomtoXVPkAZ4XZr5gzd5ckBcfLzz After: https://drive.google.com/open?id=1MZ4wt7LW68CK-KqzLKgLKuZNNUBcrS59 Bug: 990406 Change-Id: I4f088d4d49e4b0df0b467b1f195dcd16f08aa84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732480Reviewed-by:
-
Clark DuVall authored
This feature was removed in http://crrev.com/c/1732409, so we no longer need these tests. Bug: 824840 Change-Id: I582216aac6a27bf14b04ed6760b25aa65f698628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735949 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Takumi Fujimoto authored
Record UMA metrics whenever the Mirroring Service encounters a SessionError. Change-Id: Ic1f6eb02232dcb4164bf5a9ba0d6105fa7128c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714208Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Tim Judkins authored
Bug: 747715 Change-Id: I957d86b986d2da087c0ade85e8cc04228a7a4eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725050 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684069}
-
Chris Sharp authored
TBR=nhiroki@chromium.org Bug: 990900 Change-Id: I585308ff8ccb07c933f6c79a585a209be194785a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737093Reviewed-by:
-
Brian Sheedy authored
Adds "Win10 FYI x64 Release (Intel UHD 630)" to chromium.gpu.fyi, which is identical to "Win10 FYI x64 Release (Intel HD 630)" except that it triggers tests on a machine with a newer GPU. Bug: 986939 Change-Id: Ia7408cad7b862738d7562f954cf213e2bd9355c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734166 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#684067}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a5468613faff..53d495005f0c git log a5468613faff..53d495005f0c --date=short --no-merges --format='%ad %ae %s' 2019-08-05 perezju@chromium.org [Telemetry] Fix handling of default arguments set by benchmarks Created with: gclient setdep -r src/third_party/catapult@53d495005f0c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:990395,chromium:985712 Change-Id: Iaa78c593bd01e10fb17b0ca69f91180361ffa03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735898Reviewed-by:
-
Scott Haseley authored
We're renaming core/scheduler to core/scheduler_integration_tests because the new name more fully reflects the purpose of its contents, and distinguishes it from modules/scheduler which contains the experimental postTask API. Bug: 979017 Change-Id: I0d2956a0e51e5661c29cc015abf8a68052cd0540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729061Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#684065}
-
Mikel Astiz authored
If engine initialization fails, the code passes an empty string as cache GUID, hence the DCHECK is not legit. Bug: None Change-Id: I5a8f4d96e0c3994407444d2b344f3cae8c800be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736360 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#684064}
-
Artem Titov authored
This reverts commit 2e872764. Reason for revert: Breaks webrtc msvc bots: https://webrtc-review.googlesource.com/c/src/+/147948/ Original change's description: > Roll src/third_party/nasm/ f564874f4..da0dcccc4 (1 commit) > > https://chromium.googlesource.com/chromium/deps/nasm.git/+log/f564874f4955..da0dcccc44f1 > > $ git log f564874f4..da0dcccc4 --date=short --no-merges --format='%ad %ae %s' > 2019-08-01 rnk Skip compiling ilog2.c on Windows where 'inline' uses C++ semantics > > Created with: > roll-dep src/third_party/nasm > > Bug: 989745 > Change-Id: I712bc7d2cb6b3d6ab8315174459f9837581d84b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734032 > Commit-Queue: David Benjamin <davidben@chromium.org> > Commit-Queue: Reid Kleckner <rnk@chromium.org> > Auto-Submit: David Benjamin <davidben@chromium.org> > Reviewed-by: Reid Kleckner <rnk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683807} TBR=davidben@chromium.org,rnk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 989745 Change-Id: I6aac384304d31e714595633d18b5a1b2f62de2c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736684Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Artem Titov <titovartem@chromium.org> Cr-Commit-Position: refs/heads/master@{#684063}
-
minch authored
Bug: 977430 Change-Id: I35b13019f049ac4f90a3b5add999da0061931a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673966Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#684062}
-
Fabrice de Gans-Riberi authored
Bug: 990196 Change-Id: I5177f0ef7fbf764e9bf79b5ab1ed167d96b04eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733098 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
Justin Cohen authored
Bug: 989497 Change-Id: I83cafb3fdb0a5e8695d89eab7ede78628e1f26e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730558 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#684060}
-
Rayan Kanso authored
Although only one icon is still passed, this is the first step to allow having multiple icons per content index registration. Bug: 973844 Change-Id: Ie699ecbd5d92b37c78fa9ae389e02d7667da7276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732086Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#684059}
-
Clark DuVall authored
I found a workaround for crrev.com/c/1728889 so it no longer needs to use this method, so it can safely be removed. Bug: 824840 Change-Id: I9e1ac8a2beadb8de7bcf8f690599fde2b53c349d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734975 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
