GitLab

pointer lock.

This CL fixes two separate issues. One is that when a
CrossProcessFrameConnector is being destroyed, if the
RenderWidgetHostViewChildFrame holds the mouse lock it must
unlock the mouse.

The second issue is that when flash holds a fullscreen
pointer lock and releases it, the WebContents is notified
of the lost mouse lock, even though it was never notified
that the mouse lock was acquired (because flash has extra
privileges to acquire the lock).

BUG=619571
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2112923002
Cr-Commit-Position: refs/heads/master@{#405195}

This check is now made at presubmit time, preventing hard to debug failure on
the infrastructure.

The failure mode is not obvious, the recipe throw an exception at trigger time
and this is hard to diagnose.

This fixes the problem before this is even sent to run as a try job.

Tested manually.

R=thakis@chromium.org
BUG=626766

Review-Url: https://codereview.chromium.org/2151503003
Cr-Commit-Position: refs/heads/master@{#405194}

BUG=none

Review-Url: https://codereview.chromium.org/2131863002
Cr-Commit-Position: refs/heads/master@{#405193}

|EVP_PKEY_up_ref| was a BoringSSL addition to OpenSSL The next major,
public OpenSSL release will include it, but it'll return 0/1 rather than
the object being referenced.

This change updates Chromium to expect that function signature (in a
backwards compatible way). Once all callers have been updated likewise,
BoringSSL will align this function with upstream OpenSSL.

BUG=none

Review-Url: https://codereview.chromium.org/2113143004
Cr-Commit-Position: refs/heads/master@{#405192}

"Bookmark added!" => "Bookmark added"

ainslie@ says it doesn't belong.

BUG=none

Review-Url: https://codereview.chromium.org/2142103002
Cr-Commit-Position: refs/heads/master@{#405191}

The CL 2129543002 introduced an option to override variation parameters
using a feature in chrome://flags. The list of options for the given
feature always includes "Default", "Enabled", and "Disabled". Even
though the semantics of "Enabled" was meant as 'enabled with the default
parameter values', the API forced to specify the variation for "Enabled"
as well.

This is unnecessarily cumbersome and confusing. This CL makes the
"Enabled" option completely automatic - no need to specify its variation
any more.

BUG=609059

Review-Url: https://codereview.chromium.org/2146903002
Cr-Commit-Position: refs/heads/master@{#405190}

The bug was introduced in the last patch set of
https://codereview.chromium.org/2129213003/.
1. Open an app window with insets (hidden header) and a few other windows.
2. Enter overview
3. While in overview close a few windows so that all windows grow.
4. Close overview by clicking the window with active shape (app frame).

The first active window has its header and some client area content
masked.

BUG=624431
TBR=tdanderson@chromium.org

Review-Url: https://codereview.chromium.org/2148703002
Cr-Commit-Position: refs/heads/master@{#405189}

More sprinkling of artisanal const &s.

BUG=None

Review-Url: https://codereview.chromium.org/2141753002
Cr-Commit-Position: refs/heads/master@{#405188}

Mark ref test affected by same change as Pass Failure

BUG=627844

Review-Url: https://codereview.chromium.org/2143983003
Cr-Commit-Position: refs/heads/master@{#405187}

This CLs adds an entry in mb_config.pyl for a new Cronet Release Asan bot.

BUG=567323

Review-Url: https://codereview.chromium.org/2143363003
Cr-Commit-Position: refs/heads/master@{#405186}

The issues w/ the remoting targets have been addressed, so let's
give this another try.

TBR=rsesek@chromium.org
BUG=618468

Review-Url: https://codereview.chromium.org/2143863002
Cr-Commit-Position: refs/heads/master@{#405185}

Update the ordering of polymer properties passed to Polymer() to match
https://www.chromium.org/developers/web-development-style-guide.

BUG=529395
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2140513003
Cr-Commit-Position: refs/heads/master@{#405184}

BUG=612205
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2076213002
Cr-Commit-Position: refs/heads/master@{#405183}

The test is exceedingly simple. It uses requestAnimationFrame and WebGL APIs
to animate the background color of the page.

BUG=616811

Review-Url: https://codereview.chromium.org/2143523002
Cr-Commit-Position: refs/heads/master@{#405182}

"Toasts" are ARC++ notifications coming from the Android side. These need
to migrate to WmWindow/WmShell so we can use them in mus.

Also make sure the toast bounds are computed based on the "target" root window
where they will appear. The existing code placed the toasts on the target root
window (which could be the secondary display), but used the primary display's
bounds for positioning.

TODO - Convert the unit test, which relies on DisplayManager for unified
desktop mode.

BUG=619636
TEST=ash_unittests, manually spawn toasts with Ctrl-Alt-Shift-O

Review-Url: https://codereview.chromium.org/2139183003
Cr-Commit-Position: refs/heads/master@{#405181}

BUG=566163
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2138183002
Cr-Commit-Position: refs/heads/master@{#405180}

The navigation type "blink::WebNavigationTypeReload" is now
forwarded to the browser process.

Two more tests pass when browser-side-navigation is enabled.
http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_reload.html
http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_reload.html

BUG=576272

Review-Url: https://codereview.chromium.org/2136963002
Cr-Commit-Position: refs/heads/master@{#405179}

Specifically:

- chromium
  - Win
- chromium.perf
  - Win Builder
- official.desktop
  - win
  - win64
- official.desktop.continuous
  - win trunk

There are still various FYI and memory builders on GYP, as well as
the GYP builders on the chromium.win waterfall.

R=brucedawson@chromium.org, brettw@chromium.org
BUG=623659

Review-Url: https://codereview.chromium.org/2139833002
Cr-Commit-Position: refs/heads/master@{#405178}

- Remove command line flags enable-toolbar-swipe-in-document-mode and
  enable-tab-switcher-in-document-mode.

- Several corresponding methods in FeatureUtilities have become
  obsolete as it is no longer possible to have the tab switcher
  enabled in document mode.

BUG=612245

Review-Url: https://codereview.chromium.org/2141783002
Cr-Commit-Position: refs/heads/master@{#405177}

BUG=NONE

Review-Url: https://codereview.chromium.org/2145083002
Cr-Commit-Position: refs/heads/master@{#405176}

I fell prey to one of the classic Java bugs.

BUG=626544

Review-Url: https://codereview.chromium.org/2136083002
Cr-Commit-Position: refs/heads/master@{#405175}

Now that FOR_EACH_OBSERVER supports dependent types, we can use it
instead of its expansion.

BUG=627209
TEST=trybots

Review-Url: https://codereview.chromium.org/2147443005
Cr-Commit-Position: refs/heads/master@{#405174}

This patch makes setting of the lowbox toke a warning rather than a hard
failure. Some configurations cause the setting of the token to fail, this
is most likely issues with third party software. Worst case this will mean
that the lowbox token is not set, but we'll continue with the original
restricted token sandbox.

BUG=501975
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2130753002
Cr-Commit-Position: refs/heads/master@{#405173}

Include fixes.

https://chromium.googlesource.com/external/swarming.client.git/+log/df6e95e76698..7f63a272f7d9

$ git log df6e95e76..7f63a272f --date=short --no-merges --format='%ad %ae %s'
2016-07-12 maruel Add default output directory name.
2016-07-07 nicholaslin Fix stream_client() in bootstrap.py.
2016-06-23 tansell luci-py: Making __file__ usage unicode safe.
2016-06-23 nodir run_isolated: change cipd package flags
2016-06-22 borenet Add --cipd-package flag to swarming.py
2016-06-22 maruel Fix encoding for isolateserver_smoke_test.
2016-06-20 bpastene Correct ${SWARMING_BOT_FILE} run_isolated value documentation.
2016-06-16 nodir swarming: do not leak cache dirs in tests
2016-06-15 nodir swarming-cipd: custom installation paths
2016-06-14 nodir swarming-cipd: fix for Windows
2016-06-10 bpastene Change swarming's on_before_task hook to dump bot state to a file.
2016-06-10 maruel Add command to cancel a task.
2016-06-09 nodir run_isolated.py: install CIPD packages
2016-06-07 vadimsh Do not rely on IP whitelist during bot bootstrap process.
2016-06-07 vadimsh Send authorization headers when calling Swarming backend.
2016-06-03 nodir Fix abstraction leak in LocalCache implementations
2016-06-03 vadimsh Add file_path.atomic_replace function.
2016-06-03 nodir refactor isolate stats protocol
2016-06-01 kjlubick Clean out the isolate cache after every poll
2016-05-31 vadimsh Increase timeouts in threading_utils_test.py.
2016-05-30 maruel Inhibit OS error reporting in python processes.
2016-05-27 nodir task_runner: always use run_isolated
2016-05-25 maruel Changing license header, again!
2016-05-25 maruel Add deployment documentation and generally improve the doc.
2016-05-24 nodir run_isolated: fix python path
2016-05-17 dnj Add LogDog Python client library.
2016-05-13 nodir Do not add empty option group
2016-05-12 maruel Backport two subprocess42 fixes done in recipe_engine.
2016-05-12 nodir swarming: change meaning of inputs_ref
2016-05-06 iannucci Fix bug in subprocess42 with super-fast processes.
2016-05-03 nodir run_isolated: close storage
2016-05-03 nodir run_isolated: support non-isolated commands
2016-04-29 nodir run_isolated: move isolation stats from map_and_run
2016-04-29 nodir swarming: add fs.ensure_dir
2016-04-29 borenet Add diff_isolates.py script
2016-04-21 sergeyberezin luci-py: roll infra_libs to b6cb5db
2016-04-15 sergeyberezin luci-py: roll infra_libs / gae_ts_mon to 4d74a66
2016-04-13 maruel Enforce users to specify a 'pool' dimension when triggering a task.
2016-04-13 maruel Strip xsrf_client.
2016-04-13 maruel Use PerformanceStats generated by run_isolated.
2016-04-08 maruel Automatically trim the isolated cache on bot startup.
2016-04-08 maruel Make run_isolated trim as it is downloading files.
2016-04-08 maruel Stop choosing $TMPDIR as a safe place to create hardlinks on OSX.
2016-04-08 maruel Remove require_command arg from fetch_isolated().
2016-04-05 maruel Change run_isolated.py to output statistics in its json output file.
2016-04-05 maruel Update copyright notice from Swarming to LUCI; add AUTHORS and CONTRIBUTORS.
2016-03-29 sergeyberezin luci-py: Roll ts_mon to 9f215df
2016-03-17 maruel Fix run_on_bots.py.
2016-03-17 maruel Fix url_open() with gzip encoding.
2016-03-16 maruel Add 'is_fine'; fix 'swarming.zip attributes'; update httplib2; add logging.
2016-03-03 sergeyberezin Roll ts_mon to 4b3e37f
2016-03-01 maruel Print an error when running swarming.py reproduce twice in a row.

R=nicholaslin@google.com
TBR=agrieve@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2146913002
Cr-Commit-Position: refs/heads/master@{#405172}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/990ed91c..2faaf5ec

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2151483002
Cr-Commit-Position: refs/heads/master@{#405171}

The new baselines (-expected.txt and -expected.png) were downloaded by running:

  Tools/Scripts/webkit-patch rebaseline-from-try-jobs

BUG=474273

Review-Url: https://codereview.chromium.org/2106873003
Cr-Commit-Position: refs/heads/master@{#405170}

Revert of Roll buildtools aa47d9773d..924d50ecae (patchset #1 id:1 of https://codereview.chromium.org/2138013004/ )

Reason for revert:
Broke uses of 'clang=1 llvm_force_head_revision=1' on clang tot waterfall:
https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot

Original issue's description:
> Roll buildtools aa47d9773d..924d50ecae
>
>   In order to roll GN b9999d69..4828a631 (r403866:r404813) and pick up
>   the following changes:
>
>   5662a808 GN: Don't define argument overrides globally
>   45a841b0 Suggest `gn help` for internally set arguments.
>   bf462ea0 [GN docs] Add missing word in gn actions help string
>   8273381e Fix typos in GN error message
>
> TBR=dpranke@chromium.org
>
> Committed: https://crrev.com/932788e86f1f59cdff52df8ae78784af6f8a17e6
> Cr-Commit-Position: refs/heads/master@{#405054}

TBR=dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2146023002
Cr-Commit-Position: refs/heads/master@{#405169}

I moved this code out of VisualViewport in r404359 but forgot this one check
and early-out. The crashes started happening right after that so it's likely the
culprit.

BUG=627442

Review-Url: https://codereview.chromium.org/2140263002
Cr-Commit-Position: refs/heads/master@{#405168}

https://chromium.googlesource.com/skia.git/+log/e3aea10428d1..9199a9fef989

$ git log e3aea1042..9199a9fef --date=short --no-merges --format='%ad %ae %s'
2016-07-13 robertphillips Move GrDrawTarget::clear logic into GrDrawContext

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2147853004
Cr-Commit-Position: refs/heads/master@{#405167}

BUG=588956

Review-Url: https://codereview.chromium.org/2133383002
Cr-Commit-Position: refs/heads/master@{#405166}

Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001 of https://codereview.chromium.org/2138513002/ )

Reason for revert:
Caused unit_tests failure on Linux ChromiumOS Tests (1):

ArcAppModelBuilderTest.RemoveAppCleanUpFolder

Original issue's description:
> arc: Use the new InstanceHolder for unittests
>
> Instead of having unit tests go through Mojo and jump through hoops to
> ensure that all messages have propagated to all the threads, we can use
> the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> directly set the concrete fake (and optional version). This simplifies
> testing quite a bit.
>
> BUG=626695
> TEST=trybots
>
> Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> Cr-Commit-Position: refs/heads/master@{#405138}

TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626695

Review-Url: https://codereview.chromium.org/2146573005
Cr-Commit-Position: refs/heads/master@{#405165}

Disable Full-WPO for the x64 official builds (this doesn't
affect the PGO builds).

This should help me to get an official
"non-PGO & non-WPO" build that I can compare against an official PGO
build.

Also I'm not sure if it's worth keeping WPO turned on for the official
builds at the moment ? We don't ship these builds (we ship the PGO ones)
and so this only slowdown the builders that build an official x64 build
for testing purposes (especially considering that they need to link all the unittests with Full-WPO)

BUG=490934, 617982

Review-Url: https://codereview.chromium.org/2142603002
Cr-Commit-Position: refs/heads/master@{#405164}

The underlying issues with Flash fullscreen and OOPIFs were already
fixed by https://codereview.chromium.org/1973813002, and this follows
up with a test.  Note that the test doesn't actually turn on
--site-per-process so that we get coverage both with OOPIFs (on Site
Isolation FYI bots) and without (on regular bots).

BUG=593522
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2123093005
Cr-Commit-Position: refs/heads/master@{#405163}

BaseFeatureProvider is currently the only implementation of
FeatureProvider (despite its name implying there should be more). As we
move to generated code for Features, pulling the code to vend features
away from the code to populate from a JSON file is necessary.

Pull the parsing/population code out of BaseFeatureProvider into a
JSONFeatureProvider class, inheriting from BaseFeatureProvider (which
maintains the code for returning features). Generated FeatureProviders
will also inherit from BaseFeatureProvider.

BUG=280286

Review-Url: https://codereview.chromium.org/2133783002
Cr-Commit-Position: refs/heads/master@{#405162}

BUG=619086

Review-Url: https://codereview.chromium.org/2140793002
Cr-Commit-Position: refs/heads/master@{#405161}

The UI calls MostVisitedSites::RecordOpenedMostVisitedItem when an item is clicked. Before this CL, MostVisitedSites would get some info from its |current_suggestions_|, but those might have changed in the meantime. Now, all required info is passed into RecordOpenedMostVisitedItem instead.

BUG=612160

Review-Url: https://codereview.chromium.org/2136503002
Cr-Commit-Position: refs/heads/master@{#405160}

Reland of Make components source_sets on Android. (patchset #1 id:1 of https://codereview.chromium.org/2151523002/ )

Reason for revert:
Didn't help.

Original issue's description:
> Revert of Make components source_sets on Android. (patchset #1 id:1 of https://codereview.chromium.org/2137023003/ )
>
> Reason for revert:
> Speculative, might've broke llvm_force_head_revision=true builds (see comment on the original review).
>
> Original issue's description:
> > Make components source_sets on Android.
> >
> > There was a perf regression reported when components were changed from source sets to static libraries in the non-component build. This patch switches back to source sets on Android only to see what happens to thread_times.key_silk_cases and the build performance.
> >
> > BUG=619593
> >
> > Committed: https://crrev.com/89248dc70996f9927292a7fee6911715464e1643
> > Cr-Commit-Position: refs/heads/master@{#405056}
>
> TBR=dpranke@chromium.org,brettw@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619593
>
> Committed: https://crrev.com/aa5466df6e58dd54bc1dd1a5192f2c52ebf6ff29
> Cr-Commit-Position: refs/heads/master@{#405152}

TBR=dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619593

Review-Url: https://codereview.chromium.org/2145063002
Cr-Commit-Position: refs/heads/master@{#405159}

GCCC_ERROR_ACCESSDENIED is a reason value, not a return value.

GetRealUserId() doesn't need to be called until it's needed, and if it
fails, only FindChromeTicket(kUserTicket) needs to be skipped, not the
whole rest of the function.

Review-Url: https://codereview.chromium.org/2151503002
Cr-Commit-Position: refs/heads/master@{#405158}

Before, Sandwich was modifying local cache directories by issuing
cachetool commands sequentially. But it was painfully slow.

This CL implement the cachetool's batch mode that process sequence
of command received from the stdin and return the commands results
in the stdout. This way, Sandwich just have to launch cachetool once
in the background and push to its stdin commands to process.

On cache directories populated by big webpages such as cnn.com's
home page, the Sandwich cache processing for NoState-Prefetch
emulation was taking 491s when spawning one cachetool process
for each commands versus 3s with this new online mode.

BUG=582080

Review-Url: https://codereview.chromium.org/2114933002
Cr-Commit-Position: refs/heads/master@{#405157}

When merging before submitting, this change did not make it into
codereview.chromium.org/2070633002.

As it stands, this CL reduces .dex size by 127kb and saves us 27kb of
dirty memory per process.

See paste.googleplex.com/6304692032241664 for what was removed.

BUG=619937

Review-Url: https://codereview.chromium.org/2147583003
Cr-Commit-Position: refs/heads/master@{#405156}