GitLab

Review URL: https://codereview.chromium.org/441593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287706 0039d316-1c4b-4281-b951-d872f2087c98

Ephemeral apps are unloaded and disabled after they stop running to
ensure that they have no background activity while they are cached.

The event router, message service and message center no longer need
special handling for idle ephemeral apps.

BUG=339001,358052
TEST=browser_tests
TBR=dewittj@chromium.org (for removal of code in message_center_settings_controller.cc)

Review URL: https://codereview.chromium.org/344543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287705 0039d316-1c4b-4281-b951-d872f2087c98

If the QPC value is less than 44 bits, it is safe to multiply by a 20 bits
value (1000000) without risking overflow. This optimization reduces the
call time by half.

BUG=158234

Review URL: https://codereview.chromium.org/429743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287704 0039d316-1c4b-4281-b951-d872f2087c98

page_test.py.

Fixed all files that refer to MeasurementFailure in this patch. Rest of
subclasses of PageMeasurement will be fixed in a follow up patch.

BUG=383635

Review URL: https://codereview.chromium.org/434443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287703 0039d316-1c4b-4281-b951-d872f2087c98

The window title should be "Settings - Keyboard settings", but that
prefix is missing.

This doesn't change the title display within the overlay itself
("Keyboard settings").

R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/442583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287702 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/441023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287701 0039d316-1c4b-4281-b951-d872f2087c98

Move construction of flow_controller_ to QuicSession constructor to avoid streams being initialized with a NULL ptr.
BUG=

Review URL: https://codereview.chromium.org/442943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287700 0039d316-1c4b-4281-b951-d872f2087c98

This removes the setting entirely since it's always true in production.
Once we stop setting it, we can remove it from blink.

BUG=365857

Review URL: https://codereview.chromium.org/443573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400553

Review URL: https://codereview.chromium.org/419683014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287698 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287697 0039d316-1c4b-4281-b951-d872f2087c98

$ git log 9755ed384..bbf1fcca7 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-08-05 maruel Improve the load test script.
2014-08-04 maruel Fix a secondary exception when an error occurs to delete a directory.
2014-08-01 maruel Save client json data on the fly as the load test is on-going.

R=csharp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/442063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287696 0039d316-1c4b-4281-b951-d872f2087c98

This will be used by Android Chrome to register external
experiments.

BUG=400357

Review URL: https://codereview.chromium.org/440693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287695 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394855

Review URL: https://codereview.chromium.org/438163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287694 0039d316-1c4b-4281-b951-d872f2087c98

Since we create and rasterize mask and replica layer tiles as well,
we need to ensure that they get the DidBecomeActive signal in order
to ensure the tile priorities of the contained tiles are correct.
(DidBecomeActive switches active and pending priorities and clears
the pending priority). Without this, there are cases where the pending
priority can remain high without any mechanism clearing it.

BUG=400560
R=enne

Review URL: https://codereview.chromium.org/441863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287693 0039d316-1c4b-4281-b951-d872f2087c98

Add a basic browser test for functions in notification provider API.
This is mainly to test the connection and provide a skeleton for future
tests. The functions are not fully implemented yet, and more tests will
be added as the functions are implemented.

BUG=

Review URL: https://codereview.chromium.org/416423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287692 0039d316-1c4b-4281-b951-d872f2087c98

Home Card will be minimized when an activity is activated, so don't re-activate home card. There is also no need to activate bottom home card, so activate the centered home card only.

BUG=400575

Review URL: https://codereview.chromium.org/435293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396403

Review URL: https://codereview.chromium.org/432473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287690 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces the PrefHashBrowserTestBase fixture which these tests are based on.

This fixture (in conjunction with the new PREF_HASH_BROWSER_TEST macro) provides an easy way to override 3 methods in order to:
 1) Setup Chrome as desired in a PRE_ test.
 2) Attack Preferences while Chrome isn't running.
 3) Relaunch Chrome and verify reaction to attacks.

The fixture+macro also parametrizes every test such that they are ran in every SettingsEnforcement trial group.

A few pieces were resurrected from the old PrefHashBrowserTest used to test unloaded profile seeding prior to http://crrev.com/277209

Review URL: https://codereview.chromium.org/431973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287689 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes vectors from the eviction tile
iterator at the layer level. It reworks the code
a bit to use the underlying layer's tilings
directly using indecies and ranges, instead of
constructing a separate vector to hold the
values.

As well, this ensures that the iterators
are only created when they are visited.


R=reveman

Review URL: https://codereview.chromium.org/428533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287688 0039d316-1c4b-4281-b951-d872f2087c98

There is a chance that the Demuxer calls host_->OnDemuxerError() right
before Stop() is called. The Pipeline always posts a ErrorChangedTask() for
OnDemuxerError() with base::Retained(this).

After the Demuxer fires the stop callback, the Pipeline could be destroyed
immediately. So If the media thread hasn't been destroyed we could end up with
running ErrorChangedTask() on null pipeline which causes a crash.

This CL uses a weak pointer for DemuxerHost calls so that no task will run
after the pipeline is destroyed.

BUG=397656, 399417, 365141
TEST=Updated unit tests to cover this case.
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/423073012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287687 0039d316-1c4b-4281-b951-d872f2087c98

Forward the boolean flag indicating if the resource is lost and let
canvas handle how to handle the lost resource, not simply ignore to
call mailboxReleased.

BUG=390960

Review URL: https://codereview.chromium.org/369823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287686 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287685 0039d316-1c4b-4281-b951-d872f2087c98

Move avatar_menu to disable-enable flag. A future CL will set the default behavior to be new_avatar_menu=enabled.

BUG=391497
TBR=davemoore@chromium.org (changes are very minor and are in unit tests)

Review URL: https://codereview.chromium.org/431083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287684 0039d316-1c4b-4281-b951-d872f2087c98

Needed to fix libppGoogleNaClPluginChrome.so breakage.

BUG=394497
R=vapier@chromium.org
TBR=teravest@chromium.org, vapier@chromium.org

Review URL: https://codereview.chromium.org/445833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287683 0039d316-1c4b-4281-b951-d872f2087c98

The message center already does this for notifications with a higher
priority than the notification they replace, but this makes it explicit
for Web Notifications (which cannot indicate priority).

TBR=dewittj (reviewed in cl 301713002)
BUG=366102

Review URL: https://codereview.chromium.org/439073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287682 0039d316-1c4b-4281-b951-d872f2087c98

Update the contextual search API to include a parameter specifying whether the server shoudl return a resolved search term.

BUG=397734,397738

Review URL: https://codereview.chromium.org/424013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287681 0039d316-1c4b-4281-b951-d872f2087c98

Each application <> shell connection is represented by a ShellImpl instance
on the shell side. This CL makes the Application watch its ShellPtr for pipe
errors so it can Quit() itself if the shell goes away (shell loop destroyed).

mojo_shell_tests starts using a new method to terminate all shell connections
in this CL, and waits afterward until KeepAlive quits the loop signifying that
all apps are gone. This is done prior to destroying the shell MessageLoop so
that the test ensures apps have all died before the next test. In the future
it would be a test failure if this wasn't a no-op, but we have things in the
shell that don't quit themselves right now.

The shell itself won't wait around for apps to die (as of this CL), but
~MessageLoop will still send the message to Application sides that will quit.

** NOTE ** This does not require an app build target to explicitly add magic
*.cc files to their sources.  It requires selecting an appropriate
mojo_application_{chromium, standalone} library akin to mojo_environment_*.
We can possibly combine these two in the future.

BUG=394477

Review URL: https://codereview.chromium.org/394903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287680 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

BUG=388517

Review URL: https://codereview.chromium.org/432133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287678 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the options of customizing external display's device
scale factor from the options page. There are two TODOs though:
- the configured device scale factor should be stored
- not possible to specify device scale factor and resolution at the
  same time; from 1600x900, it can't enter to 1920x1080(2x). Instead
  it enters to 3840x2160, then the user needs to select 2x again.

Actually the former would solve the latter; this CL sets the new
resolution and the DSF at the same time but resolution change is
asynchronous, so changed DSF will be overwritten by the resolution
change.

I will address these issues in further CL(s).

BUG=396704
R=oshima@chromium.org, stevenjb@chromium.org
TBR=asvitkine@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/417113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393235

Review URL: https://codereview.chromium.org/396293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287676 0039d316-1c4b-4281-b951-d872f2087c98

Makes a window that has been resized to maximized bounds, then maximized and then restored shrink. This allows it to be resized easier after this sequence.

BUG=392599
TEST=ash_unittests --gtest_filter="WindowStateTest.RestoredWindowBoundsShrink"
TEST=unit_tests --gtest_filter="WindowSizerAshTest.DefaultStateBecomesMaximized"
TEST=unit_tests --gtest_filter="WindowSizerAshTest*"

Review URL: https://codereview.chromium.org/424463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287675 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287669 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fix and reenable checkbox in Polymer page set. (https://codereview.chromium.org/437353002/)

Reason for revert:
Fails on N5 (at least).

Unhandled exception while running http://www.polymer-project.org/components/paper-elements/demo.html#paper-checkbox

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:533
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:232
    self._RunMethod(page, self._action_name_to_run, action_runner)
  _RunMethod at tools/telemetry/telemetry/page/page_test.py:241
    run_method(action_runner)
  RunSmoothness at tools/perf/page_sets/polymer.py:124
    self.TouchEverything(action_runner)
  TouchEverything at tools/perf/page_sets/polymer.py:154
    self.DoActionOnWidgetType(action_runner, tappable_type, self.TapWidget)
  DoActionOnWidgetType at tools/perf/page_sets/polymer.py:169
    element_query + '.offsetParent != null'):
  EvaluateJavaScript at tools/telemetry/telemetry/page/actions/action_runner.py:148
    return self._tab.EvaluateJavaScript(expression)
  EvaluateJavaScript at tools/telemetry/telemetry/core/web_contents.py:108
    expr, context_id=None, timeout=timeout)
  EvaluateJavaScriptInContext at tools/telemetry/telemetry/core/web_contents.py:124
    expr, context_id=context_id, timeout=timeout)
  EvaluateJavaScript at tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:176
    return self._runtime.Evaluate(expr, context_id, timeout)
  Evaluate at tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py:46
    raise exceptions.EvaluateException(res['result']['result']['description'])
EvaluateException: TypeError: Cannot read property 'offsetParent' of undefined

Locals:
  context_id : None
  expr       : 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null'
  request    : {'params': {'returnByValue': True, 'expression': 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null'}, 'method': 'Runtime.evaluate', 'id': 173}
  res        : {u'id': 173, u'result': {u'wasThrown': True, u'exceptionDetails': {u'url': u'', u'text': u"Uncaught TypeError: Cannot read property 'offsetParent' of undefined", u'line': 1, u'column': 68}, u'result': {u'className': u'TypeError', u'type': u'object', u'description': u"TypeError: Cannot read property 'offsetParent' of undefined", u'objectId': u'{"injectedScriptId":4,"id":1}'}}}
  timeout    : 90

http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1213/steps/smoothness.polymer/logs/stdio

Original issue's description:
> Fix and reenable checkbox in Polymer page set.
> 
> BUG=394756
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287596

TBR=dtu@chromium.org,nduca@chromium.org,wiltzius@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=394756

Review URL: https://codereview.chromium.org/443793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287667 0039d316-1c4b-4281-b951-d872f2087c98

This isn't right from a UI perspective. Needs to be reimplemented and put
through UI review.

> Make chrome app colored frames available on ChromeOS.
> 
> This feature has been available on Windows and Mac for some time, but
> was never made available on ChromeOS.
> 
> BUG=371642
> 
> Review URL: https://codereview.chromium.org/407073002

TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/442853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287661 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287655 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287654 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (ht… (https://codereview.chromium.org/444453002/)

Reason for revert:
Macbots are getting stuck here:
[       OK ] page_runner_unittest.PageRunnerTests.testDiscardFirstResult (10464 ms)
[ RUN      ] page_runner_unittest.PageRunnerTests.testHandlingOfCrashedTab
[ RUN      ] chrome://crash

http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.6%20Tests%20(3)
http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.7%20Tests%20(3)

Original issue's description:
> Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (https://codereview.chromium.org/318123002/)"
> 
> This reverts https://codereview.chromium.org/320693002/
> 
> The original regression this caused (PageRunnerTests.testHandlingOfCrashedTab in telemetry_unittests) does not seem to be happening anymore (locally or on trybots), but please revert and let me know if it happens on the main waterfall.
> 
> TBR=tonyg,dtu
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287612

TBR=tonyg@chromium.org,dtu@chromium.org,oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/446743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298788
NOTRY=true
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/446643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287647 0039d316-1c4b-4281-b951-d872f2087c98

This test times out on Windows.

BUG=400922
TBR=tonyg@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/441153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287646 0039d316-1c4b-4281-b951-d872f2087c98

This gives an idea how long it took a connection to complete as well
as the arrival of data messages.

Also records received GCM data burst size and intervals in UMA, and
added previously left-out xml description for another UMA metric.

jar: please review histograms.xml

BUG=386273

Review URL: https://codereview.chromium.org/409653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287645 0039d316-1c4b-4281-b951-d872f2087c98