- 01 Aug, 2019 40 commits
-
-
Alex Danilo authored
Feedback panels were visible on all active File Manager windows. Disable display of the panels if the File Picker is active which is deduced by using the 'type' of the main window body and using the existing CSS rule for visibility when the main body type is 'full-page' only. Also moves the panel location in the DOM to be contained by the dialog main panel in all cases so that positioning for layout will be relative to the dialog-main <div> rather than the 'dialog-container'. No-try: true Bug: 988193 Tests: browser_tests --gtest_filter="*PanelsDisabled". Change-Id: I5d152ab8a0d2cd7bf299c706223505da97ca7a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723572Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683080}
-
Shuo-Peng Liao authored
PIXEL_FORMAT_MT21 maps to V4L2 fourcc format MT21, a proprietary format used for an intermediate frame between certain v4l2 video decoder and image processor. As long as we directly pass platform specific format via ImageProcessor::PortConfig, we shall remove the format which will not be seen outside platform specific implementation. BUG=985683 TEST=Run VDA_unittest and media_unittest on elm Change-Id: Ifb55f18d7cf71e6ea98749eff4d701cef30e472b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723852 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#683079}
-
Piotr Pawliczek authored
This is a fuzzer for ZeroconfPrinterDetector. Currently it works only with a set variable ASAN_OPTIONS=detect_odr_violation set to 0 or 1. According to OSS-Fuzz team, it is allowed and compatible with ClusterFuzz configuration. BUG=chromium:969666 TEST=tested locally on my workstation Change-Id: Ia614858c5f82e3b831d0c842f6f768b91149db45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675686Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683078}
-
David Benjamin authored
Bug: none Change-Id: I6802b933c8d09f1d0d7f08abd11df13877c3e91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727436Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#683077}
-
Ramin Halavati authored
No comments! Change-Id: Ibec9b76e384895a9376b3c6391c61f9327282e60 TBR: nicolaso@chromium.org Change-Id: Ibec9b76e384895a9376b3c6391c61f9327282e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730151Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#683076}
-
Minggang Wang authored
This CL typemaps network.mojom.URLRequest with network::ResourceRequest for Blink variant. As it's the last CL of this series, the temporary url_request_for_blink.typemap will be deleted, and we will share the url_request.typemap used for Chromium variant. The final typemapping is: Before: none After: typemap with network::ResourceRequest This CL is part of a series of CLs which are targeted to typemap network.mojom.URLRequest with network::ResourceRequest for Blink variant finally. 1. https://chromium-review.googlesource.com/c/chromium/src/+/1669131 2. https://chromium-review.googlesource.com/c/chromium/src/+/1672768 3. https://chromium-review.googlesource.com/c/chromium/src/+/1680505 4. https://chromium-review.googlesource.com/c/chromium/src/+/1679984 5. This CL BUG=860403 Change-Id: I556712ff10efdc621fe46e019d24dd1ee4d8c419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683493Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#683075}
-
Eric Willigers authored
The Launch Service is used to open a new application window. TBR=avi@chromium.org Bug: 966288 Change-Id: Ibc7c1f49fa109335e81744ddda292a08f36b80a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723794 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#683074}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3157c496d4b..2bd4cf346e06 git log f3157c496d4b..2bd4cf346e06 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 rmhasan@google.com [Typ] Create a public static method in TestExpectations which finds unused expectation patterns Created with: gclient setdep -r src/third_party/catapult@2bd4cf346e06 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:973936 Change-Id: Idfbbed3965076caced3f3322e8cf8216a2db18d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683073}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2880bd346d5c..5136bc88d5ae Created with: gclient setdep -r src-internal@5136bc88d5ae The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iee1d8d756f632c1633e6a837d45b9d209f8b5637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730752Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683072}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/588b4604c876..dcf3c07791fc git log 588b4604c876..dcf3c07791fc --date=short --no-merges --format='%ad %ae %s' 2019-08-01 hidehiko@chromium.org chromite: Run TastVMTest on betty-release. Created with: gclient setdep -r src/third_party/chromite@dcf3c07791fc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iabdf4e900c515a91fd7262ed4943f47faffb1f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730751Reviewed-by:
-
Robert Ogden authored
It's not useful or used. Bug: 986522 Change-Id: Ic091ba24ea35e26e86750a722fa0a0dd22ef0039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729532Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#683070}
-
David Benjamin authored
The CQ has been preventing changes that touch annotations.xml from landing: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906385911867632656/+/steps/check_network_annotations__with_patch_/0/stdout There were problems with two of the entries. https://chromium-review.googlesource.com/c/chromium/src/+/1724519 fixed one of them, but then https://chromium-review.googlesource.com/c/chromium/src/+/1715304 reverted it in a mismerge. Additionally, https://chromium-review.googlesource.com/c/chromium/src/+/1726655 introduced a new instance. Fix them. Bug: none Change-Id: I254823c436a6fbffb2e20591c2ba1eb0346585ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729806 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This is a preparation CL for WorkerShadowPage removal. Before this CL, outside FetchClientSettingsObject is created by WorkerShadowPage's Document. After this CL, it's manually created by WebSharedWorkerImpl. This doesn't change the existing functional behavior. Ideally, FetchClientSettingsObject should be passed from the connector's Document via the browser process, but it's out of the scope of this CL. Bug: 538751, 937177 Change-Id: I6f17fb291d461d1901dfcb7a225bcba7e3e08dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730489 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#683068}
-
Kunihiko Sakamoto authored
Before this patch, SignedExchange certificates with validity periods longer than 90 days were allowed if: - current time is before 2019-08-01 00:00 UTC, and - the certificate was issued before 2019-05-01. Now the first condition is always false, so we only have to check the validity period. Bug: 953165 Change-Id: Iba4d8a4b067efce9acb698329be90a32c9a1728d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728578Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#683067}
-
Hirokazu Honda authored
VideoFrame::RowBytes() computes the bytes per one row of a buffer. It is used to compute a height in VerifyVideoFrame(). This correct the computation by using VideoFrame::Rows(). Bug: None Test: video.ARC* Change-Id: I321cd77f689ecb2ad0f6099ed573a17e1282ca80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730312 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8f8354a9a3c6..78eedba78f03 git log 8f8354a9a3c6..78eedba78f03 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 reed@google.com WIP: hack to try combining bicubic stage Created with: gclient setdep -r src/third_party/skia@78eedba78f03 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: Icd308abe53c83e8590a24eb01bc17fe1020e3106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730649Reviewed-by:
-
Nigel Tao authored
BUG=826982 BUG=989789 Change-Id: I49bd3793bf9fcfc89726fd2f7df690421996e0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728411Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c2ae9342875..2880bd346d5c Created with: gclient setdep -r src-internal@2880bd346d5c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id20c203af9a0b72680c2fecc1899b351f50ca0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730609Reviewed-by:
-
Kenichi Ishibashi authored
This reverts commit 7bfff78e. We are going to remove legacy on-the-main-thread script fetch soon. Bug: 967272 Change-Id: Ic191ce2a77deb153c7b4c6f1a90fb8cbd2ce8c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730652Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683062}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 75be86d0. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ibbe90a49d72b4376a3e5a50da99a300805a3bb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729401Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683061}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLBRElement> and DynamicTo<HTMLBRElement> as new downcast helper. 2. Use IsA<HTMLBRElement>(element) in place of IsHTMLBRElement(element) Bug: 891908 Change-Id: I8f9a3b2854ad4539ec571512ce97ac9a81552652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728129Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/78b685d68f34..588b4604c876 git log 78b685d68f34..588b4604c876 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@588b4604c876 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I296ce247e6d7ae19b98bbe416fe26bf2e642f0ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730509Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/471a922d82ca..f3157c496d4b git log 471a922d82ca..f3157c496d4b --date=short --no-merges --format='%ad %ae %s' 2019-08-01 simonhatch@chromium.org Pinpoint - Record job timings Created with: gclient setdep -r src/third_party/catapult@f3157c496d4b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:987371 Change-Id: Ib832aa6444600e26a21eff93e397304e89183f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730179Reviewed-by:
-
tby authored
The RecurrenceRanker isn't threadsafe, so we should formalize this. This CL adds a sequence DCHECK to all public methods (and a couple of private callbacks, for clarity). Bug: 921444 Change-Id: Ib52f8e33be82de147efd23e67c424083ff980184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729991Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#683057}
-
Paul Dyson authored
Move to a helper file some functions and constants that will be needed for inference. Bug: 899123 Change-Id: I5e4984fafd084abb2a3ae8ca02e42290d5f52479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727851Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
-
Alan Cutter authored
There is no Extension specific code in PendingBookmarkAppManager anymore, this code and its tests can be generalised as BMO/Extension agnostic web app code. This also renames BookmarkAppInstallationTask to PendingAppInstallTask. Bug: 916381 Change-Id: Id6972624100d1da1d326e099ad86c20b86a482e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725426 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Kyle Milka authored
Make it so either a tile can be selected or the switch can be toggled on. Bug: 937570 Change-Id: I2b4b75670d49419eeaa235f567282146e817a37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726818 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#683054}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I6fe0d6e37e34a483082da5a7950c21a60178a10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730550Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683053}
-
Patrick Monette authored
Third-party DLL blocking is still not enabled those metrics are still needed to monitor the feature. Bug: 975735 Change-Id: I7a6fa9166a4314ba301f3213a90bb4186d8dfcc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721354Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#683052}
-
Patrick Monette authored
The metrics that it's recording are no longer needed and would expire soon anyways. Bug: 975034, 975126, 975551 Change-Id: Icec43cbaed375a0206db64c107bd6931fc6dc5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715634Reviewed-by:
-
Raymes Khoury authored
Currently we allow any URLs to be handlers for calls to registerProtocolHandler as long as they are same origin accessible. However: 1) This has led to bugs (see below) 2) It doesn't make much sense for handlers to be data:, blob: URLs etc 3) The spec gives freedom to implementers to add additional checks like this https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers 4) The guidance on https://developer.mozilla.org/en-US/docs/Web/API/Navigator/registerProtocolHandler states that "The handler's URL must use one of "http" or "https" as its scheme." (even though this isn't mandated in the spec) 5) Firefox restricts handlers to https. This CL requires http/https or chrome-extension URL handlers. Chrome status entry: https://chromestatus.com/feature/5066079862784000 Note: This CL was originally landed without support for chrome-extension URLs. The updated CL includes support and a test for this case. Bug: 971917,952974 Change-Id: I89d47e7daf45b9e7c36a25c629494531ef660d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728369 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#683050}
-
tby authored
We have an on-device model ranking commonly used URLs in the CrOS launcher, which stores these URLs in the model itself. This CL observes the history service and deletes URLs from the model that are removed by the user. Bug: 931149 Change-Id: If9e9654a00ae804807319a3dc5dc91b599698c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725032 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683049}
-
Kalon Hinds authored
This patch adds current line number and file line number range to the GoToLine dialog in the Sources tool. This allows vision impaired people to know their location in a file via ctrl+g. The UI affordance is similar to the experience in VSCode. Before: https://i.imgur.com/D3thzu4.png After: https://i.imgur.com/SHttcdD.gif Bug: 963183 Change-Id: I72fbc64b7e916438dfb1f3db883cc34f2a7e00b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660789 Commit-Queue: Kalon Hinds <kahinds@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#683048}
-
Kevin Marshall authored
Allows the Agent to control some runtime aspects of Cast applications, like enabling touch input. * Adds unit test and integration tests to verify Frame interactions and publishing logic. * Adds the new Cast unit test suite to the trybots. Bug: 953796,953958 Change-Id: I58c2f8eb95cfc7441e27fd85393dd05cce0f35de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672109Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#683047}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea9798c5eb96..fd643a4782c9 git log ea9798c5eb96..fd643a4782c9 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 pacaro@google.com Build core audio for older windows versions 2019-07-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1bdd7918..d488661c (682806:682945) Created with: gclient setdep -r src/third_party/webrtc@fd643a4782c9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Ib4080c3b5779d8786ad015ad9107ee1ffadc981a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729206Reviewed-by:
-
Gayane Petrosyan authored
Custom color picker with following features: - keyboard navigation - preselect - updates color picker colors according to the generated theme - maintains the selected color while the dialog is open, even when other tiles are selected, but resets after dialog is closed. screencast: https://screencast.googleplex.com/cast/NjM3NTk3NTc5MTA5OTkwNHwxNjY5MDE1Mi1kYg Bug: 988066 Change-Id: I4d1b6a1ecb0e4daf81806327f3b613a704a1df96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723019 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Before this patch: The permanent Bookmark Mobile folder is created only during initial Sync on the server. After this patch: The permanent Bookmark Mobile folder is also created for existing users as well upon GetUpdatesRequest. This is more aligned with the implementation of the real Sync server. Change-Id: I7e4c6bb348528b23a46c0fc0751bf8173cbcc716 Bug: 989440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728581 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#683044}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/acd8dbea94f7..8f8354a9a3c6 git log acd8dbea94f7..8f8354a9a3c6 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 bsalomon@google.com Reland "Remove GrCaps::SupportedRead::fSwizzle and supporting code" 2019-07-31 benjaminwagner@google.com Revert "Remove GrCaps::SupportedRead::fSwizzle and supporting code" 2019-07-31 benjaminwagner@google.com Reland "Add LUM8 case to GrGLCaps::getYUVAColorTypeFromBackendFormat" Created with: gclient setdep -r src/third_party/skia@8f8354a9a3c6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I6dd456055554d93bea8a2ce9408398bd26bd5bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728348Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/033c7fb180fb..6d82d95f2dd0 git log 033c7fb180fb..6d82d95f2dd0 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 thestig@chromium.org Initialize CPDF_CMap members in the header. 2019-07-31 tsepez@chromium.org Remove CPDF_ModuleMgr. 2019-07-31 tsepez@chromium.org Break direct dependence between fpdfsdk and fxcodec. 2019-07-31 tsepez@chromium.org Remove unused header from cpdfxfa_context.cpp. 2019-07-31 thestig@chromium.org Fix a rendering bug with unwanted lines. 2019-07-31 thestig@chromium.org Add a pixel test for a rendering bug. Created with: gclient setdep -r src/third_party/pdfium@6d82d95f2dd0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I694ffee9084abf2bd1ba68a3166c2c4fcb5b0c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730047Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16a3e45749cb..1c2ae9342875 Created with: gclient setdep -r src-internal@1c2ae9342875 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I92ee7439632a84f8abfcddfc55412abdb49c5d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730274Reviewed-by:
-
