GitLab

This happens when a move animation starts while a resize animation, typically during creation is in progress. Now the animation starts from where the last one left.

Fixes a bug where from bounds and to bounds are reversed in the called StartBoundsAnimation in OnSizeChanged.

BUG=106573
TEST=Instructions in bug report.


Review URL: http://codereview.chromium.org/8879005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113746 0039d316-1c4b-4281-b951-d872f2087c98

PrintDialog crashes with the focus restore fix http://codereview.chromium.org/8821004 will be fixed with this patch.

BUG=109616
TEST=none

Review URL: http://codereview.chromium.org/8872043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113744 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98690
TEST=


Review URL: http://codereview.chromium.org/8095007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104361
TEST=Manual


Review URL: http://codereview.chromium.org/8821004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113741 0039d316-1c4b-4281-b951-d872f2087c98

base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8879032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113740 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113722 - Add Pass(), which implements move semantics, to scoped_ptr, scoped_array, and scoped_ptr_malloc.

This modification to the scopers implements the "moveable but not copyable" semantics that were introduced in C++11's unique_ptr<>.

With this, is now possible to use scopers as an argument type or a return type.  This signifies, in the type system, transfer of ownership into a function or out of a function respectively.  Calling, or returning such a function MUST use the temporary resulting from the scoper's Pass() function. You CANNOT just pass the scoper by copy as there is still no copy constructor or assignment operator; trying to do so will yield a compilation error.

This distinction makes it possible to avoid the implicit ownership transfer issues of auto_ptr, but still allow us to have compiler enforced ownership transfer.

Also adds a Passed() helper that allows using a scoper with Bind().

BUG=96118
TEST=new unittests

Review URL: http://codereview.chromium.org/8774032

TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/8890060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113738 0039d316-1c4b-4281-b951-d872f2087c98

This has to land after http://trac.webkit.org/changeset/101885 is rolled
into Chromium.

BUG=none

TEST=

Review URL: http://codereview.chromium.org/8788008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113735 0039d316-1c4b-4281-b951-d872f2087c98

gdk_pixbuf_render_to_drawable has been deprecated since libgtk 2.4 and
won't be in libgtk3 at all.

BUG=106060
TEST=none


Review URL: http://codereview.chromium.org/8890048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113733 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/8872001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113732 0039d316-1c4b-4281-b951-d872f2087c98

This will be needed to change the default of URLPattern to
USE_PORTS.

BUG=104104

Review URL: http://codereview.chromium.org/8885022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106543

Review URL: http://codereview.chromium.org/8872050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106902
TEST=none (just docs)


Review URL: http://codereview.chromium.org/8883031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106934
TBR=dtseng@chromium.org

Review URL: http://codereview.chromium.org/8873046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113727 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93571
TEST=none


Review URL: http://codereview.chromium.org/8806030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113726 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cbentzel
Review URL: http://codereview.chromium.org/8890058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113725 0039d316-1c4b-4281-b951-d872f2087c98

This replaces all calls to GetSurfaceNamed with GetImageNamed if the
image is theme dependent, or with calls to ResourceBundle if the image
can be shared across Profiles.

BUG=106060
TEST=none


Review URL: http://codereview.chromium.org/8866002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113724 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds virtual function in reverse interface needed to support
Native Client side debuggging only support for sending standard output
and standard error output (write syscall buffer contents) through the
reverse channel to the renderer to be transformed into PostMessage
data.  We do not use message channels because PPAPI currently does not
support message channels; instead messages are prefixed by a fixed
string which a debug-use-only event listener should match (and invoke
stopPropagation on).

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2474
TEST= nacl-side CL, see http://codereview.chromium.org/8825007


Review URL: http://codereview.chromium.org/8826005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113723 0039d316-1c4b-4281-b951-d872f2087c98

This modification to the scopers implements the "moveable but not copyable" semantics that were introduced in C++11's unique_ptr<>.

With this, is now possible to use scopers as an argument type or a return type.  This signifies, in the type system, transfer of ownership into a function or out of a function respectively.  Calling, or returning such a function MUST use the temporary resulting from the scoper's Pass() function. You CANNOT just pass the scoper by copy as there is still no copy constructor or assignment operator; trying to do so will yield a compilation error.

This distinction makes it possible to avoid the implicit ownership transfer issues of auto_ptr, but still allow us to have compiler enforced ownership transfer.

Also adds a Passed() helper that allows using a scoper with Bind().

BUG=96118
TEST=new unittests

Review URL: http://codereview.chromium.org/8774032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113722 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8831001

TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8889036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113719 0039d316-1c4b-4281-b951-d872f2087c98

(This only affects GPU bots).

Tested locally on Linux debug.

BUG=
TEST=GPU bots
Review URL: http://codereview.chromium.org/8890056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113718 0039d316-1c4b-4281-b951-d872f2087c98

If the avatar bubble closed while opening a profile we would crash.

Here's the sequence of events:
   AvatarMenuBubbleGtk::OpenProfile
      ->SwitchToProfile();
          ...
            AvatarMenuBubbleGtk::OnDestroy()
                delete this;
      this->bubble_->Close();  <--- crash here because this is deleted

To prevent these kinds of errors I changed the OnDestory() code to use MessageLoop::DeleteSoon(). This ensures that there no AvatarMenuBubbleGtk functions are in the backtrace when the bubble is deleted.

BUG=106640
TEST=Reprorduced the crash. Applied my patch and verified that it no longer crashed.


Review URL: http://codereview.chromium.org/8889027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113717 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8888026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113716 0039d316-1c4b-4281-b951-d872f2087c98

If NSS is not initialized, conceptually the SSL session
cache is empty.  So it doesn't make sense to initialize
NSS just to clear an empty SSL session cache.

Remove the suppression for the leak this CL fixes from
suppressions_mac.txt.  Widen a related suppression in
suppressions.txt to cover this leak.

R=mattm@chromium.org,cbentzel@chromium.org
BUG=105431,95718
TEST=valgrind bots should not report a leak in
SSL_ClearSessionCache. 

Review URL: http://codereview.chromium.org/8849005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8889023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113714 0039d316-1c4b-4281-b951-d872f2087c98

base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8879031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113713 0039d316-1c4b-4281-b951-d872f2087c98

(This only affetcs GPU bots)

BUG=
TEST=GPU win bots green
Review URL: http://codereview.chromium.org/8888035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113712 0039d316-1c4b-4281-b951-d872f2087c98

I investigated deriving from IOThreadExtensionFunction, but we need access to Profile in the midst of our work. Deriving from UIThreadExtensionFunction appears to be the right way to do that. It's possible that we'll want to address performance issues caused by jumping back and forth between threads, but for now this seems to work well enough.

See http://code.google.com/p/chromium/issues/detail?id=106802 for future plans to deal with lifetime more elegantly.

Also reapply http://codereview.chromium.org/8819029/, which is what led to this bug/fix.

BUG=106656
TEST=no new ones; just refactoring.


Review URL: http://codereview.chromium.org/8857004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113710 0039d316-1c4b-4281-b951-d872f2087c98

Aura uses views textfield and needs to set focusable on omnibox instead of location bar.
 I used "views::Widget::IsPureViews" instead of ifdef because
this allow us to provide a flag to enable views textfield on widnows.

BUG=106632
TEST=BrowserFocusTest pass

Review URL: http://codereview.chromium.org/8832002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106883
TEST=

Review URL: http://codereview.chromium.org/8879034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113708 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:21845
TEST=wrench menu 'Lock screen' should have 'screen' in lower case, consistent with rest of wrench menu options.

Review URL: http://codereview.chromium.org/8873014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113707 0039d316-1c4b-4281-b951-d872f2087c98

Refactors some common Skia drawing code into RenderText internal
class SkiaTextRenderer. Rewrite RenderTextLinux::DrawVisualText()
to use SkiaTextRenderer and refactor RenderTextWin::DrawVisualText()
to also use SkiaTextRenderer, to re-use code.

BUG=103648
TEST=Run Linux views_examples_exe --use-pure-views. In the textfield
example tab, the text field should draw its text correctly.

Review URL: http://codereview.chromium.org/8725002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113706 0039d316-1c4b-4281-b951-d872f2087c98

With the new logic in SendPendingAccessibilityNotifications, it is no longer necessary to fire a load complete  as the first notification to the browser. Since we walk the parent chain, looking for the first entry actually in our browser cache, we will always end up walking up to the root.

This change therefore also makes sure that notifications fired on the root will include all of the subtree when composing the notification.
BUG=none.
TEST=manual.

Merge remote-tracking branch 'origin' into build_break

Merge branch 'trunk' of http://git.chromium.org/git/chromium into build_break

Attempt fixes at chrome frame tests redness.

TBR=dtseng

Review URL: http://codereview.chromium.org/8869006

TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/8888034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113705 0039d316-1c4b-4281-b951-d872f2087c98

With the new logic in SendPendingAccessibilityNotifications, it is no longer necessary to fire a load complete  as the first notification to the browser. Since we walk the parent chain, looking for the first entry actually in our browser cache, we will always end up walking up to the root.

This change therefore also makes sure that notifications fired on the root will include all of the subtree when composing the notification.
BUG=none.
TEST=manual.

Merge remote-tracking branch 'origin' into build_break

Merge branch 'trunk' of http://git.chromium.org/git/chromium into build_break

Attempt fixes at chrome frame tests redness.

TBR=dtseng

Review URL: http://codereview.chromium.org/8869006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113704 0039d316-1c4b-4281-b951-d872f2087c98

It seems to be passing.

BUG=91729

Review URL: http://codereview.chromium.org/8873024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113703 0039d316-1c4b-4281-b951-d872f2087c98

With the new logic in SendPendingAccessibilityNotifications, it is no longer necessary to fire a load complete  as the first notification to the browser. Since we walk the parent chain, looking for the first entry actually in our browser cache, we will always end up walking up to the root.

This change therefore also makes sure that notifications fired on the root will include all of the subtree when composing the notification.
BUG=none.
TEST=manual.

Merge remote-tracking branch 'origin' into build_break

Merge branch 'trunk' of http://git.chromium.org/git/chromium into build_break

Attempt fixes at chrome frame tests redness.

TBR=dtseng

Review URL: http://codereview.chromium.org/8869006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113702 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23809
TEST=SelectFileDialogExtensionBrowserTest.*

Review URL: http://codereview.chromium.org/8819025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113701 0039d316-1c4b-4281-b951-d872f2087c98

Also switch how cross-origin URL is generated so we can enable NaCl URLLoader tests.
BUG=NONE
TEST=ui_tests --gtest_filter=PPAPITest.URLLoader*, PPAPINaClTest.URLLoader*
Review URL: http://codereview.chromium.org/8886001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113700 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8831001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8885016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113698 0039d316-1c4b-4281-b951-d872f2087c98

base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8885020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113697 0039d316-1c4b-4281-b951-d872f2087c98