- 23 Jan, 2020 40 commits
-
-
Abhijeet Kandalkar authored
This CL removes old legacy IPC to adopt new mojo types. It also removes unwanted implementations form RenderFrameImpl class. The goal of this CL is to tell renderer to perform the given action on the media player location at the given point in the view coordinate space. Bug: 1040105 Change-Id: I4b52e1352dc69f433bf8c965459bbd8b060c6f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002488Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#734547}
-
Nate Fischer authored
This separates developer mode state from the mechanism for plumbing developer mode information. These were previously tied together (we examined the enabled state of the ContentProvider which provided flags over IPC), but we observed an issue on Android Q related to disabling and re-enabling a ContentProvider in the same process. Instead, DeveloperModeContentProvider is always enabled and exported, and we examine the state of DeveloperModeState, which is a dummy component we never launch. While this creates slightly more complex code, this significantly simplifies the runtime behavior, because we no longer need to worry about functional code falling into a non-recoverable disabled state. We use an <activity-alias> as the dummy component because it requires the least amount of boilerplate, and there's little harm if the user somehow successfully launches this component. This also includes temporary workaround code: because the previous versions explicitly disabled the ContentProvider, and PackageManager persists this across upgrades, we need to explicitly reset the component state. To make potential future migrations easier, this updates the disableDeveloperMode() to set the component to DEFAULT rather than DISABLED. Bug: 1041943 Test: Manual - try enabling and disabling developer mode on Android Q Test: Repro the bug with buggy APK, upgrade to this APK, UI works Test: Disable dev mode with buggy APK, upgrade to this APK, UI works Change-Id: I410f36fa590026ddc53837f076e6b5912fa075f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005973Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734546}
-
Takumi Fujimoto authored
Set the controller type to kMirroring so that local mirroring sessions don't show up in Global Media Controls. Bug: 1043302 Change-Id: Ib667dae4afc3b078b6aaa7b76618024cf0de1810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007318 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734545}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I9953fbcbd08b61ac98b77be0d838649534a671a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014917 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734544}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=javierrobles@chromium.org Bug: 1042208 Change-Id: I951945d01287beb4c2f57357da575ec093fa89e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015170 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#734543}
-
gogerald authored
Bug: 1045018 Change-Id: I7be550116de433e73fc8c61001110edca9f8e594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017045Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#734542}
-
Jit Yao Yap authored
crrev.com/c/1877088 updated the default behavior of web dialog views to close when the Escape accelerator is pressed. This CL updates the login screen extension UI dialog to not close when receiving the accelerator. Bug: 957573 Change-Id: I72d283f38dd95af6d3909d5c2871b46880117d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014961 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734541}
-
Charlie Harrison authored
These are useful to have around for a while longer. Bug: 1034588 Change-Id: Iaddeed9b331e10d2b9409c1ec0273fa5146cbb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015739 Auto-Submit: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#734540}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 707e7c14. With Chromium commits locally applied on WPT: 0cbea1f0 "SharedWorker: Add meta.url WPT for SharedWorker with type 'module'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ie763c7bae19d091bb94dd8c9b0e56699c62f42bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017122Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734539}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/261523f9..1b20535e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I28adf7d618e11bd8edfbcc4cbeec1887e8874a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017102Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734538}
-
Askar Aitzhan authored
Change the dates to 2021-03-01 for all of them: 1. Because the feature "Cloud Policy over FCM" is not yet released to prod 2. For all of them to be consistent Bug: 1043709, 1043709 Change-Id: I2443e056dd22c141834e9402f7ba0cddbf34ca36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012023Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#734537}
-
Patrick Noland authored
This prevents an NPE that can happen when the IPH controller is initialized after ChromeTabbedActivity#initializeToolbarManager. Since the IPH controller is initialized in a posted task, it's not robust to rely on its initialization order; the simplest solution is to make it responsible for screenshot monitoring directly, avoiding the possibility of an NPE entirely. Bug: 1044888 Change-Id: I6eb4e255cffac998d1bd9e821df73cc90b8d0b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016905 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#734536}
-
Benjamin Beaudry authored
This is a reland of 4ccbed03 It got reverted because I forgot to run the Win7 bot and fix the failing tests. Original change's description: > Fix selected state when focused for ARIA gridcell and treeitem > > Before this change, focused gridcell were perceived as selected by ATs. > This is because we assumed that a focused gridcell was also selected, > but that can't be the case. > Gridcells are mentioned here, but all ARIA grid roles and treeitem were > affected by this misinterpretation of the specs. > > According to ARIA 1.0 and above, all ARIA grid cells, rows and columns > are selectable, but not necessarily selected. We can't assume a > relationship between the focused state and the selected state as they > are completely independent. We can only do so when the aria-selected > attribute is implied or required. To the best of my knowledge, it only > is implied and/or required for: > - ax::mojom::Role::kListBoxOption: > - ax::mojom::Role::kMenuListOption: > - ax::mojom::Role::kTab: > > This CL introduces AXLayoutObject::SelectionShouldFollowFocus(). > This method was implemented following the ARIA specs, so that only the > elements with an implied and/or required aria-selected attribute value > are also marked as selected when focused. > > Bug: 1030378 > Change-Id: I5875cf3f6198aeea73100806d365bb73f7a6c389 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996138 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#734001} TBR=kschmi@microsoft.com TBR=aleventhal@chromium.org Bug: 1030378 Change-Id: I43bb335cf19f3a9b64f0505c97299133503a3f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015139 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734535}
-
Chris Lu authored
This flag will be used to build out support for scoping FullscreenController to a Browser while keeping the current BrowserState-scoped logic as default. Bug: 790886 Change-Id: Iac1811181a6313271561ffecae306fe4b7b94684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007314 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#734534}
-
Stepan Khapugin authored
Moves a bunch of methdos and properties that aren't used in MainController to SceneController and updates call sites. Bug: none Change-Id: Ib5b26f5cd402cb435426f23f060c53dac522104a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012382 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Ben Mason authored
Bug: 1044636 TBR: pauljensen so we can green up the builders Change-Id: I59d296744a6b7481262315db2a66d173a39cf4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016879Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#734532}
-
sebsg authored
Bug: 747064 Change-Id: I4a921a4e33890c751d144c4d257aa83444b47caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015800Reviewed-by:
-
Maksim Moskvitin authored
The test is flaky on various platforms. Bug: 1028968 Change-Id: Ib4d54d0d3625b26e3ac93bc016905c9d3bf44a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017324 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#734530}
-
Xianzhu Wang authored
ScrollingCoordinator::UpdateCompositorScrollOffset (renamed from UpdateCompositedScrollOffset) now updates cc scroll tree's scroll offset instead of cc::Layer's. cc::Layer::SetScrollOffset will be limited for layer tree mode only. We need to update the scroll tree's scroll offset immediately (instead of during PrePaint or Paint) because the scroll offset will be used to calculate the new scroll offset with the impl-side scroll delta applied before blink's document lifecycle update. Bug: 1043147 Change-Id: Ic50847da2c8c74cfc2f1cbfda4f5decbf8be466e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013653Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734529}
-
Sigurdur Asgeirsson authored
Keeping track of the average write rate on the instrumented message pipe will allow reasoning on whether there's a spurt of messages coming through, or whether the unread quota protocol implementation is stalling somehow. Likewise the additional cumulative counts and the lifetime will shed some light on the usage of the abused interfaces. Bug: 1011441 Change-Id: I9e3d2b1fcfe2a264208108d2c7ff3cdc4dd11e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013480 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#734528}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10e83a92760c..b04d7c55bff1 git log 10e83a92760c..b04d7c55bff1 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 petermarshall@chromium.org Only call Debugger.setAsyncCallStackDepth while debugger is enabled 2020-01-23 aerotwist@chromium.org [Global] Update refs to Persistence.isolatedFileSystemManager 2020-01-23 tvanderlippe@chromium.org Migrate sdk/ to import cross-module 2020-01-23 aerotwist@chromium.org [Global] Update refs to UI.viewManager & UI.zoomManager 2020-01-23 tvanderlippe@chromium.org Migrate workspace/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@b04d7c55bff1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1010534 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4969fe4faca21c6a8e788dd98b9dfbc0b1de9302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734527}
-
Saman Sami authored
Adds CheckOverlayCapabilitiesSync() that returns the result synchronously rather than running a callback. Add a base::Feature that determines whether to use the synchronous or asynchronous API. The synchronous API simply blocks on the DrmThread to run the test. We will monitor the metrics to see if this approach is sufficiently performant. Bug: 1034559 Change-Id: Ib90132e984d007064f8f6e91a462c0e227da172f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013465 Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#734526}
-
Qingsi Wang authored
Bug: None Change-Id: I47cb1a453705043b7d273bb1f649447c1ac5e18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015650Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#734525}
-
Egor Pasko authored
The usage of the flag was removed in crrev.com/719331. I planned to remove the declaration of the flag separately to make reverts smaller, but forgot to remove it in the end. Do it now. Bug: 1028600 Change-Id: Ia2cb8bd18389c25e440c2c95773b4c49ce120d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017405 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734524}
-
Peter Wen authored
This a simple upgrade of an existing public Google library (http://errorprone.info/) from version 2.3.3 to version 2.3.4. It pulls in error prone's new maven dependencies and removes the ones that error prone has removed. Also fixes some of the new issues that were exposed by the new checks. Bug: 1030676 Change-Id: I2f76601befe4575bb19588a1c701c0bb73170c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953863Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change moves PasswordAccessAuthenticator and ReauthPurpose from //chrome into //components, performs some code clean ups and improves the tests of PasswordAccessAuthenticator and PasswordsPrivateDelegateImpl. Bug: 1019174 Change-Id: I13d6ee5486169b9072536fb753c30efcdaa0f81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887812Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#734522}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I9c7c13f415582f3d204c8246703cf320f31ad44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016866Reviewed-by:
-
Maksim Ivanov authored
This fix part 2/2 for the bug with the bad spinner being displayed after the end of the SAML login. This suppresses the ease-in/ease-out animations of the Gaia frame in case the SAML login was just performed. The animations are unwanted in this case, because they would lead to weird UI - two spinners displayed at the same time during the animation (one is the screen-gaia-signin's own spinner, and another is the Gaia's /programmatic_auth_chromeos one). Bug: 1024253 Change-Id: Ic4f7077c99d16d02324f22a3b15204e46e311643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000703Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/00a30873c415..cdd73e095cd4 git log 00a30873c415..cdd73e095cd4 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 titovartem@google.com Migrate PC level tests on new video codec configuration API 2020-01-23 eshr@google.com Remove unused field trial WebRTC-InitialFramedrop Created with: gclient setdep -r src/third_party/webrtc@cdd73e095cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id2eac77ccdd71bce01a9da34ccd6feda1d029cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017065Reviewed-by:
-
chrome://omniboxmanukh authored
We previously considered persisting all inputs, but decided to hold off because 1) it would make asking users to extract data more error prone, and 2) having options to 'reset inputs' and 'toggle persistence' would be too complicated. Since then, I've come into the habit of 1) open chrome://omnibox, 2) enable 'connect window to omnibox', 3) enable 'thin rows', and then 4) type my input. This becomes cumbersome when opening multiple chrome://omnibox tabs, e.g., to compare results. To satisfy both requirements, this CL persists display options only. Since query inputs aren't persisted, the extracted JSON won't be affected, and 'reset inputs' and 'toggle persistence' options won't be required. Change-Id: I8b2f4d17ce840f6b4d1cec4df8b446122b7e28eb NOTRY=true To skip android-binary-size bot due to a bug (crbug.com/1045024). Other try-bots have passed. Change-Id: I8b2f4d17ce840f6b4d1cec4df8b446122b7e28eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002983 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#734518}
-
sczs authored
- Updates the error state on editable cells for SaveCardTableVC whenever an invalid value has been entered. This is done whenever the TextField value is updated or it loses focus. - Changes TableViewTextEditItems so the error icon is displayed even if the cell is being edited. - Adds the correct Item Type to each of the TableViewTextEditItem, they were incorrectly all set to ItemTypeCardExpireYear. Bug: 1029067 Change-Id: Icc076695710ac0ddadab2f4d8949686e5287321e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007256Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#734517}
-
bttk authored
This check accidentally prevents package-private declarations of annotations. Change-Id: I7516f653d8b75ed82bb82c975586301f7fcb360a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014050Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#734516}
-
Tim Volodine authored
Currently committed safebrowsing interstitials are not supported in weblayer. This patch adds this support and tests. In this patch: - add support for committed interstitials for safebrowsing in weblayer (i.e. when kCommittedSBInterstitials is enabled). - add SafeBrowsingBlockingPage and SafeBrowsingNavigationThrottle - make SafeBrowsingBrowserTest work when kCommittedSBInterstitials feature is enabled. - parameterize tests to run both with committed interstitials and non-committed interstitials. BUG=1042662 TBR=vakh@chromium.org Change-Id: I5f732c1f0c2c6c09b2041ea0a7c8d41e81bce9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003857 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
-
Anastasiia Nikolaienko authored
If child user has secondary accounts, the IsChild profile property will be set to false after removal of any account. Fix this by checking if the removed account is a primary account in OnExtendedAccountInfoRemoved method. Bug: 1043108 Change-Id: Ia9038932bb3baff8ae69a46675b5a995e3294826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015161Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#734514}
-
Shimi Zhang authored
Currently DeleteSelectionCommand accept a VisibleSelection as the parameter, which is not necessary in many places. This CL converts the VisibleSelection |selection_to_delete_| to SelectionForUndoStep. So we could avoid canonicalization. This enables us to avoiding to use VisibleSelection::CreateWithoutValidationDeprecated() later. Bug: 1024738 Change-Id: I4b32507afca4e77338e9f6a83c01b3a30ea3b188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013905Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734513}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/68125d909621..ef832e92773a git log 68125d909621..ef832e92773a --date=short --first-parent --format='%ad %ae %s' 2020-01-23 fancl@chromium.org Simplify some part of the E-Divisive Created with: gclient setdep -r src/third_party/catapult@ef832e92773a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: I053584685427e7cd9f696df2495124348fadc221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016877Reviewed-by:
-
Olga Sharonova authored
TBR=miu@chromium.org Bug: 1043812 Change-Id: I33211652636fd47c034e516aca438ee46240c99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015057Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#734511}
-
Maksim Ivanov authored
Provide test coverage for the scenario where a new user authenticates via SAML using a smart card (or, generally speaking, using a security token via an extension using the chrome.certificateProvider API). This also provides some test coverage for the <security-token-pin> Polymer element used on the Login Screen. Bug: 1033936 Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968989Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
sczs authored
https://crrev.com/c/1996167 introduced a refactoring to infobar_translate_vc that broke this functionality, this CL fixes that by making the call to the right object. Bug: 1043094 Change-Id: I4ba6f804f91697c24264fec09584acd1c7a32a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015801 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Nico Weber authored
Bug: 1015315 Change-Id: Ia34164d1bee32f7b217300b7afdf0dfb00682352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016843 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#734508}
-
