GitLab

bluetooth_type_converters_unittest did not follow the style guide.
This refactors it to follow it with more refactoring.
- Use snake_case rather than camelCase for variables.
- Introduce ValueToJson() utility.
- Split TESTs into smaller pieces.
- Shorten var names if possible, specifically based on the context by TEST
  split.

BUG=None
TEST=Ran try.

Change-Id: I352e6d9e43d8ac15b3922a43699ff356d749ba42
Reviewed-on: https://chromium-review.googlesource.com/735164Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512544}

Prevent saving a printer if the uri is invalid.  Validation in the UI
will be added in a follow up.

Bug: 778383
Change-Id: I584c8d63248da6aadd7cb7cbef0cea4d2fd80cc2
Reviewed-on: https://chromium-review.googlesource.com/742266Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512543}

The NEON specific code will be hosted in the folder 
'contrib/optimizations/arm' while the platform independent 
C code is hosted in the upper directory.

This allows to easily implement the inffast optimization for other
architectures by simply implementing 2 functions and including the
necessary header in chunk_copy.h (that is used by inflate and inffast).

The idea is with time to move all optimizations to this new folder.

Bug: 769880
Change-Id: I404ec0fdf3f6867c9c124da859ca38bf57b25447
Reviewed-on: https://chromium-review.googlesource.com/740907Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512542}

Hide controls that don't fit on the new media controls based on width
and height for <video> elements and width only for <audio> elements. If
the controls cannot be shown we should show them on the overflow menu.

BUG=761309

Change-Id: I0c9b12f4d37a9041c27983d4de2ee94acbd3cc6c
Reviewed-on: https://chromium-review.googlesource.com/727984
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512541}

The 'FIXME' in LayoutTextFragment.h comment by eae@ is done, remove it.

BUG=
R=eae@chromium.org
Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: I8c93bd1c3785c31086b403cbc951ee8a67a5fb5e
Reviewed-on: https://chromium-review.googlesource.com/737403Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512540}

R=sugoi@chromium.org

Bug: 778254
Change-Id: Ib201e3fbc4adf7749b1be5a6fe9ebaf86691a94e
Reviewed-on: https://chromium-review.googlesource.com/741747Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512539}

Clank build excludes usb_ids.*, but the source files (inlcude the giant
file usb_ids_gen.cc) still got compiled, even though its results are not
included in the final APK. This adds unnecessary work for Clank builds,
and creates overhead to Supersize archive command. This CL removes these
vacuous usb_ids.* compilation under Android. This speeds up Supersize
archive by about 20% (and probably shaves seconds from Clank build).

Bug: 779162
Change-Id: I4e4a9eb4274bfa9d298a5ce887179629a5cb6b7f
Reviewed-on: https://chromium-review.googlesource.com/740688
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512538}

The metric is no longer used, should be dead code now.

Bug: 632021
Change-Id: Ic6615654a74128b2782ae93fbf7c05dc95e4aaa9
Reviewed-on: https://chromium-review.googlesource.com/744201Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512537}

Many of the first fuzzers were implemented under //testing, including a
few MSE-related fuzzers. This change moves those MSE fuzzers closer to
the code they test under //media.

BUG=779238

Change-Id: Ied496bbaa78864e54d670cc549da46bdd09eeeb2
Reviewed-on: https://chromium-review.googlesource.com/742452
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512536}

https://chromium.googlesource.com/angle/angle.git/+log/2a35741bd197..87c358839ccd

$ git log 2a35741bd..87c358839 --date=short --no-merges --format='%ad %ae %s'
2017-10-19 oetuaho Prune no-op statements with a single traverser
2017-10-13 jiawei.shao Fix incorrect hashing on built-in interface block fields

Created with:
  roll-dep src/third_party/angle


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ibf9563df538d0edf6fd1411a9fd2a9e95fd07935
Reviewed-on: https://chromium-review.googlesource.com/744102Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512535}

We have enabled the fullscreen launcher by default, so it's time
to remove the flag.

The first step will be to return true at
to it as we remove the dead code paths.

features: :IsFullscreenAppListEnabled(), and then remove all references
Bug: 775279
Change-Id: I2f8fe96d04d009e7d4bd2f9cabd1c9aa3913ea7c
Reviewed-on: https://chromium-review.googlesource.com/736222
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512534}

This reverts commit cbb6a624.

Reason for revert: <INSERT REASONING HERE>
Revert the CL for breaking some content suggestions egtests, e.g. ContentSuggestionsTestCase/testAdditionalItemsKept
Link:
https://build.chromium.org/p/chromium.mac/builders/ios-simulator-full-configs/builds/59

Original change's description:
> Allow WebStateObserver to observe N WebStates [2/N].
> 
> Convert WebStateObserverBridge to allow client code to control
> which WebStates are observed. Still support the constructor to
> let WebStateObserverBridge itself manages the registration.
> 
> Bug: 775684
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I06cc3f8d84f708f493221042a0257ede143b91d0
> Reviewed-on: https://chromium-review.googlesource.com/738864
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512498}

TBR=sdefresne@chromium.org,eugenebut@chromium.org

Change-Id: I880597b95b92aacd5f1bbcc844eef972c9ddd2eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/744082Reviewed-by: Menglu Huang <huangml@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512533}

This test fails in test automation run for Android Build bot for Chromium.

Bug: chromedriver:2108
Change-Id: I67f8d7beec444167621d70fef9d0fcf4fb2defce
Reviewed-on: https://chromium-review.googlesource.com/744161
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512532}

With this CL, a single TLS slot is used to store data about the
ObserverListThreadSafe notification being dispatched on one thread
rather than one TLS slot per ObserverListThreadSafe instance.

Bug: 728049
Change-Id: Ibae6538cd77ee55594e231ae24c09b0fb7f43ada
Reviewed-on: https://chromium-review.googlesource.com/740989Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512531}

Screenshot: https://goo.gl/bk3ZEz

Bug: 761813
Change-Id: I1656ebfd174de1a4bff5c197fce37896b6be85be
Reviewed-on: https://chromium-review.googlesource.com/743628Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512530}

Sometimes, an Android device is meant to behave like a desktop. For
example, when an external monitor and mouse are connected. When this
happens, things like a right mouse click should show a context menu
positioned at the click location (rather than showing a long-press modal
dialog).

In order for this to happen, we need to pipe the source type into
ContextMenuParams. This allows us to make the decision of how to display
the ContextMenu later in the pipeline.

BUG=687787

Change-Id: Ia60d65f132e1ea671c3929bd623aae900d871867
Reviewed-on: https://chromium-review.googlesource.com/731507
Commit-Queue: Chris Blume <cblume@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512529}

from clipping immersive moded tablet windows.

Fixes  two of overview mode introduced by tablet mode work.

- Do not allow the top of the settings app to get trimmed.
- Hide the selection widget while dragging.

Test: manual
Bug: 777652
Change-Id: I9b8313cbd255378cf51c7919269491e85190f449
Reviewed-on: https://chromium-review.googlesource.com/733728
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512528}

The LogoServiceFactory caches the UI at creation, but since it can
now change at runtime, this can cause displaying Doodles on classic
New Tab Pages with ChromeHome's white background.

As temporary workaround for M63 that won't display Doodles in
ChromeHome, we simply stop configuring the LogoServiceFactory to
fetch ChromeHome specific Doodles.

Bug: 776725
Change-Id: I1b2df2250f597671057aa10c86e5a1fa2177d8fa
Reviewed-on: https://chromium-review.googlesource.com/743901Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512527}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a74137d7..dd608e6f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I42b3dc326db8f53b3326d26962e8b127ca5e66a3
Reviewed-on: https://chromium-review.googlesource.com/743686Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512526}

BUG=779075

Change-Id: I7dfb1425c06aa94c47094280bcce71938b17f568
Reviewed-on: https://chromium-review.googlesource.com/742653Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512525}

Remove unnecesary call to set background distance.

Bug: none
Change-Id: I2060a7c3b2d239ca7e03fb30ca5995b706452ece
Reviewed-on: https://chromium-review.googlesource.com/742163Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512524}

https://chromium-review.googlesource.com/726403 accidentally lost a line
that sets recreate_context_ for passthrough command buffer. This
restores it.

Bug: 778911
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib5890c6015df014baf72fb2e7f5f55dcfaa78a15
Reviewed-on: https://chromium-review.googlesource.com/742226Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512523}

Also, use it to calculate better TextMetrics.

Bug: 277215
Change-Id: I45a2abba1820f770ea99fd792c6cc31dae40bb3c
Reviewed-on: https://chromium-review.googlesource.com/731104
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512522}

BUG=412884

Change-Id: I987ffebb76b8ecb06c7754a517c42ec20c888ae1
Reviewed-on: https://chromium-review.googlesource.com/738801Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512521}

The JSON rotation file we use contains user names for people with
@chromium.org and full email addresses for all other cases.

It turns out passing '--tbrs foo' to git-cl results in foo@chromium.org
being added to the Gerrit CL, so we can simplify our code a little bit.

Bug: 755753
Change-Id: If86524ec1937525b8cb8b3d4a937c06f4ce21295
Reviewed-on: https://chromium-review.googlesource.com/744011
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512520}

With WKBasedNavigationManager, native URLs are loaded asynchronously.
Added WebStateObserver to wait for load to finish before asserting in
tests.

Bug: 776467
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2d0da5770ea09988a57e9af3e3561d1dc5bd3ebf
Reviewed-on: https://chromium-review.googlesource.com/740370
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512519}

This test now measures performance when using double-buffering. Any
problems related to the release of buffers can cause this test to drop
frames.

Bug: 765393
Change-Id: I3c0bbd678e48b0601e3b420ac0ff4c3f4a115211
Reviewed-on: https://chromium-review.googlesource.com/743685
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512518}

https://pdfium.googlesource.com/pdfium.git/+log/7170226d2020..1fc3c3b309d9

$ git log 7170226d2..1fc3c3b30 --date=short --no-merges --format='%ad %ae %s'
2017-10-30 rharrison Fix overflow in image size check

Created with:
  roll-dep src/third_party/pdfium
BUG=779342


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ib002c903b923ca2efe472c96c9da0a3e4a7a9d74
Reviewed-on: https://chromium-review.googlesource.com/743711
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512517}

This CL removes the direct use of WebToolbarController to allow easier
refactoring.
As this is removed, it also breaks the functionalities previously
owned by BVC in two protocols implemented by the ToolbarCoordinator.

Bug: 778226
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I75ecd1c34532d2950c22d50bfa746e865084f819
Reviewed-on: https://chromium-review.googlesource.com/738251Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512516}

https://skia.googlesource.com/skia.git/+log/2d8d196318a6..228da62fa791

$ git log 2d8d19631..228da62fa --date=short --no-merges --format='%ad %ae %s'
2017-10-26 liyuqian Output calmbench json in nanobench format
2017-10-30 robertphillips Fix Debian9-Clang build
2017-10-27 robertphillips Fix GrDefaultPathRender inversely wound path bug

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I33598ff4ca0fcf23c68edaebf8b7e536f74cab0f
Reviewed-on: https://chromium-review.googlesource.com/743707Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512515}

Using wpt-import in Chromium 56946ae9.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/4295

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
eae@chromium.org, szager@chromium.org:
  external/wpt/intersection-observer

TBR=leon.han@intel.com

No-Export: true
Change-Id: I3d30c5a042db0bbab672ebfc4e46db02545ee092
Reviewed-on: https://chromium-review.googlesource.com/743843
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512514}

ipc::ChannelMojo calls GetWeakPtr() to bind WeakPtrs into helpers
returned by CreateThreadSafeChannel(), and in OnPipeError().

Since these calls can be made concurrently from different threads, they
should create a WeakPtr at initialization to use in those calls.

Bug: 
Change-Id: I8a86c4e7241314b3aa23dba9915c14d1cb078d31
Reviewed-on: https://chromium-review.googlesource.com/742498Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512513}

Inline scripts start in the middle of some HTML, and so their start
position is non-zero.

Bug: chromium:582873
Change-Id: I8c5aa2e62c69067e45baad5fc7bd3c46b4097e96
Reviewed-on: https://chromium-review.googlesource.com/743982Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512512}

Bug: 
Change-Id: I390df5f47a9a735441d7f5180ce0ba132ebc08f3
Reviewed-on: https://chromium-review.googlesource.com/743684Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512511}

This reverts commit 74b56fb1.

Reason for revert:
This introduced other regressions, as documented on the linked bug.

Original change's description:
> cocoa: use cocoa background color for constrained windows
> 
> These were using SK_ColorWHITE when they should have been using
> [NSColor windowBackgroundColor].
> 
> BUG=743120
> 
> Change-Id: Icf5cff4c1e4451c55580921c0d661fd8381b19da
> Reviewed-on: https://chromium-review.googlesource.com/575167
> Reviewed-by: Jayson Adams <shrike@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488748}

TBR=ellyjones@chromium.org,shrike@chromium.org,mark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 743120
Change-Id: I9d86a973a55ff7cf6df39ae54ef7a5e602e680fb
Reviewed-on: https://chromium-review.googlesource.com/744081Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512510}

This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/705775

That CL caused issue 768886 (spike in hang reports). I suspect this
was caused by a change in enum IDs rather than this change to the
hang watching code and this CL will help narrow down the cause.

R=asvitkine@chromium.org

NOPRESUBMIT=TRUE (shuffling of code using deprecated BrowserThread IDs)

Bug: 689520,768886
Change-Id: Id7bf1c7b5f5d34c4b1e7b1e71e9b015725695997
Reviewed-on: https://chromium-review.googlesource.com/743846
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512509}

Add a DCHECK to enforce that FrameSinkIds are registered before adding
them to hierarchy. This is already the case for all usage, except one
test which I fixed, but this will enforce it doesn't get broken.

Also remove ImageTransportFactory initialization from
OffscreenCanvasProviderImplTests. It's not actually used.

Bug: 657959
Change-Id: Ie197b655ecb1b1eabb5da56ca92fd590e2dfa450
Reviewed-on: https://chromium-review.googlesource.com/738284Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512508}

https://chromium.googlesource.com/angle/angle.git/+log/b79e7bb691ae..2a35741bd197

$ git log b79e7bb69..2a35741bd --date=short --no-merges --format='%ad %ae %s'
2017-09-05 bryan.bernhart WebGLCompatibility: Disable ES format extensions by default.
2017-10-27 cwallez Revert "BUILD.gn: prepare dEQP test support on Mac"
2017-09-18 jiajia.qin ES31: Add std430 support for OpenGL backend
2017-10-26 oetuaho Use array_specifier in struct declarator parsing
2017-10-26 oetuaho Fix setting array sizes on a constructor
2017-10-11 cwallez BUILD.gn: prepare dEQP test support on Mac
2017-10-25 oetuaho Accept valid geometry shader inputs regardless of syntax
2017-10-23 bryan.bernhart WebGLCompatibility: Fix shader validation using define macros.
2017-10-25 ynovikov Use angle::BitSetIterator optimizations on arm64 as well

Created with:
  roll-dep src/third_party/angle


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I2032006dcf7d14e4162b8854f6ebd9acd3b5dcd4
Reviewed-on: https://chromium-review.googlesource.com/743862Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512507}

Convert TabUsageRecorder to observe to all WebStates inserted
in the WebStateList it observes. Remove the helper class that
was required when WebStateObserver could only observe a single
WebState.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icb42548d628465e16f91613c7c881f3ff269cb58
Reviewed-on: https://chromium-review.googlesource.com/738872
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512506}

This resolves race condition when App Launcher expects that installation
starts for default app and delay on Eve caused by Assistant flow.

Bug: b/68400737
Test: Manually on device. Spinning animation for deferred launch and
      app in App Launcher persist while Assistant flow is active. Unit
      tests extended

Change-Id: I7756987b20af6a7ef4e6b94db86acc61221559f2
Reviewed-on: https://chromium-review.googlesource.com/742648Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#512505}