- 15 Oct, 2020 40 commits
-
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 86.0.4240.99 TBR=estaab@chromium.org Bug: 1041619 Change-Id: Ib3f1818b30bada61f7a1c361b373881edc61b920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476580 Commit-Queue: Rakib Hasan <rmhasan@google.com> Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#817667}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9dfc25eb5de2..63fa6951fb7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pkasting@google.com,jbroman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pkasting@google.com,jbroman@google.com Change-Id: Ifad4cae80bee6247479f0942b7b84cc091b76157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477225Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817666}
-
Matt Jones authored
Bug: 1135465 Change-Id: I3202884bcaaa9c80c6d6b3940da77c717f54b357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459108Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817665}
-
Austin Eng authored
This is a reland of 290037a8 It's been preceded by a fix to set dawn_use_x11=false to fix compilation on lacros. Original change's description: > Set use_dawn=true on Linux > > This enables WebGPU on Linux behind --enable-unsafe-webgpu > and --enable-features=Vulkan. Shared image support requires > SkiaRenderer (default on Linux) and Vulkan to be enabled. > > Bug: 976495 > Change-Id: I97065f2ac6aadd110971254bfe3526d366318b83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368534 > Commit-Queue: Austin Eng <enga@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817266} Bug: 976495 Tbr: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux-lacros-rel Change-Id: I6bcf6daa48e838bc8e721126f353c97a5eb752e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476774 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#817664}
-
Richard Knoll authored
This adds a UMA metric that records the result of the promise returned by a call to showNotification. This allows us to spot and pinpoint common errors earlier. TBR=peter@chromium.org Bug: None Change-Id: If6505a86acbfc20f101a421b6a187c08f32c4af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475882 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817663}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602709027-5dd91a5323ea4bffe2a30c2aaff27b21af6d45ea.profdata to chrome-win32-master-1602730724-a2f2ccfa1a9355c75a0cf65d2477506fef2f19f5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib971cbbf8cf9ce06afa307524496e6b09eacca97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817662}
-
Benoit Lize authored
ThreadCacheRegistry is a singleton, using the common static local pattern. However this doesn't work for PartitionAlloc-Everywhere builds on Windows, as static locals are not safe very early on, and this one is called during CRT initialization. To avoid using a static local here, use a regular global variable in the .cc. This means that the object must be constexpr-constructible, so this CL: - Moves to PartitionLock vs base::Lock - Makes PartitionLock's constructor constexpr Bug: 998048 Change-Id: Ie16c642122696d34d9f07813a763ca986b25895c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474857 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#817661}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602762990-5610fc4d08ce928742199548ea998fa82cc20428.profdata to chrome-linux-master-1602784677-a93fbaee821e881bb685f33a6370b1d8843d7235.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic965a389f3d69598d73d67d60105595ccdfe2db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477274Reviewed-by:
-
Steven Bennetts authored
This CL: * Removes the no longer accurate typedef * Eliminates DictionaryValue from ShillClientHelper BUG=1109627,1137487 Change-Id: I1ae00753e7a8d77c2c7948c78c7ad31c1bcabb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466382 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#817659}
-
Gavin Williams authored
In Wallpaper app add a blue border around the category to show when focused. Screenshot: https://screenshot.googleplex.com/C6LMc4tGitLTkdA Bug: 1045359 Change-Id: Icd3e36343451e517b1f10a1de303a5df827fec94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476557Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#817658}
-
minch authored
Bug: 1131543 Change-Id: I358c1bac6cdb59302c15144340f64e43cead1258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472597 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#817657}
-
Ryan Heise authored
Bug: 1138953 Change-Id: Ie8475db0b7991c867564894cccd775c0cbf19dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476674Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817656}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/a3f46f23c526..bd45d582f51e 2020-10-15 jophba@chromium.org Allow loopback for discovery If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I2ccd0ed0216ae007259015a7b2ec0b80748abeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477217Reviewed-by:
-
Dave Tapuska authored
No one listens or sends messages via RenderViewObserver anymore. BUG=1097816 Change-Id: I760e8f97992a23f6aaec51cb187405881f494471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476754Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#817654}
-
Devlin Cronin authored
browser_action and page_action are being replaced by simply "action" in manifest v3. Limit browser_action and page_action to manifest v2. Bug: 987838 Change-Id: Ib007f607e8879b6a2667093ee223a03572fb616c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473142Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817653}
-
Matt Jones authored
Recent changes to the SceneOverlay system have allowed it to be used more dynamically; features don't need such a close relationship the the LayoutManager. This patch moves the contextual search feature code out of LayoutManager and into ContextualSearchManager since LayoutManager shouldn't and no longer needs to be responsible for it. Bug: 1100332 Change-Id: I133f4104de0d1dbeff8f6c355d66a2d7955db42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456634Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817652}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602762990-5c0ecdd782b8586c3ade2c97da0a453329c89923.profdata to chrome-mac-master-1602784677-cb2da9a5056db49e979dc05760b0abb885837837.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib7569241d98126435730ddd0b7708285e2344f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477229Reviewed-by:
-
Andrew Grieve authored
* source_path, object_path, template_name, and "name" all now use the class name that a symbol was merged from rather than the one it was merged into. * Made lambda name normalization work for class merging * Changed object_path to be the same whether or not source_path exists (because why would it differ!?) * Added more tests :). Bug: 1121569 Change-Id: I7d52b75f6887df529ce2178ad5430d49107ec864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473368 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#817650}
-
Leonid Baraz authored
Bug: b:169248924 Change-Id: Icd034dbfc84b33a9fc8325043d85391bce185480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458288Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817649}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/029d567d..aedca41e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iebf1e2fed409e4a39003e0c3f2e6fc787ef70088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476575Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817648}
-
Victor Hugo Vianna Silva authored
EnableEncryptEverything() and IsEncryptEverythingEnabled() were only relevant for the Directory implementation of Nigori, so they can be removed now, together with the associated plumbing. Bug: 1033040 Change-Id: Iccad5b4bcbbedd2167df258f1f370adf8ca7db2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465856 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#817647}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5d099fcb489d..39d870e1f07f 2020-10-15 sdefresne@chromium.org Fix `git map-branches` when branch is named after a file/directory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I2308c806d57e6d7af9c3a6faa5af5e3d2dd262db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477216Reviewed-by:
-
Ella Ge authored
This reverts commit af52bf4c. Reason for revert: Reland with fix Original change's description: > Revert "Merge Webapk/TWA disclosure controller 1" > > This reverts commit 6460aa02. > > Reason for revert: Looks to have broken Android compile: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/15768 > > Original change's description: > > Merge Webapk/TWA disclosure controller 1 > > > > This CL moves WebappDisclosureSnackbarController to browserservices > > folder, makes it use TrustedWebActivityModel and the > > DisclosureInfobar as TrustedWebActivityDisclosureController. > > > > This will change the text in unbound webapk's disclosure snackbar text > > to be the same as TWA one. > > > > Bug: 1128675 > > Change-Id: I900c41c04a6f36489bed1e08cf81c74f89e2801e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453896 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Peter Conn <peconn@chromium.org> > > Commit-Queue: Ella Ge <eirage@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817516} > > TBR=agrieve@chromium.org,peconn@chromium.org,eirage@chromium.org > > Change-Id: I97a14528dbe701a19753b87b3a9a13963716099f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1128675 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476775 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817533} TBR=pkasting@chromium.org,agrieve@chromium.org,peconn@chromium.org,eirage@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1128675 Change-Id: I8575237c9c14f1edf53be3605fba962c0b7de3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476915Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#817645}
-
harrisonsean authored
If a user accesses the Google Services settings page through the Safe Browsing Check row of the safety check and clicks done, then the Google Services Coordinator is not properly stopping and crashing the browser. This makes sure that the Google Services coordinator is stopped when done is clicked. Bug: 1078782 Change-Id: I3f0679b9d501095aabb8560b27c22993e4d99607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474915 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#817644}
-
Idries Hamadi authored
AwContents currently attaches the PreDraw listener all the time, but it does nothing unless WEBVIEW_MEASURE_SCREEN_COVERAGE is enabled. This may be the cause of a perf regression. This CL changes the behaviour of WEBVIEW_MEASURE_SCREEN_COVERAGE so that the listener will not even be attached unless the flag is enabled. Bug: 1138032 Change-Id: I3e2f792c16bdccc0cc9f8f57e1490f70414b4bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475853Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Idries Hamadi <idries@google.com> Auto-Submit: Idries Hamadi <idries@google.com> Cr-Commit-Position: refs/heads/master@{#817643}
-
Andrew Grieve authored
Requires adding expectations in //clank as well in a separate commit. Bug: 1117577 Change-Id: I149718ae175c3709d657bc7822b18236fd6690d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475974Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#817642}
-
kylechar authored
This is a reland of 0be396a2. Using SharedImageRepresentationFactory if Mailbox::IsSharedImage() returns true caused failures on AMD GPU FYI bot. Remove that change from the CL to land. Original change's description: > Fix Windows overlay texture lifetime > > With SkiaRenderer on Windows overlay textures weren't kept alive after > the client destroys them if still in use. Implement something in > SkiaOutputDeviceGL that is similar SkiaOutputDeviceBufferQueue where we > keep a map of mailboxes to textures to keep alive. Instead of using > SharedImageRepresentationOverlay we have to use GLImage still as not all > Windows video paths are using shared image. > > Bug: 1136194 > Change-Id: Ibeb5726b914058c0868a90dcc9bca74a8499c660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462038 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817164} Bug: 1136194 Change-Id: I601814a082a26d6025c376b984d3a9005c8c94be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475978 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#817641}
-
Stephanie Kim authored
Bug: 1136565 Change-Id: I38d3499f359cfca44b5c7d88dc4907edde6aa9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473038 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#817640}
-
Joon Ahn authored
With data initialized to 0, you can somewhat see the plot line at y=0. This has the potential to be misinterpreted. Bug: 1125150 Change-Id: I3422359f1ef5d21c5376a633af9c16cb0d803ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476518 Commit-Queue: Joon Ahn <joonbug@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817639}
-
Dave Tapuska authored
With the removal of Fullscreen Pepper we no longer need to traverse the frame tree to decide if something has focus or not. Now focus will match what blink believes it is. Since the plugin will be focused so we can look for the focused WebPlugin and if it exists ask via that API. This brings the flow inline with other editing command (selection, editing). This change has minor changes on the SimulateIMEEvent code flow in that simulated IME events are now dispatched to the pepper instance they were invoked on and not the focused one that they previously would have. The tests always focus the instance so this shouldn't be an issue. Verified in Pepper via: out/Release/chrome --register-pepper-plugins="out/Release/libppapi_example_ime.so;application/x-ppapi-example-ime" BUG=1097816 Change-Id: I9a6b4514b80432938783043d392a96448e530216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463553 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#817638}
-
Danan S authored
Some <webview> hosted apps are slow to set up their postMessage listener. This results in the initialization message from this class being missed completely. This change makes the PostMessageAPIServer ping the guest content with init messages with an exponetial-backoff delay until either it responds with an 'init' message itself, or a maximum number of attempts is reached, after which it resets back to the minimum delay again. It repeats this process until the guest content confirms initialization. This should not cause an issue with CPU load, since the postMessage calls are low overhead, and they do not involve any network round-trips. If we find that the timeout is insufficient for some very slow cases (i.e. web apps that are very slow to start listening due to connection issues affecting the load of async resources), then we can consider implementing exponential backoff. Bug: 1133469 Change-Id: Iabff295083a245fbf7010a716320fbf4d2a0e688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438751Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#817637}
-
Gang Wu authored
This CL create a general layout xml for the custom view. Also fix the issue that "Downloads" and "Bookmarks" always show the icon, this is not a real bug, only happen if someone manually enabled phase 2(regroup) and nothing else. Also set show icons by default for phase 4 & 5. Bug:1138987 Change-Id: Ida2f697d85055ed9fcf9d3bc6e8da8010b9de3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467077 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL fixes the failing dependency_manager import on the bots BUG=1138758 Change-Id: Ib76d51e5fda163e044d39875546dd28ca305602f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475976 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#817635}
-
Kyle Horimoto authored
This class manages startup/shutdown of the Nearby utility process by using a reference count of the active clients. It is used by a future CL to connect to the process for Nearby Sharing. This CL leaves a TODO for a future CL to add the asynchronous shutdown flow. Tests for this new class are omitted in this CL and are added in the follow-up CL which adds the asynchronous shutdown flow [1] to prevent unnecessary churn in the test. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2460230 Bug: 1130069 Change-Id: I72782c4c2d8c5024cbcc7613497b7efbd46ecb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459112 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#817634}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ios. R=rohitrao@chromium.org Bug: 1113033 Change-Id: Ibe0f5032e497668b9b6327dc07fc0c43a719b470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469221 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#817633}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/41fc174d7967..ec64d037bd04 2020-10-15 mtklein@google.com cond_stack/mask_stack for CPU backend 2020-10-15 kjlubick@google.com [canvaskit] Expose Perlin Noise shaders. 2020-10-15 kjlubick@google.com [canvaskit] Clean up Shader docs/types/names 2020-10-15 adlai@google.com Migrate debugger & canvaskit to GrDirectContext 2020-10-15 bsalomon@google.com Ref GrDirectContext in MakeBackendRenderTargetSurface 2020-10-15 ethannicholas@google.com moved SkSL InterfaceBlock data into IRNode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I24dcaab427c4af24778f6a4944b79907e8e496f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476566Reviewed-by:
-
Ian Kilpatrick authored
Previously LayoutGrid performed a simple logical-height change check to determine if a grid-item needed relayout. This wasn't correct as when setting an override logical-height the definiteness can change causing %-height children to resolve differently. This became troublesome after we moved relative-positioning into NG as %-block-start, %-block-end offsets weren't resolving correctly. This however also fixes other issues such as test: percentage-size-subitems-002.html Where LayoutGrid wasn't performing a relayout causing grandchild to size incorrectly. This may have a performance hit for any legacy children being having layout performed by a LayoutGrid, however should be fine for an NG child as we have much more precise cache logic for this case. The following tests have been marked as failing: virtual/layout-ng-grid/external/wpt/css/css-grid/relative-grandchild.html virtual/layout-ng-grid/external/wpt/css/css-grid/grid-items/percentage-size-subitems-002.html as GridNG doesn't correctly set up the constraint spaces yet. Bug: 1138504, 1018439 Change-Id: Iac2484f1b175f152e491f421449fb7b555c9e125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474917 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#817631}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/53380f9ed76f..481ecff293db 2020-10-15 dsinclair@chromium.org [ast] Require StructType to have a name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: enga@google.com Change-Id: Ia8ad636e8e50cddc1a5aaff97f3428fd37d5b844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476572Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I286bf611e9142af7ed21facdbf2814e6568e4904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476777Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#817629}
-
Peter Boström authored
Fixes regression where the dialog had to be explicitly accepted to apply pending updates. Bug: 1137491 Change-Id: I9c8166aa013714b08280eaf1d51c7831dcd6b9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476719 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817628}
-
