- 23 Jan, 2011 9 commits
-
-
rdsmith@chromium.org authored
This change shifts standard download processing to wait on history insertion (note that actual data download does not wait). This makes the download process less racy and is expected to make the download tests less flaky. Note that it also brings the rename to the download intermediate file rename inline into standard download processing; i.e. now we always rename to the intermediate file name and then to the final file name. This again reduces raciness and possibly tset flakiness. BUG=63237 TEST=All current download tests. Review URL: http://codereview.chromium.org/6096003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72301 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
Also move the implementation from header to the source file. BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6264010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72300 0039d316-1c4b-4281-b951-d872f2087c98
-
jnd@chromium.org authored
BUG=none TEST=Run webkit layout test fast/canvas/webgl/framebuffer_test.html in embedded environment. Review URL: http://codereview.chromium.org/6365006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72299 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72295 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=67219 TEST=unit-tested Review URL: http://codereview.chromium.org/6213002 TBR=georgey@chromium.org Review URL: http://codereview.chromium.org/6259016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72293 0039d316-1c4b-4281-b951-d872f2087c98
-
georgey@chromium.org authored
BUG=67219 TEST=unit-tested Review URL: http://codereview.chromium.org/6213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72292 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6342016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72291 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=70511 TEST=greener tree TBR= mpcomplete@chromium.org Review URL: http://codereview.chromium.org/6352014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72290 0039d316-1c4b-4281-b951-d872f2087c98
-
mhm@chromium.org authored
Since new tab pages cannot be overridden in incognito windows, a note should be specified in the documentation. Some users I have seen in IRC and Forums have this confusion. The reason why you cannot override is from the following bug, where extension developers discussed the following issue: http://crbug.com/39372 BUG=None TEST=Open the page and the content will be shown Review URL: http://codereview.chromium.org/6295008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72286 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jan, 2011 31 commits
-
-
willchan@chromium.org authored
Perf test done. BUG=none TEST=none Review URL: http://codereview.chromium.org/6342017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72285 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
Will revert after getting a run on the perf cyclers. BUG=none TEST=none Review URL: http://codereview.chromium.org/6288011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72284 0039d316-1c4b-4281-b951-d872f2087c98
-
crogers@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6308014 TBR=crogers@google.com Review URL: http://codereview.chromium.org/6322007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72283 0039d316-1c4b-4281-b951-d872f2087c98
-
crogers@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6308014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72282 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6106004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/6313002 TBR=vitalybuka@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72281 0039d316-1c4b-4281-b951-d872f2087c98
-
crogers@google.com authored
TBR=rniwa git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72280 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/6265009crogers@google.com authored
TBR=rniwa git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72279 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/6339004crogers@google.com authored
BUG=none TEST=none TBR=rniwa git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72278 0039d316-1c4b-4281-b951-d872f2087c98
-
gavinp@chromium.org authored
With this counter of all startups, you can now use metrics to compute ratios of sessions. Also add some UMA to the tracking file. TEST=not this time BUG= no Review URL: http://codereview.chromium.org/6281009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72277 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72273 0039d316-1c4b-4281-b951-d872f2087c98
-
rniwa@chromium.org authored
Revert 72225 - This patch moves the experiments settings from the user profile to the browser's local state, since these settings correspond to command line switches. This is a release blocker for NaCl, so we decided to push this through. Windows browser tests are failing. TEST=manual BUG= http://code.google.com/p/nativeclient/issues/detail?id=1322 Review URL: http://codereview.chromium.org/6267009 TBR=bbudge@google.com Review URL: http://codereview.chromium.org/6262010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72271 0039d316-1c4b-4281-b951-d872f2087c98
-
rniwa@chromium.org authored
Windows browser tests are failing. BUG=none TEST=none (tested locally on Mac OS X to verify about:flags shows the web audio feature and that it can be enabled/disabled) Review URL: http://codereview.chromium.org/6339004 TBR=crogers@google.com Review URL: http://codereview.chromium.org/6364005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72270 0039d316-1c4b-4281-b951-d872f2087c98
-
rniwa@chromium.org authored
Windows browser tests are failing. TBR=tony TBR=rniwa@chromium.org Review URL: http://codereview.chromium.org/6268011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72269 0039d316-1c4b-4281-b951-d872f2087c98
-
rniwa@chromium.org authored
This CL caused a lot of browser tests to crash on Windows. It's possible that the crashes were caused by some bot flakiness but we need to revert this CL first to diagnose the cause. BUG=none TEST=none (I tested locally on Mac OS X against all of my web audio API demos) Review URL: http://codereview.chromium.org/6265009 TBR=crogers@google.com Review URL: http://codereview.chromium.org/6314015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72268 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@google.com authored
BUG=chromium-os:9870 TEST=Run browser_tests. Review URL: http://codereview.chromium.org/6385002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72267 0039d316-1c4b-4281-b951-d872f2087c98
-
rniwa@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6254007 TBR=chaitanyag@chromium.org Review URL: http://codereview.chromium.org/6275015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72264 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
other messages being processed. Added unittests for MessageReader. BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6271004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72262 0039d316-1c4b-4281-b951-d872f2087c98
-
crogers@google.com authored
BUG=none TEST=none (tested locally on Mac OS X to verify about:flags shows the web audio feature and that it can be enabled/disabled) Review URL: http://codereview.chromium.org/6339004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72261 0039d316-1c4b-4281-b951-d872f2087c98
-
rniwa@chromium.org authored
TBR=tony git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72260 0039d316-1c4b-4281-b951-d872f2087c98
-
crogers@google.com authored
BUG=none TEST=none (I tested locally on Mac OS X against all of my web audio API demos) Review URL: http://codereview.chromium.org/6265009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72259 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitbm@google.com authored
Review URL: http://codereview.chromium.org/6297014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72258 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
BUG=68677,67273 TEST= Review URL: http://codereview.chromium.org/6354016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72255 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
This is the change requested by Will. BUG=None TEST=None Original Review URL: http://codereview.chromium.org/6243010/Signed-off-by:
Simon Glass <sjg@chromium.org> Reviewed-by:
William Chan <willchan@chromium.org> Reviewed-by:
Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/6299015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72254 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
BUG=64144 TEST=manual (Code relies on Extension, which can't be mocked out) Review URL: http://codereview.chromium.org/6352010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72253 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6376008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72252 0039d316-1c4b-4281-b951-d872f2087c98
-
cevans@chromium.org authored
the current menu command to whoever opened the custom menu. We have to track it in a slightly ugly manner thanks to GTK's out-of-order messaging for "menu item selected" vs. "context menu closed". BUG=NONE TEST=manual Review URL: http://codereview.chromium.org/6278013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72251 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Get rid of RenderViewHostDelegate::BrowserIntegration since it was unnecessary. RenderViewHost used to dispatch messages only to call that interface, and TabContents would do the work. Instead have TabContents dispatch the messages directly. Review URL: http://codereview.chromium.org/6336012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72250 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6371007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72249 0039d316-1c4b-4281-b951-d872f2087c98
-
noelallen@google.com authored
which portion of ppapi to use. This revents ppapi from inducing dependencies on other libraries such as base, or large code bases such as mesa in the cases where the ppapi user doesn't need them. BUG=nacl1339 TEST=None Review URL: http://codereview.chromium.org/6265022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72248 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Based on discussion from https://bugs.webkit.org/show_bug.cgi?id=52697 to be consistent with other WebKit ports. BUG=69499 TEST=media_unittests Review URL: http://codereview.chromium.org/6259012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72247 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
that these requests can upload data on the same lines as regular HTTP POST and PUT requests. As a result we would end up never sending out the request to the server. Cleaned up the code in our IBindStatusCallback::GetBindInfo implementation to always honor the posted data length associated with the current request and use it to determine whether we have data to upload. Fixes bug http://code.google.com/p/chromium/issues/detail?id=70302 BUG=70302 TEST=As described in the bug at this point. We need to add support in the HTTPTest server to allow the PROPFIND and other custom methods. Will do that in a subsequent CL. Review URL: http://codereview.chromium.org/6360011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72246 0039d316-1c4b-4281-b951-d872f2087c98
-