- 25 Sep, 2020 40 commits
-
-
Adam Rice authored
There was a race condition in the network service where if a disconnect on the writing or reading data pipes was detected before the disconnect on the mojo interfaces it would fail to send a close frame. To fix, stop resetting the connection when the data pipes are closed. Re-enable the SendCloseFrameWhenTabIsClosed browser test. It should no longer be flaky, and it's the only test we have for this behaviour. Also modify the SendCloseFrameWhenTabIsClosed test to no longer timeout on failure. BUG=1123349 Change-Id: Ib4aaa46cb1f9f97e09509f59ef421228d02c941d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398036 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#810463}
-
Bo Majewski authored
Part 2 of 2: Clean up mojo bound and call flow. reset() the pdf_thumbnailer_ when the server replies with a Bitmap to make the code robust to server errors (ignore disconnects) during post-processing of the Bitmap. Bug: 1129607 No-try: true Change-Id: I7dbbdecc667116c4d2a56e630b9f54162fb47279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426628 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810462}
-
James Cook authored
- Change namespace from search_box to ash. - Rename some constants to add prefix kSearchBox - Eliminate SEARCH_BOX_EXPORT macros. They aren't needed because search box is just a source_set. Bug: 1131641 Test: compiles, ash_unittests Change-Id: I55a4706bc57de90a823663a6f42f4554c09577b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430043 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810461}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a3fd937cbdee..e11be3c4ad04 2020-09-24 cpinnamaneni@microsoft.com [DevTools] Shorthand properties bug fix 2020-09-24 tross@microsoft.com Add option to group issues by category 2020-09-24 sigurds@chromium.org Update DevTools protocol 2020-09-24 aerotwist@chromium.org TypeScriptify HeapSnapshot Worker supporting files 2020-09-24 sigurds@chromium.org [ts] Type-check front_end/coverage/CoverageModel.js with TypeScript 2020-09-24 jacktfranklin@chromium.org Move extractSearchRegex into StringUtilities 2020-09-24 mathias@chromium.org Remove the global spacesPadding and numberToStringWithSpacesPadding helpers 2020-09-24 wolfi@chromium.org Allow keyboard navigation on frame details view 2020-09-24 alexrudenko@chromium.org Typescriptify Distances tool in inspector overlay 2020-09-24 sigurds@chromium.org Show initiator URL in developer resources view 2020-09-24 jacktfranklin@chromium.org Migrate SearchView to TypeScript 2020-09-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-24 szuend@chromium.org Use object notation for MediaModel.js and enable TypeScript 2020-09-24 szuend@chromium.org [ts] Type-check media/TickingFlameChartHelpers.js with TypeScript 2020-09-24 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from media/PlayerDetailView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1002914,chromium:1011811,chromium:1050549,chromium:1069378,chromium:1072331,chromium:1131801 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0551708a1ccd38d99f52a5b7fc6e8cc0492f735b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430188Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810460}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b97b3cb2bd0..fe3d9a23095e 2020-09-24 fmalita@chromium.org Reland "[skottie] Reduce CompositionBuilder stack footprint" 2020-09-24 bsalomon@google.com Reland "Allow rect and circle blur fast cases to be used with rotation matrices." 2020-09-24 jlavrova@google.com ICU project: text break iterators in SkShaper 2020-09-24 fmalita@google.com Revert "[skottie] Reduce CompositionBuilder stack footprint" 2020-09-24 brianosman@google.com Add missing include to fix generated files bot 2020-09-24 mtklein@google.com q14 rethink 2020-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9a7bc8d5 to 6a3c229f (401 revisions) 2020-09-24 fmalita@chromium.org [skottie] Reduce CompositionBuilder stack footprint 2020-09-24 csmartdalton@google.com Add "AllPathsVolatile" skpbench bots 2020-09-24 csmartdalton@google.com Begin implementing onPrePrepare for tessellation ops 2020-09-24 rmistry@google.com Add digital micrography svg to the RecreateSKPs bot 2020-09-24 johnstiles@google.com Update doc comments to match new enum structure. 2020-09-24 ethannicholas@google.com Revert "Revert "moved BinaryExpression's data into IRNode"" 2020-09-24 brianosman@google.com Remove unsafe compiler methods related to external values 2020-09-24 robertphillips@google.com Revert "Allow rect and circle blur fast cases to be used with rotation matrices." 2020-09-24 adlai@google.com Revert "Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext"" 2020-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6aadd31a5f98 to a09406249fa3 (1 revision) 2020-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0b29732cd84f to 75e5ed6161fc (3 revisions) 2020-09-24 csmartdalton@google.com Make WangsFormula_* tests more tolerant of rsqrt approximation 2020-09-23 jvanverth@google.com Add AMD allocator to D3D12 backend. 2020-09-23 herb@google.com error on the side of safety for empty blobs 2020-09-23 adlai@google.com Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext" 2020-09-23 johnstiles@google.com Fix crash with invalid out parameters. 2020-09-23 csmartdalton@google.com Optimize GrWangsFormula 2020-09-23 johnstiles@google.com Add new unit tests for SkSL. 2020-09-23 bsalomon@google.com Allow rect and circle blur fast cases to be used with rotation matrices. 2020-09-23 brianosman@google.com Various cleanup related to symbol tables 2020-09-23 egdaniel@google.com Add optional param to setBackendTextureState to return previous state. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1087705 Tbr: csmartdalton@google.com Change-Id: Ib95bf885bcc08c27023664f4534abae31c830525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429892Reviewed-by:
-
Roman Arora authored
Bug: 1099917 Change-Id: I90dd2b7bf62d6289976c5ae53293773529f0e4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429468Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#810458}
-
Andrew Grieve authored
Reworks a lot of how arg parsing works so that there is less room for failure (hopefully). Including: * Rename: --no-source-paths -> --no-output-directory * Make --ssargs-file top_args only. Also allows passing --no-native via command-line and have that work when .ssargs file is used. Bug: 1132015 Change-Id: Ia4e46e056d9878e51d497041a231cb5dcde846fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429449 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#810457}
-
danakj authored
The test was flaky but the underlying flakiness was fixed in 86ae1baf. The MainThreadEventQueue now destroys its OneShotTimer on the main thread in ClearClient() before the main thread reference to the MainThreadEventQueue is dropped. This prevents the timer from being destroyed along with the MainThreadEventQueue on the compositor thread, if that is the last reference to the MainThreadEventQueue. R=dtapuska@chromium.org Bug: 1104826 Change-Id: I0e46906f731ea5c628cb997eb9b9e0b57f407daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429803Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810456}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I189ed9d9e19b6d288a8da927c28d2b7734a5a019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430231Reviewed-by:
-
Fabrice de Gans-Riberi authored
Bug: 1104411 Change-Id: I0ad22ab8c852f5c66813136f4a4c07bdcc4e1234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427186 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#810454}
-
Sunny Sachanandani authored
Remove the NV12, decode swap chain, and underlay feature flags since these features have shipped for quite some time. The NV12 feature flag was also used for using YUY2 over NV12 for tests so introduce a new flag for choosing the default SDR video overlay swap chain format. Add tests for NV12, YUY2, and BGRA instead of just YUY2. Also cleanup some of the testing code to be consistent in other_args, switch names, etc. Bug: 869677 Change-Id: I0831b103506f394d6fe26bf1085401e2e2d50599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424576Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#810453}
-
Xianzhu Wang authored
This avoids unnecessary transform node when there are compositing reasons for other paint property nodes. For example, for backdrop-filter we should create an effect node but not a transform node. In the future will-change:opacity should not create a transform node either, when we fix crbug.com/900241. Change-Id: Ic9389137019381390c099688a078d65a5a6e56b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429394Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810452}
-
Felipe Erias authored
Break up the scrollbar-gutter tests into separate files for horizontal and vertical writing modes, and add additional tests. Move the tests to wpt_internal/css/css-overflow since they require the non-standard feature ::-webkit-scrollbar Bug: 710214 Change-Id: I988f2acd8cd17a6623765aedfb8938e71942a683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417471 Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#810451}
-
Joel Hockey authored
Bug: 1130361 Change-Id: Ic034197c38272e34b84849785fb5f9d29f491f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428511 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#810450}
-
Siyu An authored
1. Add stored offer data count 2. Add logging for data validity Bug: 1112095 Change-Id: I31c5ccbe555e9e0f1c314768b612c56eaecf32d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425391 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#810449}
-
Xinghui Lu authored
The separator is only needed if clicking on the left and the right of the row does different things. SafetyCheck not run: before: http://screen/Ak3K7GEyxFsMEb6 after: http://screen/Gm8y5irTtwbh7Be SafetyCheck run: before: http://screen/5XUCb2MoLjMV38R after: http://screen/BJmxvGDGpxtKWSZ Bug: 1128564 Change-Id: Ib9c24395180b24a58f0feee2c8a2f9674578f00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426547Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810448}
-
chrome://media-appTrent Apted authored
Currently this only applies to .mkv files. Without the fix, '.MKV' in the same folder as a photo won't be navigation options when Backlight opens. (An .MKV will still be opened if selected by itself.) Bug: b/169360871 Change-Id: I18cebbdadaa76466860784ab47230c75bfe0660b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428513Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#810447}
-
Jimmy Gong authored
This reverts commit 4f4586fd. Reason for revert: Reverting due to flaky browsertests behaviors. See more details: crbug/1131452 Original change's description: > Printer settings: Make saved/nearby printers use FocusRowBehavior > > Description: > This change allows users to tab to the first printer in the saved > and nearby printer lists and use the arrow keys to navigate the > remaining printers. Users can also use the arrow keys to navigate > through a printer entry's associated buttons/icons. Lastly, the > printer entry row will be highlighted (blue background) if it is > being focused. > > Screenshots: > - http://shortn/_Fqf1Nn9qjF nearby printers > - http://shortn/_BSspETkjzV saved printers > > Bug: 987422 > Test: gtest_filter=OSSettingsCupsPrinterLandingPageV3Test.All > Change-Id: I68fc5fc3ff2ceec88ce81f95da5b451a6ad3beb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399601 > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Commit-Queue: Michael Checo <michaelcheco@google.com> > Cr-Commit-Position: refs/heads/master@{#809354} TBR=jimmyxgong@chromium.org,michaelcheco@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 987422, 1131452 Change-Id: Id5f71a13ee85f9d58c4fa38ed9e0a7422f797160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429289 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#810446}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I766ce2f732ca991070bb87c98f8d677c80c24eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429977Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810445}
-
Moe Ahmadi authored
- Merges the new header info with the old one in ACResult rather than replacing it. The old header info may be needed by the old matches. - Clears the header info along with matches in AutocompleteResult::Reset - Moves the logic to strip the match group IDs that don't have an equivalent header string next to the logic for grouping and demoting matches with headers in ACResult for improved readability. Bug: 1122669, 1130826, 1130880 Change-Id: Ibddaa30ccd19969a71e10befa993adb688a1f572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424549Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810444}
-
Donn Denman authored
Never expire one key histogram for Contextual Search that indicates how often something useful is being shown in the Bar. This is a key metric for usefulness of the feature. BUG=1089460 Change-Id: Ic973ecfeb7e47d14aaeaf039aed2815ddc57ad2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425423 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#810443}
-
K. Moon authored
Drops various GetDownloadProgress() APIs from the PDF viewer because: 1. We never call pp::URLRequestInfo::SetRecordDownloadProgress(), so calls to pp::URLLoader::GetDownloadProgress() always return false. 2. We only use GetDownloadProgress() in DocumentLoaderImpl, to try to get the total content length if we fail to get it from the Content-Length header. But the total content length reported by GetDownloadProgress() also comes from Content-Length, so this is not useful. 3. GetDownloadProgress() won't be useful post-Pepper, as blink::WebAssociatedURLLoader does not have a similar API. Instead, the client is expected to track this internally. Bug: 1099022 Change-Id: I6f2f183e84b2d9e4c0dee2c116ac08bce3dc4ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429545Reviewed-by:
-
Alex Turner authored
Bug: 973801 Change-Id: I001b71e204baaaf5cfd7f8e14b8683a58d1907a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429244Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#810441}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Id98e0e2c3f27a7077205fd991e6f79cc64a38434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429429Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#810440}
-
Sunny Sachanandani authored
These tests have been disabled for a long time, and don't seem to be testing anything useful. Remove them completely. Bug: None Change-Id: I86126e852498d51d28ba2ded0f42ca61c9ad1798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424725Reviewed-by:
-
David Bienvenu authored
In response to comment on crrev.com/c/2384332. Per mpearson@: For enums versus sparses, the underlying UMA data / logs will look the same. It's only the implementation in Chromium that would be different. Change-Id: Ia75d78379977f36ec7873d5fb5d52998e6a366d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429975Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810438}
-
Dominic Mazzoni authored
All of these tests were triggering starting the "real" TTS engine, even though a mock TTS engine was installed. I ran all of the ChromeVoxBackground tests before and after this change on my system with --test-launcher-jobs=20. If the speech engine is installed, the average test time drops 30%, from 8200 ms to 6200 ms. Even if the speech engine is not installed, it still drops 25% from 7700 ms to 6200 ms. Bug: none Change-Id: Iea23951ce397176cd1fda64d801422f3031a1fba AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422585 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#810437}
-
Liquan (Max) Gu authored
RendererFrameHost could have been removed (e.g., because the page has navigating away), when payment_request_factory is trying to create the desktop PaymentRequest service. So payment_request_factory should check RendererFrameHost.isCurrent() before the creation of the service. Bug: 1131214f Change-Id: Idde6077f1ce559072f7272b52b0d994d93aab805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426252Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810436}
-
Nick Burris authored
This patch adds a browser-side flag that can be used to disable the feature regardless of the Blink feature state. Bug: 1131040 Change-Id: Ie879301e62404c6c73cf7dc39b2c12ad5908e4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430044 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
-
evliu authored
This CL moves the code checking the SODA paths to before the service is launched. Bug: 1121384 Change-Id: I70e1caf6086dce94a25c425a2959381293545bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429745Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#810434}
-
Peter Kasting authored
Bug: 1131842 Change-Id: I0612adf1075e417bcb43cd24b69b19b96be6b7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429785 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
My Nguyen authored
This wasn't carried over when I added the translate-target because I don't really understand its intention. Update test and comment. Before: http://screen/3Uh7wzmoFjZVHTN After: http://screen/BVcaJp66E8CpSvs Bug: 1113439 Change-Id: I10fc16aa8287a0901ffc41599eba5cda42a0c926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428510 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810432}
-
Sonny Sasaka authored
This reverts commit 54974f6a. Reason for revert: After evaluation, staying with green is decided. BUG=b:167556640 Original change's description: > [Bluetooth] Use secondary text color for device connectivity status. > > As per recommendation in Comment #30 of crbug.com/1114876. This > is the same grey used in Network Settings secondary text. > > Bug: b:167556640 > Change-Id: I5a669cae3e43fc7cfe3d57eb276a4f6584a322e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404141 > Auto-Submit: Ryan Hansberry <hansberry@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805877} TBR=khorimoto@chromium.org,hansberry@chromium.org,vecore@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:167556640 Change-Id: Ie4780eb924787986a80cf1dff00a0e48c5fd8207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429971Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
-
Tim Judkins authored
This change gates the ability to use promises with the extensions API on the calling context being associated with a Manifest V3 extension or WebUI. Bug: 978538 Change-Id: I3a1d11fdc128b7ad3728f7e95298ba73d089cde4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380341 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810430}
-
Patrick Noland authored
The process of supplying OverviewModeBehavior is now async to prevent re-entrancy in OneshotSupplier (as of https://crrev.com/c/2321067). Since observer notification in LayoutManager is synchronous, this creates a race condition where observers miss an update because an event (e.g. a touch event, as in the linked bug) queued before the call to set() can trigger synchronous observer notification before observers can add themselves. Reland note: StatusBarColorController failed on L due to a difference in how colors should be calculated. I'm not positive why TabbedAppMenuTest failed, but it seemed to be a race condition triggered (or uncovered) by the change in timing caused by making observer notification async. I think I've fixed it by blocking on the call to showAppMenu rather than polling the status via the instrumentation thread. Bug: 1129783 Change-Id: I88ac8efcc845826f0396cb624450ef1ba8d5b399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427428Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#810429}
-
Dan McArdle authored
https://chromium.googlesource.com/external/github.com/google/libprotobuf-mutator.git/+log/439e81f8f484..8942a9ba43d8 $ git log 439e81f8f..8942a9ba4 --date=short --no-merges --format='%ad %ae %s' 2020-08-18 vitalybuka Update probuf revision 2020-07-29 vitalybuka Move cpplint invocation into a separate job 2020-07-29 vitalybuka Avoid parsing of last mutated message 2020-07-29 vitalybuka Use gmock in LibFuzzerTest 2020-07-28 vitalybuka Fix message before every LLVMFuzzerTestOneInput This is needed to make sure that corpus is still compartible. 2020-05-05 vitalybuka Update protobuf lib 2020-05-05 nareddyt Revert "Dissable AllowUnknownField" 2020-05-05 nareddyt Revert "Fix the test" 2020-04-24 vitalybuka Fix the test 2020-04-24 vitalybuka Dissable AllowUnknownField 2020-04-20 nareddyt Review comments 2020-04-17 nareddyt Add test 2020-04-17 nareddyt Allow unknown fields in corpus parser 2020-04-10 vitalybuka Add missing #include <iostream> 2020-04-10 vitalybuka Add missing #include <iostream> 2020-04-09 jorg.brown Add missing #include <iostream> 2020-03-26 vitalybuka Fix std::bitset overflow 2020-02-04 vitalybuka Lint fixes 2020-02-04 vitalybuka Add Clone test 2020-02-04 vitalybuka Improve efficiency of mutator by allowing Copy/Clone only in CrossOver 2020-02-04 vitalybuka Fix compilation issues for Google internal code 2020-01-29 vitalybuka Remove unnececary size_increase_hint adjustment 2020-01-29 vitalybuka Implement Any support Fixes #151 2020-02-04 vitalybuka Deflake FailedMutations test 2020-01-29 vitalybuka Accept arrays of messages in MutateImpl For #151 2020-01-29 vitalybuka Improve field test by preventing copying of top level messages 2020-01-29 vitalybuka Run InsertField for proto3 2020-01-29 vitalybuka Move CrossOver next to Mutate 2020-01-29 vitalybuka Combine post processing and initialization It's going to be useful for Any support 2020-01-27 vitalybuka Add Any tests for #151 2020-01-27 vitalybuka Reduce number of iterations in some tests 2020-01-27 vitalybuka Make test output more verbose 2020-01-27 vitalybuka Add google.protobuf.Any into test messages 2020-01-26 vitalybuka Remove unneded namespaces 2020-01-26 vitalybuka Implement CrossOver using Copy/Clone mutations 2020-01-26 vitalybuka Use bitset to controll allowed mutations 2020-01-26 vitalybuka Extract GetMaxSize function 2020-01-26 vitalybuka Clone implementation 2020-01-25 vitalybuka Use size_increase_hint selecting copy source 2020-01-25 vitalybuka format 2020-01-25 vitalybuka Use signed size_increase_hint 2020-01-25 vitalybuka Use max_size_hint instead of size_increase_hint 2020-01-25 vitalybuka Update README 2020-01-24 vitalybuka Take into account size_increase_hint selecting mutation 2020-01-24 vitalybuka Make post_processors_ private 2020-01-24 vitalybuka Allow to use a different message as "copy" source Preparation for #44 2020-01-15 vitalybuka Log message when IsInitialized assert fail 2020-01-08 vitalybuka Support multiple callbacks per message type Fixed #146 2020-01-07 vitalybuka Fix typo 2020-01-07 vitalybuka Update README.md 2020-01-07 vitalybuka Fix typo 2020-01-07 vitalybuka Fix typo 2020-01-07 vitalybuka Remove const 2020-01-07 vitalybuka Document PostProcessorRegistration 2019-10-08 vitalybuka Check post_processors_.empty() in CrossOver 2019-09-30 pefoley Add global mutator support 2019-09-06 vitalybuka Update googletest and protobuf 2019-09-06 vitalybuka Don't "post process" and InitializeAndTrim from recursive Mutate calls 2019-09-06 pefoley run clang-format 2019-09-06 vitalybuka Move registration in function scope static variable 2019-08-31 vitalybuka Replace Custom mutations with mutation post processing 2019-09-05 vitalybuka Update README.md 2019-08-31 vitalybuka Remove static members from Mutator 2019-08-30 vitalybuka Use Mutator as singleton 2019-08-31 vitalybuka Move random number generator inside of Mutator. 2019-08-12 aaskar Add Travis and oss-fuzz badges to README 2019-04-29 31459023+hctim More dependencies! 2019-07-29 vitalybuka Remove trailing spaces 2019-07-29 vitalybuka Update protobuf 2019-07-29 vitalybuka Move no_mutator_test.cc 2019-07-29 vitalybuka Initialize fields of map entries 2019-07-29 vitalybuka Convert more tests into TYPED_TEST 2019-07-29 vitalybuka Fix no_mutator_test build for "check" 2019-06-08 toshi.piazza Renames SANITIZER_INTERFACE_WEAK_DEF to LIB_PROTO_MUTATOR_WEAK_DEF 2019-06-07 topiazza Introduced SANITIZER_INTERFACE_WEAK_DEF 2019-06-01 topiazza Builds tests with MSVC 2019-05-29 topiazza Updates CMakeLists.txt to build for MSVC 2019-04-29 31459023+hctim Add a line break. 2019-04-29 31459023+hctim Add proto dependencies to prerequisites. 2019-04-17 spq Fix compile error/warning in src/field_instance.h (was comparison with unsigned < 0, which is always false) 2019-02-04 vitalybuka Remove workaround for stack overflow 2019-02-04 vitalybuka Update protocolbuffers 2019-01-31 vitalybuka Add check to avoid stack overflow parsing nested messages 2019-01-30 kcc replace std::mt19937 with a much faster std::minstd_rand 2019-01-31 vitalybuka Speedup unit tests 2019-01-29 konstantin.s.serebryany Update README.md Created with: roll-dep src/third_party/libprotobuf-mutator/src Change-Id: Ie0169814c587b00fa1a25239fe0f8d338634b7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427157Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#810428}
-
Elaine Chien authored
Bug: 779414 Change-Id: I8e7597877f68be4a88595b9b055e26b4c0b25e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422817 Commit-Queue: Elaine Chien <elainec@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810427}
-
Aaron Leventhal authored
- Display: none objects should not get an accessible name. - EnsureComputedStyle() should not be called during a potentially unsafe time. This is fixed by calling it during Init(), in cases where it will likely be needed (inside a display:none subtree). - Remove unnecessary and often incorrect heuristic for determining when inside an aria-labelledby or aria-describedy calculation. This flag is already passed in via recursion when following that kind of relation. - Do not recurse into children that are explicitly hidden - Improve explicitly hidden computation for CSS visibility. Explicitly hidden means that the element was specifically hidden, and that it didn't just inherit the fact that it's hidden. - Improve results in name-calc-visibility, where an element explicitly referenced by aria-labelledby wasn't included in the name because it was visibility:hidden element. Elements that are explicitly referenced must be included in a name or description even if they are hidden. Bug: 1130436 Change-Id: I58b7b70b53c5c1d37ec1407bc2ecb35de3d17d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212795Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810426}
-
My Nguyen authored
New language settings for Chrome OS is looking at removing this option because it seems confusing to users. Adding metrics to measure usage. Mock: http://go/cros-lang-settings-ux-slide#slide=11 Bug: 1113439 Change-Id: I206212e5f09e90893bb40a41adcb6b3e8f0a8ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423656Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
-
Robert Ogden authored
This is a reland of 821323c7 This reland disables BFCache for the previously failing task so that the test always gets a spare renderer. See http://shortn/_gKtHBOaX5w Original change's description: > Add Render Process for Site Instance Assignment to content API > > This CL adds an enum, SiteInstanceProcessAssignment, which > describes all the ways a SiteInstance may be assigned a render > process. This is exposed in the content API to allow embedders to > record this usage. > > See design doc in bug and/or chained CL for more info. > > Bug: 1129505 > Change-Id: I0654d52b4c0fef3830a877fb1c1476dea4ad9361 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417100 > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809620} Bug: 1129505 Change-Id: I9d78c7afd6219499fedf84094954aa6308435f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426253 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#810424}
-
