GitLab

We want to turn unexpected initialization of incognito mode to prevent
incognito window creation when it's disabled by policy.
These crashes are better to be reported though the crash infrastructure,
to investigate and these fix access paths.

BUG=789642

Change-Id: I040aa5b5e286df2be491952253d415c6daf0ac79
Reviewed-on: https://chromium-review.googlesource.com/806497
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521724}

The Layout Test MediaStreamTrack-gc-no-crash.html was non-determinstic in that
it depend on a race between the JavaScript side declaring the asynchronous test
"finished" and the callback to GetUserMedia arriving.

It appears there were at least 3 possible outcomes. The first case was that
the finishJSTest() would be invoked before the call to GetUserMedia
would do anything much, and the test would essentially verify nothing.
The second case was that when finishJSTest() was invoked, GetUserMedia would
have reach a point where it would have temporarily taken shared ownership
of the blink document but the callbacks would not yet have been invoked.
The third case would be that finishJSTest() would be invoked after the
callback to GetUserMedia had finished running.

It looks like in practice, at least on my local machine, the first case
was the only one reached so far.

When trying to activate the new video capture service with [1], the
timing changed so that the second case would typically be reached. This case
would lead to the leak detector running at the end of the test reporting
leaked blink objects and failing the test. I verified that the same would
happen without activating the video capture service, simply by making the
call to FakeVideoCaptureDeviceFactory::GetDescriptors() taking a bit longer,
via PlatformThread::Sleep().

After this CL, the test should deterministically always reach the third case.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/719416

Bug: 789669
Test: third_party/WebKit/Tools/Scripts/run-webkit-tests --target gn_release --enable-leak-detection fast/mediastream/MediaStreamTrack-gc-no-crash.html
Change-Id: I17c39e66cfd8c4af89f8f9b078d6512feaedbe6d
Reviewed-on: https://chromium-review.googlesource.com/806442Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521723}

Flakiness dashboard looks green, so remove @RetryOnFailure.

Bug: 767180
Change-Id: I62d513b6c89836af85bf6933bdef18f6e9df468c
Reviewed-on: https://chromium-review.googlesource.com/806318Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521722}

https://chromium.googlesource.com/angle/angle.git/+log/614dd0f537d4..3dddccff31be

$ git log 614dd0f53..3dddccff3 --date=short --no-merges --format='%ad %ae %s'
2017-11-14 jgilbert Support RGB gl-tex-external stream consumers for StreamProducerNV12.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ibe2412da1211f4a665c0c0864102f0f4bc21e405
Reviewed-on: https://chromium-review.googlesource.com/808988Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521721}

AXPlatformNodeAuraLinux was returning always 0 for GetIndexInParent, and
adding an ATK specific implementation of get_index_in_parent. As a result,
AX API would not return the right value, even if ATK would.

This fix makes get_index_in_parent rely on GetIndexInParent, and
GetIndexInParent use the delegate to obtain the value.

Bug: None.
Change-Id: Ic8d79da9f481c2cf92f28eefeb6b2030cce5e657
Reviewed-on: https://chromium-review.googlesource.com/806037
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521720}

Not overriden in any derived classes.

Change-Id: Ic31257df96803ea205834253385d760102a62f86
Reviewed-on: https://chromium-review.googlesource.com/808725Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521719}

Bug: 789067, 656015
Change-Id: Ie4201d0b9db4add3321917c31b18152b5b441411
Reviewed-on: https://chromium-review.googlesource.com/808504Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521718}

Bug: 755643
Change-Id: Idfee763c036f7efa56bc4092a6826e2e6974e74b
Reviewed-on: https://chromium-review.googlesource.com/807307
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521717}

One of the heristics rules is to capture a case like below:
country-code(max_length=3), number-field(max_length=10).

The first field will be country code and second and will be CITY_AND_NUMBER.

This fails to capture some sites where they expect a longer length, where
they expect people to put more formatting(or they do it for user), like
instead of 5141231234, they expect (514)-123-1234.

An example would be https://shop.lululemon.com/.

This change increase autofill's heuristic expectation of length to 14 for
this case.

Change-Id: I89e08d1fce9c033d3076bc75971e762d8cdf3035
Reviewed-on: https://chromium-review.googlesource.com/804358Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521716}

This change refactors CanvasAsyncBlobCreator to remove the intermediate
ImageData object and use StaticBitmapImage directly.

Bug: 787039
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8b49cfc455a50a06a83ebc3dc3c6f418346be4db
Reviewed-on: https://chromium-review.googlesource.com/780279
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521715}

This is unnecessary now that Blink code can freely use
service_manager client library APIs.

It's also incorrect since content::BlinkInterfaceRegistryImpl
uses an internal WeakPtr to the underlying BinderRegistry on
the main thread, while the BinderRegistry actually lives on the
IO thread.

This does not create any problematic races in practice since
usage on the main thread is guaranteed to preceed movement to
the IO thread, but it does violate the usage constraints of
WeakPtrFactory and triggers DCHECKs.

BUG=789064

Change-Id: Id491e7f126c861220d4b2c3b85ad25fd6384a1f5
Reviewed-on: https://chromium-review.googlesource.com/807265Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521714}

The delegates will become optional in favour of notification handlers,
so simulate events through the NotificationDisplayServiceTester instead.

Bug: 
Change-Id: I501da74ed0691e9bdb89bda139ecb12644a88893
Reviewed-on: https://chromium-review.googlesource.com/806835
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521713}

Exposing kSSLInterstitialDelayInSeconds allows tests to use it directly
rather than duplicating the value of the constant.

Bug: 790934
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If2cabdf773ce414dc966e0396847660d835c1d72
Reviewed-on: https://chromium-review.googlesource.com/806643
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521712}

This reverts commit bcb8fea0.

Reason for revert: The first good commit is c3da1e61bccf4c6a37e871f5202f937ace78898a.

Original change's description:
> Roll src/third_party/webrtc/ 83d27683a..e16927250 (15 commits)
> 
> https://webrtc.googlesource.com/src.git/+log/83d27683a83d..e169272507de
> 
> $ git log 83d27683a..e16927250 --date=short --no-merges --format='%ad %ae %s'
> 
> Created with:
>   roll-dep src/third_party/webrtc
> BUG=None,None,None,None,None
> 
> 
> The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> TBR=webrtc-chromium-sheriffs-robots@google.com
> 
> Change-Id: Iaffdd6e8ce61b9580f183b627c815c7ef3dc6cfd
> Reviewed-on: https://chromium-review.googlesource.com/808745
> Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521706}

TBR=webrtc-autoroll@chromium.org,webrtc-chromium-sheriffs-robots@google.com

Change-Id: Icc268a1e246a3f689c5a497d961e8c73f73531d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/809166Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521711}

In landscape, some entries are not visible and tests fail.
Allow to scroll to find them.

Bug: 791945
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6119ff89528a67a42501988ccd4db19e457d8fe7
Reviewed-on: https://chromium-review.googlesource.com/808785
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521710}

Prior to this patch, DoRun() in MessagePumpNSRunLoop and
MessagePumpNSApplication didn't handle well the case where keep_running_
is initially false.

This situation reproduces in the convoluted scenario of deferred quits
that involve yet another nested loop being started exactly between the
quit request and its deferred execution, which is actually exercised in
some browser tests.

The proposed solution mimics what other analogous pumps do.

Bug: 787551
Change-Id: Ida8c93f9bc189477e5ad16f86e88ac1613160ba2
Reviewed-on: https://chromium-review.googlesource.com/782563Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521709}

Some code paths require access to Blink strings that can only be
 accessed on the main thread.
A test that triggers the bug is coming up on crrev.com/c/738040.

Bug: 791992
Change-Id: I55ae617ae623766d4bd975a19070bde410d8af1d
Reviewed-on: https://chromium-review.googlesource.com/809005Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521708}

Bug: 790996
Change-Id: Ida50f82021a0cbb10306c4ee522367b500ccac16
Reviewed-on: https://chromium-review.googlesource.com/806718
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521707}

https://webrtc.googlesource.com/src.git/+log/83d27683a83d..e169272507de

$ git log 83d27683a..e16927250 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None,None,None,None,None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iaffdd6e8ce61b9580f183b627c815c7ef3dc6cfd
Reviewed-on: https://chromium-review.googlesource.com/808745Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521706}

This change also moves more tests from interactive_ui_tests to
browser_tests since they don't really need to be interactive_ui_tests.

Bug: 661629
Change-Id: I24b1c4badf848826adf6db4511ddfb1368eb60e0
Reviewed-on: https://chromium-review.googlesource.com/806686Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521705}

Enabling feature CompositeOpaqueFixedPosition revealed crbug.com/663291
that promoted fixed opaque element indirectly caused a one pixel gap due
to the way cc synced offset back to main. flackr@ fixed it by rounding
the scroll offset instead of flooring it but the fix later on caused
a regression crbug.com/677686. So he reverted the fix as well as the
feature CompositeOpaqueFixedPosition in Jan 2017
(https://codereview.chromium.org/2629793003).

This patch relands flackr's revert patch. Meanwhile, it fixes a rounding
bug which causes fractional delta pushed to main thread by adjusting the
delta with the diff between active_base_ and its rounded value.

Bug: 663291, 677686
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I9b7454760dc976b438ecf76c92c846f7086b6284
Reviewed-on: https://chromium-review.googlesource.com/793973Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521704}

In CSS Color 4, RGB() and RGBA() were synonymized, along with allowing
whitespace to separate the channels instead of commas, introducing
a backslash as a new way to separate the alpha parameter, and allowing
percent values for the alpha parameter. This updates our parsing
behavior to reflect these changes, and enables now-passing WPT tests.
The new spec is at https://drafts.csswg.org/css-color/#rgb-functions.

Bug: 788707
Change-Id: Ib0f29009e477fc88cd1ceda03ff0ebb947a36ea3
Reviewed-on: https://chromium-review.googlesource.com/798831
Commit-Queue: Chris Nardi <hichris123@gmail.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521703}

Using wpt-import in Chromium a943dd3e.
With Chromium commits locally applied on WPT:
fce5d69f "Make css-multicol/multicol-nested-column-rule-001.xht narrower."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6948

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley

No-Export: true
Change-Id: Ie8a43414cc4779db5792ddc405c346ce4363505c
Reviewed-on: https://chromium-review.googlesource.com/808644
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521702}

The builder on master side was removed in https://crrev.com/c/806035.

R=machenbach@chromium.org

Bug: 747960
Change-Id: I1a1b145f0eff4c8854583b37e5959c75c1260d76
Reviewed-on: https://chromium-review.googlesource.com/806455Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521701}

A postMessage call from the doodle resizes the iframe. The event data
supports these parameters.
  cmd (required): must be "resizeDoodle".
  width (optional): a CSS width (with units) or null. Because the doodle
    cannot know the size of the outer page, only "100%" (full page
    width) and null (default width) are recommended.
  height (optional): a CSS height (with units) or null for the default
    (200px). Must not be a percentage, but otherwise any units are OK.
  duration (optional): a CSS duration, such as 130ms or 1s. If null or
    absent, 0s (no transition) is assumed.

If a second resize is requested while a first resize is in in
transition, the doodle will eventually reach the size from the second
call, but the interpretation of the duration is not defined.

Bug: 761994
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f6afe956e710001a45a9b327748a74eab36ea01
Reviewed-on: https://chromium-review.googlesource.com/804034
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521700}

For chrome specific files, this is nicer for the user since looking at
the files in notepad is much easier.  For shared files like the google
parent categories, this is important otherwise the enterprise bundle
build script will fail when files have the same name but different
content.

Bug: 791488
Change-Id: Ie3f035a7e07500f9c023735f837aec96a5ffb7e1
Reviewed-on: https://chromium-review.googlesource.com/806691Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521699}

Bug: 788725
Change-Id: I09d62b7df3f739006972a27f35ab26da4808e310
Reviewed-on: https://chromium-review.googlesource.com/807933Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521698}

Matchers already exist to clear cache and cookies, so this test
should use those.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I70749c6e222d8e745b26469709778359452a1754
Reviewed-on: https://chromium-review.googlesource.com/806638Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521697}

The test is flaky on Lollipop Phone Tester

Bug: 774451
Change-Id: Idebf57f1a19b991d2e437b0feaed4dff1dd1c21d
TBR: mlamouri@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/809045Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521696}

Bug: none
TBR: skyostil@chromium.org
Change-Id: Ic7973be016e3f2bb7387ac1481934cc7fc0f138f
Reviewed-on: https://chromium-review.googlesource.com/809104Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521695}

The element visibility observer posts visibility updates to
RemoteFrameView. Based on crash reports, it looks like these can
sometimes arrive after the RemoteFrame has been removed from the
frame tree, making the FrameClient inaccessible. This CL causes an
early return in that case, avoiding a null pointer dereference.

Bug: 789460
Change-Id: Ibe82253859a9c0f90917331532dac39ba90fd364
Reviewed-on: https://chromium-review.googlesource.com/806363Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521694}

This CL lands server change 177311740 by clshepherd.

BUG=488484

Change-Id: I257a10f801e375453d38c05f9f6c84514782a5a6
Reviewed-on: https://chromium-review.googlesource.com/807145
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521693}

Change-Id: I46a33d40a6f5ea96b905268a548e1c0c09c01f2c
Reviewed-on: https://chromium-review.googlesource.com/809024Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521692}

SavePasswordsPreferences never registers itself as an
OnPreferenceChangeListener so its onPreferenceChange method never gets
called. This CL removes that dead code.

Note that OnPreferenceChangeListener is still used in-line, so the
import is not removed.

Bug: 788701
Change-Id: I87ae4f6be3e2dc4322fad56551338b0a8355e062
Reviewed-on: https://chromium-review.googlesource.com/808265Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521691}

Bug: 787500
Change-Id: I2966d90b7d9353c91f72b7bf09e1d5e6d120ebc3
Reviewed-on: https://chromium-review.googlesource.com/808544Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#521690}

This includes performance fixes for hb_set. After this lands, we need to
inspect the graphs for issue 782220 and 781794 to see if performance
regressions return. Previously, these performance regressions were fixed
by reverting to the old hb_set implementation, compare
https://chromium-review.googlesource.com/c/chromium/src/+/804374.

1.7.2 also includes an additional API that allows setting the CTFont
directly, and should help with issue 785522.

Bug: 791915
Change-Id: I447c1527d81e01c01253d0c3fa5b8c8b3a5a3683
Tbr: behdad, eae, kojii
Reviewed-on: https://chromium-review.googlesource.com/807986
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521689}

Although the omnibox popup itself honors safe are in the table view, the width
of the omnibox pop text can be too wide.

Bug: 787164
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If10523863a4ffd404a8c255bbad6b5219aa534e1
Reviewed-on: https://chromium-review.googlesource.com/807784Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521688}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f5d857d3..b88605f7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I2da8e2cd62c4e972b305a1215b984266d992f5f9
Reviewed-on: https://chromium-review.googlesource.com/808624Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521687}

Speculatively re-enable based on comment #5 in the bug.

TBR=guidou@chromium.org

Bug: 783790
Change-Id: Ie10aa49212a4279a8696dfbc021a577bda0a2dfd
Reviewed-on: https://chromium-review.googlesource.com/808845Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521686}

std::make_unique is preferred over base::MakeUnique, and allows
one less include.

Bug: 
Change-Id: Ibf3f6c1b061d4e53331ff976c0966b0773dcf80f
Reviewed-on: https://chromium-review.googlesource.com/806414
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521685}