- 03 May, 2019 40 commits
-
-
Peng Huang authored
The flash is because the child window created by GLSurfaceGLX doesn't match the visual of parent window. Fix the problem by always creating parent window with the same visual. Bug: 956061 Change-Id: I88cb65b4a0313be6fdea1bd8d6770d351500ccbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591946Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#656497}
-
wutao authored
Continue reading suggestion chip is using the tab's navigation title as its title. However navigation title could be empty. This patch handles the empty case to use the navigation url as a fall back title, similar to what does in the recent_tabs_sub_menu_model. Bug: 956268 Test: manual Change-Id: Iae4054bcdbbb5040829283554d3d5ff085811f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594207Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#656496}
-
Vincent Boisselle authored
(only for Linux) Bug: 954379 Change-Id: I0fa6d80dd56cc239ed2eaa554c89b0700950acf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574899 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#656495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/caf7bdf789eb..1499f5591e06 Created with: gclient setdep -r src-internal@1499f5591e06 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: I7442b71623cfcda7e6b398f8be7459e09ddd8f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594777Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656494}
-
Peng Huang authored
After hooking up skia flush done callback, we don't need this GenerateCleanupFence() call anymore, so delete it. Bug: 944194 Change-Id: I520beee3306040c35eb29f0537b508e83c1e8eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594201Reviewed-by:
-
Alex Cooper authored
This change refactors some shared code across the three runtimes into a base GamepadBuilder class to help unify the string copies and manage adding values to the arrays. This class creates/uses a few helper classes as well. In the process of enabling WebXR support, some refactoring of the OpenVR WebVR Gamepad logic was done as well, to avoid non-trivial code duplication. Bug: 956201 Change-Id: Ic757589c46723305f8188e6109b5d6ee9013bb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592274Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#656492}
-
Brandon Wylie authored
Adds the context menu and the code for the homescreen shortcut. Bug: 955514 Change-Id: I851059a23d1283340e453f1a2f00280cebd93142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589375 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#656491}
-
Joshua Peraza authored
48675b4bd3dd Remove pid_t in platform-independent code 59cdfbb031df linux: support multi client sockets in ExceptionHandlerServer a11243e8f12a linux: add wrappers for send/recvmsg e23286dc371c linux: extend handler protocol with credential messages 607c80e0b8f0 linux: Implement StartHandler() Change-Id: If2d825d90b4711a70f5a5178fb8171e60b24c12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592697Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#656490}
-
Joel Klinghed authored
PersonalDataManager::NotifyPersonalDataObserver will call OnPersonalDataChanged and often OnPersonalDataFinishedProfileTasks on PersonalDataManagerObserver. Trouble is that it does this in the same ObserverList loop. So if PersonalDataManagerObserver implementation of OnPersonalDataChanged calls PersonalDataManager::RemoveObserver(this) then it will still be called on OnPersonalDataFinishedProfileTasks. Worse, if PersonalDataManagerObserver deleted itself after removing itself as an observer you now have a use-after-free calling a virtual method on a destroyed object. There are not currently any PersonalDataManagerObserver implementations that I can find that has this problem. Bug: 959172 Change-Id: I2bb0a625f5c3a847c5d035ccc57b5fdb349366b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594529 Commit-Queue: Joel Klinghed <the_jk@opera.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#656489}
-
Andrew Grieve authored
Was getting a few: ERROR Input to target not generated by a dependency. Bug: 843307 Change-Id: I58ad10e74842b6f1df9e53cc5b592d6169cc8553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591947 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#656488}
-
Dale Curtis authored
These affect the fuzzer archive size and seem totally unused. For the rest of the .yuv files we should switch to using vp9-lossless to reduce the size by up to 90%. This changes removes 15,367,680 bytes. Change-Id: Ic38a4029803a5544f298713afe5387a1df95c911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591890Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#656487}
-
Fabrice de Gans-Riberi authored
Tried multiple runs locally with no flakes, attempting to re-enable. Bug: 760687 Change-Id: I71a077e52028182dde777c79aea337dbcf1f6d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592627 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#656486}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/14fc5d16ccf4..ed8036a40a27 git log 14fc5d16ccf4..ed8036a40a27 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 moragues@google.com atlas: Mark as important for CQ Created with: gclient setdep -r src/third_party/chromite@ed8036a40a27 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iec2b173d28c34d78b2986134166738a5ee7239b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656485}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of bfd17e5e The downstream dependency removal has been rolled. Original change's description: > Remove SoleIntegration flag > > Sole integration was launched in M65, and we no longer need this flag. > > Bug: 778805 > Change-Id: I6669a87dcb7a6ff4705a30aaa2cf71d6670a822a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578101 > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653718} Bug: 778805 Change-Id: Ifccdbe470d7444c07dc29ba509bb105ca741ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594803Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/09db9d21756e..7e603db01068 git log 09db9d21756e..7e603db01068 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 ethannicholas@google.com SkSL interpreter optimizations 2019-05-03 halcanary@google.com Shaper Tests: make a macro, rename test resources. 2019-05-03 halcanary@google.com SkColors: Fix new color constants 2019-05-03 fmalita@chromium.org [skottie] Relocate "GMs" to resources/ Created with: gclient setdep -r src/third_party/skia@7e603db01068 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I1f9ffeabe3673894489addeab1bec5f658151c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594776Reviewed-by:
-
Andrey Kosyakov authored
This reverts commit 605d15db. Reason for revert: caused a bunch of hidpir tests to fail on Mac Bug: 959360 Original change's description: > [ozone/wayland] Fixed some issues related to scaling on HiDPI screens. > > There are two independent scale factors that were not used properly, which > caused incorrect scaling behaviour on HiDPI screens. > > The first scale factor is property of the window manager (Wayland); it is > integral and expected to be used as scale of buffers that back the window > surface (see wl_surface_set_buffer_scale). This value is provided by > the window manager, and neither user nor browser can affect it directly. > I will refer to this value as 'platform scale'. > > The second scale factor defines how much the browser UI should be scaled. > This value is real (floating point), and it can be set via the aforementioned > --force-device-scale-factor command line flag. The default base scale is > equal to the platform scale, which results in UI that looks more or less > the same size as other applications. This scale is set in display::Display, > and I will refer to it as 'UI scale'. > > So here is what this CL fixes. > > 1. The platform scale had been forwarded to the UI scale with no regard to > the forcing flag, which caused issue 910797 (the flag did not have any > effect). > 2. The platform scale had not been used to scale the backing buffers, which > caused the issue 929871 (blurry contents of windows on HDPI screens). > 3. The coordinate-aware events (mouse and touch) and window sizing logic > were not aware of the buffer scaling. > 4. Both parameters had been named 'device scale factors' which was confusing. > > There are some issues that will be fixed in consequent CLs. The forced > device scale factor is not propagated properly through display::Display. > For fixing that, https://crbug.com/950313 is filed. > > Bug: 910797 > Change-Id: I51a95e7218306295e3ab1f90d4b088b8bee93951 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472617 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Malay Keshav <malaykeshav@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Auto-Submit: Alexander Dunaev <adunaev@igalia.com> > Cr-Commit-Position: refs/heads/master@{#656423} TBR=sadrul@chromium.org,rjkroege@chromium.org,sky@chromium.org,thakis@chromium.org,tedchoc@chromium.org,afakhry@chromium.org,bsep@chromium.org,malaykeshav@chromium.org,dominickn@chromium.org,msisov@igalia.com,adunaev@igalia.com Change-Id: Ia69d743a907aaf8d31ed2bc25f4b9e6280d8f041 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594991Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#656482}
-
Vincent Boisselle authored
This reverts commit 4149e2e9. Reason for revert: It is breaking "Mac10.11 Tests" component_unittests: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8914455830721893472/+/steps/components_unittests_on__none__GPU_on_Mac_on_Mac-10.11/0/stdout Original change's description: > Reland "Added handling of large requests to Autofill API." > > This is a reland of c6677df1 > > Original change's description: > > Added handling of large requests to Autofill API. > > > > Increased the limit of Query GET requests, added a POST Query fallback, and > > added UMA metrics to keep track of URL length and associated events. > > > > This change might be needed when metadata is enabled. > > > > Bug: 948862 > > Change-Id: If0934a685758ab8999ceea6ce22a27499e4f772f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549615 > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#656080} > > Bug: 948862 > Change-Id: I29eee8f16ae6c3775eb31e8e95d4a289c31f1485 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594618 > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Commit-Queue: Vincent Boisselle <vincb@google.com> > Cr-Commit-Position: refs/heads/master@{#656452} TBR=rogerm@chromium.org,ftirelo@chromium.org,vincb@google.com Change-Id: I3a0883512443168336622ad1eac5cd08d23ccaed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594923Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#656481}
-
Jacob Dufault authored
Original change's description: > Revert "cros: Move OobeScreen entries into the respective handlers." > > This reverts commit d88313dc. > > Reason for revert: broke build on chromeos bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8914459008811246352/+/steps/compile/0/stdout > > Original change's description: > > cros: Move OobeScreen entries into the respective handlers. > > > > TBR=yusukes@chromium.org > > TBR=xiyuan@chromium.org > > TBR=antrim@chromium.org > > > > Bug: 928555 > > Change-Id: I058355af1b411eb7bb4b68b9cfc1aa2c61d7cad0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584992 > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#656457} > > TBR=tbarzic@chromium.org,jdufault@chromium.org > > Change-Id: Idaee1caf8d136f42239dcb2664a2441eaed93cd4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 928555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594340 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656464} TBR=tbarzic@chromium.org,caseq@chromium.org,jdufault@chromium.org Change-Id: If935f683f1eb34cdbf110068f7bf135ebf4afdaf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594149Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#656480}
-
John Budorick authored
This reverts commit 8bb448c9. Reason for revert: broke compilation: https://ci.chromium.org/p/chromium/builders/ci/android-dbg/4941 Original change's description: > Reland "base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag" > > This reverts commit 22829656. > > Reason for revert: Reland with fix in blink_x86_avx source_set deps. > > Original change's description: > > Revert "base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag" > > > > This reverts commit 3553b590. > > > > Reason for revert: Causing win-rel compile error. > > > > Original change's description: > > > base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag > > > > > > Currently NOTREACHED() uses LogErrorNotReached() on ChromeOS for release > > > builds, and DCHECK(false) otherwise. However, there are other projects > > > depending on Chromium that would prefer using DCHECK(false) in all cases, > > > and currently there's no easy way to do so. > > > > > > This CL adds an |enable_log_error_not_reached| gn arg to control whether > > > to use LogErrorNotReached() for NOTREACHED() to solve this problem. It > > > is enabled by default only for ChromeOS release builds to keep the > > > current behavior. > > > > > > Bug: 760393 > > > Change-Id: I512227563d8ad4a08a8d7b5d1ec966a8aacbcc08 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586593 > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#655701} > > > > TBR=thakis@chromium.org,xhwang@chromium.org > > > > Change-Id: Iadcee95984e8783f26aeb687dc1cd31f9186e03d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 760393 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592478 > > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#655714} > > TBR=thakis@chromium.org,xhwang@chromium.org > > Change-Id: Idd16cea9c37cdf5bb5f0b7dbac9d5b974c8c4b63 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 760393 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592861 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656476} TBR=thakis@chromium.org,xhwang@chromium.org Change-Id: I28e50016a417d21344682856f08e87338ce7ceb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 760393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594205Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#656479}
-
Charlie Reis authored
This allows it to be accessed during GetFrameHostForNavigation, which is important for making process model decisions based on headers. BUG=922191 Change-Id: I6e8d2ce0f56ef5329f2b8c84d7d09337524dde89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592127Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#656478}
-
Greg Kerr authored
This adds the MTLCompilerService to the sandbox, allowing for more efficient video rendering. Bug: 957217 Change-Id: I67ffb983b5f866e64724abff20a099083d343036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592051 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#656477}
-
Xiaohan Wang authored
This reverts commit 22829656. Reason for revert: Reland with fix in blink_x86_avx source_set deps. Original change's description: > Revert "base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag" > > This reverts commit 3553b590. > > Reason for revert: Causing win-rel compile error. > > Original change's description: > > base: Add ENABLE_LOG_ERROR_NOT_REACHED buildflag > > > > Currently NOTREACHED() uses LogErrorNotReached() on ChromeOS for release > > builds, and DCHECK(false) otherwise. However, there are other projects > > depending on Chromium that would prefer using DCHECK(false) in all cases, > > and currently there's no easy way to do so. > > > > This CL adds an |enable_log_error_not_reached| gn arg to control whether > > to use LogErrorNotReached() for NOTREACHED() to solve this problem. It > > is enabled by default only for ChromeOS release builds to keep the > > current behavior. > > > > Bug: 760393 > > Change-Id: I512227563d8ad4a08a8d7b5d1ec966a8aacbcc08 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586593 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#655701} > > TBR=thakis@chromium.org,xhwang@chromium.org > > Change-Id: Iadcee95984e8783f26aeb687dc1cd31f9186e03d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 760393 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592478 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#655714} TBR=thakis@chromium.org,xhwang@chromium.org Change-Id: Idd16cea9c37cdf5bb5f0b7dbac9d5b974c8c4b63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 760393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592861 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#656476}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ad7d5341ef84..edd261a49708 git log ad7d5341ef84..edd261a49708 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 treehugger-gerrit@google.com Merge "Use write_into_file for heap_profile helper." 2019-05-03 taylori@google.com Merge "perfetto-ui: Add confirm dialog for sharing trace" 2019-05-03 fmayer@google.com Do not overflow for command lines with many arguments. Created with: gclient setdep -r src/third_party/perfetto@edd261a49708 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:131893397 TBR=perfetto-bugs@google.com Change-Id: I96390aff43f4a7469a80a27cbb4e016a6819729a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594817Reviewed-by:
-
Gabriel Charette authored
R=fdoray@chromium.org Bug: 708584 Change-Id: I3d51b3e1b567974805d255cc1300d1b0baf49ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594914 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#656474}
-
Mike Wasserman authored
Also perform some simple cleanup. Bug: 958073 Change-Id: Idf9e0abbd734af3f60928fd4d26dd9e74da26431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591666 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#656473}
-
Dan Sanders authored
MediaPlayerRenderer does not report tracks or natural size in its metadata. Due to the kMinimumVideoSize condition, MediaPlayerRenderer WatchTime has not been reported starting in M69. This CL reinitializes the WatchTimeReporter when MediaPlayerRenderer emits its first natural size change event, and treats playback without such an event as audio-only. Bug: 959037 Change-Id: I4765e0a4d8044f084c313682092abedc205cc9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592617 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#656472}
-
Adithya Srinivasan authored
Makes resources/simple-portal.html use PortalHost.postMessage instead of a BroadcastChannel, and simplifies some tests that use simple-portal. Change-Id: I7cae1a4412111bda65a01ef4557b5396eb799560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592114 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#656471}
-
Xianzhu Wang authored
- For scroll offset translation, set cc::TransformNode::scroll_offset directly instead of setting cc::TransformNode::local then clearing it and setting scroll_offset. - Avoiding TransformPaintPropertyNode::SlowMatrix(). Bug: 954520 Change-Id: I14ceeb938c915e8f8b382568ec96496c317634c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594172Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#656470}
-
Yulun Wu authored
Adding browser tests to check welcome screen -> language settings flow. Adding browser tests to check welcome screen -> accessibility flow. Adding browser tests to verify accessibility, language, and keyboard setup in OOBE works properly. Bug: 953020 Change-Id: I6184ca0fe47bc127dd0bc1b74bb9e2a5a0c8677c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586586 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#656469}
-
Xianzhu Wang authored
This can avoid a lot of hash map lookups during PAC::Update(). Bug: 954520 Change-Id: I0e839322d9e79301f2156fb0572e8f9ffbf5f470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594083 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Donn Denman authored
BUG=958954 Change-Id: Id4fa46cc7d1f7a87dafb7ba4f71ed443933db696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592700Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#656467}
-
Dave Tapuska authored
The PR has been merged into the fetch spec. https://github.com/whatwg/fetch/pull/853 BUG=348877 Change-Id: I5e06ebee3b968e569453df51a441338fb93df72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566154Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#656466}
-
Erik Luo authored
Fixes a crash while highlighting nodes. Some nodes do not have font properties calculated, so this CL adds a check. Bug: 958958 Change-Id: I5b8c56ce378aa2b545c237674ca8ba81d61c2273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592231Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#656465}
-
Andrey Kosyakov authored
This reverts commit d88313dc. Reason for revert: broke build on chromeos bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8914459008811246352/+/steps/compile/0/stdout Original change's description: > cros: Move OobeScreen entries into the respective handlers. > > TBR=yusukes@chromium.org > TBR=xiyuan@chromium.org > TBR=antrim@chromium.org > > Bug: 928555 > Change-Id: I058355af1b411eb7bb4b68b9cfc1aa2c61d7cad0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584992 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656457} TBR=tbarzic@chromium.org,jdufault@chromium.org Change-Id: Idaee1caf8d136f42239dcb2664a2441eaed93cd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594340Reviewed-by:
-
Saman Sami authored
SkiaRenderer already works on Windows when direct composition is disabled (with some minor quirks during resize) so don't automatically fail to create an output surface on Windows. Change-Id: I420d8a288c1e11d1f68ef9f339019545a35f2aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594833Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#656463}
-
Chris Hamilton authored
This moves the WeakPtr to be an internal member of the proxy class, hiding it as an implementation detail. This will allow the future RenderProcessHostProxy and RenderFrameHostProxy to have parallel interfaces. Change-Id: Ic8215257373fdf3b515f54eecbcadb493240f01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591962 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#656462}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4fe8eb31e4a4..dcc9fd7958e7 git log 4fe8eb31e4a4..dcc9fd7958e7 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 chrisforbes@google.com Add input attachment support for VK_FORMAT_A2B10G10R10_UINT_PACK32 2019-05-03 chrisforbes@google.com Add support for VK_FORMAT_A2B10G10R10_UINT_PACK32 render targets 2019-05-03 chrisforbes@google.com Fix blitter clears of 2D views of 3D textures Created with: gclient setdep -r src/third_party/swiftshader@dcc9fd7958e7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141,chromium:b/131896622,chromium:b/nnn TBR=swiftshader-team+autoroll@chromium.org Change-Id: I73a1d0ea26407ee5818364a8bd71c969bbbb1482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594815Reviewed-by:
-
Jeffrey Cohen authored
This is the most reliable way to make sure send tab to self information is not tracked for syncing purposes while sync is paused (DICe signout). Bug: 950642 Change-Id: I4998ea2bcfeb651590c4914249d12e170da13f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593401Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#656460}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/86c72c9486a9..c0640dabfddd git log 86c72c9486a9..c0640dabfddd --date=short --no-merges --format='%ad %ae %s' 2019-05-03 johnkslang@users.noreply.github.com Merge pull request #1758 from jeffbolznv/convertonly 2019-05-03 cepheus@frii.com Fix #1759: Check for specialization constants when literals required. Created with: gclient setdep -r src/third_party/glslang/src@c0640dabfddd The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org,jmadill@chromium.org Change-Id: Ic8cddb5aa707993aa0b8dcec4a89ca66aece4dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594102Reviewed-by:
-
Dan Beam authored
R=kristipark@chromium.org BUG=none Change-Id: Iaf5f7f5d0c5cefd4e6aec0fd5b1b415c95376043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592865 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#656458}
-
