GitLab

The HitTestDataChangeObserver requires a clean state of HitTestData
before any change happens. Previously we didn't check whether child1's
hit test data are ready or not. If its data arrive after the pointer
events change, the HitTestDataChangeObserver will not work properly.

Bug: 968970
Change-Id: Ib00a324ff0960c85c98c7f0800ef300cc4ebddd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837147Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702489}

These methods (originally added in crrev.com/ef8f0ca9) were used
to mark which apps had been re-ordered on the NTP. The preference is
no longer checked anywhere.

Remove both the setter and getter, and add the preference to the list
of obsolete preferences to remove.

Bug: None
Change-Id: Ife36753fb52b5ede503fab02c839a3bf13fed824
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836020Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702488}

The current fakebox focus animation makes the G slightly visible to the
left (in LTR mode) of the omnibox background. This insets the G a bit,
which makes it animate within the omnibox background.

Bug: 988883
Change-Id: I7fcd782feb9ab593b31d0c56aa4481fd9c37f025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832706Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702487}

The code assumes that whenever the signed-in non-sync user clicks on
"protect account" that they are automatically recorded by the
security event recorder. However, the code needs to make sure that
the account is the unconsented primary account. Thus, to prevent
confusion in the metrics, only log the action when we can actually
mark the account at risk.

Bug: 914410
Change-Id: I52fc1c8432ab64da37a6526f2d1dcfe1713c3279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834848Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702486}

When keyword mode has been explicitly entered, and experimental keyword
mode has been enabled, we don't want document suggestions (unless its
search provider matches the keyword provider). Without this restriction,
these suggestions tend to show up when we're only expecting keyword
suggestions, since they rank highly.

Bug: 837395, 883901
Change-Id: If821f0efa8e3ffb6b05555ec6455849dc1d7f059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825779
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702485}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/16438a83d608..880a3f812b03

git log 16438a83d608..880a3f812b03 --date=short --no-merges --format='%ad %ae %s'
2019-10-03 ahassani@chromium.org Revert "chromeos_config: Mark lakitu paladin builders experimental"
2019-10-03 saklein@chromium.org packages service: Add builds method.
2019-10-03 saklein@chromium.org cros_install_debug_syms: fix parallel installation
2019-10-03 lamontjones@chromium.org PRESUBMIT.cfg: verify that we work with signer.

Created with:
  gclient setdep -r src/third_party/chromite@880a3f812b03

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ibb4360808f68eae8fa2c49582232f8cfdb1faa59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837574Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702484}

This function is a large, and hard to follow. I'm hoping to break out a
bunch of functions that are clearer about what they're doing and make
ordering clearer.

In this change I do fix an exception handler to actually catch the
exception it was intending to catch (and you can easily repro the crash
by disabling the targeted Activity while the leaving Chrome alert dialog
is up).

I also make sure that when we fail to show the alert dialog for reasons
other than a BadTokenException, we also propagate this back so we don't
get into a state where we report an async action action is taking place
when it isn't.

Bug: 1006927
Change-Id: Ie09214f64ead85c31fb8e83e187878d984f2afc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835144Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702483}

This CL ignores Device PropertyChanged updates sent before the initial
GetProperties request is received. It fixes an edge case triggering a
DCHECK when the |type| property is not set yet (it is set when the
initial properties are received).

Bug: 1008193
Change-Id: I1a32578ba8a9f5ae7deda53c27c9c2fc8556e0b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836178Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702482}

This CL removed the unused delegate class for ImpressionHistoryTracker.

Bug: 965133
Change-Id: I0463a99f4dc7344c66533b4881fec5fe8fa6393a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832711Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702481}

The resource types weren't localizable. This change fixes this by calling ls`` on each resource type in ResourceType.js. In addition, the tooltips for the record and search buttons. These were already localizable, but the module title descriptor wasn't running through ls().

Bug: 941561
Change-Id: I1d2a035bd2f763597458ab463c4343edc8a9337c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791440Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Commit-Queue: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#702480}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6cf9a9ef99f7..ab5d4d490562


Created with:
  gclient setdep -r src-internal@ab5d4d490562

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: Ie5212cdf6618e6d6e0b0862f48291f91ed72d0f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837276Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702479}

It's unused.

Change-Id: Ic108d486fac11e5d5ee7615c076d78173a4352d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835175Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702478}

A lot of these were left around after code was updated to use the
network service. This CL particularly focuses on
test_url_fetcher_factory.h includes.

This CL also removes "using base::TimeDelta" from
url_request_test_util.h, which also affects a couple files with the
unnecessary includes.

Bug: None
Change-Id: Id3f104bf43fd935c692497dd0e00e669271323d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836512Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702477}

The unpredictable nature of when the favicon fetch occurs was causing
the fetch to fail. This CL prefetches it, so it will be cached.

Bug: 1006637
Change-Id: I2d16fa80b3ffe05c1cc6e21437c9a8a95dbd8bd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835092
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702476}

With the recent port of the streams API to C++ [0], the natives blob is
now unused and will shortly be removed. V8 API related to the natives
blob is being deprecated [1] and will be removed in the next release.

This CL is the minimal change to keep up with these API deprecations.

In follow-up work, all other infrastructure related to the natives blob
should be removed.

[0] https://crrev.com/c/1746118
[1] https://crrev.com/c/1824944

Bug: v8:7624
Change-Id: I26e409660d177035cdb5d92c317fc2e0174be2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834352Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702475}

A bunch of tests were instantiating them but not using them, so also
remove the classes from those tests.

TBR=lambroslambrou@chromium.org
TBR=rogerm@chromium.org
TBR=dvadym@chromium.org
TBR=hendrich@chromium.org

Bug: 1010491
Change-Id: I0528cd61f69e0010eefa45f5c65edf63a09fc6d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834926
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702474}

This patch means removing variable unused.
string16Container looks like used in legacy code.

Bug: None
Change-Id: I17867cd8c48dd13c1fb46c3376d5424f5ccacf3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828665Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#702473}

Starts from Android N, notification by default has the app name, so the
title should not be same as the app name. This CL removes the title as
the content text already has enough context.

Bug: 875906
Change-Id: I24b222377d87dc348a5cd39eed7c9eeba2824f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830174Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702472}

This is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1832929
which suffered from unstable try bots and created incomplete
rebaselines.

TBR=huangs@chromium.org

Change-Id: I3a2a01cec46caa8e0eb8ed4df3228bff89e07dac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836986Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702471}

Use fake module support added to device API: https://crrev.com/c/1811762

Bug: 1000749
Change-Id: I9810e8fea7b1ab1359693b8bc8110965416395bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835218
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702470}

Now that the WebAuthn WebDriver API has landed on the spec [1], update
the implementation to match it closely:

* Add isUserVerified flag to AddVirtualAuthenticator
* hasResidentKey and hasUserVerification are optional and default to
  false.

[1] https://w3c.github.io/webauthn/#sctn-automation-add-virtual-authenticator

Bug: 922572
Change-Id: I884988c15e4a46ab5aad2395c76dca284386dc7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837477Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702469}

https://quiche.googlesource.com/quiche.git/+log/d85976f86ec3..67840e16ec81

$ git log d85976f86..67840e16e --date=short --no-merges --format='%ad %ae %s'
2019-10-01 dschinazi Disable SupportsAntiAmplificationLimit to avoid infinite loop
2019-10-01 dschinazi Prevent fuzzer from sending version negotiation packets
2019-10-01 dschinazi Prevent fuzzer from sending unsupported RETRY packets
2019-10-01 bnc Record header compression ratio.
2019-09-30 bnc Add QPACK logging for each encoded header list to track whether encoding is blocked.
2019-09-30 fkastenholz Add comments explaining why some tests are only for IETF QUIC or Google QUIC.
2019-09-30 wub gfe-relnote: Default-initialize QUIC BBRv2's inflight_hi_headroom from flags. No behavior change.
2019-09-29 wub Internal QUICHE change
2019-09-27 dschinazi Allow parsing PROX packets with length prefix
2019-09-27 nharper Use 16-byte auth tags when initial obfuscators are used
2019-09-27 zhongyi gfe-relnote: (n/a) comments only
2019-09-27 renjietang Add debug visitor for SETTINGS sent.
2019-09-27 wub gfe-relnote: For QUIC BBRv2: 1) Don't grow inflight_hi unless it's fully used, and 2) Cap inflight_lo in PROBE_CRUISE. Protected by --gfe2_reloadable_flag_quic_bbr2_fix_inflight_bounds.
2019-09-27 bnc Optimize QpackBlockingManager::blocking_allowed_on_stream().
2019-09-27 bnc Fix two blocking_allowed_on_stream() calls in QpackBlockingManagerTest.BlockingAllowedOnStream.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I614c1c5d4b615fc7a6c8cd7411cacdeb0eb209c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836595
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702468}

The mixer service receiver allows other processes to communicate directly
with the mixer. See https://docs.google.com/document/d/1t4ef1yVKcDRwEGrVxUGDmjtSEjgtf5bT9g92dXrxFWI

Bug: internal b/127963522
Test: on device

Merge-With: eureka-internal/317379
Change-Id: If9f4a39610f0a231041c431fc4785ec0a86c98ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829463
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702467}

Bug: 1005370
Change-Id: I84369f3e56b5ed94a9064ad858f2944bc9885d81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829240Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702466}

We were already preventing breaks inside line boxes, but we also need to
do the same for certain types of block nodes, such as replaced content.

Add a unit test for break-before:avoid before monolithic block level
content, since the existing web_tests corpus has no break-between
avoidance tests at all.

Bug: 829028
Change-Id: I2240f96714e6dd760fac4f86089a0c8e6bf346ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836492
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702465}

It is possible that more than one states indicate ready state,
e.g. |VISIBLE|.

Bug: None
Test: locally run multiple tast tests in sequence
Change-Id: I2ad3a89e7bc0839c60a78f6b3c4360ff05b27a35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836022
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702464}

Restores a missing rectangular highlight to the download item. The
transparent button is often hosting the InkDrop but previously had no
path defined.

Bug: chromium:1007546
Change-Id: Ib0dffc72be2e0b3db33569538dde38391c62a8b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837978
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702463}

(Almost) all aspects of webauthn are owned by fido/OWNERS and Kim is OOO.

Bug: 1010934
Change-Id: I1e13d357bcc5f5b4168126d60aa92a4c9a10faa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837873
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#702462}

This ensures a profile is obtained even when outside a user window,
which resolves an issue that occurred when printing from ARC apps using
the ArcPrintService.

Bug: 1010228
Test: Print from an ARC app using an ArcPrintService printer
Change-Id: I4fa5759519aef11773045ff79612342583cf66e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836984
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702461}

On switching to a different desk, we attempt restoring snapped
windows into splitview. But while being on another desk, orientation
may change in such a way that makes the snapped windows unsnappable
in splitview. Snapping those back when we attempt restoring splitview
would hit a DCHECK.

This CL fixes this issue.

BUG=1010115
TEST=Added new test that crashes without the fix.

Change-Id: I41c4b47a78fc2fbb0ebd52cd139bf56881569e5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834901
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702460}

BUG=914910

Change-Id: I46198de26b7963d31f216a2355bba0d8a4e6999a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837751
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702459}

Reland of https://crrev.com/c/1825620

Change-Id: Iae413f777b3fdb094cf85d49e6110321628125e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836985Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702458}

TBR=yoichio@chromium.org

Bug: chromium:1010670
Change-Id: I6aa22e2e81c024e17dddbd3644033918e06220ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836989
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702457}

CertVerifierWithTrustAnchorsTest: call SupportsAdditionalTrustAnchors on the correct CertVerifyProc implementation.

In the current implementation this isn't critical, since
CertVerifyProcChromeOS just defers the SupportsAdditionalTrustAnchors to
the base class CertVerifyProcNSS which is what
CertVerifyProc::CreateDefault would create.

Also clean up some uses of "new".

Change-Id: I3f2ab343e032b415d676cc5ced707e49209add4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836633Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702456}

The test is failing for Linux ChromiumOS MSAN, perhaps due to code path
where |history_db_task_id_| is used without initialization.

TBR=tommili@chromium.org

Bug: 1010944
Change-Id: Ic5f4fb55155b44d58c415ab58c5c339fcfe7a77a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837974Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702455}

Use more C++11 and modern commenting style. Replace a NOTREACHED() with
a DCHECK.

Change-Id: Iebe7dffe39f5c9391cfce6e151870448fb29b68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837119Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702454}

https://dawn.googlesource.com/dawn.git/+log/0da52f2d92c3..3fd022ef6041

git log 0da52f2d92c3..3fd022ef6041 --date=short --no-merges --format='%ad %ae %s'
2019-10-03 enga@chromium.org Validate injected errors are not NoError

Created with:
  gclient setdep -r src/third_party/dawn@3fd022ef6041

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: chromium:1010703,chromium:1004368
Change-Id: Ibeea6c666a7b82f17fa1cd64f98bd9e6f8db716e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837189Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702453}

This CL changes MediaDialogView to use a layer and adds rounded corners
to that layer. This prevents an issue where the ScrollView was creating
a child layer that ignored the rounded corners of the dialog frame.

Bug: 992869
Change-Id: Ie539038400ef4a8bc170a5c8a4d446f2b4ca360c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832663Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702452}

Solution to lazily instantiate the InstallEngine and avoid calling
the CommandLine will fix the problem for the VrModule's early call to
isInstalled() [see ChromeApplication.java (startActivity)].

Related to:
https://chromium-review.googlesource.com/c/chromium/src/+/1813520

Bug: 1010887, 1005802
Change-Id: I9d217abb0f9e09f97054fe0d3c6afee59aac198c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837657
Commit-Queue: Fred Mello <fredmello@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702451}

Adds expires_after attribute for 122 histograms that do not already have one.
The date will get pushed out automatically if significant use is detected.

Change-Id: I225cf94567c2b9824f9f175c0757a92e0a5a605b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837353Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@google.com>
Cr-Commit-Position: refs/heads/master@{#702450}