GitLab

platform.

Review URL: http://codereview.chromium.org/28237


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10556 0039d316-1c4b-4281-b951-d872f2087c98

Reviewed in issue 27186.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10555 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10554 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/27186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10553 0039d316-1c4b-4281-b951-d872f2087c98

LGTMed by Elliot Glaysher.
See http://codereview.chromium.org/27079



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10552 0039d316-1c4b-4281-b951-d872f2087c98

don't post a dummy task to ProcessPendingQueue (with a
writer).

BUG=4731
TEST=unittest.

Review URL: http://codereview.chromium.org/27149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10551 0039d316-1c4b-4281-b951-d872f2087c98

renderer trees look different because of our forked changes to
RenderTextControlMultiLine, specifcally the call to setOverflowX,
which results in creating the different layers.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/28229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10550 0039d316-1c4b-4281-b951-d872f2087c98

Rebaseline an SVG layout test. The border lines of the top box are drawn in a slightly different shade of red compared to the baseline, and as always, the vertical edge lines of the entire image is in a very slight different shade.
Review URL: http://codereview.chromium.org/27239

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10549 0039d316-1c4b-4281-b951-d872f2087c98

Fix toolbar keyboard focus (shift-alt-t), which was broken by me, and toolbar button context menus on VK_APPS, which was broken by Jonas.

The overall focus issue was caused by my change that made View::RequestFocus() sanity-check that the View was focusable.  The toolbar uses a crazy hack where it purposefully wants to get focus even though it's not focusable.  :P

The context menu issue was caused by Jonas changing the name of a virtual function, presumably not realizing it was a virtual, not just a simple accessor.  I changed the name back and marked this function (and several others) as virtual.  In order to avoid blowing up the source in toolbar_view.cc, I reverted users of the accessor to just using the member variable name.

Also reordered a couple functions to match the order they were originally declared in View.h.
Review URL: http://codereview.chromium.org/27175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10548 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/28228

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10547 0039d316-1c4b-4281-b951-d872f2087c98

* Clarify some comments.
* Simplify some redundant boolean logic.
* Add a helper function for something a lot of callers were checking manually.
* Fix lint.
Review URL: http://codereview.chromium.org/27247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10546 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/28206


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10545 0039d316-1c4b-4281-b951-d872f2087c98

The controlling code in filter.cc doesn't significantly distinguish
FILTER_OK and FILTER_NEEDS_MORE_DATA, but we *should* transition
to a semantic where FILTER_OK becomes instead "FILTER_NEEDS_OUTPUT_SPACE"
and then we'd need to do this uniformly for all filter code.
We *could* then improve the driving filter code (for example, not have
to sniff output buffer usage to deduce that the filter wanted to be 
called again to emit more data).

r=huanr
Review URL: http://codereview.chromium.org/28193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10544 0039d316-1c4b-4281-b951-d872f2087c98

Now that the buildbots have cycled, it looks like two tests
that I recently rebaselined are now passing on Linux. Update
the testlist to reflect that.

Review URL: http://codereview.chromium.org/28235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10543 0039d316-1c4b-4281-b951-d872f2087c98

TBR=aa
Review URL: http://codereview.chromium.org/27248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10542 0039d316-1c4b-4281-b951-d872f2087c98

TBR to get the tree green.

Review URL: http://codereview.chromium.org/28236


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10541 0039d316-1c4b-4281-b951-d872f2087c98

TBR=evan

Review URL: http://codereview.chromium.org/28231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10540 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tony

Review URL: http://codereview.chromium.org/28234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10539 0039d316-1c4b-4281-b951-d872f2087c98

TBR=avi

Review URL: http://codereview.chromium.org/28233

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10537 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/28232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10536 0039d316-1c4b-4281-b951-d872f2087c98

Fix a DCHECK in certain cases when coming out of fullscreen mode.  The frame gets to layout before the browser view, but it needs to know what the browser view's tabstrip layout is going to look like, or it will lay out wrong.
Review URL: http://codereview.chromium.org/27231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10535 0039d316-1c4b-4281-b951-d872f2087c98

port third-party code that reports memory allocation
failures.

R=darin,eroman
Review URL: http://codereview.chromium.org/28216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10534 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/27226


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10533 0039d316-1c4b-4281-b951-d872f2087c98

R=dglazkov

Review URL: http://codereview.chromium.org/27222

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10532 0039d316-1c4b-4281-b951-d872f2087c98

Defer new tests.

Fix wdiff to have deletes be red and new lines be green (it was reversed).

Review URL: http://codereview.chromium.org/28213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10531 0039d316-1c4b-4281-b951-d872f2087c98

it wasn't that the bookmark bar was all black, rather that BrowserView
thought the bookmark bar was parented when in fact it wasn't. The
black was the result of BrowserView reserving the space for the
bookmark bar and not painting anything in it's space.

BUG=7922
TEST=see bug

Review URL: http://codereview.chromium.org/28191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10530 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/27236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10529 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/27242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10528 0039d316-1c4b-4281-b951-d872f2087c98

This corresponds with <http://codereview.chromium.org/28049>.

BUG=2764
Review URL: http://codereview.chromium.org/28220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10526 0039d316-1c4b-4281-b951-d872f2087c98

included in data pack files.

Review URL: http://codereview.chromium.org/28222


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10525 0039d316-1c4b-4281-b951-d872f2087c98

While I'm at it, remove references to .dll in comments in the file.

Review URL: http://codereview.chromium.org/27223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10524 0039d316-1c4b-4281-b951-d872f2087c98

VNC servers don't support Xrender. For this use case, we implement a
slow fallback which byte-fiddles the Skia bitmaps as needed to support
32 and 24 bit visuals.

Review URL: http://codereview.chromium.org/27227


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10523 0039d316-1c4b-4281-b951-d872f2087c98

The tests below have had their baseline changed
upstream and we need to follow suit (see diffs
in review folder):

-LayoutTests/fast/events/offsetX-offsetY.html
-LayoutTests/editing/selection/select-from-textfield-outwards.html
-LayoutTests/editing/selection/select-missing-image.html

NOTE: For the last test above, we now match the
mac baseline so I just removed our text baseline.

New tests that just needed to be baselined (only
differ in font metrics):

-LayoutTests/fast/lists/list-marker-with-line-height.html
-LayoutTests/fast/overflow/overflow-float-stacking.html
-LayoutTests/fast/overflow/overflow-stacking.html
-LayoutTests/fast/replaced/embed-display-none.html
-LayoutTests/fast/replaced/applet-display-none.html
-LayoutTests/fast/replaced/object-display-none.html

Review URL: http://codereview.chromium.org/28211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10522 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 25b05025dae174c94e6de74fa697a3338175f957.

Review URL: http://codereview.chromium.org/27243


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10521 0039d316-1c4b-4281-b951-d872f2087c98

made once the DelayTimer has been destroyed.

Review URL: http://codereview.chromium.org/27234


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10520 0039d316-1c4b-4281-b951-d872f2087c98

bug=8139

Review URL: http://codereview.chromium.org/28225


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10519 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/27232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10518 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/28224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10517 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/28218


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10515 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/28217


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10512 0039d316-1c4b-4281-b951-d872f2087c98