- 28 Sep, 2018 40 commits
-
-
Jeremy Klein authored
This is a reland of 3e67df64 Fixed the ASAN test by actually just removing some unnecessary code. Original change's description: > Install Messages PWA when host is set or verified. > > This change moves the logic for installing the Android Messages PWA into > a helper class which is a HostStatusProvider::Observer. This allows it > to install the PWA when a host is set and also when signing into a new > Chromebook if the account already has a valid host. > > Bug: 887775 > Change-Id: I1a1433b03010d391f9b8256754fc578dfb8a140b > Reviewed-on: https://chromium-review.googlesource.com/1248130 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594943} Bug: 887775 Change-Id: I1941c20d7c31f8424f3d080db8e3580be01cd41f Reviewed-on: https://chromium-review.googlesource.com/1252626Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#595250}
-
Matt Falkenhagen authored
Reland of r592363, which was reverted due to timeouts. The timeout issue should be fixed by r594723, which changed the mechanism of sending the "last url" message from the navigated frame. Other revisions from the original patch: - Removed the unused expected_tags parameter from the default variant test function. - Removed the dummy message resolver for "last url" from client_variant_test, which is no longer needed after the change mentioned above. - Fixed a bug in redirect-worker.js's getClients(), where we returned instead of continued to the next iteration. Original commit description: > This adds a ?client variant to navigation-redirect.https.html, which > does a lot of redirect tests. This tests the following: > - resultingClientId is the id of the client, if one was created via > that request. > - get(resultingClientId) for requests that did not create a client > resolves with undefined. > - resultingClientId is reset on cross-origin redirects. > - Client.url is the creation URL. > > Bug: 778497 > Change-Id: I08387e96a97df4656d800637862b67b7c8466e14 > Reviewed-on: https://chromium-review.googlesource.com/1206054 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592363} Bug: 778497 Change-Id: I770f98cef7618c89c1b54245bc89a9c53a19bd5c Reviewed-on: https://chromium-review.googlesource.com/1250306Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#595249}
-
Joey Arhar authored
The request queued time was not converted from seconds to milliseconds before being exoprted to HAR, which is in milliseconds. Added test coverage by adding more timing information to a HAR export test. Bug: 841613 Change-Id: Iea119b16f67a29b2984a7bcca6cf53bd7313723b Reviewed-on: https://chromium-review.googlesource.com/1252881Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#595248}
-
Tarun Bansal authored
Add an API that exposes typical network quality for a given effective connection type. This API would be used to set RTT and throughput values when effective connection type value is overridden due to holdback experiment, or otherwise. Bug: 880545 Change-Id: If83593e31e44e2e0e9ab8357a673300e032cea9e Reviewed-on: https://chromium-review.googlesource.com/1249962Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#595247}
-
Scott Chen authored
Bug: 874122 Change-Id: I99b1feb5cdbd6e7aa5b3ad640567cc54b93c66b3 Reviewed-on: https://chromium-review.googlesource.com/1232879Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595246}
-
David Tseng authored
Bug: 876571 Change-Id: I18523d2928c203026761b8eefdc2bcd2f939f4f1 Reviewed-on: https://chromium-review.googlesource.com/1251468Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595245}
-
Scott Violet authored
Otherwise we hit DCHECKs, and likely leave the remote side in a bad state. BUG=890370 TEST=covered by tests Change-Id: Ibb903bf6fe6c67081e18459a142c7c67da0b2ac5 Reviewed-on: https://chromium-review.googlesource.com/1252639Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595244}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/82b404766db2..42db84264880 git log 82b404766db2..42db84264880 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 bhthompson@google.com Enable Grunt PFQs with HWTests Created with: gclient setdep -r src/third_party/chromite@42db84264880 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ica9776846ceb8bd80ee6d4e49bf6ad7edcafab72 Reviewed-on: https://chromium-review.googlesource.com/1252372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595243}
-
BUG=762641 TBR=minch@google.com Change-Id: I97cd0ec969f3cdd38a50f52e924b849e24a491a1 Reviewed-on: https://chromium-review.googlesource.com/1252842Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595242}
-
Ryan Hansberry authored
Though UnlockManager listens to Bluetooth power events, it previously did not communicate those events to lower objects, such as RemoteDeviceLifeCycle. This caused crbug.com/889641: RemoteDeviceLifeCycle attempted to begin a connection to the host device without first checking if Bluetooth was present or powered, and because Bluetooth is briefly not present on wake after the laptop lid is closed, RemoteDeviceLifeCycle would always fail. An alternate approach to this issue might have been to place Bluetooth listening logic inside RemoteDeviceLifeCycle, but UnlockManager is already a complex state machine that handles several events including Bluetooth power -- it's cleaner and easier to follow if state changes remain in this one class. Bug: 889641 Change-Id: I2c80da4c4e965b6fc11a0c70230705824dc34dbe Reviewed-on: https://chromium-review.googlesource.com/1252369Reviewed-by:
-
David Tseng authored
This aligns us with Jaws behavior. The underlying data for table row/column count, and cell row/column index are noteably missing for these layout table nodes, so ChromeVox cannot provide very good feedback for them. Sometimes, there are no cells at all under these layout tables. In terms of the cell navigation, it is typically useful to allow for navigation of these structures using cell navigation commands, but that may need to be handled elsewhere separately from the current set of table commands since not all of the same data is available. Change-Id: Ie04e28eee2c416668a516e0accf49bd9517556fb Reviewed-on: https://chromium-review.googlesource.com/1251456Reviewed-by:
-
David Tseng authored
- reuse ws::mojom::EventInjector - follow up change will add a binding to chrome.accessibilityPrivate to send a synthesized mouse event (required for ChromeVox + VK support) - removed last bits of ash deps from the file Bug: 594887 Test: chromevox_tests (which makes extensive use of the chrome.accessibilityPrivate apis to send synthetic key events). Change-Id: I1d4ce0703af526a747dd3b9db4422acb6b302307 Reviewed-on: https://chromium-review.googlesource.com/1250126Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595239}
-
Charlie Harrison authored
See intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WsnBm53M4Pc Even though speech API does not work properly on content shell, this change can be tested in layout tests because it fails immediately without calling into any synthesis code. To force autoplay, tests need to use the new unified autoplay flag: --autoplay-policy=document-user-activation-required Bug: 812767 Change-Id: I41bee6e37ab46ff2013d096c714b5124bd0ccc2c Reviewed-on: https://chromium-review.googlesource.com/1225650 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#595238}
-
Peter Kasting authored
Per UX leads, this is dead. Bug: 752226 Change-Id: Ie5a353ca973d75b06436a9fef3ac2534bd2b6a3d Reviewed-on: https://chromium-review.googlesource.com/1241813Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#595237}
-
Adam Langley authored
Although these are related, it's a little confusing to users since we otherwise use the origin as the “identity” of a web site. Change-Id: Ic2e5fc09c67094d0a6bbd14910714b56b19e7e97 Reviewed-on: https://chromium-review.googlesource.com/1246300Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#595236}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6956b3094ad4..72f78323a89f Created with: gclient setdep -r src-internal@72f78323a89f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3f7e819d93e90078138ed95b8a272e2a003e9219 Reviewed-on: https://chromium-review.googlesource.com/1252371Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595235}
-
Joanmarie Diggs authored
Step 2E of the Accessible Name and Description Computation spec states: "If the embedded control has role combobox or listbox, return the text alternative of the chosen option." This part of the accessible name calculation had not been implemented in AXNodeObject::TextAlternative. Bug: 890066 Change-Id: I3829d8229b816fe69e939307aa6c44563a757eef Reviewed-on: https://chromium-review.googlesource.com/1249887Reviewed-by:
-
Tommy C. Li authored
Split the Steady State Elisions flags into two: - One for hiding scheme. - One for hiding trivial subdomains. Because of architectural reasons, this also necessitated moving these flags to the toolbar component, which is probably where it should have lived in the first place. This CL also makes ToolbarModelImpl the "flag-checker" instead of OmniboxEditModel. This makes more sense to me in general. This also means some unit test logic is moving to test the logic in ToolbarModelImpl rather than OmniboxEditModel. Bug: NONE Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I17531dc5bc88a5c739c1d2219777805e3374e42b Reviewed-on: https://chromium-review.googlesource.com/1238998 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#595233}
-
Brandon Wylie authored
Bug: 872342 Change-Id: Iaa017e045effcac0f593f79b304f1413350c494c Reviewed-on: https://chromium-review.googlesource.com/1243829Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#595232}
-
siyua authored
1) Associate card network and card number to checkbox. 2) Add accessible text for Google Pay logo and tooltip text for all credit card images. 3) Make migration bubble sticky when first shown. !!!: The problem that checkbox reads "unchecked" even if it is actually checked has not been fixed yet. Has filed bug 889602. Would like to submit this CL first to unblock the browser-tests CL. Bug: 852904 Change-Id: I48ea4a92e7d95327be432bb10126e8338496be97 Reviewed-on: https://chromium-review.googlesource.com/1244888Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#595231}
-
John Abd-El-Malek authored
Bug: 890104 Change-Id: Id2f726cf4a2052080c1f984cb5844f1d084bf1b0 Reviewed-on: https://chromium-review.googlesource.com/1249732 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595230}
-
Mike Klein authored
We're doing some clean up and would like to retract SkColorSpaceXform from Skia's public API. It's obsolete now that you can either, 1) just use Skia's drawing pipeline or readPixels()/writePixels() for most of its functionality; or 2) use the much more flexible skcms interface for fancy features. In this case, SkPixmap::readPixels() works just fine. Change-Id: I7195eecae4ca71d408a9641c4be8d247d877ac50 Reviewed-on: https://chromium-review.googlesource.com/1203996Reviewed-by:ccameron <ccameron@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#595229}
-
Esmael El-Moslimany authored
- Remove paper-slider dependency. - Differentiate active/inactive markers based on knob position. - Add label support from display-size-slider. - Replace display-size-slider with settings-slider. Bug: 881290, 858882 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib0863f37f5484f146d7cd944af4fe9a13a35ea0a Reviewed-on: https://chromium-review.googlesource.com/1211805 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595228}
-
Raymond Toy authored
Implement a few optimizations for AudioParams o Preallocate summing_bus instead of creating a new summing bus each time the final values need to be computed. And only use the bus if needed. o Use vectorized Vclip to clamp the values to the nominal range. Roughly the CPU usage (according to top) goes from 120% to 90% on my machine. The bug contains pprof dot files that show all of the profiling results. Bug: 878301 Change-Id: I99670a8397f5344e9a3ad88fe4d748f7e0486895 Reviewed-on: https://chromium-review.googlesource.com/1249583Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595227}
-
Charlie Harrison authored
Bug: 820612 Change-Id: If4d415afbbdeef41ad2a0a2d5df27f3a9ebde9e7 Reviewed-on: https://chromium-review.googlesource.com/1227251 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595226}
-
Christian Biesinger authored
To avoid the previous regression (see analysis in bug), we force layout in the case where we otherwise would get an outdated result. This relands https://chromium-review.googlesource.com/c/chromium/src/+/1246730 with an additional fix for the Chrome UI CSS. I also split out the test change into its own patch. IF THIS BREAKS ANY FURTHER CHROME UI: Please don't revert this patch; instead, add min-height: 0 to any inner nested flexboxes that may be affected by this patch. This is an important change for web interop with the other browsers. Bug: 596743,890100 Change-Id: Ice629c2a7823ef07d075fa23b99022b4012c6200 Reviewed-on: https://chromium-review.googlesource.com/1252682Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#595225}
-
Christian Biesinger authored
This relands just the testcase portion of https://chromium-review.googlesource.com/c/chromium/src/+/1246730, so that it won't be reverted in case the patch reland will be reverted again. R=eae@chromium.org, mstensho@chromium.org Bug: 596743 Change-Id: I7c0d76794d65278c96de7eb650a717e3802bbf97 Reviewed-on: https://chromium-review.googlesource.com/1252681Reviewed-by:
-
Roger McFarlane authored
This CL adds a pref which is used to track the form signatures (modulo ~1000) for which uploads have been triggered and for which events. The pref is reset every 28 days. PasswordManager use a different throttling mechanism; they opt out of this one by passing nullptr for the pref service when they upload. Bug: 860285,801698 Change-Id: I132408ae9fa48d2af1272913f16f21787dc30839 Reviewed-on: https://chromium-review.googlesource.com/1236413Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#595223}
-
Jonathan Metzman authored
OWNERS file generation was broken for a long time until today. The fix caused the generation script to invoke the "git" command which breaks on Windows because "git" is not a binary on the path. This fix makes the script find the path of the git binary on Windows. Bug: 890451 Change-Id: Ib3df557170ac53ad259663dfec6bc5481b76f6d0 Reviewed-on: https://chromium-review.googlesource.com/1252464Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595222}
-
Quinten Yearsley authored
This would enable Pylint with a few warning types in chromium/src. Change-Id: Ie37d44da7b8256a52f0b9f05a0c517b599b11da3 Reviewed-on: https://chromium-review.googlesource.com/1252201Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#595221}
-
Min Qin authored
Cancelled download cannot be interacted on Android. Thus we can safely remove them from history. BUG=889213 Change-Id: Ia6c85a230a60c26d5a35f0f07cd68ec32d28044f Reviewed-on: https://chromium-review.googlesource.com/1244736 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595220}
-
Jordy Greenblatt authored
The bug was caused by the change event on the password text field triggering the event 'user-submitted-password' which causes a forward navigate attempt. This fails if the password is wrong (this causes the 'incorrect password' issue in the bug) and succeeds if the password is correct (this causes the spurious flow continuation issue). Bug: 884965 Change-Id: I4ae9f9f9fd01901dacd9e69a216bdd3123eb9344 Reviewed-on: https://chromium-review.googlesource.com/1252503 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
-
Chris Palmer authored
When we have satisfied the allocation with a new OS page, we can skip the `memset`. Bug: 864462 Change-Id: Ib13539a83a931dbad3e588001aa248ff994d3900 Reviewed-on: https://chromium-review.googlesource.com/1213957 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#595218}
-
Gabriel Charette authored
When a kMsgHaveWork task is processed by the pump, allowing it a timeslice in which to process tasks, we pull the next MSG from the thread's queue and dispatch that, to minimize impact of kMsgHaveWork on MSG scheduling. WM_QUIT must be observed directly by GetMessage in order for a nested loop to exit, though, so we must re-post it to the thread queue, for GetMessage to report. Re-posting was removed by crrev.com/553653, which caused WM_QUIT to be ignored by MessagePumpForUI, missing that we must still re-post the message, in case we're inside a nested loop, to allow it to quit. To address this: - When pulling a MSG to replace kMsgHaveWork, we unconditionally re-post WM_QUIT messages, in case ::GetMessage() needs to see them. - Only actually handle WM_QUIT when it is observed directly by DoRunLoop(), i.e. if WM_QUIT was the kMsgHaveWork replacement, don't process it until we see it re-posted. - Continue ignoring WM_QUIT when handled iff |!enable_wm_quit_| to properties of crrev.com/573620. - Add comments and tests to properly explain and verify the special-case handling of WM_QUIT. - Document a another edge case bug uncovered by this investigation. Bug: 888559, 890016 Change-Id: I548165b6103b1c7454f90335ba6dfb4f8cf149d9 Reviewed-on: https://chromium-review.googlesource.com/1240158 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#595217}
-
Chris Blume authored
third_party/vulkan-validation-layers/src used to be populated by a DEPS file in ANGLE. Because of this, it was added to the .gitignore to prevent excess code downloading. However, ANGLE later changed to pull its DEPS into third_party/angle/third_party. That left third_party/vulkan-validation-layers/src inside .gitignore without actually being pulled in by DEPS. This patch removes that directory from the .gitignore file so we can later update the directory. This is needed to pull in a fix for a bug. BUG=843346 Change-Id: I0563deadeef759af11f85dbdb0781238e82b21eb Reviewed-on: https://chromium-review.googlesource.com/1252622Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#595216}
-
Andrew Grieve authored
Bug: 890360 Change-Id: I9ec730922415edf59e1878f89f9a046e5d1cc811 Reviewed-on: https://chromium-review.googlesource.com/1252006 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595215}
-
chcunningham authored
The old SigninManager::IsSignoutProhibited() had a few smells 1. callers of SM::SignOut() were expected to always call SignOut() even when prohibited. This allowed the *chrome* client to do special cleanup. 2. ProhibitSignout() was really meant to narrowly prohibit user-triggered sign-out for scenarios like cloud-managed accounts. But the prohibition was applied broadly for all SignOut() calls, leading to weird states when sign-out was triggered for internal reasons (e.g. cloud policy changes). These issues came up in planning an analogous API for the new IdentityManager. This CL implements the proposed fixes https://docs.google.com/document/d/14esaufZT0fr258zL5I69y7YBBc24XsxtDU0B7wpWxBo/edit#bookmark=id.t69fnqpy377k Namely: - Prohibiting sign-out is now up to the SigninClient. SignOut() signals the source of the sign-out (user-driven vs internal reasons) and the client runs a callback indicating whether the sign-out may continue. - signin_util::SetUserSignoutAllowedForProfile() chrome/ code allow/block user-driven sign-outs. - Other implementers of SigninClient never block sign-out and are unchanged. NOTE: For now, signin_util::SetUserSignoutAllowedForProfile() actually prohibits most non-user-driven signouts to avoid changing sign-out behavior in this large plumbing CL. This will change in a follow up CL where non-user-driven sign-outs are always permitted. https://chromium-review.googlesource.com/c/chromium/src/+/1175797/ Bug: 866518 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4758706d796f953cbb68ff1b4a0c8d2985d12fb3 Reviewed-on: https://chromium-review.googlesource.com/1162173 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595214}
-
Raymond Toy authored
The WebAudio spec moved the resume method from the BaseAudioContext to its subclasses AudioContext and OfflineAudioContext. Update the idl and implementation to reflect this change. This change causes the following tests to fail: AudioContext/audiocontext-properties.html BaseAudioContext/baseaudiocontext-properties.html OfflineAudioContext/offlineaudiocontext-properties.html We remove these tests because they basically duplicate the test in external/wpt/webaudio/idlharness.https.window.html. Bug: 889663, 888870 Test: already covered by existing tests Change-Id: Ic7ed8a5f950e8d069ac7c916d716526f96bf3c18 Reviewed-on: https://chromium-review.googlesource.com/1247703Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595213}
-
Francois Doray authored
mojo::MakeRequest never fails to create to initialize the InterfacePtr and it is ok to start using the InterfacePtr before initialization is complete. https://cs.chromium.org/chromium/src/mojo/public/cpp/bindings/interface_request.h?l=96-99&rcl=2985a2476a50ee04dbd78b6a0c3228c5f96a2559 Change-Id: Ie5ec84cdcf8896cf646a58aca4ceab8db82eb428 Reviewed-on: https://chromium-review.googlesource.com/1249811Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#595212}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/928526013073..6956b3094ad4 Created with: gclient setdep -r src-internal@6956b3094ad4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie15ea4976a4c890e70b01fcafae4985763fe7843 Reviewed-on: https://chromium-review.googlesource.com/1252344Reviewed-by:
-
