- 02 Jul, 2018 40 commits
-
-
Sky Malice authored
RunCallbackAndroid was very commonly bound into a callback itself, and due to being overloaded, it was difficult for base::Bind to figure work correctly. This change changes each version to have a unique name and updates all call sites. If there was a useless method previously disambiguating this change removes it. Additionally any lint violations were fixed. TBR=nyquist, carlosk, treib, tedchoc, fgorski, boliu, maxmorin Bug: 857155 Change-Id: Ia09c936983b95f466c831bade04821ab29ebb14a Reviewed-on: https://chromium-review.googlesource.com/1117619 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#571952}
-
Markus Heintz authored
Bug: 850161 Change-Id: Id7a976c6a3a4430fb263a9f6de317cf1df7d3b8d Reviewed-on: https://chromium-review.googlesource.com/1120501 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Chris Lu authored
Instead directly link button action method to method in tableview in cellForRowAtIndexPath Change-Id: Ic571e8e49190e55bcb86277f2a4846f7b7088dc3 Reviewed-on: https://chromium-review.googlesource.com/1120844 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#571950}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/09646f2d0497..e353d72449a9 git log 09646f2d0497..e353d72449a9 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 tsepez@chromium.org Use UnownedPtr<> in cfwl_event.h and cfwl_message.h Created with: gclient setdep -r src/third_party/pdfium@e353d72449a9 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie8071d0889ebe8744462ee47d28da66f670a8298 Reviewed-on: https://chromium-review.googlesource.com/1122777Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571949}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Ic1b7c5c411a37a93371ea623aa3f696b2c365e76 Reviewed-on: https://chromium-review.googlesource.com/1112254 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#571948}
-
Ahmed Fakhry authored
- Avoid copying mega bytes of feedback data when sending reports. - Explicitly use OnceCallback and RepeatingCallback when appropriate. BUG=748742 TEST=manual + unittests. Change-Id: I6fb76e50f41f01a6df57e401cbfe1a1033e4db82 Reviewed-on: https://chromium-review.googlesource.com/1121077Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#571947}
-
Douglas Creager authored
When processing a report, we can't assume that the report's origin matches the origin that the corresponding policy belongs to. If the policy uses include_subdomains, then it might be used for reports for any subdomain of the policy's origin. We had a couple of places where we did assume they were the same, and used a DCHECK to verify this. That caused segfaults whenever we tried to process a subdomain report. Bug: 854248 Change-Id: I251d82664c7deee2293144ceed199e084795152c Reviewed-on: https://chromium-review.googlesource.com/1106304Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#571946}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5c71e74331bd..9f2e62402443 git log 5c71e74331bd..9f2e62402443 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 henrik.lundin@webrtc.org Break out NetEqEventLogInput to separate source files 2018-07-02 aleloi@webrtc.org Flags and settings for AGC2 in AgcManagerDirect. Created with: gclient setdep -r src/third_party/webrtc@9f2e62402443 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I21452705d07dd365d790775b31bb98fa6c5d4b71 Reviewed-on: https://chromium-review.googlesource.com/1122896Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571945}
-
Kyle Horimoto authored
Previously, it resided in: //chromeos/services/secure_channel/public/cpp/shared. It was placed in the shared directory because it was planned to be shared with client code, but this ended up not being true. The files are now in: //chromeos/services/secure_channel. Bug: 824568 Change-Id: I380d7f796e42fa775ba69dabe0373f18321b1f84 Reviewed-on: https://chromium-review.googlesource.com/1117864Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#571944}
-
tzik authored
This CL replaces MockTimer with MockOneShotTimer or MockRepeatingTimer as a preparation of OnceCallback support of base::Timer. Bug: 850247 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1e9ed0d8edee50f2ad194ee92bcc248219f9273a Reviewed-on: https://chromium-review.googlesource.com/1122150Reviewed-by:
-
sczs authored
Fixes a TableVIew model inconsistency crash. Whenever an item was inserted somewhere other than the end of the model, a crash occurred. Example: If the item was inserted second to last at index 9, then the tableViewDidInsert value was also 9. This meant that tableViewDidInsert was called twice (once for the item just inserted and once for the previous item) and that the item that used to be at 9 shifted to 10. The problem is that tableViewDidInsert was never called for index10. This was causing an inconsistency crash at the end of tableUpdates. Now we always call tableViewDidInsert with the total count of items, in order to successfully let the tableView a new row as been inserted. Bug: 836562 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3705cf6bd78364f04f99f29393695c1b00d613bd Reviewed-on: https://chromium-review.googlesource.com/1121792 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Xi Cheng authored
Bug: 851163 Change-Id: I852e1c1bcab17d250ddd5dcb7f69ca7d81d0ccdc Reviewed-on: https://chromium-review.googlesource.com/1122964Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#571941}
-
Matt Swartwout authored
Bug: None Test: Unit tests that add/remove more than 1 observer now pass. Change-Id: I097eaa3bea90501e9325b969963e2e02caf62878 Reviewed-on: https://chromium-review.googlesource.com/1119627Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#571940}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6856800e..079d2806 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I29c241ffaaf3d8a70b62df738cd8719512c55466 Reviewed-on: https://chromium-review.googlesource.com/1122481Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571939}
-
Mei Liang authored
In TasksUma.java, the histogram Tabs.Tasks.TabsInGroupRatio and Tabs.Tasks.TabGroupDensity requires to record sample in integer format and have unit in percent. The code had a casting error when we cast the ratio (in double) to integer first then multiply by 100 to convert the unit to percent. This CL fixes the casting error by multiplying the ratio by 100 first to get the correct unit then cast that result to an integer. Bug: 856275 Change-Id: Id5d1d6a3450e3d733b27ee437f1e0c3f1fb94d0d Reviewed-on: https://chromium-review.googlesource.com/1115800Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571938}
-
Vaclav Brozek authored
When parsing FormData into PasswordForm, the new parser tries to keep results from different types of analysis separate: if autocomplete attributes or server hints only provide the password fields, the parser currently does not try to figure out username with structural analysis. The server data currently lack username quite often, and also autocomplete mark-up often lacks the username. As a result, the new parser fails to find the username in many cases when the old parser could. Once server data improve, this issue will get much smaller (the autocomplete data will also get replaced by server hints). However, it is unlikely that this happens soon enough. Therefore, to keep the effect of the change of parsers in M69 small, this CL adds the ability to merge username from structural analysis / HTML classifier with the results from server hints or autocomplete attributes. The CL also renames ParseResult to SignificantFields, because both "parse" and "result" are somewhat overloaded in this file. The CL further does a few similar minor changes to naming, comments and code structure, in an attempt to increase readability Bug: 845426 Change-Id: Ie5a6297a2f7eb1a0d89421ea91a93bdd5a7112b5 Reviewed-on: https://chromium-review.googlesource.com/1117183 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#571937}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bc72265ebab00210b4853cb6f842749351f1f3b Reviewed-on: https://chromium-review.googlesource.com/1122973Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#571936}
-
Nasko Oskov authored
This CL adds a test case to verify that navigating away from an error page properly swaps SiteInstance when error page isolation is enabled. Bug: 838161 Change-Id: Ibe16bf39b24dd1d18666c4383bfba5777f8c965e Reviewed-on: https://chromium-review.googlesource.com/1122840Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#571935}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/483580b38ef1..621c9d28c3d0 git log 483580b38ef1..621c9d28c3d0 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@621c9d28c3d0 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie2f7dcd0efee1bdc84b8d881aa22f836fa4d034a Reviewed-on: https://chromium-review.googlesource.com/1122897Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571934}
-
Theresa authored
Return early in #maybeShowContentInSheet if the model doens't have suggestions or the suggestions source is null. This indicates that suggestions are trying to be shown after state has been cleared. BUG=859214 Change-Id: Ie553f3d799e21e2a37b066ad6ed1e5353fd9dd0f Reviewed-on: https://chromium-review.googlesource.com/1122956Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#571933}
-
Sergey Abbakumov authored
This prevents from reading uninitialized memory according to MSAN reports. Bug: 856537 Change-Id: I750447942c3c0a41f49375cd1335068c4e5e34ce Reviewed-on: https://chromium-review.googlesource.com/1116220 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571932}
-
Carlos Knippschild authored
This reverts commit 61f145b5. Reason for revert: Offline Prefetch should not be enabled by default but instead it should be selectively enabled via Finch. Original change's description: > Enable Offline Prefetch by default. > > Bug: 687364 > Change-Id: I4727334dcf0060b5a8202a9694e7bd60d31029ec > Reviewed-on: https://chromium-review.googlesource.com/1105031 > Reviewed-by: Dmitry Titov <dimich@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Commit-Queue: Carlos Knippschild <carlosk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568230} TBR=fgorski@chromium.org,dimich@chromium.org,carlosk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 687364 Change-Id: I2d70657feba03f695ab461caaa8384703e81c196 Reviewed-on: https://chromium-review.googlesource.com/1122936Reviewed-by:
-
Charlie Andrews authored
NOTRY=true TBR=nednguyen@chromium.org Bug: 859575 Change-Id: I81e1c060bf93f8d30c56a4cc8563c6f828b524fb Reviewed-on: https://chromium-review.googlesource.com/1122970 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#571930}
-
Theresa authored
The use of a TintedImageView was causing crashes on older versions of Android when trying to mutate the state of a LayerDrawable containing a RoundedBitmapDrawable on older versions of Android. BUG=857408 Change-Id: I81326ab571c34e10a739d5f185c9179e41faf94e Reviewed-on: https://chromium-review.googlesource.com/1122853Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00d2e8ebcb13..d818ebf4a317 git log 00d2e8ebcb13..d818ebf4a317 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 bsalomon@google.com Revert "Some scissor state cleanup." 2018-07-02 bungeman@google.com Roll FreeType 2018-07-02 bsalomon@google.com Some scissor state cleanup. Created with: gclient setdep -r src/third_party/skia@d818ebf4a317 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I8567254342417982ee7852e9491c3c73ad8c41a4 Reviewed-on: https://chromium-review.googlesource.com/1122736 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571928}
-
Sky Malice authored
Bug: 714018 Change-Id: I73cf48ba17dd96f6f4571bad941b6669509ba6b2 Reviewed-on: https://chromium-review.googlesource.com/1117575 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1483cf11. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20619 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=kereliuk No-Export: true Change-Id: I18133f72442faa70315651af71f4dd8962bd011d Reviewed-on: https://chromium-review.googlesource.com/1122488 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571926}
-
Greg Kraynov authored
It's bug-prone to expect reversed-order supply to a queue. Since we requeue non-nestable tasks by pushing to the front it makes sense to iterate that queue in the reverse order instead of expecting an unnatural order. Change-Id: I24feebbd40701d6f29392a84578d09a8b5154368 Reviewed-on: https://chromium-review.googlesource.com/1122622 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571925}
-
Elad Alon authored
Avoid initiating the upload of WebRTC event logs when either: * Not connected to any network. * Connected to any network other than WiFi or Ethernet. Note that this is not bullet-proof, since a machine may be connected to multiple networks at the same time, but NetworkConnectionTracker only reports one of those. Also, if connected to a mobile hotspot, this wi will appear to us as WiFi. Bug: 775415 Change-Id: I44ed2560903751c27c1b1fe98a66ea89bd463a3e Reviewed-on: https://chromium-review.googlesource.com/1122123Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#571924}
-
Steven Bennetts authored
This is used by getPrimaryDisplayNameForTesting which is called from the CrOS autotest enterprise_RemoraRequisitionDisplayUsage.py. Includes a TODO to update the autotest to call the equivalent extension API. If this breaks enterprise_RemoraRequisitionDisplayUsage, please revert. Bug: 855251 Change-Id: I73007ba2a4d4a20c46da940f59fe98353cabf294 Reviewed-on: https://chromium-review.googlesource.com/1114295 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#571923}
-
sczs authored
==== Original CL: crrev.com/c/1107216 - Updates SigninPromoView to support a new UI Layout based on UIRefresh Phase 1 flag and a new flag received on init. Screenshots: https://drive.google.com/open?id=1FnR436FEX9_3GwFbIIrJsQ8qHZOdqJpl https://drive.google.com/open?id=1__aPHb1ye3WkiHKHJp9kIyJ6hhABq1Y6 https://drive.google.com/open?id=1ibjz3nnXHBrO_akJm4e9tgghpD85f3u0 https://drive.google.com/open?id=1dCVkiMW1IMQjWkxcegVxi8r1PLh5ZCqM ==== Updates: There were some issues when moving the UI setup from self, which I had tried to fix on the original CL. I've now moved the UI setup to self, this means that some call to self will remain. Bug: 805188 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4eab7b1b4388e1e4f41b0b9861ef44057d99aab7 Reviewed-on: https://chromium-review.googlesource.com/1118912Reviewed-by:
-
Devlin Cronin authored
Add .mjs to type mappings for the javascript MIME type. This is necessary for .mjs to be recognized as a valid for use in modules when served by the extension protocols, where the mime type is determined by our net code (as opposed to a server). Update the extension API test for modules to include a .mjs file test. Bug: 857076 Change-Id: Ib14cabbc52057cfb57c933de5a9c3ed4b13b87d2 Reviewed-on: https://chromium-review.googlesource.com/1117203Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571921}
-
Kyle Milka authored
Bug: 859375 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I17777cde0b1ef1e2a3106453ce54c1cabe7a7382 Reviewed-on: https://chromium-review.googlesource.com/1122854Reviewed-by:
-
Vadym Doroshenko authored
Checkboxes are not part of calculation of form signature. So despite the same signature it might be different number of fields. For example when the site adds or removes checkboxes dynamically. This CL removes assumption that initially observed form and server predictions have the same number of fields. Unique_renderer_ids are used for field identification. Bug: 831123, 853149 Change-Id: Ibb6551e702cf073562dea1c4be47c5421143f713 Reviewed-on: https://chromium-review.googlesource.com/1118258 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571919}
-
Theresa authored
This reverts commit 36fc4d87. Reason for revert: caused crbug.com/859423 and crbug.com/859421 BUG=859421,859423,835412 Original change's description: > Modern] Update toolbar button animation for NTP > > Fade out the toolbar buttons rather than scrolling them off when the NTP > is scrolled. > > BUG=835412 > > Change-Id: I9c273aaa83f3546c9e04f9a7140c39796f09af9c > Reviewed-on: https://chromium-review.googlesource.com/1120442 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571530} TBR=twellington@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 835412 Change-Id: I98b3f2d9b561eff9f80b798abb3965065ecf6002 Reviewed-on: https://chromium-review.googlesource.com/1122877Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#571918}
-
Emily Hanley authored
Bug: 757933 Change-Id: Ica1832c5f95d0cb0d3d034d318ff58c9e5a4ac70 Reviewed-on: https://chromium-review.googlesource.com/1106549Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#571917}
-
Alexander Timin authored
Bind input-related mojo interface to the input task runner and add a feature to assign the highest priority to it. BUG=857099 R=alexclarke@chromium.org,yutak@chromium.org,haraken@chromium.org,rkaplow@chromium.org CC=eseckler@chromium.org,hajimehoshi@chromium.org Change-Id: I19f3e08bcc6af626dba298f31570102ddaffc4ac Reviewed-on: https://chromium-review.googlesource.com/1117188Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571916}
-
khmel@google.com authored
RequestAccountInfo -> OnAccountInfoReady is implmented as truly async calls. It seems that it is possible the case when instance is removed after making a request and this leads to crash (however it is pretty rare case). TEST=N/A BUG=801947 Change-Id: I0ae3f7a250e0796d2174ea5252e33db84f949592 Reviewed-on: https://chromium-review.googlesource.com/1120777Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#571915}
-
Ovidio Henriquez authored
This change splits the runtime enabled flag for WebUSBOnDedicatedAndSharedWorkers into WebUSBOnDedicatedWorkers and WebUSBOnSharedWorkers to facilitate the independent development of the features. Bug: 837414 Change-Id: Icb9237a42a1f0b27391f602db7b3f395d53dcd6d Reviewed-on: https://chromium-review.googlesource.com/1098031 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#571914}
-
Sky Malice authored
Bug: 714018 Change-Id: Icf820390ed7ae7dd66219d9473dedae3e90e382a Reviewed-on: https://chromium-review.googlesource.com/1117569 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#571913}
-
