- 11 Jul, 2019 40 commits
-
-
Fergal Daly authored
mac-rel is being weird, so NOTRY=true TBR=aboxhall@chromium.org NOTRY=true Bug: 982234,982998 Change-Id: I2f8998ac253cba11bbe319c5cf890b913093abd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697403 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#676307}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08a3d8e2a0d8..78dec0421b69 git log 08a3d8e2a0d8..78dec0421b69 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 eliribble@chromium.org Show nice error on failure to enumerage input files. Created with: gclient setdep -r src/third_party/depot_tools@78dec0421b69 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:983006 TBR=agable@chromium.org Change-Id: I33d052c6b39b0fc3c0946e7e8459088e7a5ba1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676306}
-
Antonio Gomes authored
This CL is a prepraration step to Onion souping webmediaplayer_ms.cc|h, webmediaplayer_ms_compositor.cc|h. It is part of phase 4.4, described in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ BUG=704136 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: Ifa20c5e06feae9433a6c8438f845546088b025f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692389 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676305}
-
Alex Oldemeier authored
This CL adds the Termina kernel version to Crostini enterprise reports. This CL has three parts: - Add a pref to cache the Termina VM kernel version. Also rename the pref containing the Termina component version to make its content more transparent. - If reporting is enabled, a call to concierge's GetEnterpriseReportingInfo is made on Crostini startup to write the Termina kernel version to the pref. - Finally, the pref is copied to the status proto at device status collection time. Test: unit_tests --gtest_filter="Crostini*", browser_tests --gtest_filter="DeviceStatusCollectorTest.*Crostini*" Bug: 844468 Change-Id: I8b53a7e75b365311433a47f532e10d415f56c33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642556Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676304}
-
Matthew Cary authored
The fuzzer uses the shared memory API to create a file descriptor (Harness::GetFileDescriptor). This change updates that creation from the legacy shared memory API to the new one. There is no functional change. Bug: 795291 Change-Id: I186fc316c15c19fea08b04b76d8c663cdb673eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695410Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#676303}
-
Christopher Lam authored
Bug: 972967 Change-Id: I72724aa1509386424e2c656d2d3b03cda9752a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694247Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#676302}
-
Hayato Ito authored
Bug: 982290 TBR: lushnikov@chromium.org Change-Id: I9bb2b2566028faa150c3f5af1525d2143e8930e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696904 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#676301}
-
Julian Watson authored
BUG=chromium:978332 Change-Id: I1320e91db83af8e23e73d0c408ee13ed09778c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694501 Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#676300}
-
Tsuyoshi Horo authored
Currently when a main SXG is served from PrefetchedSignedExchangeCache was_in_prefetch_cache flag is set, but was_fetched_via_cache flag is not set. So "Cached" suffixed PageLoad.Clients.SignedExchange UMAs are not recorded. To fix this, this CL set was_fetched_via_cache flag when we set was_in_prefetch_cache flag. Bug: 935267 Change-Id: I22bbd9554b871ad1f1c9e3268af113ed9c22de59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696961Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#676299}
-
Miyoung Shin authored
This CL replaces the use of std::array of std containers with WTF::Vector in *test.cc files and removes unnecessary including <array> header. Bug: 952716 Change-Id: Ifb5349c03921a61394fc438e5d0501f3c8f9ac99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695361Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d3f699407f75..08a3d8e2a0d8 git log d3f699407f75..08a3d8e2a0d8 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-10 vadimsh@chromium.org [lucicfg] Update to the latest version. Created with: gclient setdep -r src/third_party/depot_tools@08a3d8e2a0d8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0dd9eaca65a9abe440a23ab0c5c223ec96f23579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696831Reviewed-by:
-
Takuto Ikuta authored
We already have 32core machine in luci.chromium.try pool. https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cores%3A32&f=pool%3Aluci.chromium.try&f=builderless%3A1&k=builderless&s=id Bug: 956776, 954450 Change-Id: I8ee1a5343c01add4717cbc26c60451364aa41d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697123 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#676296}
-
Nektarios Paisios authored
Instead of having to create an AccessibilityNotificationWaiter at the start of every test and wait on it, this method makes loading an HTML document easier and removes repeated code from tests. This patch also switches to using the modern C++ raw string litterals which have the advantage that quotes and line breaks don't need to be escaped, and the HTML could be formatted the same way as in an HTML file. R=aboxhall@chromium.org Change-Id: Iaf8e59be8eb7b9bf2b0ca90caaa7cb6c3380622a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696423 Auto-Submit: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#676295}
-
Darren Shen authored
Other styles need to be supported for certain decoders. Bug: 973354 Change-Id: I3067c4e0ede74c9f0f2b09542ec4afbbf6e22e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692222Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#676294}
-
Hayato Ito authored
This reverts commit 3582475b. Reason for revert: See https://crbug.com/983016 Unfortunately, bots complain eslint error there. Original change's description: > DevTools: Use object spread operator in AxeCoreTestRunner.js > > Support for ES9 features like object spread was enabled in https://crrev.com/d2af1fc > > Change-Id: I938768072adc451d006f6f7d374bd7148a3bf084 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689002 > Reviewed-by: Erik Luo <luoe@chromium.org> > Commit-Queue: John Emau <johnemau@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#676239} TBR=einbinder@chromium.org,luoe@chromium.org,jeffish@microsoft.com,Rob.Paveza@microsoft.com,johnemau@microsoft.com Change-Id: I0a7f964701894bb52d243c569473de117a9f5e6a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697381Reviewed-by:
-
Hayato Ito authored
TBR=peconn@chromium.org Bug: 982081 Change-Id: Idd5f0e60c07b460fd3fdc5c73afe346fd2ab2acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697024Reviewed-by:
-
Minggang Wang authored
[OnionSoup] typemap network.mojom.URLRequestReferrerPolicy with net::URLRequest::ReferrerPolicy for Blink variant This CL changes the typemapping of network.mojom.URLRequestReferrerPolicy for Blink variant. See details: Before: none After : typemap with net::URLRequest::ReferrerPolicy This CL is part of a series of CLs which are targeted to typemap network.mojom.URLRequest with network::ResourceRequest for Blink variant finally. 1. https://chromium-review.googlesource.com/c/chromium/src/+/1669131 2. https://chromium-review.googlesource.com/c/chromium/src/+/1672768 3. https://chromium-review.googlesource.com/c/chromium/src/+/1680505 4. This CL 5. https://chromium-review.googlesource.com/c/chromium/src/+/1683493 BUG=860403 Change-Id: I0cdf7ad3922cb8c68af3f9afaecd16ab4a4f491c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679984 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676291}
-
Takuto Ikuta authored
Bug: 956776, 954450 Change-Id: Ifd1c8a1119fb670e96129135e9113cebcf88db57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692566 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Alex Danilo authored
Moves the feedback panel JS files out of the main script bundle, into the lazily loaded set used for Polymer elements. Also inline the background image resources for the button for now: we will replace them in future CL with a cr-icon-button. Remove the icon pause/expand/cancel SVG images: no longer used. Bug: 947388 Change-Id: I0064b1b35a62d5f06674eada04cb0cd85191dc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692110Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#676289}
-
Mitsuru Oshima authored
This reverts commit 44db3913. Reason for revert: The root cause was fixed. Original change's description: > Disable flaky LauncherPageSwitchesTest on CrOS > > Bug: 981281 > Change-Id: I633a9876c0ddcd3102e22c1d50c29715945e8ae0 > TBR: oshima@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686670 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#674775} TBR=guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 981281 Change-Id: I3a2a8d4852a4fa5dd0a558f7b28ead3b7dccf126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696544Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676288}
-
Tsuyoshi Horo authored
This CL introduces SignedExchangeRequestMatcher:: FindBestMatchingVariantKey() method. This method is called from AlternateSignedExchangeResourceInfo::FindMatchingEntry() by PreloadHelper and PrefetchedSignedExchangeManager to decide which alternate subresource signed exchange should be used. Bug: 935267 Change-Id: I89520c27afc7efe8f2000f2c8acbecacff512a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677348 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Christopher Lam authored
Bug: 980846 Change-Id: I93fbc517d149045f9a5aacbb1ee27d51be673f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695301Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#676286}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c38cfa99a722..f304969e0f53 git log c38cfa99a722..f304969e0f53 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-11 bsalomon@google.com Blacklist GrTestingBackendTextureUploadTest on MoltenVk. Created with: gclient setdep -r src/third_party/skia@f304969e0f53 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@google.com Change-Id: I9e94058fe14c3239d2763f472b03385ea3a5260e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696697Reviewed-by:
-
Mitsuru Oshima authored
Bug: None Test: no functional change. all tests should still pass. Change-Id: I379e263e5371d808ee0aaa540531ebcc794663e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696643Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676284}
-
Yuzu Saijo authored
This CL fixes the incorrect usage of std::map. The lookup in the map is using the [] operator which is creating a default entry when the key is not present. etienne@ first tried to land this fix but had to revert because some tests became flaky (which was supposed to happen when we first associated IPCs with per-frame task runners here https://chromium-review.googlesource.com/c/chromium/src/+/1526067 , but was hidden because of this bug). Test failure example: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/13652 This is a second try to fix the incorrect map usage. -- update -- The flaky tests were because of scheduling experiments that set the background tasks to low priority, and this fix just surfaced the issue because now tasks are posted to per-frame task runners. CL to disable the experiments: https://chromium-review.googlesource.com/c/chromium/src/+/1692577 Now that the experiments are disabled, this memory leak fix should not make the tests flaky any more. Bug: 973200, 980523 Change-Id: I1eaf0af67f1bcbd582a510d70174666251b8b4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686979 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676283}
-
Yutaka Hirano authored
I'm going to land a change that allows structured cloning for errors. See [1] for the failures. - wpt/animation-worklet/stateful-animator.https.html expects errors are not serializable (see "state_function_returns_not_serializable"). - wpt/html/browsers/history/the-history-interface/001.html and wpt/html/browsers/history/the-history-interface/002.html expect a DataCloneError when calling pushState with an error. - fast/dom/Window/window-postmessage-clone.html expects a DataCloneError when calling postMessage with an error. - fast/events/message-port-multi.html expects a DataCloneError when calling postMessage with an error. - storage/indexeddb/structured-clone.html expects a DataCloneError when putting an error to the storage. All changes are expected, so I suppress all the tests here. After landing the V8 change I will modify and re-enable them. Also, add wpt/html/.../structuredclonse_0.html and structured-cloning-error-stack-optional.sub.window.html because the corresponding test changes will be merged soon. 1: https://ci.chromium.org/p/v8/builders/ci/V8-Blink%20Linux%2064/33036 Bug: 970079 Change-Id: I9b12adc81815996e1dc59b382f70ab83c4901a11 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695541 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676282}
-
Jeremy Roman authored
Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Bug: 981415 Change-Id: I363f81e8c17cabfb6031666ca0846bcfcbf97b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693602 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
After V4L2 surface is decoded, AVD might update the frame context. If AVD stops decoding because of need context update, then we need to resume decoding after that. BUG=chromium:941330 TEST=video_decode_accelerator tests --use_vd on kevin Change-Id: I45aaaf2df1431d0ace4c0fe107096538a03fd14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684788 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#676280}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e34ebb7382bc..8f0eabe40a7c Created with: gclient setdep -r src-internal@8f0eabe40a7c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hcarmona@google.com,hajimehoshi@google.com,jbroman@google.com Change-Id: I3c875f222f03622525f51350334675fe2c437c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696696Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676279}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ie4c9f183ab018c4739a56e699633ca17a88f8775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697102Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#676278}
-
yilkal authored
Bug: 977019 Change-Id: I06b58830bb975be2537b55ac71b63810d4bdd288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684672 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676277}
-
Giovanni Ortuño Urquidi authored
Admins will be able to specify the install URL for a Web App to pin that Web App to the shelf. Bug: 880125 Test: ChromeLauncherControllerTest.WebApp* Change-Id: I33e31c390f13761e140a68efbce4b0c9d547e2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670732Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#676276}
-
Alex Khouderchah authored
Bug: 975116 Change-Id: I9b2908c60bbf598d6188f085e932161a55fcfb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696141 Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Cr-Commit-Position: refs/heads/master@{#676275}
-
Ahmed Fakhry authored
The resource reporter system is likely to be removed or migrated to a new implementation (see issue chromium:976423). Until then, we extend the expiry date of these histograms till the end of the year. BUG=975534, 975218 Change-Id: Ie290e3347de9bd41e75cc4c40db2c641e6029463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691870Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#676274}
-
Sammie Quon authored
Modify the overview selection code to include tabbing through desk mini views and new desk button. To accommodate desks and also refactor the current logic, introduce a new class which handles displaying highlights in overview. The new class makes it easier to test and allows us to remove many member variables in OverviewGrid and OverviewSession, which was hard to track at times. Design doc is in the bug. This CL separates the tab highlight with the focus traversal highlight. The two probably will never show up at the same time, but I think its easier to follow this way. Additionally, this CL prevents tab events from moving the highlight while a drag is underway. Removes two tests used to enforce that behaviour. Also, the highlight just disappears if we close the window it was highlighting. Follow ups to this cl: Make sure the UI is what UX wants (no specs yet). Introduce OverviewHighlightControllerTest and move highlight related tests there. See if we should be traversing to the close buttons. Test: manual, with desks enabled and multiple monitors Bug: 978168 Change-Id: I403fc794856cb8747868ea08aa25c5e89473f57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677482 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#676273}
-
Gabriel Charette authored
Multi-threaded MOCK_TIME advances when either RunLoop::Run() or ScopedTaskEnvironment::FastForward*() is active and the system reaches an idle phase (both main thread and thread pool are out of immediate tasks). It then advances by the minimum time delta necessary to make a task able to run. In a follow-up CL, I'll split MOCK_TIME off of MainThreadType (now that it's no longer main thread specific) and migrate callers. Bug: 946657 Change-Id: Id3da34ac066623291a8fca682fd13c9473e83e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686776Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#676272}
-
Jinsong Fan authored
Safe Browsing is enabled by default, WEBVIEW_ENABLE_SAFEBROWSING_SUPPORT becomes dead. No change to logic. Bug: 799317 Change-Id: I04e0c6d7a62a29940d6fd3f423103bd28ecffee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685019Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#676271}
-
Brian Sheedy authored
Adds the ability to replace or remove arguments for tests generated using generate_buildbot_json.py by specifying a 'replacements' field in test_suite_exceptions.pyl. This is useful in cases where a subset of bots have slightly different args from usual. Previously, this required a duplicate test suite definition with the updated args. With this change, the same definition can be used with the differences listed in the exceptions. Bug: 980631 Change-Id: If3c0c22f2046ce67123ec06dea88a6bf8de9102f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691266Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#676270}
-
Charlie Andrews authored
This is a reland of https://crrev.com/c/1666806, which caused flakiness on the Mac bots and was reverted. Since submitting that CL, I've changed the pointer management in ScopedGetItems so that it no longer relies on the heap. Calling unique_ptr::Reset() was causing deadlock when the target thread was suspended while holding the heap lock. This lays the groundwork for a follow-up patch that keys items in the metadata recorder by a <name hash, integer ID> tuple instead of just the name hash. This will allow us to distinguish between metadata that might coexist with the same name within the same process. For example, if we had a piece of metadata with a lifetime between navigation and FCP, we're currently unable to distinguish between two tabs running in the same process that are both loading. This new key structure will fill up the metadata map much faster because we don't recycle keys once an item slot is allocated for them. This patch gives us some ability to recycle those keys. TBR=gab@chromium.org R=wittman@chromium.org Bug: 976864, 982034 Change-Id: Ie4f0b941c8c9281aae7ab95e54d546ee4c13c8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696347Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#676269}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/807023d1041b..9ec162df61d3 git log 807023d1041b..9ec162df61d3 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 seanabraham@chromium.org cbuildbot: remove set noparent 2019-07-10 bhthompson@google.com Move R76 Android N PFQ to gandof 2019-07-10 bhthompson@google.com Migrate branch N Android PFQ builder from reef to gandof 2019-07-10 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9ec162df61d3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id3ebd77858fed04da2a6d5a29ecccafa8e6de7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696749Reviewed-by:
-
