GitLab

The web tests checks runtime flag idleSpellCheckingCallbackEnabled, which
is a removed flag after shipping of idle time spellchecker.

Hence, this patch removes the checking of the flag.

Change-Id: Ie8f279854a2b7625d7b526bfe0e50534cf9f8891
Reviewed-on: https://chromium-review.googlesource.com/c/1351872Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611302}

|NEW_PASSWORD| votes should be sent when a user presses "Update" button in the prompt

Bug: 907910, 552420
Change-Id: I0fd422255bd0ae599c833e11a9b64529d8bddecb
Reviewed-on: https://chromium-review.googlesource.com/c/1350611
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611301}

The Mojo InterfacePtr is not thread-safe. The MdnsResponderAdapter,
which is the client of the mDNS responder service via a Mojo binding, is
created on the main thread to access the connector to the service
manager, while being used exclusively on a WebRTC work thread. As a
result, it should own a thread-safe InterfacePtr to the mDNS service.

Bug: 905566
Change-Id: I8395f4163d0d9f17b954d082a580af673bb107f3
Reviewed-on: https://chromium-review.googlesource.com/c/1351596Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Qingsi Wang <qingsi@google.com>
Cr-Commit-Position: refs/heads/master@{#611300}

This will eventually be 0 and then we can DCHECK, but is currently blocked on a few things (see blocking bugs).

Bug: 837753
Change-Id: I078cba0cf622cd9f2baf084f6c1d371b5e44457a
Reviewed-on: https://chromium-review.googlesource.com/c/1351774Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611299}

Bug: b/119185871
Test: local build

Change-Id: Id3f86cf28fe789008a479c30b916b1da64c61e9e
Reviewed-on: https://chromium-review.googlesource.com/c/1330688Reviewed-by: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611298}

This reverts commit 30e1dd18.

Reason for revert: https://crbug.com/908970

Original change's description:
> [ios] add credit card test for manual fallback
> 
> Also adds AutofillManualFallbackPhaseTwo to test bots.
> 
> Bug: 845472
> Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Commit-Queue: David Jean <djean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611171}

TBR=rohitrao@chromium.org,bpastene@chromium.org,javierrobles@chromium.org,djean@chromium.org

Change-Id: Ied47c5923ca1a71604a04df719bf2a18bae39265
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 845472
Reviewed-on: https://chromium-review.googlesource.com/c/1352513Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611297}

This is to synchronize it with the CQ settings which cosinders builds pending
>2h as timed out.

Bug: 908943
Change-Id: I56285d4236eeae1a38e525ea0f18c68f80c07d14
Reviewed-on: https://chromium-review.googlesource.com/c/1352446
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611296}

BUG=908548

Change-Id: I1f471655a5e3f629c0d316b2617fbeaf62b7ba06
Reviewed-on: https://chromium-review.googlesource.com/c/1351499
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611295}

Previously it used to use tab.tabmodel which is going to be deleted.

Bug: 899839
Change-Id: I86584dfcd6bae44b289585fe1562c2f160715406
Reviewed-on: https://chromium-review.googlesource.com/c/1321669
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611294}

Required for next work where new WebInfo structure needs to be included
into PackageInfo

TEST=unit_tests
BUG=None

Change-Id: I5b1a680c3f68e5ca0d5f37a1735efcd2a76dad7d
Reviewed-on: https://chromium-review.googlesource.com/c/1343190Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611293}

There are a few TODO(vabr) in the code. Some of them are about old
code-health improvements which proved to be unimportant enough to
consider, those are being removed in this CL. A few are still relevant
and have an associated bug filed, those are redirected to that bug
instead.

Bug: 908813, 397083, 415449, 543085
Change-Id: If506009ce54016f8a1d9680a90b6516b399af4aa
Reviewed-on: https://chromium-review.googlesource.com/c/1352186Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611292}

* Remove unnecessary top_right() calls
* Use temps to reduce wrapping
* Use WindowFromTarget() more consistently
* For parallelism, always convert from targets to windows, instead of sometimes
  using the "target" version and sometimes the "window" version and mixing calls
* Group all the EventGenerator constructor variants that take a root window

Bug: none
Change-Id: I707780ee21ec2d3652fd3d1a38e3607e1ba980be
Reviewed-on: https://chromium-review.googlesource.com/c/1347277
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611291}

The same issue as the one fixed by https://crrev.com/c/1351286.

Bug: 908781
Change-Id: Iba5696ebdebdc286949ab62b24e8c6464354e7d1
Reviewed-on: https://chromium-review.googlesource.com/c/1351948Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611290}

It hasn't run successfully in ages, and our bot seems to be the only one
running it under ASan on Android.

Bug: 908832
Change-Id: I12270a54ac34c659669b38a0f6639757bea89a48
Reviewed-on: https://chromium-review.googlesource.com/c/1350906Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611289}

This CL removes macro usage from /ios/chrome/browser/history.

This CL was uploaded by git cl split.

R=sczs@chromium.org

Bug: 589840
Change-Id: I8f5c3e1980e622a55202a76db722dd65bcf348e4
Reviewed-on: https://chromium-review.googlesource.com/c/1351960Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611288}

SafeStack support has been abandoned.

Bug: 908597
Change-Id: I292cfa06bcad8953957480ea0ecf873cdb526f4c
Reviewed-on: https://chromium-review.googlesource.com/c/1351607
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611287}

SafeStack support has been abandoned.

Bug: 908597
Change-Id: Ie4e8709c4682814fb7bebad2eb2a65990f69c3d0
Reviewed-on: https://chromium-review.googlesource.com/c/1351587
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611286}

AFAICT, post-Mac views this is always true.

This is cleanup for removing the MacRTL flag.

Change-Id: I35de9ddf6dd8f89ec90d427915917945a2164347
Reviewed-on: https://chromium-review.googlesource.com/c/1344191Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611285}

Add a mojo method to send the NSAccessibilityRemoteUIElement tokens for
the NSView and NSWindow in the viewer (app shim) process to the browser
process, and to return the NSAccessibilityRemoteUIElement for the web
contents (in the browser) the viewer (app shim) process.

Update -[BrowserAccessibilityCocoa window] to call either
-[NSView window] or -[NSAccessibilityRemoteUIElement windowUIElement],
depending on which object is returned by GetParentView.

Change -[RenderWidgetHostViewCocoa accessibilityFocusedUIElement] to
call a GetFocusedBrowserAccessibilityElement, which will return the
the NSAccessibilityRemoteUIElement when called in an app shim
process.

Bug: 900846
Change-Id: I0d3d65e9924613b0dc137a08d0030d31981ecfdd
Reviewed-on: https://chromium-review.googlesource.com/c/1351415
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611284}

Add text message to inform whether the administrators can observe
web contents via policy installed trust root certificates.

Bug: 879146
Change-Id: I3ce41487072f130f32a01e4cc6c73565fd862c27
Reviewed-on: https://chromium-review.googlesource.com/c/1337343
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611283}

https://aomedia.googlesource.com/aom.git/+log/716f2896c6ba..67223a304e09

$ git log 716f2896c..67223a304 --date=short --no-merges --format='%ad %ae %s'
2018-11-20 wtc decoder_get_frame() should use output frame index.
2018-11-21 wtc Declare pbi->output_frame_index as an array of int

Created with:
  roll-dep src/third_party/libaom/source/libaom
R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@chromium.org

Bug: 906381
Change-Id: I8f80378c1608761310a273ecdb3556d401e71cc2
Reviewed-on: https://chromium-review.googlesource.com/c/1351715Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#611282}

This will allow enabling a previously disabled test for Windows.

Bug: none
Change-Id: I58a0a62db1228e303de71519914a6b744711ce97
Reviewed-on: https://chromium-review.googlesource.com/c/1338945
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611281}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/62e154db..73bc258c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia4995cb05698c10d9f36cf23de05e4fc7d2193d4
Reviewed-on: https://chromium-review.googlesource.com/c/1351934Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611280}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=finnur@chromium.org

Bug: 903957
Change-Id: I461f534870c60e1fc6b9c1c441d388cc99646c10
Reviewed-on: https://chromium-review.googlesource.com/c/1338483Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611279}

"Clear & reset" used GURL::DomainIs() to check if a cookie belongs
to a specific domain. This doesn't handle cookies that are scoped
to a domain and all subdomains correctly.
E.g. a cookie for ".example.com" would not be removed if "example.com"
is cleared.
This is fixed by using CanonicalCookie::IsDomainMatch() instead,
which correctly determines if a cookie is visible to a domain.

Bug: 908364
Change-Id: If01fde74845c6c8a547ec86b0a3be8b9076b2d61
Reviewed-on: https://chromium-review.googlesource.com/c/1350634Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611278}

This is a followup to https://crrev.com/c/1350984.
In particular, this moves the code from /components/browser_sync/ into
/components/sync/, where autofill code can actually access it.

Bug: 903290
Change-Id: Id7b90cf5c1344cb4404d9a672d057a67e74d35b9
Reviewed-on: https://chromium-review.googlesource.com/c/1352160Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611277}

Fixes uses of deprecated Object::Set and FunctionTemplate::GetFunction
to use Context version that return Maybe values.

Bug: v8:7283, v8:7295, v8:8238, chromium:883496
Change-Id: Ia400ec8b36d138b9f6b87c4a91f7ccb12c2eeefa
Reviewed-on: https://chromium-review.googlesource.com/c/1352314
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611276}

See also go/chromerulesetservicemerge.

This CL removes the delegate file from core, and changes it as
well as the ContentRulesetService to the more appropriate name
of RulesetPublisher and RulesetPublisherImpl.  It also splits the
header files appropriately.  The final step will be to split the
source files, which will be done in a follow-up CL.

Change-Id: I2f5b077c9564c81586861b0ecae99f089b2237f3
Reviewed-on: https://chromium-review.googlesource.com/c/1340644Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611275}

Move the action buttons to using the MediaSessionAction
enum now that it is available.

BUG=893296

Change-Id: I174d7f9aadc0b1cf89b0b1a2f01d8e2a5269aead
Reviewed-on: https://chromium-review.googlesource.com/c/1320653
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611274}

Make tab switcher bottom toolbar clickable to prevent clicks from
going through the bottom bar and selecting a tab.

Bug: 905077
Change-Id: Iae34cd43f6f82aef1c8d62cdcdad20e38b075d5b
Reviewed-on: https://chromium-review.googlesource.com/c/1351753Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611273}

.desktop files act as shortcuts on Linux, allowing arbitrary code
execution. We should send pings for these files.

Bug: 904182
Change-Id: Ibc26141fb180e843e1ffaf3f78717a9109d2fa9a
Reviewed-on: https://chromium-review.googlesource.com/c/1344552Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611272}

- Allow infinite cull rect to be properly clipped and expanded through
  scroll translation. This can prevent SPv2 performance regression when
  painting scrolling contents when some ancestor uses infinite cull
  rects. This achieves the similar results of SPv1 painting composited
  scrolling contents.

- Copy and adapt the interest rect tests from composited_layer_mapping_test.cc
  into paint_layer_painter_test.cc

- Add infinite cull rect unit tests

Bug: 792577
Change-Id: Ia784416557e10a3193cd677ad8d31101fd077bc6
Reviewed-on: https://chromium-review.googlesource.com/c/1347354Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611271}

Keywords size, layout, style, paint now serialize in that order
for the 'contain' property.
https://drafts.csswg.org/css-contain/#contain-property

Bug: 908353
Change-Id: Ifde635f2d313add887dd43a0a0d98249e45bff4b
Reviewed-on: https://chromium-review.googlesource.com/c/1350562
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611270}

SafeStack support has been abandoned.

Bug: 908597,889532
Change-Id: I989dbf90bab522c6a4c50117de64a85509b4932f
Reviewed-on: https://chromium-review.googlesource.com/c/1351585
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611269}

Meaning: column containers, ortho children, and non-horizontal
writing modes

Bug: 845235
Change-Id: Iba6525752d0c14a77bc9a13cc75a484cdf3a711d
Reviewed-on: https://chromium-review.googlesource.com/c/1332247
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611268}

To be consistent with Android native view, this patch make WebView always show AUTOFILL menun in the overflow menu.

Bug: 907698
Change-Id: Ibe9e8bfd3850177339cfd969488649b44b5524d5
Reviewed-on: https://chromium-review.googlesource.com/c/1347000
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611267}

Bug: 816708
Change-Id: I0477ba7d3c93bef726c9bf0bc9879882ebedbfd9
Reviewed-on: https://chromium-review.googlesource.com/c/1290144Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611266}

Change-Id: Iefb439e6437a8589599155097365d9dd9cb17bb3
Reviewed-on: https://chromium-review.googlesource.com/c/1349853
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611265}

This updates the layout test and some code changes to make those tests
pass to be mode 2 tests (ie append after lock).

R=chrishtr@chromium.org

Bug: 882663
Change-Id: I44554d486c5af0db1c680d5be719d687fd2745d2
Reviewed-on: https://chromium-review.googlesource.com/c/1344263Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611264}

P is now being build with SDK code 28 and we're moving to targeting Q.
BUG=908821

Change-Id: I316883e0b1bf6cad2157a73a68c0ee567263c543
Reviewed-on: https://chromium-review.googlesource.com/c/1351479Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611263}