- 01 Apr, 2020 40 commits
-
-
Xianzhu Wang authored
It's dead code. It had been there before the blink reformat. Change-Id: Ibddd1f4994a5ec38a61e69fc19d9598b6dc2c01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131527Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755399}
-
Ehimare Okoyomon authored
Add a check to only call the cookie controls service if the new state is different from the previous state, because calling setChecked programmatically triggers onCheckedChanged. Bug: 1040091 Change-Id: I639a08cf47e365a3542c94b18ba680defca55b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132209Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#755398}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/media. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=raymes@chromium.org, tommi@chromium.org Bug: 714018 Change-Id: Ie7f42f27b2b92a1c0529a1e712ed627a4fe05803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132255 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755397}
-
Hailey Wang authored
Add calculation logic for maximum simultaneous load inside BackgroundTabLoadingPolicy. This will be used for restricting the number of background tabs loading in a future CL. Bug: 1059341 Change-Id: I7ecd751fafb202ffda09472a2121f72a02a22cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120267 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#755396}
-
Clark DuVall authored
The geolocation permission was getting automatically denied on some test runs. This should verify if it is because the prefs are getting persisted across test runs. Bug: 1064500 Change-Id: I385bb1326efa51c7885181a0f2557c8081bc313a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132669 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#755395}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/chromeos/attestation. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=emaxx@chromium.org Bug: 714018 Change-Id: Iebee9bd19db9cd252dffa538ea34ebb1d169df62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132253 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#755394}
-
Jan Krcal authored
This is a core Sync health metric. Bug: 1063924 Change-Id: Ie7b6c047bc6be518f41cf8ff5b8bfded202c2cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131827 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#755393}
-
Sean Harrison authored
Translation team flagged this string for having an erroneous period. Bug: 1032584 Change-Id: Iedc92d023a6fe9e223c1be426daf4370122d1d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131916Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#755392}
-
Anton Bikineev authored
This check was missing. Bug: 522357 Change-Id: I6dfa88e07f30c0c6c3a4f09378c75554f3b3fc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130988Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#755391}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3459bf5bf9c9..eafb2c3665f7 git log 3459bf5bf9c9..eafb2c3665f7 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-31 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-31 khmel@chromium.org arc: Support AndroidMetadata in union build 2020-03-31 saklein@chromium.org scripts: Remove -v short options for not verbose. 2020-03-31 dhanyaganesh@chromium.org report_stages: Add master_bb_id to metadata.json 2020-03-31 lamontjones@chromium.org Revert "Refactor to use service/artifacts for BuildAutotestTarballsForHWTest." 2020-03-31 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@eafb2c3665f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I59c4b19633862ee596acf615548d0e1a4e4719af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131688Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755390}
-
Rushan Suleymanov authored
This reverts commit 83dccf5d. Reason for revert: this patch contains refactoring of client tag based model type processor. To prevent too many changes in one release it is better to reland this patch after M83 will be branched. Original change's description: > [Sync] Refactor model type processor: entity tracker lifetime > > Make entity tracker's lifetime same as initial sync done. The tracker > won't exist if we still have no data from the server. > > In this patch also authentication_account_id is not set explicitly for > metadata coming from ModelReadyToSync. The behavior for this field > becomes similar to cache_guid. If authentication_account_id differs from > activation request then the metadata will be reset. Generally it should > not affect anything. > > In the next patch unittests will be added. > > Bug: 947044 > Change-Id: I34a75006d1f31888f8ca485a94538b6dd98923c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038733 > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750920} TBR=mastiz@chromium.org,rushans@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 947044 Change-Id: Icc0ae96eb2afa549024bf5b61efb799a6a92969c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130212Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#755389}
-
kylechar authored
Change DisplayResourceProvider so that it records memory dumps when used with SkiaRenderer. Also shared ownership edges were broken with shared image backed resources, so update both GLRenderer and SkiaRenderer to make a GUID based on mailbox. This might break shared ownership in GLRenderer with things that aren't on shared image yet, but it fixes shared ownership for everything that uses shared image. Bug: 1058974 Change-Id: Iaaf981f28212cabe4d5e4535158afabaff2bd6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131016Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#755388}
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I1644b62216c9ada36516027caf4f3166f5735fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117913Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#755387}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/c6954897f7..fba8a316c3 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/c6954897f7..fba8a316c3 Bug: None Change-Id: Ic77d9aa95061b53f9c3fbfd0b67bd7e8450e45e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132446Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#755386}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0301269a..05530618 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3c82db7e96c4e569db961ca4af00836b17822ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132029Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755385}
-
Ayu Ishii authored
This adds changes to the Modification API path behavior to match the explainer[1]. 1. Rejects relative paths (not starting with /) 2. Adds / to the end of paths that don't end in / [1]https://github.com/WICG/cookie-store/blob/master/explainer.md#paths Change-Id: Iefaef4e60f718727da45f99c8d6504a387560fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131031Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#755384}
-
Filip Gorski authored
* Mostly adds tests covering 100% of DeviceConditions * Makes NetworkChangeNotifier expose resetting of its instance to tests outside of its direct package (to enable unit testing). Bug: 1066565 Change-Id: I20012d10e3b55a903fb15b65a39d5ef50359e5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128717Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#755383}
-
Chris Lu authored
FullscreenController will soon be Browser-scoped, so InfobarCoordinator will need its browser property assignable. Bug: 790886 Change-Id: Ifcde830dd331e1561217b102343749ae4db6779b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123319 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#755382}
-
Finnur Thorarinsson authored
This adds coverage for the no-file-to-decode situation and the no-decoder-connection situation. Bug: 656015 Change-Id: Ic524cee8117e5d47cc1ad4f06836154cd518c032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126996 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#755381}
-
Jacobo Aragunde Pérez authored
This event is emitted by alert-like contents like bubbles or infobars. The auralinux backend now emits the platform event "object:state-changed:showing". It fixes one aspect of the bug 1052675: there was no event indicating the appearance of the bubble. Bug: 1052675 Change-Id: I73a8441b457088261e70dbddb4c00795c8553a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062349 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#755380}
-
Vladimir Levin authored
This patch removes unlocking for activation. This is instead replaced with scrolling the element into view for the auto case. Find-in-page still activates, since it needs further testing and because it needs to work with hidden-matchable as well as auto. R=chrishtr@chromium.org, aleventhal@chromium.org Change-Id: Ice3e488281da6e55bac1451c596e648aaa2b440f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130680 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#755379}
-
Timothy Gu authored
Currently, no matter what the branding of the browser is, the name of the PulseAudio contexts are always "Chromium" and "Chrome Input". This is shown in e.g., GNOME Settings. Instead, use current branding to determine the name to use: "Chromium" and "Chromium Input", or "Google Chrome" and "Google Chrome Input". Change-Id: Ibff97112b990cb43eb568be11310d85604642b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130766Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755378}
-
Colin Blundell authored
WebLayer currently passes null as the RedirectHandler implementation used by ExternalNavigationHandler. We are targeting sharing Chrome's RedirectHandler implementation. In advance of that sharing, this CL adds tests of WebLayer's external navigation launching that verify areas impacted by the RedirectHandler implementation used. In particular, these tests highlight area where WebLayer's external intent launching is not up to par with Chrome's thanks to the missing RedirectHandler implementation: the tests launch intents that in Chrome would be blocked. When WebLayer brings in Chrome's RedirectHandler impl, these tests should fail and consequently have their behavior updated to verify that the intents are blocked. Change-Id: I35a00ed4b15cbd046c3106bf4d91bb042ec91da3 Bug: 1031465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130277 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#755377}
-
Maksim Sisov authored
As was discussed in https://crrev.com/c/2013106, the workspace updates have been moved to the display::Screen class. How it worked: A client called to X11DesktopHandler singleton and setup self as an observer, which was then notified about workspace updates. How it works now: display::Screen and DisplayObserver interfaces were extended and new methods were added OnCurrentWorkspaceChanged and GetCurrentWorkspace. X11DesktopHandler no longer receives any workspace updates. Instead, that functionality was moved to ui/base/x/x11_workspace_handler. In case of non-Ozone/X11 and Ozone/X11, both DesktopScreenX11 and X11ScreenOzone create XDisplayManager that stores DisplayObservers and notifies them about workspace changes that it gets from X11DesktopHandler. Thus, the run-time flow looks like that: non-Ozone/X11: - Client-->display::Screen::GetScreen()->AddObserver()--> XDisplayManager::AddObserver(); - X11WorkspaceHandler::DispatchXEvent()--> XDisplayManager::OnCurrentWorkspaceChanged()--> DisplayChangeNotifier::NotifyCurrentWorkspaceChanged(); Ozone/X11: - Client-->display::Screen::GetScreen()->AddObserver()--> PlatformScreen->AddObserver()--> XDisplayManager::AddObserver(); - X11WorkspaceHandler::DispatchXEvent()--> XDisplayManager::OnCurrentWorkspaceChanged()--> DisplayChangeNotifier::NotifyCurrentWorkspaceChanged(); Basically, the difference is who owns the XDisplayManager. In non-Ozone case, it's DesktopScreenX11 and in Ozone/X11 case, it's X11ScreenOzone. Bug: 1044555 Change-Id: Ic0e31ad4b9f4dbffbdc8a6bda0a6f592094feffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093438 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#755376}
-
Maksim Sisov authored
When X11Window goes to fullscreen, it takes bounds of the display and provides XServer with updated size and origin of itself. XServer expects the bounds to be in pixels, but X11Window got the bounds in dip. This CL fixes the issue by taking display's size in pixels instead. Also, a test was written to verify this functionality. Bug: 1055057 Change-Id: If964856386e700a4a651303fe0e4ca81c769e851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124710Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#755375}
-
Andreas Haas authored
The benchmarks have already been deleted in https://crrev.com/c/1576030, but there seem to be some leftover configs. Bug: chromium:936998 Change-Id: I7968902a59e10ee82e02edca743ef3be93574587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132212Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#755374}
-
Timothy Gu authored
Currently in some geometry classes we are using std::min() and std::max() over numbers specified in IDL as "unrestricted double", meaning they could take the special value NaN. These STL helpers internally use the < operator, as in std::min(a, b) = a < b ? a : b. However, the IEEE 794 < operator always returns false when _either_ operand is NaN, so the result of min(0, NaN) and min(NaN, 0) could, confusingly, be different. This is difference is in fact visible through JavaScript. For instance, new DOMQuad({ x: NaN }, { x: 0 }, { x: 0 }, { x: 0 }).getBounds().x gives NaN, but new DOMQuad({ x: 0 }, { x: 0 }, { x: 0 }, { x: NaN }).getBounds().x gives 0. A similar problem is present for DOMRect/DOMRectReadOnly as well. This CL implements [1], which is to adopt semantics similar to JavaScript's Math.min() and Math.max(), which propagates NaN from either operand. This also aligns our behavior with WebKit. [1]: https://github.com/w3c/fxtf-drafts/pull/395 Fixed: 1066499 Change-Id: Id9a4282fa00dafcfe9c5616643efbe2eaace411e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129889 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#755373}
-
Haiyang Pan authored
android-pie-x86-fyi-rel CI builder is kept so that the links in the associated crbugs are still reachable. Bug: 1022533 Change-Id: I1cf9ca11c401584de4c1f841b033b080c6678115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121497Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#755372}
-
Liviu Tinta authored
Fixed memory leaks. Bug: 810882 Change-Id: I36397952cb86df4a21afb47ba186cd599818610c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124242Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#755371}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I6a3042388d83f90492aa2caba8ba1e2f119990e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132146Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#755370}
-
David Van Cleve authored
The experimental Trust Token API (https://github.com/wicg/trust-token-api) takes in parameters specifying a Trust Tokens protocol operation, annotates outgoing requests with request headers corresponding to protocol state, and processes corresponding response headers. For the MVP of the API, we're making the functionality available via Fetch, iframe, and XHR. To implement the XHR surface, this CL adds a new XHR setter, that accepts a trustToken object (identical to the one for the Fetch interface added in crrev.com/c/2036648) specifying a Trust Tokens operation to execute against the request. propagated correctly from the XHR interface to the network stack. Test: Expands integration tests to ensure Trust Tokens params are Bug: 1062395 Change-Id: I5f32d60c7b59002e79dc877719ba549ce5b9f412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120266Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#755369}
-
Clemens Arbesser authored
Also changed IntegerSum from two operands to N operands. Not sure why it wasn't set up like that in the first place. Bug: b/145043394 Change-Id: I81bf164b7fd10e76c0741889b479f04061fd5e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130552 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#755368}
-
Mugdha Lakhani authored
1. Move the padding from the icon to the textview. 2. Reduce the padding to 5dp to improve aesthetics. 3. Set the color of the icon and the text to modern-grey-900. Screenshots here: https://drive.google.com/drive/folders/1gvXWF_0ZKFG0VDmEsqrUHbI45Dx2zJMz?usp=sharing Bug: 1025607 Change-Id: I87200d7e4dc7f4436008136233ae99e31f154e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130247Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#755367}
-
Andrew Solovey authored
Send missing parameter |platform_version| to Gaia during Chrome OS add account flow. Bug: 1064677 Change-Id: I6e4745eb62fdc34c3ed303d138639e6d26bdb81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121264 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#755366}
-
Chris Harrelson authored
These fields are only ever set for content layers such as canvas and video. However, such uses don't make sense any more, because the "parent" concept originally had to do with a parent layer, which is no longer a concept in layer list mode. Bug: 1008483 Change-Id: I053f9048e5a152f84c4df761f1b1500a5a0019c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129893Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#755365}
-
Vidhan authored
Bug: 928851 Change-Id: I0983a1d6bfa734379fd0c1e770e212207847e843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130851Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#755364}
-
Guillaume Jenkins authored
- Update the Ukrainian spell check Hunspell dictionary used by Chromium - Roll src/third_party/hunspell_dictionaries/ e96f230bf..6fdad5388 (1 commit) Bug: 913536 Change-Id: I6e49dc2d4caba6311888aa861ff840d3ac54990c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130068Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#755363}
-
Christos Froussios authored
Also some minor visual changes Bug: 1066785 Change-Id: Ia6c58c2f3cc5b78fce2ab819f8d4fe1d45782e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128491Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#755362}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0f5e7581a004..e8d2080a34ed git log 0f5e7581a004..e8d2080a34ed --date=short --first-parent --format='%ad %ae %s' 2020-04-01 bsalomon@google.com Revert x2 "Assert that all GrCaps colortype/format -> swizzle queries are legal." 2020-04-01 reed@google.com remove unused flag Created with: gclient setdep -r src/third_party/skia@e8d2080a34ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1066850 Tbr: michaelludwig@google.com Change-Id: I7dda3321899f4b6c0f88691b87ba194fb9308959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755361}
-
sandromaggi authored
Previously, we did run the |safeNativeSetVisible(true)| which does not show the content or expand the bottom sheet while in the |RUNNING| state. This CL forces an expand of the bottom sheet in that scenario. Bug: b/152951618 Change-Id: I9702f825f8ee29e90814c3b15524d0181dc6f821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132367Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#755360}
-