GitLab

Collects stack samples at 10 Hz for 30 seconds at startup. Uploading of
samples to UMA is controlled by a Finch experiment.

This change moves to a callback-based mechanism for communicating
completed profiles to the metrics provider to avoid profiles lingering
in memory when reporting is disabled.

BUG=464929

Review URL: https://codereview.chromium.org/1029653002

Cr-Commit-Position: refs/heads/master@{#324175}

Clients that already set the async parameter (in this case, with 'cta:1'), will
end up with query strings with two differeny async parameters, instead of a
comma delimited async param.

E.g. converts ?async=cta:1&async=es_dfp:123 -> ?async=cta:1,es_dfp:123

BUG=414528

Review URL: https://codereview.chromium.org/1066923002

Cr-Commit-Position: refs/heads/master@{#324174}

Don't use the canvas() from the PaintContext so that we can have the
PaintContext be backed by a DisplayItemList instead in the future.
Access to the Canvas should be done through a PaintRecorder.

For compositing effects (opacity) we use a CompositingRecorder to
provide a scoped opacity change.

R=pkasting
BUG=466426

Review URL: https://codereview.chromium.org/1062293003

Cr-Commit-Position: refs/heads/master@{#324173}

The upcoming VideoRenderer needs a way to know when time starts and
stops moving; this extends the RendererImpl to let the VideoRenderer
know about time changes.

I considered introducing a TimeSourceDependent observer-like interface
for TimeSources, but it ended up being way more complicated. I also
considered a proxy TimeSource, but again it was way more complicated.
The approach here is quite simple and small in complexity.

BUG=439548
TEST=new unittest.

Review URL: https://codereview.chromium.org/1068593003

Cr-Commit-Position: refs/heads/master@{#324172}

With this tricky we don't need this strange 'j' variable laying around
outside the loop, even better, since that variable is not even used
outside of the for loop.

The iteration using this tricky goes like the following:

The old tricky using just 'i':
For i = 0:
    0 * 2     = 0
    0 * 2 + 1 = 1

For i = 1:
    1 * 2     = 2
    1 * 2 + 1 = 3

For i = 2:
    2 * 2     = 4
    2 * 2 + 1 = 5

The new tricky using 'j':
For i = 0:
    j = 0
    0     = 0
    0 + 1 = 1

For i = 1:
    j = 2
    2     = 2
    2 + 1 = 3

For i = 2:
    j = 4
    4     = 4
    4 + 1 = 5

So the new code does the same thing as the old but with the advantage of
not having to use a temporary variable outside the loop.

And the tricky with 'j' has also the benefit of avoid a multiplication and the rules of operator precedence.

BUG=None
TEST=base_unittests --gtest_filter=MD5*
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1065733005

Cr-Commit-Position: refs/heads/master@{#324171}

BUG=474674

Review URL: https://codereview.chromium.org/1063453004

Cr-Commit-Position: refs/heads/master@{#324170}

For auto-launched kiosk apps permissions are granted automatically, without a
user consent. In such case a notification will be shown though.

TEST=unit_tests: *FileSystemApiConsentProviderTest*
BUG=440674

Review URL: https://codereview.chromium.org/1032313002

Cr-Commit-Position: refs/heads/master@{#324169}

This adds a test to check that clicking the columns headers in Files
resorts the columns in the correct order. It checks for ascending and
descending.

TEST=browser_tests -gtest_filter="*SortColumns/FileManagerBrowserTest*"
BUG=None

Review URL: https://codereview.chromium.org/1063453003

Cr-Commit-Position: refs/heads/master@{#324168}

This CL moves protocolExtensionManager from SessionConnector into its own class.
The ProtcolExtensionManager will be exposed via the ClientPlugin.

The higher level goal is to remove functionality from the SessionConnecctor
so that it can be removed altogether in a future CL.

BUG=474766

Review URL: https://codereview.chromium.org/1067133002

Cr-Commit-Position: refs/heads/master@{#324167}

Has to land after Blink CL: https://codereview.chromium.org/1057193003/

BUG=474692

Review URL: https://codereview.chromium.org/1059563005

Cr-Commit-Position: refs/heads/master@{#324166}

BUG=471928

Review URL: https://codereview.chromium.org/1060793003

Cr-Commit-Position: refs/heads/master@{#324165}

BUG=424436,467287

Committed: https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b
Cr-Commit-Position: refs/heads/master@{#324089}

Review URL: https://codereview.chromium.org/1068603002

Cr-Commit-Position: refs/heads/master@{#324164}

Also, I fixed two issues in a11y page:
1. settings. -> settings.settings. (b/c the names were already prefixed with "settings.")
2. Correctly concat the list of prefs to request via chrome.send()  (this will go away later anyway when we switch to settingsPrivate API.)

BUG=464898

Review URL: https://codereview.chromium.org/990473002

Cr-Commit-Position: refs/heads/master@{#324163}

The OutputSurface used with a Display should never call these.

Review URL: https://codereview.chromium.org/1009013002

Cr-Commit-Position: refs/heads/master@{#324162}

This patch ensures that we don't do extra hidden iterations in the
loop over tiles (erase is linear).

R=danakj, enne

Review URL: https://codereview.chromium.org/1069493003

Cr-Commit-Position: refs/heads/master@{#324161}

This ensures that subframe processes aren't left around if a parent page
removes an out-of-process iframes.

TBR=jam@chromium.org
BUG=471346, 474772
TEST=See bug for repro steps.
Credit to nick@ for TaskManagerOOPIFBrowserTest.LeavePageWithCrossSiteIframes

Review URL: https://codereview.chromium.org/1039403002

Cr-Commit-Position: refs/heads/master@{#324160}

again

Review URL: https://codereview.chromium.org/1065113003

Cr-Commit-Position: refs/heads/master@{#324159}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f36d5e0..68b67cd

TBR=falken@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/1067093003

Cr-Commit-Position: refs/heads/master@{#324158}

The function snprintf is not available in Visual Studio prior to VS
2015. In some places this omission is dealt with with a #define to map
snprintf to _snprintf. This was never a good idea (_snprintf doesn't
guarantee null-termination) and with VS 2015 it is not even legal.

This change conditionally disables one instance of this remapping.

The build errors that occur without this change are:

stdio.h(1926): warning C4005: 'snprintf': macro redefinition
stdio.h(1926): note: command-line arguments:  see previous
definition of 'snprintf'
stdio.h(1929): fatal error C1189: #error:  Macro definition of
snprintf conflicts with Standard Library function declaration

R=scottmg@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1069433002

Cr-Commit-Position: refs/heads/master@{#324157}

This CL abstracts Me2Me and It2Me under one common interface
remoting.Activity.

Instead of littering desktop_remoting.js with if statements based on the
mode, all Me2Me specific logic can be moved into
remoting.Me2MeActivity and likewise for It2Me.

BUG=466406
NOTRY=true
TEST=All integration tests passed on chromoting bots.
https://chromium-swarm.appspot.com/user/task/26aed85d041d9d10

Review URL: https://codereview.chromium.org/1054273002

Cr-Commit-Position: refs/heads/master@{#324156}

BUG=343237
TEST=WindowSelectorTest.BasicWithDocked, plus manual

Review URL: https://codereview.chromium.org/1059903002

Cr-Commit-Position: refs/heads/master@{#324155}

TBR=sky@chromium.org
BUG=465815

Review URL: https://codereview.chromium.org/1062293004

Cr-Commit-Position: refs/heads/master@{#324154}

Don't use the canvas() from the PaintContext so that we can have the
PaintContext be backed by a DisplayItemList instead in the future.
Access to the Canvas should be done through a PaintRecorder.

R=piman@chromium.org, sadrul
BUG=466426

Review URL: https://codereview.chromium.org/1066183002

Cr-Commit-Position: refs/heads/master@{#324153}

It seems all of the known bugs with Mali-400 are related to framebuffer
discarding.  Blacklist framebuffer discarding universally on Mali-400
and reenable ganesh and canvas where it was still blacklisted on Mali-400.

There was a preexisting workaround applied to all ARM < 4.4 which was
originally written in the context of Mali-T604; this explains why the
bugs only reproed on some Mali-400 devices.  Add a new one for all 4xx.

Also, a recently added Nexus 6 workaround did essentially the same
thing, but at the level of making the discard do nothing instead of not
advertising the extension.  In OpenGL ES 3, this is a core method so
failing to advertise won't be sufficient, so merge the two workarounds
and remove the "_ext_" from the name.

BUG=449488,451230

Review URL: https://codereview.chromium.org/1068573004

Cr-Commit-Position: refs/heads/master@{#324152}

BUG=474749

Review URL: https://codereview.chromium.org/1069503002

Cr-Commit-Position: refs/heads/master@{#324151}

BUG=445542

Review URL: https://codereview.chromium.org/1050043003

Cr-Commit-Position: refs/heads/master@{#324150}

This custom polymer element is used as a button to toggle the cast-mode-player (hide/show). It is styled after the current cast extension's drop down button.

BUG=464222

Review URL: https://codereview.chromium.org/1032533002

Cr-Commit-Position: refs/heads/master@{#324149}

BUG=381338,474622
TEST=ctrl+alt+z; navigate to html5demos.com/geo; observe speech is as expected (reads contents of bubble).

Committed: https://crrev.com/36318aa45e02cf0b5cf871bf38bbe47f3431cc8d
Cr-Commit-Position: refs/heads/master@{#323982}

Review URL: https://codereview.chromium.org/1067113002

Cr-Commit-Position: refs/heads/master@{#324148}

BUG=390991

Review URL: https://codereview.chromium.org/1062803003

Cr-Commit-Position: refs/heads/master@{#324147}

Turn on the DrawCallPerf test set on the Windows 7 Nvidia GPU bot.

BUG=468852

Review URL: https://codereview.chromium.org/1069103002

Cr-Commit-Position: refs/heads/master@{#324146}

We don't support API level 14 and 15 anymore. \o/

Also remove CreateSingleBuffered which is dead code not being used.

BUG=473837

Review URL: https://codereview.chromium.org/1060233002

Cr-Commit-Position: refs/heads/master@{#324145}

BUG=none
R=grt@chromium.org

Review URL: https://codereview.chromium.org/1024943002

Cr-Commit-Position: refs/heads/master@{#324144}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bb4a1cf..6c27535

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1060423002

Cr-Commit-Position: refs/heads/master@{#324143}

This is only used for usage statistics (without which we can't apply smart ordering to masked credit card suggestions, or sync usage stats between devices for unmasked cards).

There was already code in place for IDs for addresses, which was essentially unused (ID was always empty). This generates an ID to help identify server addresses for the usage stat tracking.

The tables are not actually synced yet (that's TODO).

BUG=none

Review URL: https://codereview.chromium.org/1042353003

Cr-Commit-Position: refs/heads/master@{#324142}

Review URL: https://codereview.chromium.org/1059183004

Cr-Commit-Position: refs/heads/master@{#324141}

Instead of completely regenerating all of the data each time anything
extension-y happens, have the extensions ui observe specific events and only
regenerate/update the extensions that were modified. Start by limiting events
to loaded/unloaded and error added events.

Also add a basic browsertest for some of the extensions page functionality.

BUG=461039

Review URL: https://codereview.chromium.org/1049483003

Cr-Commit-Position: refs/heads/master@{#324140}

Use the permission_broker's new CheckPathAccess method to filter
devices presented to the user by whether or not Chrome will be able to
open them later.

By having FakePermissionBrokerClient and the base UsbDevice class always
return true to access requests a number of #if defined(OS_CHROMEOS)
checks can be removed.

//third_party/cros_system_api is rolled from 95c486f3 to aea83430 to
pull in the new kCheckPathAccess definition in service_constants.h.

BUG=441526

Review URL: https://codereview.chromium.org/1034333002

Cr-Commit-Position: refs/heads/master@{#324139}

Revert of Add the ability to build Chrome tools to the Win Clang build script. (patchset #2 id:20001 of https://codereview.chromium.org/1068603002/)

Reason for revert:
Broke all bots on http://build.chromium.org/p/chromium.fyi/console?category=win%20clang , they fail with:

________ running 'C:\b\depot_tools\python276_bin\python.exe src/tools/clang/scripts/update.py --if-needed' in 'C:\b\build\slave\CrWinClang\build'
usage: update.py [-h] [--no-clobber] [--tools [TOOLS [TOOLS ...]]]
update.py: error: unrecognized arguments: --if-needed

Probably easy to fix (just add a dummy --if-needed parameter to argparse), but reverting to get that waterfall back to green.

Original issue's description:
> Add the ability to build Chrome tools to the Win Clang build script.
>
> BUG=424436,467287
>
> Committed: https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b
> Cr-Commit-Position: refs/heads/master@{#324089}

TBR=hans@chromium.org,dcheng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=424436,467287

Review URL: https://codereview.chromium.org/1063273002

Cr-Commit-Position: refs/heads/master@{#324138}

Don't use the canvas() from the PaintContext so that we can have the
PaintContext be backed by a DisplayItemList instead in the future.
Access to the Canvas should be done through a PaintRecorder.

R=sadrul
BUG=466426

Review URL: https://codereview.chromium.org/1064133003

Cr-Commit-Position: refs/heads/master@{#324137}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0cdfa90..f36d5e0

TBR=falken@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/1063223002

Cr-Commit-Position: refs/heads/master@{#324136}