1. 22 Sep, 2014 40 commits
    • ziran.sun's avatar
      Set autofilled property after autofilled value is set. · ae2e0995
      ziran.sun authored
      Autofill preview sets the field's autofill property to true. When the field is
      autofilled right after preview happens, we'd like to clear the autofill property
      that was set by preview before filling happens. This is handled in Blink side in
      SetValue() function -
      
      https://codereview.chromium.org/553983012/
      
      R=isherman@chromium.org
      BUG=412311
      
      Review URL: https://codereview.chromium.org/551403002
      
      Cr-Commit-Position: refs/heads/master@{#295955}
      ae2e0995
    • elizavetai's avatar
      Class MixinBasedBrowserTest was added. This class expands its base class,... · dbd9c9b2
      elizavetai authored
      Class MixinBasedBrowserTest was added. This class expands its base class, InProcessBrowserTest, by supporting adding mixins. Mixins can be used to add some features not related directly to the testing process in order not to make the test class too complicated and to set up them in a proper time (at the same time when the corresponding set ups for the main test are run).
      
      A mixin should be a class inherited from MixinBasedBrowserTest::Mixin. Test which wants to use some mixin should call AddMixin(mixin_) from its constructor, where mixin_ should be an instance of e.g. MixinYouWantToUse.
      
      Also, now LoginManagerTest is inherited from MixinBasedBrowserTest.
      
      BUG=395653
      
      Review URL: https://codereview.chromium.org/574703002
      
      Cr-Commit-Position: refs/heads/master@{#295954}
      dbd9c9b2
    • dgozman's avatar
      [DevTools] Move target-related methods from DevToolsHttpHandlerDelegate to DevToolsManagerDelegate. · 252e18d2
      dgozman authored
      This decouples targets discovery from remote debugging in preparation
      of moving discovery to the protocol.
      
      BUG=398049
      
      Review URL: https://codereview.chromium.org/560323005
      
      Cr-Commit-Position: refs/heads/master@{#295953}
      252e18d2
    • mcasas's avatar
      Mac VideoCapture: Support for Blackmagic DeckLink device & capabilities enumeration, using SDK. · 9b46fe68
      mcasas authored
      This CL adds a new class VideoCaptureDeviceDeckLinkMac with
      two static methods EnumerateDevices() and
      EnumerateDeviceCapabilities(). This class also has some
      empty methods to comply with VCD interface.
      
      DeckLink uses ScopedComPtr style APIs, so an internal
      template class is provided with the needed bits for automatic
      reference counting inside VCDDeckLinkMac.
      
      Static methods for enumeration are used from VCDFactoryMac.
      
      Support for Blackmagic SDK as a third party is discussed in
      http://crbug.com/408534 and is necessary prerequisite
      for landing this CL. This SDK landing is under review in
      http://crrev.com/509313002.
      
      Other CL(s) will follow to use DeckLink devices for capture.
      
      BUG=408493, 408534
      
      Review URL: https://codereview.chromium.org/518073002
      
      Cr-Commit-Position: refs/heads/master@{#295952}
      9b46fe68
    • peria's avatar
      [SyncFS] Test MetadataDatabaseTest using both on-memory and on-disk indexes · 9eed34b6
      peria authored
      BUG=409743
      TEST=unit_tests --gtest_filter="MetadataDatabaseTest*"
      
      Review URL: https://codereview.chromium.org/552723002
      
      Cr-Commit-Position: refs/heads/master@{#295951}
      9eed34b6
    • blink-deps-roller's avatar
      Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) · f57e3cf2
      blink-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/chromium/blink/+log/08e97a9..0f6e289
      
      TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org
      
      Review URL: https://codereview.chromium.org/588163003
      
      Cr-Commit-Position: refs/heads/master@{#295950}
      f57e3cf2
    • vasilii's avatar
      Disable DeviceInertialSensorBrowserTest.LightOneOffInfintyTest. · f01d1be1
      vasilii authored
      BUG=416406
      TBR=rijubrata.bhaumik@intel.com
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/592733002
      
      Cr-Commit-Position: refs/heads/master@{#295949}
      f01d1be1
    • kulkarni.a's avatar
      Added the "DISALLOW_COPY_AND_ASSIGN(Timer);" for Timer class in gin/module/timer.h. · a3eab57a
      kulkarni.a authored
      BUG=
      
      Review URL: https://codereview.chromium.org/587713002
      
      Cr-Commit-Position: refs/heads/master@{#295948}
      a3eab57a
    • vasilii's avatar
      Revert of Roll src/third_party/WebKit 08e97a9:38de67c (svn 182386:182399)... · f5d0c07d
      vasilii authored
      Revert of Roll src/third_party/WebKit 08e97a9:38de67c (svn 182386:182399) (patchset #1 id:1 of https://codereview.chromium.org/587233002/)
      
      Reason for revert:
      Compilation failure on Mac:
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/OfflineAudioCompletionEvent.idl"
      /bin/sh: line 1:  8665 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/OfflineAudioCompletionEvent.idl"
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/OscillatorNode.idl"
      /bin/sh: line 1:  8666 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/OscillatorNode.idl"
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/PannerNode.idl"
      /bin/sh: line 1:  8669 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/PannerNode.idl"
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/PeriodicWave.idl"
      /bin/sh: line 1:  8670 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/PeriodicWave.idl"
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLResultSetRowList.idl"
      /bin/sh: line 1:  8674 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLResultSetRowList.idl"
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLError.idl"
      /bin/sh: line 1:  8681 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLError.idl"
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLResultSet.idl"
      /bin/sh: line 1:  8682 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLResultSet.idl"
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLStatementCallback.idl"
      /bin/sh: line 1:  8684 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLStatementCallback.idl"
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/WaveShaperNode.idl"
      /bin/sh: line 1:  8673 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/WaveShaperNode.idl"
      FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/Database.idl"
      /bin/sh: line 1:  8676 Killed: 9               python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/Database.idl"
      2014-09-22 03:17:59.684 ibtoold[8067:707] [MT] DVTAssertions: ASSERTION FAILURE in /SourceCache/IDEInterfaceBuilder/IDEInterfaceBuilder-5056/InterfaceBuilderKit/Document/IBDocument.m:1627
      Details:  Some objects didn't get the ibBeginArchivingDocument:withContext: callback. A class has probably overridden the method without calling through to super.
      
      missing objects:
      <NSTableHeaderView:0x7fb363b91650>
      
      IBCocoaDocument:
        <NSCustomObject:0x7fb363bf25d0> id=-2
        <NSCustomObject:0x7fb363bf2670> id=-1
        <NSCustomObject:0x7fb363bf2690> id=-3
        <NSWindowTemplate:0x7fb363bf26d0> id=1
          <NSView:0x7fb363bf29d0> id=2 relationship=contentView frame={{0, 0}, {480, 268}}
            <NSCustomView:0x7fb363bf2e90> id=36 relationship=ibDesignableContentView.ibShadowedSubviews frame={{269, -2}, {211, 52}}
              <NSButton:0x7fb363bf3e60> id=7 relationship=ibDesignableContentView.ibShadowedSubviews frame={{5, 12}, {96, 32}} layoutFrame={{11, 19}, {84, 21}}
                <NSButtonCell:0x7fb363bf3f30> id=8 relationship=cell
              <NSButton:0x7fb363bf3230> id=5 relationship=ibDesignableContentView.ibShadowedSubviews frame={{101, 12}, {96, 32}} layoutFrame={{107, 19}, {84, 21}}
                <NSButtonCell:0x7fb363bf3730> id=6 relationship=cell
            <NSCustomView:0x7fb363bf4370> id=40 relationship=ibDesignableContentView.ibShadowedSubviews frame={{0, 205}, {71, 32}}
              <NSTextField:0x7fb363bf4610> id=9 relationship=ibDesignableContentView.ibShadowedSubviews frame={{17, 6}, {50, 17}} layoutFrame={{20, 6}, {44, 17}}
                <NSTextFieldCell:0x7fb363bf4a70> id=10 relationship=cell
            <NSCustomView:0x7fb363bf7170> id=44 relationship=ibDesignableContentView.ibShadowedSubviews frame={{0, -2}, {139, 52}}
              <NSButton:0x7fb363bf73c0> id=3 relationship=ibDesignableContentView.ibShadowedSubviews frame={{14, 12}, {111, 32}} layoutFrame={{20, 19}, {99, 21}}
                <NSButtonCell:0x7fb363bf7630> id=4 relationship=cell
            <NSTextField:0x7fb363bf77c0> id=13 relationship=ibDesignableContentView.ibShadowedSubviews frame={{74, 210}, {386, 22}}
              <NSTextFieldCell:0x7fb363bf7890> id=14 relationship=cell
            <NSScrollView:0x7fb363bf7da0> id=67 relationship=ibDesignableContentView.ibShadowedSubviews frame={{20, 50}, {440, 147}}
              <NSOutlineView:0x7fb363bf8b70> id=69 relationship=documentView frame={{0, 0}, {438, 129}}
                <NSTableColumn:0x7fb363c75c80> id=72 relationships=(outlineTableColumn, ibShadowedTableColumns)
                  <NSTextFieldCell:0x7fb363bf9880> id=73 relationship=dataCell
              <NSScroller:0x7fb363c019a0> id=71 relationship=verticalScroller frame={{423, 17}, {16, 129}}
              <NSScroller:0x7fb363c02a70> id=70 relationship=horizontalScroller frame={{1, 130}, {438, 16}}
            <NSCustomView:0x7fb363c028a0> id=90 relationship=ibDesignableContentView.ibShadowedSubviews frame={{0, 236}, {460, 32}}
              <NSTextField:0x7fb363c05f00> id=91 relationship=ibDesignableContentView.ibShadowedSubviews frame={{17, 5}, {216, 17}} layoutFrame={{20, 5}, {210, 17}}
                <NSTextFieldCell:0x7fb363c03c90> id=92 relationship=cell
        <NSCustomObject:0x7fb363c058d0> id=34
        <NSCustomObject:0x7fb363bf26b0> id=37
        <NSTreeController:0x7fb363c069f0> id=74
      
      Object:   <IBCocoaDocument: 0x7fb365803e00>
      Method:   -willArchiveWithContext:
      Thread:   <NSThread: 0x7fb361419330>{name = (null), num = 1}
      Hints: None
      Backtrace:
        0  0x0000000108a75ac1 -[DVTAssertionHandler handleFailureInMethod:object:fileName:lineNumber:assertionSignature:messageFormat:arguments:] (in DVTFoundation)
        1  0x0000000108a75519 _DVTAssertionHandler (in DVTFoundation)
        2  0x0000000108a757ff _DVTAssertionFailureHandler (in DVTFoundation)
        3  0x0000000107aae172 -[IBDocument willArchiveWithContext:] (in IDEInterfaceBuilderKit)
        4  0x000000010e28773e IBCompileKeyedObjectsData (in IDEInterfaceBuilderCocoaIntegration)
        5  0x000000010e28762e -[IBCocoaDocument compiledKeyedObjectsDataWithOptionserror:] (in IDEInterfaceBuilderCocoaIntegration)
        6  0x000000010e287afa -[IBCocoaDocument internalCompiledPackageWithOptionserror:] (in IDEInterfaceBuilderCocoaIntegration)
        7  0x0000000107ac67b1 __47-[IBDocument compiledPackageWithOptionserror:]_block_invoke (in IDEInterfaceBuilderKit)
        8  0x0000000107aeb0c9 -[IBDocument assertIfArbitrationIsScheduledDuring:] (in IDEInterfaceBuilderKit)
        9  0x0000000107ac6722 -[IBDocument compiledPackageWithOptionserror:] (in IDEInterfaceBuilderKit)
       10  0x000000010789ef8b (in ibtoold)
       11  0x00000001078a23ad (in ibtoold)
       12  0x00000001078acb65 (in ibtoold)
       13  0x00000001078ad0c0 (in ibtoold)
       14  0x00000001078acf90 (in ibtoold)
       15  0x00000001078ab3e7 (in ibtoold)
       16  0x00000001078ac7b7 (in ibtoold)
       17  0x00000001078abd6e (in ibtoold)
       18  0x00007fff978607e1 start (in libdyld.dylib)
      ninja: build stopped: subcommand failed.
      
      Original issue's description:
      > Roll src/third_party/WebKit 08e97a9:38de67c (svn 182386:182399)
      >
      > Summary of changes available at:
      > https://chromium.googlesource.com/chromium/blink/+log/08e97a9..38de67c
      >
      > TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org
      >
      > Committed: https://crrev.com/f838f453af2d146a6bdd0f960f2edce0c03d4c27
      > Cr-Commit-Position: refs/heads/master@{#295946}
      
      TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/590103002
      
      Cr-Commit-Position: refs/heads/master@{#295947}
      f5d0c07d
    • blink-deps-roller's avatar
      Roll src/third_party/WebKit 08e97a9:38de67c (svn 182386:182399) · f838f453
      blink-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/chromium/blink/+log/08e97a9..38de67c
      
      TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org
      
      Review URL: https://codereview.chromium.org/587233002
      
      Cr-Commit-Position: refs/heads/master@{#295946}
      f838f453
    • hirono's avatar
      Gallery: Fix a beginning position gap of cropping. · 3b3280d7
      hirono authored
      The gap occures when a user moves the mouse cursor fast at the beginning of
      cropping. The reason the app uses the first mousemove event's coordinate as the
      beginning position of cropping.  The CL uses the mousedown event's coordinate
      instead of the first mousemove's one.
      
      BUG=412237
      TEST=manually
      
      Review URL: https://codereview.chromium.org/590073002
      
      Cr-Commit-Position: refs/heads/master@{#295945}
      3b3280d7
    • dzhioev's avatar
      Added 'contextReady' message for HostPairingScreen. · b817eec5
      dzhioev authored
      Sometimes the screen starts to send updates to JS part to early, when screen
      is not registered yet. As a result several messages with context diffs could
      be ignored, and JS context became inconsistent with C++ context. I added
      'contextReady' message, that is send from JS when context is ready to recieve
      updates. Before that the screen handler caches changes in the local context.
      
      BUG=375191
      
      Review URL: https://codereview.chromium.org/581593003
      
      Cr-Commit-Position: refs/heads/master@{#295944}
      b817eec5
    • wensheng.he's avatar
      dmprof expand command supports to analyze unhooked components · 0599b145
      wensheng.he authored
      Currently when analyze the memory usage details of the unhooked components, like unhooked-other, the dmprof expand command does nothing. The purpose of this patch is to enhance 'dmprof expand' command. As unhooked maps have no call stack traces, the result just filters MMAP_LIST items in *.heap files, which belongs to current component specified by the command parameter.
      
      R=kouhei@chromium.org
      BUG=416314
      
      Review URL: https://codereview.chromium.org/587193002
      
      Cr-Commit-Position: refs/heads/master@{#295943}
      0599b145
    • mgiuca's avatar
      App list: Crop all switcher button icons to 24x24. · 6daafb75
      mgiuca authored
      Previously, the images had padding to make them 32x32 (the size of the
      button). Now the button size is set programmatically, so the images can
      be as small as the actual graphic within.
      
      BUG=411775
      
      Review URL: https://codereview.chromium.org/579093002
      
      Cr-Commit-Position: refs/heads/master@{#295942}
      6daafb75
    • v8-autoroll's avatar
      Update V8 to version 3.29.70.1 (merged r24071). · fcfc3c49
      v8-autoroll authored
      TBR=machenbach@chromium.org
      
      Review URL: https://codereview.chromium.org/590833003
      
      Cr-Commit-Position: refs/heads/master@{#295941}
      fcfc3c49
    • xiang.long's avatar
      ServiceWorker: Change worker script fetch error code. · 1987a826
      xiang.long authored
      Change worker script fetch error code in "Update" algorithm to align
      with spec:
      Non 2xx response will be rejected with NetworkError;
      Redirected response will be rejected with SecurityError;
      Reponse with Wrong MIME type will be rejected with SecurityError.
      
      (1/3): https://codereview.chromium.org/546353003/
      (2/3): this
      (3/3): Layout test & Blink side cleanup
      
      BUG=408421
      TEST=http/tests/serviceworker
      
      Review URL: https://codereview.chromium.org/567903002
      
      Cr-Commit-Position: refs/heads/master@{#295940}
      1987a826
    • sdefresne's avatar
      Add wfh@chromium.org to ipc OWNERS files · 71926f1a
      sdefresne authored
      Followup to https://codereview.chromium.org/550503003 that missed
      //content/public/common/OWNERS.
      
      BUG=None
      
      Review URL: https://codereview.chromium.org/588493003
      
      Cr-Commit-Position: refs/heads/master@{#295939}
      71926f1a
    • loislo's avatar
      Quick fix for windows try bots flakiness. · 0ef3f039
      loislo authored
      It was a race between animation scheduled by WebTestProxyBase and ResourceLoader which received the test script content.
      
      In case of failure I see the next sequence of top level events:
      1) RootGraphicsLayer was cleared
      2) html resource arrived and animation was scheduled
      3) js resource arrived, onload event handler was called and the test finished in the ASSERT
      
      The expected sequence of top level events:
      1) RootGraphicsLayer was cleared
      2) html resource arrived and animation was scheduled
      3) scheduled animation was executed
      4) js resource arrived, onload event handler was called and the test finished successfully
      
      The simplest solution is to run pending animations.
      
      BUG=397321
      
      Review URL: https://codereview.chromium.org/581983002
      
      Cr-Commit-Position: refs/heads/master@{#295938}
      0ef3f039
    • rijubrata.bhaumik's avatar
      [DeviceLight] Browser+java part · f07da397
      rijubrata.bhaumik authored
      This is part 2 of the Adding Device Light [content side]
      Adding the Browser and Java part in the content side for the
      DeviceLight API.
      
      BUG=336424
      
      Review URL: https://codereview.chromium.org/292693004
      
      Cr-Commit-Position: refs/heads/master@{#295937}
      f07da397
    • jochen's avatar
      Roll pdfium to 0c53324 · d6a52053
      jochen authored
      0c53324 Invoke V8::Initialize() explicitly during V8 setup
      c5cab02 Add FPDF_GetSecurityHandlerRevision
      
      TBR=jam@chromium.org
      BUG=none
      
      Review URL: https://codereview.chromium.org/588113003
      
      Cr-Commit-Position: refs/heads/master@{#295936}
      d6a52053
    • perkj's avatar
      Replacing OWNERS in third_party/libjingle/libjingle.gyp · 53a3bdee
      perkj authored
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/583183003
      
      Cr-Commit-Position: refs/heads/master@{#295935}
      53a3bdee
    • mgiuca's avatar
      Experimental launcher: Switcher buttons are larger and centered. · 2177f5fd
      mgiuca authored
      Buttons are now 39x39, giving them bigger click/tap target zones,
      spacing them further apart, and centering them within the switcher area.
      The actual image sizes have not changed.
      
      Moved the separator line up 1px to make room and to match the mocks.
      
      Also added a new test of the exact dimensions of the app launcher, to
      make sure we don't accidentally enlarge the window (which would have
      been easy to accidentally do in this patch).
      
      BUG=411775
      
      Review URL: https://codereview.chromium.org/581923002
      
      Cr-Commit-Position: refs/heads/master@{#295934}
      2177f5fd
    • mithro's avatar
      Enable debugging symbols to always use DWARF-4 format. · fb34b348
      mithro authored
      Adding -gdwarf-4 to make DWARF-4 the output format.
       * gcc 4.6 outputs DWARF-2 by default
       * gcc 4.7 outputs DWARF-4 by default
       * clang <3.4 outputs DWARF-3 by default
       * clang >3.4 outputs DWARF-4 by default
      
      DWARF-4 is the latest debug output format which includes features for
      macro-expansion, better var tracking and other similar options.
      
      From http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html
      > -gdwarf-4
      >  Produce debugging information in DWARF format (if that is
      >  supported). The value of version may be either 2, 3 or 4; the
      >  default version for most targets is 4.  Note that with DWARF
      >  Version 2, some ports require and always use some non-conflicting
      >  DWARF 3 extensions in the unwind tables.
      >
      >  Version 4 may require GDB 7.0 and -fvar-tracking-assignments for
      >  maximum benefit.
      
      BUG=
      
      Review URL: https://codereview.chromium.org/198363002
      
      Cr-Commit-Position: refs/heads/master@{#295933}
      fb34b348
    • alekseys's avatar
      Add Print Preview UI to accept and reject printer sharing invitations. · 67d48589
      alekseys authored
      BUG=397741
      
      Review URL: https://codereview.chromium.org/587013003
      
      Cr-Commit-Position: refs/heads/master@{#295932}
      67d48589
    • chromeos-commit-bot's avatar
      Automated Commit: Committing new LKGM version 6289.0.0 for chromeos. · fa3be437
      chromeos-commit-bot authored
      Cr-Commit-Position: refs/heads/master@{#295931}
      fa3be437
    • shreeram.k's avatar
      DumpAccessibilityTreeTest.AccessibilitySource is failing. · 33b2e1d3
      shreeram.k authored
      Skipping the test case for source tag. This might be failing because still there are issues related with audio tags control attribute.
      
      BUG=411987
      
      Review URL: https://codereview.chromium.org/585093004
      
      Cr-Commit-Position: refs/heads/master@{#295930}
      33b2e1d3
    • blink-deps-roller's avatar
      Roll src/third_party/WebKit 8bc0f5b:08e97a9 (svn 182377:182386) · 49057a04
      blink-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/chromium/blink/+log/8bc0f5b..08e97a9
      
      TBR=
      
      Review URL: https://codereview.chromium.org/586423002
      
      Cr-Commit-Position: refs/heads/master@{#295929}
      49057a04
    • mgiuca's avatar
      Experimental app list: Remove page indicator. · a1fbd2bd
      mgiuca authored
      This is a partial revert of commit 6c4617fc (r282586), "Experimental app
      list: Added a current page indicator to the launcher.".
      
      Latest mocks indicate the selected page by changing its icon to blue,
      rather than having a blue line above the icon. The reason we are
      removing this now is for spacing reasons -- we need to move the grey
      separator line up by 1px but the blue line can't be moved up unless we
      shrink the contents view.
      
      BUG=411775
      
      Review URL: https://codereview.chromium.org/590023002
      
      Cr-Commit-Position: refs/heads/master@{#295928}
      a1fbd2bd
    • ericwilligers's avatar
      Retire obsolete Valgrind supressions ..99435 · 73c43af2
      ericwilligers authored
      The following supressions are no longer needed:
      bug_94195
      bug_94345
      bug_96069
      bug_96568a
      bug_96568b
      bug_98568
      bug_99304
      bug_99308
      bug_99321
      bug_99435
      
      BUG=94195,94345,96069,98568,99304,99308,99321,99435
      TBR=groby@chromium.org
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/593593002
      
      Cr-Commit-Position: refs/heads/master@{#295927}
      73c43af2
    • anand.ratn's avatar
      Declaring the weak_ptr_factory in proper order. · 37571758
      anand.ratn authored
      Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/history"
      module. WeakPtrFactory should remain the last member so it'll be destroyed and
      invalidate its weak pointers before any other members are destroyed.
      
      BUG=303818
      
      Review URL: https://codereview.chromium.org/574313002
      
      Cr-Commit-Position: refs/heads/master@{#295926}
      37571758
    • vitalybuka's avatar
      GCP 2.0 prototype switches code cleanup. · 8e584114
      vitalybuka authored
      TBR=gene@chromium.org
      
      Review URL: https://codereview.chromium.org/587103002
      
      Cr-Commit-Position: refs/heads/master@{#295925}
      8e584114
    • skia-deps-roller's avatar
      Roll src/third_party/skia 29c857d:a392c9d · b44e7c8f
      skia-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/skia/+log/29c857d..a392c9d
      
      CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
      TBR=borenet@google.com
      
      Review URL: https://codereview.chromium.org/593553002
      
      Cr-Commit-Position: refs/heads/master@{#295924}
      b44e7c8f
    • anand.ratn's avatar
      Declaring the weak_ptr_factory in proper order. · d35b99c4
      anand.ratn authored
      Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/chromeos"
      module. WeakPtrFactory should remain the last member so it'll be destroyed and
      invalidate its weak pointers before any other members are destroyed.
      
      BUG=303818
      
      Review URL: https://codereview.chromium.org/572873002
      
      Cr-Commit-Position: refs/heads/master@{#295923}
      d35b99c4
    • pkotwicz's avatar
      Disables the maximize button for an app window with a maximum size and a custom frame color · b1400bfb
      pkotwicz authored
      BUG=416214
      TEST=Manual, see bug
      
      Review URL: https://codereview.chromium.org/588873002
      
      Cr-Commit-Position: refs/heads/master@{#295922}
      b1400bfb
    • pdr's avatar
      Add note about dev channel UseCount skew to dashboard summary. · 49ce0fa0
      pdr authored
      This patch adds a note to the FeatureObserver summary in histograms.xml
      about the incorrect numbers due to crbug.com/341631.
      
      BUG=341631
      
      Review URL: https://codereview.chromium.org/160773002
      
      Cr-Commit-Position: refs/heads/master@{#295921}
      49ce0fa0
    • haraken's avatar
      MediaStream content_unittests need to trigger a GC before tear down · 02b15d5a
      haraken authored
      Given that MediaStream objects in the Blink side are allocated on Oilpan's heap, we need to trigger a GC to collect MediaStream objects in the Chromium side that depend on the lifetime of the MediaStream objects in the Blink side.
      
      This CL adds Heap::collectAllGarbage to TearDown methods of MediaStream content_unittests. This guarantees that MediaStream objects used in the content_unittests are collected before the content_unittests finish. Otherwise, the LSan complains that the MediaStream objects leak in the content_unittests.
      
      This is an issue that happens only in testing.
      
      BUG=340522
      
      Review URL: https://codereview.chromium.org/566793002
      
      Cr-Commit-Position: refs/heads/master@{#295920}
      02b15d5a
    • gajendra.n's avatar
      Color picker window should not have a minimize button. · a0aab5b4
      gajendra.n authored
      Adding CanMinimize() (like CanMaximize()) function to WidgetDelegate class.
      So that ColorChooserView or any other view inheriting WidgetDelegate, can
      decide whether its window can show minimize button.
      
      BUG=365768
      
      R=sadrul@chromium.org
      
      TEST=
      1. Go to a page with <input type=color>. Here is one http://jsbin.com/yotasure/1
      2. Click on the color input button to bring up the color picker window and observe
      3. Color picker window should not have minimize button.
      
      Review URL: https://codereview.chromium.org/567463002
      
      Cr-Commit-Position: refs/heads/master@{#295919}
      a0aab5b4
    • mtomasz's avatar
      Restrict the File System Provier API permission to Chrome OS only. · bbe75265
      mtomasz authored
      This API implementation is compiled on Chrome OS only, so the permission should
      be available on Chrome OS only.
      
      TEST=Tested manually that still works on Chrome OS.
      BUG=248427
      
      Review URL: https://codereview.chromium.org/581303002
      
      Cr-Commit-Position: refs/heads/master@{#295918}
      bbe75265
    • mgiuca's avatar
      views::ImageButton: Added SetMinimumImageSize; removed SetPreferredSize. · 306b915c
      mgiuca authored
      ImageButton::SetMinimumImageSize allows the client to explicitly set a
      size larger than the image contained within the button. The image will
      be aligned inside the button according to its alignment setting.
      
      ImageButton::SetPreferredSize had a misleading name (since in fact it
      only sets the size when there is no image) and is no longer needed. Its
      original usage (r50040) is now gone. It wasn't having any effect in
      either of its two remaining callers, since they always set an image
      immediately afterwards. Therefore, deleted this method and removed both
      calls to it. Note that we are keeping the default behaviour that an
      ImageButton with no image has a size of 16x14. I wanted to remove this,
      but the list of potential clients that could be relying on it is huge.
      
      BUG=415909
      
      Review URL: https://codereview.chromium.org/583843003
      
      Cr-Commit-Position: refs/heads/master@{#295917}
      306b915c
    • jamescook's avatar
      Remove AppDelegate::GetAppDefaultIcon · 07cad335
      jamescook authored
      The default app icon resource exists in the //extensions module resources
      file and all implementations return the same icon. There's no need to delegate
      this out.
      
      BUG=none
      TEST=app_shell, athena_main and chrome all run in debug without assertions
      about missing resources
      
      Review URL: https://codereview.chromium.org/586853004
      
      Cr-Commit-Position: refs/heads/master@{#295916}
      07cad335