- 05 Mar, 2020 35 commits
-
-
Ken Rockot authored
This picks some low-hanging fruit in the effort to decompose Blink mojom into smaller targets. Bug: 1058621 Change-Id: Iaf1a8efffa43f64ea7e618555262b929235ca2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088677Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#747044}
-
Hongchan Choi authored
In cross-thread messaging, the associated execution context can be already gone when a posted task is performed sometime later in the task runner's queue. By using WeakPtr, the task runner will not perform a scheduled task in the queue when the target object is invalid. Bug: 1057735 Change-Id: I3f218ad073ff5f6dcb08aba176d722c5c729316b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086051Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747043}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/93d75eff08b0..628f3e70ee01 git log 93d75eff08b0..628f3e70ee01 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 nifong@google.com Remove experimental from name of skm44 canvas methods 2020-03-04 robertphillips@google.com Surface GrFillRectOp programs on DDLs 2020-03-04 dmazzoni@chromium.org Tiny fix to two attributes of PDF tags 2020-03-04 robertphillips@google.com Surface GrDashOp programs on the DDL 2020-03-04 robertphillips@google.com Surface programs at record time for the oval ops Created with: gclient setdep -r src/third_party/skia@628f3e70ee01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:607777 Tbr: herb@google.com Change-Id: I8d4bc9614ea8ce62ab660c37e0218745ea50035a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088457Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747042}
-
David Schinazi authored
Now that we have confirmed that 10000 is the correct limit here, remove the histogram and add a comment with the relevant data. Bug: 1053079 Change-Id: Idd767fb995295419f8b97c04960acadf445d56f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083993 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#747041}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d68f43bd4d5f..97a3ce0918a0 git log d68f43bd4d5f..97a3ce0918a0 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 android-build-automerger-merge-worker@system.gserviceaccount.com Merge "Add convenience script for java heap profiles." am: f82ee37c27 Created with: gclient setdep -r src/third_party/perfetto@97a3ce0918a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9277bf153d684d34c5da56b341a549bd46b02555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088456Reviewed-by:
-
Jing Wang authored
TEST: tested with a test device. Bug: 1042084 Change-Id: I5f7cd1b382b34f62eae6642a719c1123df66133f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083772 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#747039}
-
nancy authored
Follow up: Modify the app block dialog to use the kite icon for the child profile. BUG=1056488 Change-Id: I53791120a93cffb4f67e90f7a75a934607db51c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081725Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747038}
-
Tibor Goldschwendt authored
Adds a generic chrome-untrusted://new-tab-page/image?<image url> page that creates an iframe displaying the image at |image url|. Uses this URL to create iframes showing background collection and preview images. Additionally, add a ntp-untrusted-iframe element that abstracts away the actual iframe so that we can prevent iframe loading in tests. Change-Id: I5d3c9c5144382c748615e33960d16b36810e852b Bug: 1032328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079793Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#747037}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic3c7eee2d5bd675ce19165918068da5fe2054ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088466Reviewed-by:
-
Alex Danilo authored
Adds a custom element implementation courtesy of noel@chromium.org that handles layout of a set of navigation buttons that elide when there are more than 4 sub-path entries, and presents a drop-down menu containing the elided sub-paths. Hook this custom element into the existing location line code for files-ng. Add its source file to the BUILD and to closure compile build dependencies. Bug: 1035691 Change-Id: I85f7cf3c552320775dd34bbf5cf96a422b355f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079773 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747035}
-
Peter Kasting authored
This also adds a one-arg Widget constructor as sugar for creating the widget and then immediately calling Init(). Making more use of that will happen in a followup patch. Bug: none Change-Id: I8de0e64d5d094f99e2365505fde4088a64104b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076551 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#747034}
-
Jan Wilken Dörrie authored
This change implements the passwordsPrivate.removeCompromisedCredential extension API. This allows callers to remove a specific compromised credential from the password store. The caller is informed whether the remove operation succeeded via a callback. Bug: 1047726 Change-Id: I9b39fa2350d6d87d551bde06e2baab9ec82bdb3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082384 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747033}
-
Clark DuVall authored
This required moving a few of the other permissions java files as well. A PermissionsClient.java class was added to call into embedder specific logic in AndroidPermissionRequester. We may not need to support infobars in WebLayer, so the bulk of the infobar logic has been kept in //chrome. The xtb files for the android strings were generated from the same script that was used in http://crrev.com/c/1966700. Bug: 1025609 Change-Id: I6ea6f7380cee4de6590b9a906852fa4b2ce8f89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083714 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#747032}
-
Jose Lopes authored
This is a once callback because it is run whe the EncodeVideoFrame method completes, as documented in: * https://cs.chromium.org/chromium/src/media/cast/sender/video_encoder.h?l=27&gsn=FrameEncodedCallback * https://cs.chromium.org/chromium/src/media/cast/sender/video_encoder.h?rcl=d00d2b00c0d2b47044ea1816d51ad559d2bdcfd3&l=48 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I3e62ce9a72e632b0aa87dd2d3f839e862b63af6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074503 Auto-Submit: Jose Lopes <jabolopes@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747031}
-
Eric Willigers authored
The files - pwa_confirmation_bubble_view* - web_app_confirmation_view* - web_app_info_image_source* do not use extensions, and now appear in chrome/browser/ui/views/web_apps/ Bug: 953540 Change-Id: I6f496edc3d522d6059f82f46af7f88ba716875d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086464 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#747030}
-
Jon Mann authored
This is to allow us to store information about particular networks that is not needed by Shill. To start, this will contain the timestamp of the last successful connection to Wi-Fi networks. Bug: 966270 Change-Id: I288d8b990670cd8b541849d762ef0248af4d7152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085676Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#747029}
-
Aya ElAttar authored
There are 2 warnings can be displayed on the login screen for the managed guest session based on the force-install extensions list. Currently the message is selected based on a static list of white-listed extensions IDs. This behaviour is extended to decide the warning message based on the extensions permissions if the extensions ID is not white-listed. The local state file is updated accordingly, and the default value for the first time is to display the complete warning message. The current behaviour for displaying the login screen warnings won't be switched now to this new behaviour. This will be made in a separate cl. Bug: 1015378 Change-Id: Ic339e5480794e3c3d084f4290f6faa3ac6e3045e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960281 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747028}
-
Natalie Chouinard authored
Move Clear Browsing Data settings alongside other Browsing Data code, and update associated OWNERS files. Bug: 1047357 Change-Id: Idcb8a642beb9ca221b9ad0a56aa523c0b02b580f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075049 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#747027}
-
Avery Musbach authored
Based on the UX design linked on Monorail. Test: All/SplitViewOverviewSession*SquareBracket* Change-Id: I1a486481f938183b330f65c9b3951767f56937f2 Fixed: 1045990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068895 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#747026}
-
Henrique Ferreiro authored
The prefix native_ does not add any meaning here. Bug: 1040499 Change-Id: If4893a27a178784c1464cd21347a774e15736559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081421 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#747025}
-
David Van Cleve authored
Landing a field trial testing config to change the default referrer policy led to a number of pings from perf "regressions". Erik Chen suggested that this might be due to Web Page Replay not acting well when page JS starts following new code paths (which latter might very plausibly have happened because the change in question sometimes alters the return value of a commonly-used JS API). The plan is to reland the field trial testing config---which re-enables the change in tests---and re-baseline the perf stories that recorded large (positive or negative) metric changes: see crbug.com/1056329. == Begin original commit message We're going to 50% beta on this feature (changing the default referrer policy to strict-origin-when-cross-origin) so it's time to add a field trial testing config. Also updates the following tests, which were failing with the testing config enabled: - ContextMenuBrowserTest.OpenInNewTabReferrer - DownloadReferrerPolicyTest.DownloadCrossDomainReferrerPolicy Bug: 1014207, 1056329 Change-Id: I6fb0006e1f89fd7f2943f102f72caf54fb389716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044713 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#747024}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings search page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: Ie04f612f36480376dde981a8d475bb806eb0c44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070540Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#747023}
-
Reid Kleckner authored
TBR=haraken@chromium.org, omerkatz@chromium.org Bug: 1058608 Change-Id: I03330f4aecf276cf994cb34362e3605b616e3886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088637Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#747022}
-
Noel Gordon authored
In files-ng, the tool bar info button has a different id #info-button, than the id #metadata-button used for non-files-ng. Fix button toggle test: switch on the button name for files-ng. Rename the test to openQuickViewToggleInfoButtonKeyboard to match the rest of the test names. Add a openQuickViewToggleInfoButtonClick test to cover that case while here. These tests pass in files-ng and not. CL:2082227 deals with the files- ng case on the bots. Test: browser_tests --gtest_filter="*QuickViewToogleInfoButton*" Bug: 992824, 992818 Change-Id: I7b90a70731b2b21d765785930c99e7c5c3f4f0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087296Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fbc7ed0d7116..43d8e93fa7bf git log fbc7ed0d7116..43d8e93fa7bf --date=short --first-parent --format='%ad %ae %s' 2020-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8d9e658d..2d9b6439 (746798:746902) Created with: gclient setdep -r src/third_party/webrtc@43d8e93fa7bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3abe5b8233e0f9fba7e7c1bfe9cba8cd217f0615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088458Reviewed-by:
-
Shakti Sahu authored
We should open offline pages in incognito mode when opening from download home. This CL adds support to OfflineContentProvider::openItem to propagate this information from the UI layer, through backend and finally to custom tab. Remaining issues : 1 - Open downloads in incognito as well. This will require passing the param through DownloadItem::OpenDownload and the chain of delegates to java layer. 2 - There is still an issue where NTP incognito when opened first time doesn't set the incognito value correctly. 3 - Determine whether we need the same from desktop download shelf. 4 - Tests aren't updated yet for the API change. Bug: 651995 Change-Id: I939204a9108807bd89cc1b51d5891fa8aa8a07f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082019 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#747019}
-
Nina Satragno authored
When an excluded credential is found, the spec says InvalidStateError should be returned. The test was expecting a NotAllowedError, fix that. Bug: 875444 Change-Id: I034ea2c270909895f8935a5c5a4d659b6c7327dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088000 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#747018}
-
btolsch authored
TBR=tbarzic@chromium.org Bug: 1057814, 1057777 Change-Id: Iedad8ba38e635ad969e55e971394d30f71c994b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088672Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#747017}
-
Alexey Baskakov authored
Historically, we stored OS-specific shortcut files in a directory, specified by GetWebAppDataDirectory function: <ProfileDir> Web Applications _crx_<app_id> From now, we have a clear separation between Manifest Resources vs. OS-specific integration Resources. (see https://chromium-review.googlesource.com/c/chromium/src/+/2084215) We should rename GetWebAppDataDirectory function to GetOsIntegrationResourcesDirectoryForApp to reflect this change. We can't rename the underlying directory name: it would require a migration for all existing user profiles in the wild. This CL doesn't introduce any behavior changes. Bug: 877898 Change-Id: I41a636b2a86afa4196d68e5cc3f236d3e813cdbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086459 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Change-Id: Ic7b137d39ac73f280c307e0af53125df957451c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088015Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
Link to recent failures: http://shortn/_HrAAo0lrn8 TBR=sandromaggi@chromium.org Bug: 1058599 Change-Id: I71a98fb1b0a38e65eef9b331ac544cf955d3b33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088298Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#747014}
-
Pavol Marko authored
The feature is being used for packaged licenses and maybe also for initial enrollment soon, so the histograms are still interesting. Bug: 1053198, 1053197, 1053196, 1053195, 1053194 Change-Id: I6a1857c08e0150491b3511b7740d04f5174a662b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078912 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#747013}
-
Daniel Clark authored
Reland "Fix null check preventing AXObjectCacheImpl from registering as popup document lifecycle observer" The change was reverted because a couple of the updated tests were failing on older mac platforms. Apparently opening the date/week popops fires different numbers of events on these platforms. Since the point of the tests is to observe events fired from focus changes in an opened popup, I changed the tests to start logging events only after opening the popup. I've also modified them to provide some logging in the event of a failure instead of just timing out opaquely. Initial change description follows: Fix the polarity on a couple of null checks that were preventing AXObjectCacheImpl from registering as a lifecycle notification observer for popup documents. This failure to register was preventing AX focus events from being fired when focus changed inside of a popup. The week-picker-ax.html test was passing prematurely because of focus events received when opening the popup, without validating that additional events were fired when changing focus in the popup. Update that test to confirm that events are also fired for a focus change in the popup itself. There were a couple of analogous tests (date-picker-ax.html, month-picker.html) that were deleted when we purged old date popup tests in favor of new tests written for the new popup implementation (crrev.com/c/1967608). I don't see replacements for these in the new tests, so this change also restores those tests, updates them for the structure of the new form controls, and ensures that they are checking that focus events are fired due to changes in the popups and not just from events fired when the popups open. TBR=aboxhall@chromium.org Bug: 1022920, 1057036, 1057044 Change-Id: I8792ea074e89967c7ff68e21dfda8e0f6ba6f9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080459 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#747012}
-
Jae Hoon Kim authored
DlcserviceClient should make the life of callers as easy as possible. Since dlcservice returns a busy status: - when a platform side dlcservice client starts an installation. - when update_engine is busy performing actions. This change allows callers in Chrome to not worry about the busy status. BUG=chromium:1053745 TEST=out/Default/unit_tests --gtest_filter=Dlcservice* Change-Id: Iae6a75567345c3615662dddde2479141ab80098a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079213Reviewed-by:
-
Richard Townsend authored
armasm64.exe is Microsoft's reference compiler for 64-bit Arm assembly code. This is needed to make sure that V8 can be tested and cross-compiled under MSVC for Windows on Arm systems. Bug: v8:10012 Change-Id: Id1b9ab7bb0cc96179a707e9746f9e78e8da30de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071941 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#747010}
-
- 04 Mar, 2020 5 commits
-
-
Tina Wang authored
- CreatorMetaData stores the creator's general info. - Pass NavigationHandle object to EntryPointCoordinator as a input to fetch data. - Delete ProfileCardData because the creator meta data and the content preview data will be fetched separately. - Added DEPS Bug: 1057256 Change-Id: Iba41128235f04663c33a05f241e99faefe603304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079268Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747009}
-
James Forshaw authored
This CL adds support to the sandbox to define a random restricted SID for a single process. This combined with modifications to the DACL allows a process to access itself but no other process defined using the same lockdown type. This CL does not currently enable it for any sandbox type. Bug: 1057218 Change-Id: Iadd98cdc7331f5fe0c9ae8f414be8af64c5eeb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085751Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#747008}
-
Bailey Berro authored
This change adds a boolean histogram to track the result of a user reaching the DisplayChangeDialog Bug: 1051235 Change-Id: I483742dff98bd542dadfe1b46854e43b85ded6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050791 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#747007}
-
Bailey Berro authored
This change extends Hardware.Display.Count.OnStartup and Hardware.Display.Count.OnChange through June. Change-Id: I9a4e4fc1a72be7dc7d8d3a527bcd29ccfaa05777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071328 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of moving OS specific strings from settings_strings.grdp to os_settings_strings.grdp, specifically app section page strings. Bug: 967883 Change-Id: If69eedde2e9ee88c06aea91d73b3f744340249a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064827 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
