- 08 Oct, 2018 40 commits
-
-
Mirko Bonadei authored
WebRTC is trying to split rtc_base_approved and rtc_base, this CL avoids to rely on rtc_base_approved public_deps to depend on timeutils. Bug: webrtc:9838 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I94d8fdf216f71c56d42bd483d718fd22015a920c Reviewed-on: https://chromium-review.googlesource.com/c/1268277Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#597647}
-
Malay Keshav authored
This patch integrates SkiaVectorAnimation class with the views framework. Since most of the code is shared with ImageView, a new virtual super class is introduced, ImageViewBase. AnimatedImageView is added as a subclass of this virtual class. For now the integration class is a very basic view that can play and stop a given Skia vector animation at a custom size. This patch also adds an example to views/examples to load animations and play. Design doc: go/cros-skottie Bug: 890221 Change-Id: I55d7310ef74cdfb825cce441c8e61eadff9c5616 Component: Views, examples, skottie, SkiaVectorAnimation Reviewed-on: https://chromium-review.googlesource.com/c/1262967 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#597646}
-
Kristi Park authored
Implement Chrome sync for Custom Links. If the kCustomLinksList pref is updated remotely, refresh the current list of links and notify the associated callbacks. Bug: 861831 Change-Id: I6448eaa9615954f73673b4518d12a9c33b7cf377 Reviewed-on: https://chromium-review.googlesource.com/c/1263593 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#597645}
-
Victor Costan authored
Change-Id: I6af2fa3afea5c0d833f67501a31856511a1d064b Reviewed-on: https://chromium-review.googlesource.com/c/1266885Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#597644}
-
Scott Violet authored
This reverts commit e8aa5e34. Reason for revert: Looks to have broken build. Original change's description: > latency_info: remove unnecessary dep > > latency_info was including and depending upon gfx, but it isn't actually > using anything from there. This removes the deps and fixs the targets that > were using gfx. > > BUG=none > TEST=none > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I7f5f04316b9d11d55ed442d99e34e4155e36566a > Reviewed-on: https://chromium-review.googlesource.com/c/1267516 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597638} TBR=sky@chromium.org,tsepez@google.com,tsepez@chromium.org Change-Id: I367de1e9d0a003c02d05bcf15505e3d45dc68bca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1269107Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597643}
-
Clark DuVall authored
This CL handles network service changes needed to support DRP proxy config. This allows setting a custom proxy config that will be used if the request would otherwise be sent direct. Additionally, headers can be set at the config or request level for requests sent using the proxy. These headers can either be added pre or post cache, which allows caching of the response to be affected by the Vary: tag for some headers. Bug: 721403 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie0faf02d1499e75bf27d023a3dc73efbeab6e787 Reviewed-on: https://chromium-review.googlesource.com/c/1260262Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#597642}
-
Joey Arhar authored
SPDY in Chrome simply refers to HTTP/2 now: https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/iwUnvL0Ul6Q Bug: 704146, 881567 Change-Id: Ida5871c3a738755325413b3dd042af5d442497c1 Reviewed-on: https://chromium-review.googlesource.com/c/1268959Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#597641}
-
Carlos IL authored
Added layout tests that verify experiment functionality for blockable, optionally blockable, and all mixed content. Change-Id: I2f8496308ecfc0ad53d50ab102e474b7946aee36 Reviewed-on: https://chromium-review.googlesource.com/c/1259466 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#597640}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9f7f390a..03454421 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6dff73da40c8d7a90af8e518a4c08dae136e7410 Reviewed-on: https://chromium-review.googlesource.com/c/1268656Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597639}
-
Scott Violet authored
latency_info was including and depending upon gfx, but it isn't actually using anything from there. This removes the deps and fixs the targets that were using gfx. BUG=none TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I7f5f04316b9d11d55ed442d99e34e4155e36566a Reviewed-on: https://chromium-review.googlesource.com/c/1267516Reviewed-by:
-
Kevin Marshall authored
OzonePlatform members are intended to be leaked on browser shutdown, so any FIDL channels contained by it (directly or indirectly) will encounter connection errors on browser shutdown. This CL causes some Ozone Platform objects, and their constituent FIDL client objects, to be torn down as part of the normal browser shutdown procedure. Also fixes another shutdown breaking issue because the FocusController was wrongly taking ownership of the FrameImpl. Change-Id: I2f7bf7b9417dea33f4b4f4aa3bd763204e8e8a42 Reviewed-on: https://chromium-review.googlesource.com/c/1252901 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#597637}
-
Pete Williamson authored
This adds the scale factor of the android device into a new header called "X-Device-Scale-Factor". The scale factor is derived from android.util.DisplayMetrics.density. Change-Id: Ia8f26435fdc780354e753f87632aca03811c144a Bug: 893238 Change-Id: Ia8f26435fdc780354e753f87632aca03811c144a Reviewed-on: https://chromium-review.googlesource.com/c/1260208 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#597636}
-
Shivani Sharma authored
http/tests/history/history-entry-requires-user-gesture-push-state.html Bug: 638198 Test: python third_party/blink/tools/run_web_tests.py -t Default Change-Id: I5578749bab0da626f02e981523fb4a813be6ef98 Reviewed-on: https://chromium-review.googlesource.com/c/1251332Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#597635}
-
Peter Boström authored
GetExtensionAnchorView() previously assumed that GetBrowserActionsContainer() would always return a non-nullptr. This is not the case for browser instances that do not support Browser::FEATURE_TABSTRIP as most elements of ToolbarView are not initialized (including |browser_actions_|). Bug: chromium:892119 Change-Id: If67939cbe3c0174106848ce7339b789114391599 Reviewed-on: https://chromium-review.googlesource.com/c/1269176Reviewed-by:
-
Dirk Pranke authored
This reverts commit 9d5ef42a. Reason for revert: See crbug.com/893254; looks like a typo in the script. Original change's description: > Remove perf_expectations > > This is a modified reland of [1] with most of the changes to sizes.py reverted. > Those changes are still used by the perf dashboard so must be kept around for > the time being. > > [1] https://chromium.googlesource.com/chromium/src.git/+/5f552b39961e3b36e018fdd7d3d452526bde2e4f > > R=dpranke > Bug: 572393 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng > > Change-Id: I459387d50f4a328192110c7b75983523a14f787d > Reviewed-on: https://chromium-review.googlesource.com/c/1255303 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597614} TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org Change-Id: Ife13ece23ed3513225003bd18fbe27b0bbf16afc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 572393 Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1268904Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#597633}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/39a66e9fc8df..8fd9d735fdea git log 39a66e9fc8df..8fd9d735fdea --date=short --no-merges --format='%ad %ae %s' 2018-10-08 chowes@google.com build_dlc: Specify image and metadata directories separately Created with: gclient setdep -r src/third_party/chromite@8fd9d735fdea The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I06afea29e459c7a94c7a9e0c202d81a1b2c45195 Reviewed-on: https://chromium-review.googlesource.com/c/1268817Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597632}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c5695530095..104a27b8ed6d Created with: gclient setdep -r src-internal@104a27b8ed6d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:731383 TBR=mmoss@chromium.org Change-Id: I7f3bb5b4f6c7b3f64bf4a6488cad1f6326a4631d Reviewed-on: https://chromium-review.googlesource.com/c/1268816Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597631}
-
Kristi Park authored
This service uses a HEAD request in order to check if the specified URL can resolve to an existing page. This will be used in the New Tab Page in order to check if a new custom link URL (obtained from adding or editing) can resolve. Split from https://crrev.com/c/1249567. Bug: 874194 Change-Id: I46be9a09d6f07988c468e9e025bed4117df61437 Reviewed-on: https://chromium-review.googlesource.com/c/1259664 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#597630}
-
Victor Costan authored
This CL switches the QuotaClientList type alias from std::list<QuotaClient*> to std::vector and inlines its use. Change-Id: I2164807c15c6aa9befdf104814b5f9d3a677b717 Reviewed-on: https://chromium-review.googlesource.com/c/1266883 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597629}
-
Jordy Greenblatt authored
This CL adapts the MultiDevice notification functionality to the new spec that only considers a new phone added or switched to once it is verified rather than just set. I added tests for this behavior for both of the 'existing host' events and an extra test for the edge case of a set (but unverified) host Phone A is replace by a different host Phone B that is verified. Bug: 891822 Change-Id: Iebd9d0d209b020602a284de200fae168f34759c2 Reviewed-on: https://chromium-review.googlesource.com/c/1263425 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#597628}
-
Bailey Berro authored
- Removes a todo comment that has already been resolved. - Does not modify any code. Bug: none Change-Id: I519f16c9a871f274ca4689929cc43e7177248fdb Reviewed-on: https://chromium-review.googlesource.com/c/1265742Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#597627}
-
Bill Orr authored
Chrome/services/isolated_xr_device depends on a feature flag in chrome/common. chrome/common/chrome_features.h then includes chrome/common/buildflags.h. Sometimes buildflags.h isn't available when isolated_xr_device is built. The fix is to add a dependency. BUG=892836 Change-Id: I225dfff4158d7eca7f79ee54f5305a27eae71065 Reviewed-on: https://chromium-review.googlesource.com/c/1266596Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597626}
-
Victor Costan authored
Change-Id: I3951c8b684effb99f5d6bd20fc31ba329c7ec3bc Reviewed-on: https://chromium-review.googlesource.com/c/1266884Reviewed-by:
-
Max Rebuschatis authored
Bug: 892749 Change-Id: If8c31124c68d3a247a0cb7eb96813ffff269bfde Reviewed-on: https://chromium-review.googlesource.com/c/1259620 Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
Wez authored
The DataPipe(capacity) constructor was previously creating a DataPipe on the stack, using the DataPipe(options) constructor, but then not using it, and instead manually creating the pipe handles to return to the caller. Remove the wasted work, and clean up some ALLOW_UNUSED_LOCAL() that are no longer required, since DCHECKs in DataPipe() constructors were replaced with CHECKs. Bug: 892297, 890468 Change-Id: Id09cd7878faa9b796858169125ff6f05d19dc5f8 Reviewed-on: https://chromium-review.googlesource.com/c/1266602Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#597623}
-
Marcin Wiacek authored
Bug was added with https://chromium-review.googlesource.com/c/chromium/src/+/1195373. Currently: there is displayed maximally one site on exception list in every Settings->SiteSettings->(category) screen. It happens because of return which is ending not only internal for, but also external one. With fix: there are displayed all sites. BUG=887595 Change-Id: I924f7a6955134f9a18976c6dbab201e8b404432c Reviewed-on: https://chromium-review.googlesource.com/c/1266395Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#597622}
-
Kevin Marshall authored
context_impl_browsertest.cc was running the risk of becoming a large catch-all for all browsertests. This CL breaks the existing tests into Context- and Frame-specific suites, which should be a more manageable structure going forward. Bug: 871594 Change-Id: Ic26bb0a070088d48b51f7f47d6737ebb311a6efe Reviewed-on: https://chromium-review.googlesource.com/c/1255897 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#597621}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3a7423909164..ab09039d2ab6 git log 3a7423909164..ab09039d2ab6 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 oprypin@webrtc.org Add comment that xcode version needs to be updated in two places 2018-10-08 mbonadei@webrtc.org Revert "Export symbols needed by the Chromium component build (part 1)." 2018-10-08 mbonadei@webrtc.org Reland "Reland "Export symbols needed by the Chromium component build (part 1)."" 2018-10-08 srte@webrtc.org Adds RTT based backoff trial to SendSideBandwidthEstimation. 2018-10-08 joel@tuple.app Generate module.modulemap file when building Mac Framework 2018-10-08 oprypin@webrtc.org Notify a rotation about autoroll CLs 2018-10-08 titovartem@webrtc.org Switch usages of DefaultNetworkSimulationConfig to BuiltInNetworkBehaviorConfig Created with: gclient setdep -r src/third_party/webrtc@ab09039d2ab6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:836566 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd5dc31aa592281ffbc85551b403f905a6122c19 Reviewed-on: https://chromium-review.googlesource.com/c/1268815Reviewed-by:
-
Carlos Knippschild authored
This change replaces the previous, partial implementation of the detection of available prefetched articles when choosing how to present the Downloads Home when it is being launched from the dino page. The logic was moved from the mojom service implementation to the renderer side helper for available content and now supports both the summary and list presentation modes. Bug: 852872 Change-Id: I82652e7a19f5a864e8cd56882eb06fb44593a994 Reviewed-on: https://chromium-review.googlesource.com/c/1235373 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#597619}
-
Scott Violet authored
PointerData will be removed, so this converts mouse mojo serialization to use MouseData. Also converts to a couple of geometry types. Also, had to fix a couple of dependencies. BUG=865781 TEST=covered by tests Change-Id: Iab8f2ddb5ba0f40bc43271e7135ca46f478a397d Reviewed-on: https://chromium-review.googlesource.com/c/1267495Reviewed-by:
-
Chong Zhang authored
'HostedAppNonClientFrameViewAshTest.FocusableViews' is failing because the host resolver was not setup correctly. The test base only copies host resolver rules and pass them to Network Service after |SetUpOnMainThread()| has returned, thus we should split the setup work and put the remaining App setup into a separate |SetUpHostedApp()| method. Change-Id: Ia3f7795efc358a5d8b83b9e9baca2a3b9034a894 Reviewed-on: https://chromium-review.googlesource.com/c/1263346 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Jun Mukai authored
To process Left/Right snapping properly, CompleteDrag() in TabDragController needs some properties, thus r596783 moves ClearTabDraggingInfo() after CompleteDrag(). However https://crbug.com/892221 revealed that another propertly kIsDraggingTabsKey needs to be cleared beforehand, otherwise some bounds calculation goes wrong. This CL moves ClearTabDraggingInfo() as my previous CL does, but clears kIsDraggingTabsKey earlier so issue 892221 won't be affected. BUG=880635, 892221 TEST=manually Change-Id: Ib7edaab5e968e006bc919b027c138ad9f3d5827d Reviewed-on: https://chromium-review.googlesource.com/c/1266495Reviewed-by:
-
Tommy C. Li authored
This CL makes CurrentTextIsURL and the match generation mechanism gracefully handle Query in Omnibox. It also adds some tests for that. Bug: 874592 Change-Id: I84e2bda6b489173a0a56ba2d6f461a1d0207fb11 Reviewed-on: https://chromium-review.googlesource.com/c/1263421 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597615}
-
Tom Anderson authored
This is a modified reland of [1] with most of the changes to sizes.py reverted. Those changes are still used by the perf dashboard so must be kept around for the time being. [1] https://chromium.googlesource.com/chromium/src.git/+/5f552b39961e3b36e018fdd7d3d452526bde2e4f R=dpranke Bug: 572393 Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng Change-Id: I459387d50f4a328192110c7b75983523a14f787d Reviewed-on: https://chromium-review.googlesource.com/c/1255303 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Clark DuVall authored
These are failing on the linux-perf-fyi bot: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/158 TBR=kouhei@chromium.org Bug: 892191 Change-Id: I85f18fdaf0df3886e07f5febf7b44e51f55b9e01 Reviewed-on: https://chromium-review.googlesource.com/c/1268958Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#597613}
-
Bailey Berro authored
Two versions of this method were used during migration to a two parameter version. The one parameter version is no longer needed. Bug: none Change-Id: I78f2e1a25649f0377087d9c2d988549741c91722 Reviewed-on: https://chromium-review.googlesource.com/c/1265906 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
Bug: 889459 Change-Id: Id33ca6444bff1e6dd71b6000823cf6fec09746ef Reviewed-on: https://chromium-review.googlesource.com/c/1256208Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#597611}
-
Orin Jaworski authored
This CL modifies a few sections of code related to autocomplete to introduce the OmniboxPedalProvider and get its first Pedal working. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3847a7bf60768cf043da3b3b5a15e651f379dc1a Bug: 893183 Change-Id: I3847a7bf60768cf043da3b3b5a15e651f379dc1a Reviewed-on: https://chromium-review.googlesource.com/c/1247192 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#597610}
-
Qiyu Hu authored
This surfaces when testeris are running CtsVerifier tests. When we have two clients interacting with discovery sessions, say CtsVerifier and GMSCore. Our racy implementation could fail if StartDiscovery() follows immediately after CancelDiscovery(): - CancelDiscovery() is called. |discovery_session_| is not null. discovery_session_->Stop() is called. Note that |discovery_session_| is still not null until OnDiscoveryStopped() is called. - StartDiscovery() is called. |discovery_sessionn_| is not null. Reset timeout and return. - Now OnDiscoveryStopped() is called. Discovery session ends, and the timeout reset above doesn't help extend the session. Also merge StartDiscovery() and StartLEScan() into one StartDiscoveryImpl(). And always discard the |discovery_session_| when CancelDiscovery() is called, even in the case of error. Otherwise, the existing |discovery_session_| will hang there. And scanning is not recoverable in this case. Bug: b:113335665 Test: Manual test with CtsVerifier Change-Id: Ic70bbdc9a7e6e51d2c44965d38ac7ccd65745398 Reviewed-on: https://chromium-review.googlesource.com/c/1212098 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#597609}
-
Matt Falkenhagen authored
Consider the scenario: 1. Page makes a range request 2. Service worker responds with 200 status and a big blob. Previously, S13nServiceWorker loading code returned to the page a 200 status and attempted to return only the requested bytes from the blob. This was incorrect: if a 200 status response is returned, all the bytes should be present. Furthermore, since the service worker itself didn't return a 206 status response, it is probably not correct for the loading code to attempt to convert it to one. This CL changes the code to return exactly what the service worker returned. Bug: 892227 Change-Id: Id032ba73ae0a61b300f2d45c1cbf2ba041481788 Reviewed-on: https://chromium-review.googlesource.com/c/1267057Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#597608}
-
