- 27 Jun, 2018 40 commits
 - 
- 
Kim Paulhamus authored
Bug: 678885 Change-Id: If395f541fbf5da01531b8dd5c6a04cccca2832d6 Reviewed-on: https://chromium-review.googlesource.com/1108355 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570687}
 - 
Xiaohan Wang authored
kMaxValue is checked by clang that it's actually the max value. Test: No functionality change Change-Id: I06cb97d0c7fc65e5b7a12dda69766e6fbd0d543f Reviewed-on: https://chromium-review.googlesource.com/1115727Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570686}
 - 
Matt Falkenhagen authored
Follow-up to r570238, https://crrev.com/e5bca9a7ce3d474 Bug: 855952 Change-Id: Id75e3e16a28fe53234d18b9ee04bb08c633d175a TBR: shimazu Reviewed-on: https://chromium-review.googlesource.com/1116416Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#570685}
 - 
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c421ca1d6e41..4ab7198c3a75 git log c421ca1d6e41..4ab7198c3a75 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@4ab7198c3a75 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ie6b1a80189a54ed24f1116785fc0c1be8f640699 Reviewed-on: https://chromium-review.googlesource.com/1116478Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570684}
 - 
Jun Choi authored
Serialization for MakeCredential response is required to implement virtual CTAP2 security key. Bug: 829413 Change-Id: I268c1f11f03e23a2d0713de3de0b53694a3fc31a Reviewed-on: https://chromium-review.googlesource.com/1111337 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#570683}
 - 
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens when building in Chrome OS for the variables kErrorInvalidX509Cert in: chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc This commit solves the issue by renaming the variables to something more file specific. It also renames other variables in the same namespace, so the naming is locally consistent. Bug: 850484 Change-Id: I67fc4d43785460ea5aa8fd1a08a2fd1985569117 Reviewed-on: https://chromium-review.googlesource.com/1114963Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#570682}
 - 
Renee Wright authored
Follow up from https://chromium-review.googlesource.com/c/chromium/src/+/1077912 Also adds Profile to the StorageHandler constructor Change-Id: Iae96445b592f9e4f537ff848fa1bc60dab8a750d Reviewed-on: https://chromium-review.googlesource.com/1111740 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#570681}
 - 
Oscar Johansson authored
In jumbo builds, on chrome os, the namespace redeclarations of media_perception in: chrome/browser/extensions/api/media_perception_private/media_perception_api_delegate_chromeos.cc extensions/browser/api/media_perception_private/media_perception_api_manager.cc extensions/browser/api/media_perception_private/media_perception_private_api.cc conflict with the declaration in: third_party/cros_system_api/dbus/service_constants.h This commit solves the issue by removing the redeclaration of media_perception and instead use the full name extensions::api::media_perception_private. Bug: 850484 Change-Id: I5a6363ca7e305d1bd7929555f60f9e1bd3322bfc Reviewed-on: https://chromium-review.googlesource.com/1114852Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#570680}
 - 
Joel Hockey authored
This fixes some console errors that were showing and catches up with recent changes. Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I37c2a0f39a01727da5860b1df2c79ec293e1ffea Reviewed-on: https://chromium-review.googlesource.com/1116399 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#570679}
 - 
Morten Stenshorne authored
NG seems to support it just fine, but was prevented from doing so by two things: We forced legacy layout on the subtree. AND we unconditionally created (legacy) LayoutBlockFlow rather than LayoutNGBlockFlow. Use the factory to create the right object type. DETAILS does not establish a new formatting context, making it a rather lousy entry-point for legacy layout. This requires some rebaselining, due to cases of off by ~0.02px and also the fact that NG creates fewer and larger text runs. There are also fewer spaces than before in a couple of text dumps, apparently. This fixes one crasher, but also introduces two failures; one which is not related to DETAILS / MARKER, but rather how we deal with hit-testing inside a vertical-rl container. The other one is a paint/invalidation/ tests that behaves different from legacy now, because it has DETAILS / MARKER in it. fast/multicol/span/summary-split.html now fails again with NG block fragmentation. It recently started to pass, because of https://chromium-review.googlesource.com/c/chromium/src/+/1063891 , but that was just because the legacy DETAILS element forced the entire multicol container to be done with legacy. The actual problem here is that NG block fragmentation doesn't support column-span:all and never has. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I823b5cd2ce62240b820428302556ee6df64c8b22 Reviewed-on: https://chromium-review.googlesource.com/1114847Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#570678}
 - 
Trent Apted authored
Double-clicking a video in thumbnail mode will also "activate" it when it's loaded in the slide mode. That is, it will autoplay. Renames Gallery::onChangeToSlideMode_() to Gallery::onThumbnailActivated_() since it's not used for anything else. That passes a boolean |activate| arg to Gallery::changeCurrentMode_() which invokes {mode}activateConetent() once the load associated with the mode change is complete. Test: GalleryBrowserTest.ActivateVideoFromThumbnailMode Bug: 850372 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie93448d8c643e842e1f871514a3283706b587900 Reviewed-on: https://chromium-review.googlesource.com/1109595 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570677}
 - 
Donna Wu authored
This CL migrated to as many OnceCallback(s) as possible in services/device/media_transfer_protocol directory. Due to some unchanged DBus interfaces, there are still several base::Bind() left in the implementation. BUG=714018 Change-Id: Iceb2558f45a54e43503fc67fe40380cc9baef248 Reviewed-on: https://chromium-review.googlesource.com/1111693Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#570676}
 - 
Shik Chen authored
BUG=b:77833131,b:64996728,chromium:832816 TEST=Verify CCA works with and without external camera on Nautilus with some patches in cros_camera_service and usb hal. TEST=Verify CCA works with unmodified cros_camera_service and usb hal on Nautilus. Change-Id: Ie759846a199e41778aa3c5d97ecfa2f630515544 Reviewed-on: https://chromium-review.googlesource.com/1105648 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570675}
 - 
Hajime Hoshi authored
This CL adds an argument TaskType to LocalDOMWindow::EnqueueWindowEvent so that callers can specify a task source. Bug: 856568 Change-Id: Ied2da83d39b3be92ccd9baebbf61f3f80b35f43b Reviewed-on: https://chromium-review.googlesource.com/1114672Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570674}
 - 
Joel Hockey authored
* Add BUILD rules to include UI test JS files in closure compilation to help detect type-related errors during compilation phase. * Also including webui_resource_test and test_util_base files which are used by UI tests. * Minor fixes to various files detected by closure compiler. Bug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I88a798806e732e2d2b35a2685fb954610560b71b Reviewed-on: https://chromium-review.googlesource.com/1114677Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#570673}
 - 
James Darpinian authored
The transform feedback generic binding point is not part of the transform feedback object and is not used for transform feedback. Only the indexed binding points are used. A buffer that is bound to the generic binding point should be usable for either transform feedback or non-transform-feedback purposes. Bug: 853978 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4da8501cb21168258742c337c8c97d593f9323a1 Reviewed-on: https://chromium-review.googlesource.com/1112846Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#570672}
 - 
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: I8eaea16d8730dcc0fe8a3e5bbbe5321241c7e80e Reviewed-on: https://chromium-review.googlesource.com/1116398Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570671}
 - 
Zhongyi Shi authored
Connection Migration V1 option "migrate_session_on_network_change" is deprecated. Bug: 843299 Change-Id: I59f51d5e6b2221913b6ee92edbddb0137c23163b Reviewed-on: https://chromium-review.googlesource.com/1114302 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#570670}
 - 
edchin authored
A single selection collection view's default behavior is to momentarily deselect the selected cell on touch down then select the new cell on touch up. In this tab grid, the selection ring should stay visible on the selected cell on touch down. Multiple selection disables the deselection behavior. Multiple selection will not actually be possible since |-collectionView:shouldSelectItemAtIndexPath:| returns NO. Bug: 849653 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia9913f1ce7edae83398474f94890c5f4c6afab69 Reviewed-on: https://chromium-review.googlesource.com/1115998Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570669}
 - 
Renee Wright authored
They should now all be in the order that the sections appear in the UI itself: Dowloads Drive Browsing Data Android Crostini Other Users Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6272e2a5f252fea7f5382aa3f838f646bff9f487 Reviewed-on: https://chromium-review.googlesource.com/1109589 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#570668}
 - 
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/afc734c9..97cb0ea3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I61f0e3a05c056933fcc6d3119b9156f984a3350c Reviewed-on: https://chromium-review.googlesource.com/1116243Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570667}
 - 
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1ff0ee751d95..82af620e0559 git log 1ff0ee751d95..82af620e0559 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 jie.a.chen@intel.com ParallelCompile: Add entry points. 2018-06-26 ynovikov@chromium.org Skip ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB on Mac 2018-06-26 geofflang@chromium.org GL: Don't print driver performance warnings. Created with: gclient setdep -r src/third_party/angle@82af620e0559 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849576,chromium:768943 TBR=ynovikov@chromium.org Change-Id: Icacd1c10488eb3135f5161aac00efd8da3cf4720 Reviewed-on: https://chromium-review.googlesource.com/1116083Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570666}
 - 
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I1e32f2323b1bf5d627227aabb8dfdabc6c98e9b1 Reviewed-on: https://chromium-review.googlesource.com/1116351Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570665}
 - 
Tarun Bansal authored
This simplifies the code a bit. This has been enabled in-code as a "stable" setting since M-67 which has now hit the stable channel. Change-Id: I8cfed718113bb990087e004f6c7d667a0b5d30ce Bug: 852484 Reviewed-on: https://chromium-review.googlesource.com/1116077Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570664}
 - 
Koji Ishii authored
This patch fixes some cases where collapsible trailing spaces were not removed properly. Normally, ShapingLineBreaker can detect trailing spaces and they are easy to remove. This is more efficient when the removal may require re-shaping. However, in some cases, such as across element boundaries, non-text objects (borders etc.) overflow the line, or when out-of-flow objects follow, trailing spaces need to be removed as an additional step. Instead of patching each such case, this patch adds a flag that indicates trailing spaces removal was done, and call RemoveTrailingCollapsibleSpace() at the end of the line breaking unless the flag is set. The rebaselines revealed that justification was incorrect when e.g.: ...WORD <float><end-of-line> In this case, the algorithm needs to use the end of "WORD", not the Object Replacement Character that represents the float. This patch includes the fix too. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic685c3f045b6b8dd2d8b292a6a0fdc32a208d1d2 Reviewed-on: https://chromium-review.googlesource.com/1113159 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#570663}
 - 
Aleks Totic authored
Following tests had always failing baselines because of font mismatches (except for extend_by_character.html with is a text test with failing baseline checked in). fast/writing-mode/vertical-rl-replaced-selection.html compositing/reflections/nested-reflection-transition.html compositing/reflections/nested-reflection-animated.html compositing/reflections/nested-reflection-anchor-point.html scrollbars/overflow-scrollbar-combinations.html fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html fast/forms/text/input-text-scroll-left-on-blur.html svg/as-background-image/svg-as-background-5.html editing/selection/modify_extend/extend_by_character.html fast/text/selection/emphasis.html editing/selection/modify_extend/extend_by_character.html fast/text/selection/emphasis-vertical.html Bug: 855749 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5e62dced67a857e844af3baa760fd6b63fb0e723 Reviewed-on: https://chromium-review.googlesource.com/1115510 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570662}
 - 
Kouhei Ueno authored
This CL prepares for cert-url https restriction change CL: https://chromium-review.googlesource.com/c/chromium/src/+/1114403 Bug: 803774 Change-Id: Ifcf6b89344803188e06a0af7a83d2e16aec71d5c Reviewed-on: https://chromium-review.googlesource.com/1114526Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#570661}
 - 
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I9ccc4ad86a19818d3ee7dd557c212890ca5be3f3 Reviewed-on: https://chromium-review.googlesource.com/1116101Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#570660}
 - 
Yoichi Osato authored
This patch moves marker painting functions to new document_marker_painter.cc. This patch is pure-refactoring. Here are target functions: DocumentMarkerController:: ComputeMarkersToPaint DocumentMarkerPainter:: PaintStyleableMarkerUnderline PaintDocumentMarker ComputeTextPaintStyleFrom Bug: 850448 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibd0c002fa820e18ff03e3ec480e0151bb197b219 Reviewed-on: https://chromium-review.googlesource.com/1114532 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570659}
 - 
Takuto Ikuta authored
This is mainly to improve some slow compile steps on the builder like below builds. 3838s https://ci.chromium.org/b/8942644072250280192 3768s https://ci.chromium.org/b/8942672265238284416 3494s https://ci.chromium.org/b/8942644248527615520 3487s https://ci.chromium.org/b/8942634676123947168 Bug: 804251 Change-Id: I5f2ecae67b19d3c613b247b9dec8281c9de73207 Reviewed-on: https://chromium-review.googlesource.com/1116209Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#570658}
 - 
Findit authored
This reverts commit e6a79515. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 570649 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2YTc5NTE1ODBiNWJjNzdjYTg0MjJhZGE1ZjhiY2QyNjA3OGNjOGIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/14504 Sample Failed Step: net_unittests Original change's description: > Factor out utilities for testing QUIC_LOG() output into quic/platform/api/quic_mock_log.h > > Merge internal change: 202011580 > > Change-Id: I997c8dc7dbbf87fa32d2dcaf125ea2231cac4e23 > Reviewed-on: https://chromium-review.googlesource.com/1114143 > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570649} Change-Id: If26a62e4aa09efd41a882166367b26c7f372e775 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1116160 Cr-Commit-Position: refs/heads/master@{#570657}
 - 
Findit authored
This reverts commit c9c23766. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 570585 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M5YzIzNzY2YjVlN2NkNDdjNGE4Y2UyOWU2YzY3YzUxNjFkNjkwMTcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28051 Sample Failed Step: browser_tests Original change's description: > Directly attach ax tree to contents view of focused window > > - Remove focus stealer and directly attach ax tree to contents view of > widget delegate of focused widget. > - Returns contents view of widget delegate as focused view if no view is > focused. > > Bug: 852653 > Test: Enable ChromeVox arc native support and confirm that it works. > Change-Id: I22feb9c79e54653a037a2b78b729d76fcbb29fa2 > Reviewed-on: https://chromium-review.googlesource.com/1103982 > Commit-Queue: Yuki Awano <yawano@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570585} Change-Id: I87f22eada8856c3ef901c09e4e096640f48f1a74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852653 Reviewed-on: https://chromium-review.googlesource.com/1116159 Cr-Commit-Position: refs/heads/master@{#570656}
 - 
Kurt Horimoto authored
This CL adds the ability to specify supplemental text for the URL label and an optional badge view to display over the favicon view. Bug: 805209, 852429 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I609fe777feda0242a3748902e739e07fe43590ad Reviewed-on: https://chromium-review.googlesource.com/1104891Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570655}
 - 
Alexandre Courbot authored
MEDIA_EXPORT was missing from this declaration, causing linking errors with component builds. BUG=856065 TEST=Checked that component build completed successfully on Eve Change-Id: I0f516115d2176294e5dbe12d86c5b43ef25bd6c0 Reviewed-on: https://chromium-review.googlesource.com/1114399 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570654}
 - 
Adam Rice authored
Modify blink::ReadableStreamOperations::IsReadable() to take an ExceptionState& parameter. Modify all callers so that the ExceptionState is passed through all the way from the bindings layer. Bug: 853189 Change-Id: Icd29564d9dc869d3e91ca0fd981c0f75362f1581 Reviewed-on: https://chromium-review.googlesource.com/1114518 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#570653}
 - 
Tetsui Ohkubo authored
Previously, volume slider was missing when UnifiedSystemTray was collapsed and volume key was pressed. This CL ensures UnifiedSystemTray to be expanded when volume key is pressed. TEST=manual BUG=855508 Change-Id: Ia1408082a74a9b11a6a7802849c9dc391cf601a8 Reviewed-on: https://chromium-review.googlesource.com/1114520Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#570652}
 - 
Darren Shen authored
Forgot to install event handler to handle dragging, which meant dragging stopped working (on mouse). Dragging still worked on touch because IME still has code that handles touch dragging ¯\_(ツ)_/¯ Bug: 849980 Change-Id: Ic19aa886e23bd5f944b41ba066b94e26eed9c99a Reviewed-on: https://chromium-review.googlesource.com/1114562Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#570651}
 - 
Andrew Grieve authored
* Renames compute_grit_inputs_for_analyze -> compute_inputs_for_analyze * Computes .py inputs via exec_script (when compute_inputs_for_analyze=true) * Enforce that sub-included .jinja files are listed in targets. Bug: 843562 Change-Id: I3698c7846375530a86474bd5960bb002ac45f71a Reviewed-on: https://chromium-review.googlesource.com/1112867Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570650}
 - 
Ryan Hamilton authored
Merge internal change: 202011580 Change-Id: I997c8dc7dbbf87fa32d2dcaf125ea2231cac4e23 Reviewed-on: https://chromium-review.googlesource.com/1114143 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570649}
 - 
Weidong Guo authored
1. Create a AppListConfig that includes all layout info for app list. Override certain info for homecher flag during initialization. 2. Change AppListItem's layout and put the changes behind homecher flag. specs: https://screenshot.googleplex.com/dcJy96seMQR Bug: 853973 Change-Id: I678fc7af9cf93c677721b171436afb841d833b20 Reviewed-on: https://chromium-review.googlesource.com/1105400Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570648}
 
 -