GitLab

BUG=456016
TEST=manually tested; Edit some file in list view and see the thumbnail is updated with transition animation.

Review URL: https://codereview.chromium.org/954373003

Cr-Commit-Position: refs/heads/master@{#318679}

BUG=none

Review URL: https://codereview.chromium.org/953413003

Cr-Commit-Position: refs/heads/master@{#318678}

It looks it's no longer used in any production code.

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/964353002

Cr-Commit-Position: refs/heads/master@{#318677}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/627ffe9a..8b33fa60

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/965383002

Cr-Commit-Position: refs/heads/master@{#318676}

Previously FileSystemMetadata has multiple providers, and it switches the
providers depends on Entry state. e.g. If the entry is dirty, it uses
ContentProvider instead of ExternalProvider.

Previously each provider cached its result but they shared single
MetadataProviderCache instance. Thus if ExternalProvider returns values that are
out of sync, the values are cached and ContentProvider is never called.

The CL extracts the caching part of NewMetadataProvider as
CachedMetadataProvider wrapper class. And let it switch providers before
caching.

BUG=410766
TEST=FileManagerJsTest.*Metadata*

Review URL: https://codereview.chromium.org/971653003

Cr-Commit-Position: refs/heads/master@{#318675}

Revert of Remove dependency on //components/feedback on iOS (patchset #1 id:1 of https://codereview.chromium.org/954943004/)

Reason for revert:
This CL cause the test to run in another order, causing a hidden dependency on the ordering to be visible. Reverting as this cause test failures.

See http://crbug.com/462352

Original issue's description:
> Remove dependency on //components/feedback on iOS
>
> iOS does not use //components/feedback to report feedback so remove
> the unused dependencies.
>
> BUG=None
>
> Committed: https://crrev.com/3e96329f442c10d73174688a4786ab847a49a37f
> Cr-Commit-Position: refs/heads/master@{#318211}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/968653004

Cr-Commit-Position: refs/heads/master@{#318674}

This patch actually fixes three different issues, as I could not separate the
updated tests in a meaningful way.

1. CheckDispatchVisitor needs to look for UnresolvedMemberExpr*, since inlined
tracing introduces unresolved member references.

This visitor looks at every function call within a trace dispatching method,
and returns whether there is a call delegating to the class in question. We
need to take care of UnresolvedMemberExpr* cases in addition to MemberExpr*.

2. RecordInfo::DetermineTracingMethods() should return traceImpl() instead of
trace() as trace_dispatch_method_.

The plugin inspects the definition of trace_dispatch_method_ in order to detect
missing or inappropriate delegation to subclasses. Therefore, the method should
be something that has actual delegation calls in its body (i.e. traceImpl())
instead of a trampoline stub (i.e. trace()).

3. A silly typo in Config::GetTraceMethodType(). Really silly. Not sure why
I did this way.

This patch comes with updated tests for traceAfterDispatchImpl(). Now the tests
are more closer to real cases, using traceImpl to implement trace dispatching.

BUG=462511
R=kouhei@chromium.org
CC=zerny@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/968143002

Cr-Commit-Position: refs/heads/master@{#318673}

BUG=461476

Review URL: https://codereview.chromium.org/962213002

Cr-Commit-Position: refs/heads/master@{#318672}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ed228f8..e9fa41a

TBR=

Review URL: https://codereview.chromium.org/964273003

Cr-Commit-Position: refs/heads/master@{#318671}

Not registering them broke voice search for supervised users, because the corresponding extension comes from one of these providers.
It also resulted in inconsistent behavior for child accounts, where the providers would exist after the first sign-in, but not after the next browser restart.

BUG=458096,397951

Review URL: https://codereview.chromium.org/955683002

Cr-Commit-Position: refs/heads/master@{#318670}

Revert of Wallpaper manager now observing user child user status to update default wallpaper. (patchset #2 id:20001 of https://codereview.chromium.org/952853002/)

Reason for revert:
MultiUserNotificationBlockerChromeOSTest is failing after this CL (see issue 463049).

Original issue's description:
> Wallpaper manager now observing user child user status to update default wallpaper.
>
> BUG=461282
>
> Committed: https://crrev.com/c3a3f671f8e0c5777c6bc825f21d61c6bcafbec3
> Cr-Commit-Position: refs/heads/master@{#318666}

TBR=bshe@chromium.org,skuhne@chromium.org,merkulova@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461282

Review URL: https://codereview.chromium.org/966333004

Cr-Commit-Position: refs/heads/master@{#318669}

BUG=

Review URL: https://codereview.chromium.org/959303002

Cr-Commit-Position: refs/heads/master@{#318668}

BUG=456779
TBR=keybuk@chromium.org

Review URL: https://codereview.chromium.org/913773002

Cr-Commit-Position: refs/heads/master@{#318667}

BUG=461282

Review URL: https://codereview.chromium.org/952853002

Cr-Commit-Position: refs/heads/master@{#318666}

As a result of introducing templated traceImpl() function, the callee part of
"Base::trace()" call (i.e. Base::trace) may not be fully resolved at the time
of the plugin execution. This has caused another issue in cases where trace()
is intentionally omitted because the class has no fields to trace.

Consider the following example:

    class A : public GarbageCollected<A> { trace() { ... } };
    class B : public A { /* No trace() */ };
    class C : public B { trace() { B::trace(visitor); } };

The "B::trace()" call in C is actually A::trace(). If the callee part "B::trace"
is unresolved, we only know that "there is a function call which will be
resolved to A::trace()". We still want to mark B as traced when we see such
a function call.

This patch fixes this trace call detection logic so we can handle this case.
The new logic keeps going up the class hierarchy while the class is not
required to have a trace method, and if we find a class that matches the class
of the (unresolved) callee part, we mark the direct base class of the original
class as traced.

BUG=462511
R=kouhei@chromium.org
CC=zerny@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/964273002

Cr-Commit-Position: refs/heads/master@{#318665}

Cr-Commit-Position: refs/heads/master@{#318664}

Implement IdAllocator by storing complete id ranges of (min,max) in the
map instead of just ids. This should make allocating big amount of ids
scale a bit better.

Store a range by creating a mapping first id -> last id. Upon query of
id existence, find the lowest_bound with the id interested. The hit will
be found at the returned iterator position (range starts at the id) or
the position before (range starts before the id and expands to cover
it).

Changes the allocation results so that even though client has requested
AllocateIdAtOrAbove(high_id_number), the next AllocateId() will allocate
lowest available id (instead of lowest available after
high_id_number). This is why GLES2ImplementationTest::kBuffersStartId
changes.

BUG=344330

Review URL: https://codereview.chromium.org/692073002

Cr-Commit-Position: refs/heads/master@{#318663}

BUG=

Review URL: https://codereview.chromium.org/918913002

Cr-Commit-Position: refs/heads/master@{#318662}

BUG=462521
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/964343002

Cr-Commit-Position: refs/heads/master@{#318661}

Additional unit tests that caught this case are forthcoming. This is a
simple and safe patch for merging.

BUG=452607

Review URL: https://codereview.chromium.org/966833002

Cr-Commit-Position: refs/heads/master@{#318660}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b675a73..db873d8

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/972583003

Cr-Commit-Position: refs/heads/master@{#318659}

Check-select mode spec is here: https://docs.google.com/document/d/1kCG0AFtZSlxlkuipNHlKLY2nvjPdDCViG6RKhMI5-dc/edit

Mode transition rules:
 + Entering check-select mode
   - When two or more items are selected.
   - When checkmark area is clicked.
 + Leaving check-select mode
   - When all items are unselected.
   - When non-checkmark area on an item is clicked.
   - When direction key(UP,LEFT,etc...) results in single selection.

BUG=460220
TEST=manually tested

Review URL: https://codereview.chromium.org/962103002

Cr-Commit-Position: refs/heads/master@{#318658}

Separate out Touch Selection Orientation so that it can
be used both on Java side and native side easily.

BUG=NONE

Review URL: https://codereview.chromium.org/701823002

Cr-Commit-Position: refs/heads/master@{#318657}

HotwordServiceFactory::IsServiceAvailable() causes media device
enumeration to start as a side effect. On some platforms, this can block
resulting in a user-visible delay when opening the app list. Although
this probably doesn't affect ChromeOS, it will affect OSX if voice
search and hotwording are enabled on that platform in the future.

This was discovered as a result of investigating crbug.com/458397

Review URL: https://codereview.chromium.org/966323002

Cr-Commit-Position: refs/heads/master@{#318656}

Newly added MIDI input ports were detected and enumerated correctly,
but was not registered to listen. As a result, incoming MIDI messages
are not received at all.

BUG=n/a
TEST=manual

Review URL: https://codereview.chromium.org/960213006

Cr-Commit-Position: refs/heads/master@{#318655}

BUG=462521
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ExifParser

Review URL: https://codereview.chromium.org/968793002

Cr-Commit-Position: refs/heads/master@{#318654}

MIDIPacketList can contain multiple MIDIPacket, but MIDIPacket objects
have different sizes depending on packet contents. So we should not
refer to MIDIPackets via array index, but should use MIDIPacketNext
that Core MIDI API provides to obtain the next object.

As a result, previous code may refer invalid memory region if large
MIDI messages are received at the same time.

BUG=456780, 374560

Review URL: https://codereview.chromium.org/965793002

Cr-Commit-Position: refs/heads/master@{#318653}

The previous logic was causing a memory corruption when aborting was not
invoked with the callback, but due to unmounting the file system.

As there are multiple paths for aborting, this CL adds a method IsAborted on
the Queue class so it's possible to check if a task has been aborted before.

TEST=unit_tests: *FileSystemProviderQueue*
BUG=454310

Review URL: https://codereview.chromium.org/968763002

Cr-Commit-Position: refs/heads/master@{#318652}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/54f1d4e..ed228f8

TBR=

Review URL: https://codereview.chromium.org/965293002

Cr-Commit-Position: refs/heads/master@{#318651}

This CL fixes an issue where the custom launcher page would still be
shown when the app list was opened even when setEnabled(false) was called.

BUG=462444

Review URL: https://codereview.chromium.org/958133005

Cr-Commit-Position: refs/heads/master@{#318650}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/73165bd..b675a73

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/965273002

Cr-Commit-Position: refs/heads/master@{#318649}

This CL adds a method to create process using LowBox token on Windows. LowBox will help us tackle some of the escapes from Sandbox.

R=cpu,jschuh,rvargas,wfh,forshaw
BUG=455496

Review URL: https://codereview.chromium.org/937353002

Cr-Commit-Position: refs/heads/master@{#318648}

Fix for 'Rotate clockwise/counter clockwise' should not present in context menu in crashed PDF page.

When we are in the crashed PDf page then rotate does not have any use and it does
nothing as only sad_plugin bitmap is painted.
So rotate menu items should not present in the context menu.
Changes done to check when plugin is crashed then rotation is not allowed.
and rotate menu items are not added in context menu.

BUG=462525

Review URL: https://codereview.chromium.org/962193002

Cr-Commit-Position: refs/heads/master@{#318647}

Currently the toolbar won't get hidden until after there is some user input.

Review URL: https://codereview.chromium.org/966293002

Cr-Commit-Position: refs/heads/master@{#318646}

This fixed the remaining erros found by 'gn check', so we can enable it
on all bots.

Checked with the following command lines:

Linux
$ gn gen out-gn
$ gn check out-gn //google_apis/*

$ Android
$ gn gen out-gn-android --args='target_os="android"'
$ gn check out-android //google_apis/*

$ ChromeOS
$ gn gen out-gn-chromeos --args='host_os="chromeos"'
$ gn check out-gn-chromeos //google_apis/*

BUG=None
TEST=see above
R=dpranke@chromium.org
TBR=rogerta@chromium.org,zea@chromium.org

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/970613002

Cr-Commit-Position: refs/heads/master@{#318645}

This requirement was an error. Code behaves correctly without nodes for
these layers.

BUG=386810

Review URL: https://codereview.chromium.org/970713003

Cr-Commit-Position: refs/heads/master@{#318644}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2d29181..54f1d4e

TBR=

Review URL: https://codereview.chromium.org/966303002

Cr-Commit-Position: refs/heads/master@{#318643}

This CL fixes an issue with the app list start page sort order for
unlaunched apps. Folder items were being weighted too highly, causing
them to appear first. The items that are not in a folder will now
appear first in the recommendations, in app list order.

BUG=455338

Review URL: https://codereview.chromium.org/954363002

Cr-Commit-Position: refs/heads/master@{#318642}

R=dbeam@chromium.org
BUG=

Review URL: https://codereview.chromium.org/939533002

Cr-Commit-Position: refs/heads/master@{#318641}

Even though fixed position layers are constrained to keep a constant
position wrt to their "fixed container," their initial position must
account for the position of layers between them and this container.

BUG=386810

Review URL: https://codereview.chromium.org/967163002

Cr-Commit-Position: refs/heads/master@{#318640}