GitLab

BUG=101938
TEST=none

R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/8417004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107620 0039d316-1c4b-4281-b951-d872f2087c98

Along the way, rename the class to SensorsClient, to be consistent with
other classes in the directory, and do some minor cleanup.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8400034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107619 0039d316-1c4b-4281-b951-d872f2087c98

R=ben
BUG=run out of VRAM
TEST=open and close many tabs on touch device; VRAM should remain roughly constant

Review URL: http://codereview.chromium.org/8411002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107618 0039d316-1c4b-4281-b951-d872f2087c98

Update chromium tests for new IDBDatabase.transaction() restrictions. The transaction([]) shortcut is no longer supported, stores must be listed explicitly.

WebKit change is https://bugs.webkit.org/show_bug.cgi?id=70251

Discussion of change: https://groups.google.com/a/chromium.org/group/chromium-html5/browse_thread/thread/f667458ca6455d33/1496ad2d1a67b53f#1496ad2d1a67b53f

BUG=101927
TEST=content_unittests --gtest_filter='*IndexedDB*'

Review URL: http://codereview.chromium.org/8414002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107617 0039d316-1c4b-4281-b951-d872f2087c98

in https://bugs.webkit.org/show_bug.cgi?id=70251

See thread: https://groups.google.com/a/chromium.org/group/chromium-html5/browse_thread/thread/f667458ca6455d33/1496ad2d1a67b53f#1496ad2d1a67b53f

BUG=101973
TEST=performance_ui_tests --gtest_filter='*IndexedDB*'

Review URL: http://codereview.chromium.org/8341080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107616 0039d316-1c4b-4281-b951-d872f2087c98

Enforce that chrome/common doesn't depend on content/common through DEPS. Also add a comment in the public dir of content.

BUG=98716
Review URL: http://codereview.chromium.org/8417001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107614 0039d316-1c4b-4281-b951-d872f2087c98

Added logic that will retry to reload+reconnect the mobile payment portal page 5 times before it eventually gives up and shows service unavailable error.

Expanded frame sniffer to send an event when a frame which is being watched gets finally loaded. From the sent error (or its absence) and this new event, we can finally reconstruct on the browser side if a given iframe was loaded successfully or not.  

BUG=chromium-os:20525, chromium-os:21738
TEST=tricky one to test since it repros on 3g network flakyness. one can edit /usr/lib/cromo/config/madison.ini and put a bad value for olp_root there to trigger this.
Review URL: http://codereview.chromium.org/8341037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107613 0039d316-1c4b-4281-b951-d872f2087c98

observing in its destructor.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8417002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Look at about:flags and see 'Disable Panels'. Should be off by default.

Review URL: http://codereview.chromium.org/8416003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107609 0039d316-1c4b-4281-b951-d872f2087c98

Always use skia text rendering on Windows in Aura. GDI rendering is really wonky, and this is a convenient fix.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8400023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107608 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8341074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8401007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107606 0039d316-1c4b-4281-b951-d872f2087c98

a cached page.

The problem is that the same ResourceLoadTiming struct is re-used for each
redirect. So, we record the deltas for connect time, headers, send request, etc.,
for each redirect. But, after the last redirect, we simply have a cache hit. So,
the base_time is updated for that cache hit, but the deltas are still relative
to the old base_time value. When we apply the old deltas to the new base_time,
we end up with a time in the future.

To fix this, I clear ResourceLoadTimingInfo after each redirect.

I've added a UI test for this. I could've done a unit test, but we have no end-
to-end Navigation Timing tests and it'd be easy for this to be broken by some
unrelated change to NetLog and redirects, so I prefer having this test be a
safe guard.

On a related note, I noticed that LoadTimingObserver::OnAddURLRequestEntry() is
called at least twice for each source.id. Once for the normal URLRequest, and
once for the AppCacheURLRequest. Fortunately, they're only 100 ns apart, so it
doesn't screw up the times. But, it was a surprise to me. Perhaps we should
ignore the AppCache requests?

BUG=None
TEST=ui_tests


Review URL: http://codereview.chromium.org/8336012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107604 0039d316-1c4b-4281-b951-d872f2087c98

This change splits the GL binding initialization into to phases: core
functions and extension functions. This is motivated by two
peculiarities of the EGL window binding layer:

  1. Pointers to core GL entry points may not be queried through
     eglGetProcAddress().

  2. The return value of eglGetProcAddress() is not specified to be NULL
     for unsupported functions.

In light of these limitations, the current strategy of blindly querying
all GL entry points from eglGetProcAddress() and falling back to dlsym()
results in bogus function pointers on some EGL implementations.

This patch fixes the problem as follows:

  1. Add GetGLCoreProcAddress() that only queries dlsym() and use it to
     initialize pointers to all entry points. On EGL based platforms
     pointers to extension functions will most likely be NULL at this
     point.

  2. When a context is first made current, look up the set of supported
     extensions and use GetGLProcAddress() to populate the remaining
     extension function pointers.

The reworked GL bindings generator uses the standard Khronos headers to
recognize the extension functions and produce appropriate initialization
code.

Note that the patch also updates gl2ext.h to match the upstream Khronos
version and corrects some minor errors in the downstream changes.

BUG=5427391
TEST=

Review URL: http://codereview.chromium.org/8381001
Patch from Sami Kyostila <skyostil@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107602 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8390046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101665
TEST=these tests

Review URL: http://codereview.chromium.org/8392046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107600 0039d316-1c4b-4281-b951-d872f2087c98

http://crrev.com/107401 introduced a WebUI cert selector that relies upon NSS and/or OpenSSL.  These aren't used on Windows, so linking fails.

BUG=97856
TEST=build on windows, see if it works

Review URL: http://codereview.chromium.org/8403043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107599 0039d316-1c4b-4281-b951-d872f2087c98

This fixes these issue:
 . clicking on the desktop window ends up shrinking the desktop itself.
 . the desktop window gets in front of the chrome window on startup.
 . crash when mousewheeling on the desktop.

Also check for NULL active_workspace_ to avoid a crash when clicking on an empty desktop.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8399044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=gfx_unittets on linux_aura should go green

Review URL: http://codereview.chromium.org/8391006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107592 0039d316-1c4b-4281-b951-d872f2087c98

BUG= code.google.com/p/nativeclient/issues/detail?id=2394
TEST=cd native_client; ./scons --mode=opt-host,nacl chrome_browser_tests

Note: For some reason, trybot runs aren't appearing here. You can see them at:
http://build.chromium.org/p/tryserver.chromium/waterfall?committer=dmichael@chromium.org

The constructor is the 'new right way' to do it anyway:
http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html

Review URL: http://codereview.chromium.org/8340019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101927
TEST=IndexedDBBrowserTestWithLowQuota.QuotaTest
TBR=johnnyg

Review URL: http://codereview.chromium.org/8413001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107589 0039d316-1c4b-4281-b951-d872f2087c98

Commented out a line that reliably fails the tests, although the real
cause seems to be chromium:101665.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8363054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107588 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97248
TEST=manually

Review URL: http://codereview.chromium.org/8402031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101593
TEST=instant_browsertest


Review URL: http://codereview.chromium.org/8373010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107585 0039d316-1c4b-4281-b951-d872f2087c98

R=ivankr@chromium.org
BUG=chromium-os:22125
TEST=Verify that for users with default profile picture it's not downloaded and shown on image screen or change picture page.

Review URL: http://codereview.chromium.org/8399005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8392043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107583 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88316
TEST=AppApiTest.{AppProcess,AppProcessInstances} not flaky

Review URL: http://codereview.chromium.org/8401023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107582 0039d316-1c4b-4281-b951-d872f2087c98

 Moving them to suppression.txt as this happens on both mac and linux

TBR=rvargas@chromium.org
BUG=101853
TEST=none

Review URL: http://codereview.chromium.org/8409001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107581 0039d316-1c4b-4281-b951-d872f2087c98

space though, so if you're at the first/last workspace it'll be
aligned to the left/right edge.

BUG=none
TEST=none
R=oshima@chromium.org

Review URL: http://codereview.chromium.org/8399027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107580 0039d316-1c4b-4281-b951-d872f2087c98

This makes BrowserNonClientFrameViewAura act as if it has a
zero-height top resize border to avoid weird resizing when
dragging that region up or down.  In the longer term, this
change should be reverted and the Aura shell should instead
be responsible for disabling resizes (and preventing the
cursor from changing as well, I suppose).

BUG=101830
TEST=manual: checked that dragging the top of the frame only moves the window instead of resizing it

Review URL: http://codereview.chromium.org/8400011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107579 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=johnnyg

Review URL: http://codereview.chromium.org/8404047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107577 0039d316-1c4b-4281-b951-d872f2087c98

We need to do some more work to make it clip properly.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8401004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107575 0039d316-1c4b-4281-b951-d872f2087c98

Two changes:
a) detangle the mock compositor from compositor_test_support
a) pull in compositor when using a mock compositor

Rationale:

a) this target was meant to support using use_webkit_compositor=1 when WK isn't initialized; sometimes we will want to use the mock compositor when WK is initialized

b) we can imagine scenarios where we want to switch between mock and real compositors in the same executable, and it's one less target to update

BUG=101477
TEST=bots stay green

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107563
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=107564

Review URL: http://codereview.chromium.org/8395043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107574 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8403042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107573 0039d316-1c4b-4281-b951-d872f2087c98

Try a different, simpler approach to detect bookmark drag&drop across profiles.

BUG=101543
TEST=drag bookmark from folder, wait for folder to close, drop on bar -> no crash


Review URL: http://codereview.chromium.org/8404022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107572 0039d316-1c4b-4281-b951-d872f2087c98

This fix doesn't display selection popups properly, though (because RenderWidgetHostViewAura::InitAsPopup is not implemented).

BUG=101899,99757
TEST=Manual: click on any SELECT element

Review URL: http://codereview.chromium.org/8363047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107571 0039d316-1c4b-4281-b951-d872f2087c98

This removes the --keep-mouse-cursor flag, and moves the --touch-devices flag
from touchui-only to linux-views (i.e. chromeos, aura on linux, touchui).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8371022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107570 0039d316-1c4b-4281-b951-d872f2087c98

The way a WebTouchEvent is prepared in RWHVAura is the same as it is in
RWHVViews: the RWHVA maintains a WebTouchEvent, and each aura::TouchEvent
adds/removes/updates a WebTouchPoint in the WTE.

BUG=99757
TEST=manually, with the --touch-devices flag on linux.

Review URL: http://codereview.chromium.org/8377001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107569 0039d316-1c4b-4281-b951-d872f2087c98