- 13 Nov, 2020 40 commits
-
-
Scott Little authored
This reverts commit 674caeb6. Reason for revert: Broke ASAN browser tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38849 The initial CL (before the reland) was previously reverted, and now relanded, corresponding to the test failures in both the initial landing and the reland. See https://bugs.chromium.org/p/chromium/issues/detail?id=1148771#c3 for a more detailed explanation including discussing other possible culprit CLs. Original change's description: > Reland "UserSessionManager trigger tpm initialization whenever TPM is enabled." > > This is a reland of f5684467 > > Original change's description: > > UserSessionManager trigger tpm initialization whenever TPM is enabled. > > > > we are obsoleting `TpmIsBeingOwned()`, which is not really necessary > > anyway; even if `TpmIsBeingOwned()` returns `true`, triggering the TPM > > initilaization again is just no-ops at ChromeOS side. > > > > BUG=b:172775884 > > TEST=TBD if untitests needed. > > > > Change-Id: If4240a0c8a9a7485d77856e1e5c346c89407c09a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532155 > > Commit-Queue: Leo Lai <cylai@google.com> > > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826306} > > Bug: b:172775884 > Change-Id: I0499d47b9962f41bcfa956d6efa73b850a0b2021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534372 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Commit-Queue: Leo Lai <cylai@google.com> > Cr-Commit-Position: refs/heads/master@{#827141} TBR=achuith@chromium.org,alemate@chromium.org,cylai@google.com,adithyas@chromium.org Change-Id: I5f443979f1f420f1abaf1371cac10c10f1eb2b0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:172775884, 1148771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537580Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827323}
-
Ian Barkley-Yeung authored
Add the remaining testing hooks needed for the Browser & Tast tests for the WebUI JS Error Reporting project. In particular, added ability to log errors (via console.error) and have unhandled promise rejections. Since the page now does more than just throw exceptions, renamed from chrome://webuiexception to chrome://webuierror. Bug: chromium:1121816 Change-Id: I7aed32673569a51a3853594ac5b6e6dc04ef3b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531802Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#827322}
-
Fredrik Söderqvist authored
A follow-up CL will make use of the reason to share external resources for cloned <use> elements. Bug: 1147461 Change-Id: I0c4474a28ec9a520bf6ff556e4f386a972882aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536442Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#827321}
-
Mark Pearson authored
*Not* renaming the histogram despite the change in semantics because it looks like <0.5% of omnibox interactions are paste-and-search or paste-and-go. It's probably similar for this metric: paste-and-go as a percent of all omnibox URL navigations. This is small enough that I'm not concerned. Noted the change in semantics in the changelist description. Tested using chrome://histograms Bug: 1144343 Change-Id: I8e1bb4f37b339112174be3c2423fc47394a74661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536250Reviewed-by:
Steven Bingler <bingler@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#827320}
-
Xiaohui Chen authored
Bug: None Test: compiles Change-Id: I1adeaa38059ca097ea57ff9e9296f5a75d351e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536691Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827319}
-
Robert Ogden authored
Persists origin retry-after data to disk. Serialization of a base::Time into a DictionaryValue was tricky, suggestions welcome. Bug: 1146210 Change-Id: I57e356c44d014076fcfe3895d82cd7bd0fbdbdcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531273Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#827318}
-
Ilia Samsonov authored
New baseline are from: https://test-results.appspot.com/data/layout_results/mac-arm64-rel-tests/530/blink_web_tests/layout-test-results/results.html Bug: 1130741 Change-Id: If93f31704380893892d9cf64589fbfdc661f4e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503821Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#827317}
-
Alexander Surkov authored
base::DictionaryValue is deprecated, switch tree formatter API filter/format tree methods to base::Value. Bug: 1133330 Change-Id: If8257f86392020051a3d1c7f9b5598288b9367d5 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522210Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#827316}
-
Scott Lee authored
testLocation has been moved to testMetadata. - https://source.chromium.org/chromium/infra/infra/+/master:go/src/go.chromium.org/luci/resultdb/sink/proto/v1/test_result.proto;l=61-66 - https://source.chromium.org/chromium/infra/infra/+/master:go/src/go.chromium.org/luci/resultdb/proto/v1/test_metadata.proto;l=32-50 R=chanli@chromium.org,robertma@chromium.org CC=nodir@chromium.org Bug: 1137513 Change-Id: I9ab4cf8a4a5117c7d18cb3eae71a61da59715413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532912 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#827315}
-
Aaron Leventhal authored
Fire platform events for aria-current changes Expose as AXAriaCurrent on Mac TBR=kinuko@chromium.org,nektar@chromium.org and support aria-current on Mac AX-Relnotes: notify screen readers when aria-current changes, Bug: 1099323,1141139,1067209 Change-Id: Ic403dfbf3f777adf490f5b346a91f783c362e0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500242 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#827314}
-
Mitsuru Oshima authored
The transition is broken, and fixing the issue most likely need different solution/implementation. Bug: 1148696 Change-Id: I4a164278250f5b6150ac8fc389eda97623e96614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537591Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827313}
-
Clemens Arbesser authored
Bug: b/173128917 Change-Id: I6cea12bab4af38e9610c74406b35823bb3095986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536463 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#827312}
-
Fredrik Söderqvist authored
There are a few cases where we know that calling CreatePropertyForAnimation() will pick the CSS branch, so just call the appropriate function directly. Rename CreatePropertyForAnimation to ParseValue. Bug: 1017723 Change-Id: I316da227a51b8ffd56e6a6b57b45910d836f3ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536443Reviewed-by:
-
Aaron Tagliaboschi authored
Leaving the possibility of turning off for compat issues. Bug: 1070922, 1091285 Change-Id: Ic11ce489705c1c1b4388f24cdbf0ebdd2dca966f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532595 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827310}
-
Aleks Totic authored
Further fixes for blink unit tests. Updated runtime_enabled_features to ensure LayoutNGTable flag does not automatically enable LayoutNG flag. This allows tests that disable LayoutNG flags to pass when LayoutNGTable flag is on. Bug: 958381 Change-Id: I1404ca1e156ab7e2074f012e294c96098b4f407d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534291 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#827309}
-
Toni Barzic authored
With recent changes HomeLauncherGestureHandler has become a wrapper around a SwipeHomeToOverviewController used by ShelfLayoutManager. This CL adds SwipeHomeToOverviewController to ShelfLayoutManager, and removes the unnecessary level of abstraction. BUG=1137452 Change-Id: I19974b96a57718186137ba663dc2fc6b53ee90ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532971Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827308}
-
Ewann authored
This CL adds the EnableCloseAllTabsConfirmation feature to the fieldtrial testing config. Bug: 1119319 Change-Id: Iaa4dae8bdb9151e5199f57a1d66b22bddf5a46f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537674Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605236388-e6c2d3d375b7a2bf2904d66ae9537735f799926a.profdata to chrome-win64-master-1605255855-dc6a80021d99bde94e7af4afa11767b88ac6fee3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a4c4ec79c8f43598c966eaecee334ad08db6223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537667Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827306}
-
Chris Sharp authored
Change-Id: Ia90a4d7706fa2476c487d2513ae689ca08185879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535430 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827305}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4fb2d48fe563..8bf9368130b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I71e528ca94e8dda36e6def0671a3269927869eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536796Reviewed-by:
-
Chris Sharp authored
This change updates: DefaultSensorsSetting IntranetRedirectBehavior TargetBlankImpliesNoOpener Change-Id: I2e4a59e169ba0ae1c7bc90d32b0ae18e7ae9b3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535452Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#827303}
-
Miriam Polzer authored
Looks like service.cc now registers new out-of-process services differently. Changing the code snippet accordingly. Bug: None Change-Id: Iac9b87d5f62006e24a48d3f8fa3feff3ab1fcaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536433 Auto-Submit: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#827302}
-
David Roger authored
This is a simple code cleanup. Change-Id: Ic1c7e848d3f44e5426a91af05de40aea85ffdd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536439 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827301}
-
Sky Malice authored
Attempts to address the problem caused by https://crbug.com/1144328 by watching for browser controls change events and then manually re-trying the test body. This doesn't seem to be entirely foolproof, sometimes onControlsOffsetChanged() is not called and the IPH is still prematurely dismissed. However this seems to be very rare and it's not clear if the root cause is actually 1144328 or something else. Locally testing, testTabSwitcherButtonIph will sometimes fail after 20 runs, but sometimes pass 100 in a row. This should be good enough for the bots when they already use 3 attempts before marking failure. Hopefully this mitigation is only temporary. Bug: 1142979 Change-Id: I2b98da227d1f34ef49b20b6fe6f4c69f8e3a0737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533201 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827300}
-
Maxim Kolosovskiy authored
uploading Bug: 1111809 Change-Id: Ifc174f35e840f9bcbca0e47cfeea1a4636801d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527060 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#827299}
-
Michael Bai authored
Bug: 1137463 Change-Id: I28bd2869b0007d4894f4110a48693014a6ce0b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536083Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#827298}
-
Michael Bai authored
Bug: 1114819 Change-Id: Iba1461d2269d5d07631066c1afb7564da8f12bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536015Reviewed-by:
-
Lukasz Anforowicz authored
After this CL, chrome.tabs.update-initiated (and other extension-API-initiated) navigations to about:newtab will navigate to chrome://new-tab-page (similarly rewriting other URLs - e.g. "about:version" => "chrome://version" or "localhost:1234" [wrong scheme] to "http://localhost:1234"). This CL restores the old, pre-r818969 behavior that some extensions depend on. As pointed out in https://crbug.com/1145381#c4, exposing an ability to manipulate URLs in an unexpected way may erode some of security benefits that were achieved via an earlier r818969. This additional security risk seems acceptable because 1) this ability is only exposed to extension origins and 2) the URL is mutated upfront, before a navigation starts, 3) invalid URLs are rejected. Fixed: 1145381 Change-Id: Ia1dd7d8a0f4fd373d04e1b1353419ac30f88eb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519034Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#827296}
-
Nate Chapin authored
This removes the need for NavigatorNetworkInformation and WorkerNavigatorNetworkInformation. Bug: 1147612 Change-Id: I59f178cf746be7bf25c0246e6fc312f912b9ec47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533636 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#827295}
-
Paul Moy authored
With the initiative to create more sensible defaults for cros_healthd's diagnostic routines, the urandom routine shouldn't need to have its length_seconds parameter specified. If the parameter is not specified, the routine will use a default value. Bug: chromium:1131609 Change-Id: I9fbcedf35ea4d2cfbf44df79afb96510206c46f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533677 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#827294}
-
Dave Tapuska authored
Move the emulation code into the base class. The construction of the emulator is gated on a ForMainFrame check. BUG=1097816 Change-Id: Iec921f6639caad1f216a9429e6a2c96b095c5321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533907 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827293}
-
Mark Mentovai authored
This version of Xcode updates the macOS SDK to 11.0 20A2408 (closer to 11.0 than 11.0.1). Bug: 1108831 Change-Id: I9fe09af1d325e0e68e7351fe7f92ce84e676c922 CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537573 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827292}
-
Kenichi Ishibashi authored
This is a follow-up of [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2532161/comment/b7184485_63304094/ Bug: N/A Change-Id: Icbb987ab9753a817dd64e12f3dd17be7e20919aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537520 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#827291}
-
Aaron Leventhal authored
The call to MaybeUpdateLayoutAndCheckValidity() could end up in a call to OnImageRemoved(), which would remove the image from the map. Bug: 1144269 Change-Id: I9d38f2db283b41ce25bc40e95f10156849ebd39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537571 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827290}
-
edchin authored
Design doc: go/bling-phishguard This CL continues work to compile code in iOS that was previously disabled behind PASSWORD_REUSE_DETECTION_ENABLED. Bug: 1147962 Change-Id: I6a22a7b44d3b2948a99cc5e0dbe409061ec22745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537593 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#827289}
-
sauski authored
Previously the survey dialog inherited the default zoom level of the browser, which caused some sizing issues. This CL resets the zoom level for the HaTS website for the non-primary OTR profile in which the survey is loaded. Bug: 1147390 Change-Id: I7369ad83fae255731617d1a9a43a4c2fd588502d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526344 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#827288}
-
Hidehiko Abe authored
This is a reland of 7fdaa429 Original change's description: > Fix auto key repeat event interpretation. > > The original code interprets "rate" (the second argument) in > millisecond units. However, by definition, it is the number of > key events per second. > > Bug: 1141473 > Test: Ran on DUT. Ran unittest locally. > Change-Id: Iccdcd2c1e5fc3160da054617bc3e173bb23e9657 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507412 > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827223} Bug: 1141473 Change-Id: I9af00fa55fc77cd931d3e203afd47e3a48e4b826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537793Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827287}
-
Clark DuVall authored
This may not be needed anymore, bots seem to pass without it. It looks like this was significantly slowing down startup, so if this does pop up again we probably want to find a better way to deal with it. Startup time improvements: 7.9% on android-go: https://pinpoint-dot-chromeperf.appspot.com/job/15b854a9520000 10.7% on Pixel 2: https://pinpoint-dot-chromeperf.appspot.com/job/12c81a5b520000 3.7% improvement in first contentful paint: https://pinpoint-dot-chromeperf.appspot.com/job/16b631cd520000 Bug: 1146438, 1112001 Change-Id: Icb2dd4333146c866bf67048040414c965eb93513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535615Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827286}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/MixcfTPFsHokR735rFKmvn0Ctjeu1IlipdRyybXfstwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Idfa903002d7d0dd64dbb58a2a58015f9951b908c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537912Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827285}
-
Xianzhu Wang authored
The assumption of not compositing fixed-position elements was outdated. It no longer depends on opacity or PreferCompositingToLCDText. Also convert these tests into ref tests. Change-Id: I1b022d675858299abda0b0d37768aa3198a4ac76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533872 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
