- 15 May, 2018 31 commits
-
-
Scott Violet authored
This is a regression from recent refactoring. The TitledUrlIndex was not being populated on load, resulting in the omnibox not properly surfacing bookmarks. BUG=841375 TEST=covered by test Change-Id: I4fe924e7679f3591e5d8ad18afbfb6fdc3fdc3d4 Reviewed-on: https://chromium-review.googlesource.com/1058278 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#558568}
-
Shakti Sahu authored
Added a protection against a crash occuring during clicking of menu items in Download home. The possible reason could be that DownloadItemView can have a null |mItem| until a onBindViewHolder call is received from the RecyclerView after the creation through onCreateViewHolder. Hence we should have null checks inside the DownloadItemView against |mItem|. Bug: 834918 Change-Id: I76b8a08465da575b9ce364859f827ea3ff053bb5 Reviewed-on: https://chromium-review.googlesource.com/1058369 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#558567}
-
Kyle Milka authored
Add the 'Restore default background' UI string for NTP custom backgrounds. Bug: 839152 Change-Id: Ia221e3f515d97de456c5317f71fcdc19858bfb94 Reviewed-on: https://chromium-review.googlesource.com/1058565 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558566}
-
Bret Sepulveda authored
Split off from crrev.com/c/1048877. IsMouseEventFromTouch would always return false for non-client mouse events even if they were from touch. HWNDMessageHandler lets these fall through anyway so this change alone does not fix any bugs (as far as I know). Bug: 838870, 832291 Change-Id: I2fc58816b7586a3347fade9e8171362137a2cbf5 Reviewed-on: https://chromium-review.googlesource.com/1058548Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#558565}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a67f1510e710..dd13313c34d3 $ git log a67f1510e..dd13313c3 --date=short --no-merges --format='%ad %ae %s' 2018-05-14 chiniforooshan Telemetry: Plumb metadata through results ctor 2018-05-14 szager Rename --simpleperf-* arguments to interval-profiling-* 2018-05-14 simonhatch Dashboard - Stop using "monitored_ in list_tests. 2018-05-14 simonhatch Dashboard - Remove UI features that use "monitored" Created with: roll-dep src/third_party/catapult BUG=chromium:760553 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ib1e749e5330a5511404804bdd08a22922449d478 Reviewed-on: https://chromium-review.googlesource.com/1058317Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558564}
-
Rohit Rao authored
BUG=839439 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5bc6aea6c46d7c25808e3924f9ca45f8452682a5 Reviewed-on: https://chromium-review.googlesource.com/1057457 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#558563}
-
Qiyu Hu authored
Two relevant patches are ag/4013275 and crosreview.com/1043496. Bug: b:78593133 Test: Pass test CtsVerifier test on MTU exchange Change-Id: Ia30313b71ba2c943f7c723c1334bc3e048c1875e Reviewed-on: https://chromium-review.googlesource.com/1050621Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#558562}
-
Joel Hockey authored
Exposes concierge call to FilesApp running in browser. Bug: 832508 Change-Id: Ic4fdbc417b10399ba47f597ce47a1a57c2e13098 Reviewed-on: https://chromium-review.googlesource.com/1056770 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#558561}
-
Takuto Ikuta authored
Bug: 428099 Change-Id: I79d9c7b6b7b9697aee5eb35aaf6761b548d6d769 Reviewed-on: https://chromium-review.googlesource.com/1036715Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#558560}
-
Sam McNally authored
IPC::SyncChannel is happy without a Listener so pass nullptr instead of leaking a NoOpListener. Bug: 788671 Change-Id: I492b52ed6b1a7a1c19b31df1fa1754c841d09e92 Reviewed-on: https://chromium-review.googlesource.com/1056751Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#558559}
-
Scott Chen authored
Since switching to cr-checkbox, the focus of the checkbox within media-router becomes very hard to see. This CL updates the focus style to be more visible. Also simplifies the learn-more link HTML to make it clickable within cr-checkbox. (I looked at the original CL that added the span within the anchor tag, and there doesn't seem to be a reason the nested structure is necessary https://codereview.chromium.org/1606303005). Bug: 842631 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If628e716284ca9477559e84a689db55790ee9180 Reviewed-on: https://chromium-review.googlesource.com/1058331Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558558}
-
Sadrul Habib Chowdhury authored
The presentation callbacks needs to happen after swap-buffer is complete, not in the middle of it. So, run the presentation-callback in the next cycle in ozone-headless. Also add some debug-validation that the presentation callback does not run before swap-buffer ends. BUG=811961 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I97197c9cb383b0b7cac0be9d6a3085f20180cd91 Reviewed-on: https://chromium-review.googlesource.com/1055927Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#558557}
-
Joel Hockey authored
Bug: 834103 Tbr: fukino@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I631cdeb7ab48743424356a64222a4d2276714b1b Reviewed-on: https://chromium-review.googlesource.com/1058727 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558556}
-
Sammie Quon authored
Add a slide animation after swipe to close is activated. Test: manual Bug: 840590 Change-Id: I97757ae0cc9c05896ea85c83707e789c0dec483d Reviewed-on: https://chromium-review.googlesource.com/1058529 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558555}
-
Dave Schuyler authored
This CL fixes a typo in a comment. Along the way abbreviations were expanded and NULL swapped for nullptr to match current standards. There are no logic changes in this CL. Bug: None Change-Id: I406d7c3ff9782e95a81ade89141a8121e4728185 Reviewed-on: https://chromium-review.googlesource.com/1054850 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#558554}
-
chrome://inspectAlexei Filippov authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a3e71176ac7927b29a7885b92487991c6c503d0 Reviewed-on: https://chromium-review.googlesource.com/1058451Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#558553}
-
Qiang Xu authored
Specs: https://screenshot.googleplex.com/JRjnsxbBdeH TBR=sky@chromium.org Bug: 803292 Test: tested on device Change-Id: Ib0dde12c647b5cf5602630bee35900995dfd7c25 Reviewed-on: https://chromium-review.googlesource.com/1056149Reviewed-by:
Qiang Xu <warx@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#558552}
-
Allen Vicencio authored
Adds smb:// as a standard scheme in SmbService and also use SmbUrl to parse URLs passed into mount Bug: 757625 Change-Id: I36ab8d35c9e3dce0f9961dc2e2cfc6250861bd7b Reviewed-on: https://chromium-review.googlesource.com/1054431 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#558551}
-
Erik Luo authored
Bug: 838110 Change-Id: Ic18d63afdb5feae224258b6d5b9abcfaba4c5d19 Reviewed-on: https://chromium-review.googlesource.com/1058547Reviewed-by:
-
Xianzhu Wang authored
Previously, the behavior that a virtual test failed because of missing txt result while the base test were passing suprised many developers and took them much time to find out that the virtual test suite should be added in LayoutTests/ImageFirstTests. Change-Id: I03c6893a4aa7468cd4a327e84d1a4195124c45cb Reviewed-on: https://chromium-review.googlesource.com/1058330 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#558549}
-
Jeff Carpenter authored
Bug: 322720 Change-Id: I04c722cf1443bf09734a1851a4679eafacff22a3 Reviewed-on: https://chromium-review.googlesource.com/1058319Reviewed-by:
-
Mike Wasserman authored
Add window properties to ws2 WindowData structs, like the original ws. Add a helper function, PropertyConverter::GetTransportProperties. Have ClientRoot notify clients on property changes, like bounds changes. Add support for tracking client-initiated property changes. (this only works for client roots? what about child windows?) Encode test tracker property transport values as hex. (so a false bool value is reported as "000..000" instead of "") Add tests for WindowToWindowData and server-initiated property changes. Bug: 837695 Change-Id: I2a8e4ce7eeca0b8300cca9e20d668c178d77ee7e Reviewed-on: https://chromium-review.googlesource.com/1058118 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Vlad Tsyrklevich authored
Change-Id: I0ef73ae2c0a7a075d5dab9453a728a79bbb9d402 Reviewed-on: https://chromium-review.googlesource.com/1057902Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#558546}
-
Xiaocheng Hu authored
This patch introduces NGPhysicalFragment::ResolvedDirection() for text and atomic inline fragments to obtain the resolved direction in bidi inline layout (which can be different from CSS 'direction' property). This patch is split from crrev.com/c/1038058 and has LGTM there. It is a preparation for the following patches: - crrev.com/c/1038058: bidi adjustment for caret position computation - crrev.com/c/1056395: fix caret rect on atomic inlines in bidi text - crrev.com/c/1056029: fix hit testing on atomic inlines in bidi text Bug: 811502, 822575 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1e5fa1817ff987264181547d05e10774ff286fe5 Reviewed-on: https://chromium-review.googlesource.com/1058085Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#558545}
-
Esmael El-Moslimany authored
Bug: 841509 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibaf6dfa740738d3718494d32bd32db2de7a116e8 Reviewed-on: https://chromium-review.googlesource.com/1058178Reviewed-by:
-
Emily Hanley authored
Bug: 842376 Change-Id: I2d94d9f3348d0d1fdd4f938fd60e8c066837fedb Reviewed-on: https://chromium-review.googlesource.com/1058038Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
David Tu <dtu@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#558543}
-
CJ DiMeglio authored
This CL allows for the option for the context_provider in VideoFrameResourceProvider to be null. This is necessary because when we are in software compositing mode, we will have a null context_provider. Bug: 807840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idac8503b57b7a3490402f6db52092ffa4bd99d83 Reviewed-on: https://chromium-review.googlesource.com/1055110 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558542}
-
Lei Zhang authored
- "Print Compositor" is always on when printing is on. - "Printing Service" is for either Print Preview (PWG conversion), or printing on Windows (EMF/PS/Text conversion). - EMF bits are Windows-only. Additionally: - Fix the name of "Printing Service" to be consistent with other names. - Remove an unused GRD entry for the "PDF Convertor" which was the precursor to the "Printing Service". Change-Id: I69744f91b8113a8104438271c7c58fff8161cde7 Reviewed-on: https://chromium-review.googlesource.com/1054639 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
- Remove non-RLS test configurations because RLS has been launched in stable channel. - Reduce number of combinations of configurations and define macros to simplify tests. - Ensure configurations are tested when needed, and fix the test for the new configurations if needed. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6804424162814b4765db67e7e0c314a2afeda583 Reviewed-on: https://chromium-review.googlesource.com/1048026Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558540}
-
Sadrul Habib Chowdhury authored
Make sure the request for presentation-time gets propagated correcly from the pending-tree to the active-tree, so that if presentation-time is requested on LayerTreeHost, it reaches all the way through to the CompositorFrame. BUG=811961 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4745a1b49ed5e404610c6f491e7f98d541b178be Reviewed-on: https://chromium-review.googlesource.com/1056360Reviewed-by:
-
Steven Bennetts authored
We need more owners for the launcher code :) Bug: none Change-Id: Ief61218ab7b3771ca83940dcf0fea8e3af19bf6d Reviewed-on: https://chromium-review.googlesource.com/1058447Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558538}
-
- 14 May, 2018 9 commits
-
-
Will Harris authored
BUG=841878 Change-Id: I70db1aed7130e124cb5e257ac31e4b5711e78963 Reviewed-on: https://chromium-review.googlesource.com/1058327Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#558537}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b15c2c28232c..7e9e7b065a98 $ git log b15c2c282..7e9e7b065 --date=short --no-merges --format='%ad %ae %s' 2018-05-14 gmeinke cbuildbot: remove format command from build_stages 2018-05-14 yunlian clean up USE="thinlto" flag. Created with: roll-dep src/third_party/chromite BUG=chromium:707803 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3ae9a5d244e8fdf2bdb889819d79904f3d591402 Reviewed-on: https://chromium-review.googlesource.com/1058436 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558536}
-
Sunny Sachanandani authored
Initialize create_surface_handle_function_ only once, and handle errors. Handle error when retreiving direct composition device. R=zmo BUG=837378 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibbd8d041e7111ea13936b467c4630b45c9caadcf Reviewed-on: https://chromium-review.googlesource.com/1058173 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#558535}
-
Devlin Cronin authored
Move the ExtensionApiTest class into the extensions namespace, and updated affected sites. This CL should have no functional change. Bug: 117261 TBR=thestig@chromium.org (/chrome) TBR=dmazzoni@chromium.org (/third_party/liblouis) Change-Id: Ibd8820f47ebe53140fd725fb00b1d75c9872808c Reviewed-on: https://chromium-review.googlesource.com/1050580 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#558534}
-
Ryan Landay authored
IncognitoToggleButtonTablet implements a button we have in the Android tablet toolbar that lets a user switch between normal and incognito modes. The button only shows if there's at least one incognito tab currently open. I want to add a similar button to the toolbar on Android phones as part of the horizontal tab switcher experiment. The button won't need as much functionality on phones (we want to always show it, not only when an incognito tab is open, and the click handler will get passed from StackLayout through ToolbarPhone to the incognito button, so we can have StackLayout disable it during animations). This CL refactors the basic functionality into a new base class IncognitoToggleButton, which we can use on phones. IncognitoToggleButtonTablet will now extend this class so as to maintain the current functionality. Bug: 828224 Change-Id: I453be95f42d7baef0d5e237c61bc14f7af7faba2 Reviewed-on: https://chromium-review.googlesource.com/1058433Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#558533}
-
Scott Violet authored
In hopes of simplifying the code I want to have ws2 operate in DIPs. This means a bunch of code assuming pixels in WindowTreeClient needs to be behind a conditional. BUG=837692 TEST=none Change-Id: I13b88eb676eb79247cdf4a435ac673470c359f91 Reviewed-on: https://chromium-review.googlesource.com/1055267 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#558532}
-
https://chromium.googlesource.com/angle/angle.git/+log/5d2ccc534d26..5730c0bf431e $ git log 5d2ccc534..5730c0bf4 --date=short --no-merges --format='%ad %ae %s' 2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android. 2018-05-14 cwallez DisplayGLX: Close the X display if we own it. 2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android. 2018-05-14 geofflang DEQP: Print not supported messages from tests. 2018-05-14 geofflang Add dEQP EGL test expectations for Linux and Android. 2018-05-10 jmadill Vulkan: Implement masked color clear with depth. 2018-05-14 jmadill Fix libGLESv2 wrong .def file. 2018-05-14 jmadill Fix warnings from size_t conversions. 2018-04-23 lfy GLES1: Renderer (minimal) Created with: roll-dep src/third_party/angle BUG=chromium:834269,chromium:842028 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I1ac4625bc1c520a30186f260160dffbdf5787693 Reviewed-on: https://chromium-review.googlesource.com/1058172 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558531}
-
erikchen authored
Previously, the notifications were sent during the tab-close-loop [if multiple tabs were being closed]. This made reentrancy particularly dangerous. The logic in Browser::TabDetachedAt and Browser::TabInsertedAt relied on the |index| parameter to determine whether the index of the active tab has changed [for which there is no notification]. This CL changes those methods to always call SessionService::SetSelectedTabInWindow, and modifies SessionService::SetSelectedTabInWindow to be idempotent. Bug: 842194 Change-Id: I2fc54749e495ab9c925bdba89ef857c4ea3537d9 Reviewed-on: https://chromium-review.googlesource.com/1055732Reviewed-by:
-
Xianzhu Wang authored
We still omit OverflowClip when there is no visual overflow, but we need to apply the inner border radius clip when clipping a box. Bug: 842463 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I19937a58b99cc91f70591041782cf9dc26f1a55b Reviewed-on: https://chromium-review.googlesource.com/1057838Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558529}
-
