- 17 Nov, 2020 40 commits
-
-
danielng authored
Test images don't actually download the DLC, so installing while offline works. Normal images, however, do need to download the DLC when installing Borealis. Adding an extra check to ensure that users are online and also attached a new error to this case. Bug: b/171672034 Change-Id: I351c23f361a9857b4783973820d9f2c4f244a64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539866 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#828105}
-
Eric Orth authored
Created a new DnsResponseResultExtractor class to handle the higher- level parsing of finding and extracting the applicable results from a DnsResponse object. Logic generally moved over from HostResolverManager::DnsTask without any functional change except that nullptr DnsResponse no longer allowed for experimental query types (INTEGRITY and HTTPS). Because these types should not be fatal for a DnsTask, code would previously continue into DnsTask::Parse{Integrity|Https}DnsResponse() even if there was no DnsResponse (e.g. due to connection error), and the parse method would be responsible for inventing the relevant non-fatal result. Now with the new independent extractor class, it would be too inconsistent for it to sometimes require a DnsResponse and sometimes not, so I made it always required and created a new GetExperimentalDefaultResults() method for HostResolverManager::DnsTask to call when it doesn't have a DnsResponse. Address extraction still has its special case extraction logic in DnsResponse (TODO to convert over to those going through the new class). This is unchanged except that the DnsResponse::Result enum has been replaced by the equivalent result enum from the new class (so that DnsTask only needs to deal with 1 result type). Bug: 1147247 Change-Id: Ibb1b4b56ab04d7d85755bb05fd4c8ab915b38709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531115Reviewed-by:Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#828104}
-
Yury Khmel authored
This extends autotest API to return pre-start and start times as ARC state. Pre-start time means mini-ARC start time when we initiate the initial ARC setup process that finally starts Android root init (and on P, other processes like Zygote too). Using pre-start time allows to calculate the overhead time for Android start preparation as a difference between pre-start time and start time of the root Android process init. For the container it includes arc_setup activity and for VM it includes concierge start and booting guest Linux kernel. BUG=b:172851375 TEST=Browser test and in context of tast test Change-Id: Ieb299941849456ecc51de7d3b3d447b67b210fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536078 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Auto-Submit: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#828103}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/metadata: - content_metadata_provider.js - content_metadata_provider_unittest.js - id3_parser.js - metadata_cache_set.js - metadata_cache_set_unittest.js - metadata_dispatcher.js - metadata_model.js - metadata_model_unittest.js - multi_metadata_provider.js - multi_metadata_provider_unittest.js In //ui/file_manager/file_manager/foreground/js: - thumbnail_loader.js - thumbnail_loader_unittest.js Bug: 1133186 Change-Id: I5d6c9408bdccdfc6fd70a3f34775c528ca5aa914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543722 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#828102}
-
Darwin Huang authored
Bug: 1145787 Change-Id: I8d4b1edfbdf2dc739d2b545cb828c35b62a5cfd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520321 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#828101}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b7e7aba113f5..67c1571570a0 2020-11-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8749cb8f182d9a6e54bfd71c3077208830753abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543826Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828100}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f92a7636da65..808ef50106ef 2020-11-17 hypan@google.com Add "third_party/gsutil" to cipd.yaml for devil 2020-11-16 bsheedy@chromium.org [typ] Use requests for ResultSink 2020-11-13 hypan@google.com Add CIPD create instruction cipd.yaml that packages devil If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108014,chromium:1147992 Tbr: rmhasan@google.com Change-Id: I3f3bbd92222e9e80c84939f0bdbfab39d4379318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542748Reviewed-by:
-
David Van Cleve authored
We rolled out ReducedReferrerGranularity, which changes the default referrer policy to strict-origin-when-cross-origin, to 100% in M85 stable. To clean up the experiment, we need to enable the behavior by default. This will take effect in M88; we'll follow up by removing the flag, the corresponding enterprise policy, and the corresponding field trial testing configuration. Changing this base::Feature's default value entails cleaning up the remaining tests that weren't within the field trial testing config's scope. These changes are mostly straightforward, involving updating expectations of full-URL referrers to expectations of the corresponding origins, but some tests require logic changes to make sure that they still cover the desired behavior. (For instance, multiple tests previously expected origins in order to test that a particular, arbitrary, non-default referrer policy took effect: to achieve a similar effect, this CL updates these tests to now expect full URLs and swaps in non-default full-URL-generating policies for the prior non-default origin-generating policies.) Launch approval: crbug.com/1019930 Spec change: https://github.com/w3c/webappsec-referrer-policy/pull/142 Bug: 1014207, 1131688 Change-Id: Ib575af6a858641fb1fe2c8de73941f5702d88191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429247Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#828098}
-
Jan Wilken Dörrie authored
This change makes use of the recently added base::fixed_flat_map in cpp_bundle_generator. The generated code for GeneratedSchemas::Get will now look as follows: // static base::StringPiece GeneratedSchemas::Get(base::StringPiece name) { static constexpr auto kSchemas = base::MakeFixedFlatMap<base::StringPiece, base::StringPiece>({ ... {"namespace", kNamespace}, ... }); auto it = kSchemas.find(name); return it != kSchemas.end() ? it->second : base::StringPiece(); } Change-Id: I73ced3f7f40eacbd630089968ad46a6e664743a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532076Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#828097}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c669bf529619..4f96bf19941b 2020-11-17 m.maiya@samsung.com Remove duplicate entry of glProgramUniformMatrix4fvEXT in gl.xml If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I5b39327a8c04066a3f18fb0a4be8705d31418264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543823Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 527ae681. Reason for revert: suspect causing chrome_all_tast_tests failure on chromeos-kevin-chrome - ui.ShelfLaunchedApps First detected build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/10864 Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8863425670685038096/+/steps/chrome_all_tast_tests_on_ChromeOS/0/logs/Deterministic_failure:_ui.ShelfLaunchedApps__status_FAILURE_/0 -- Unexpected apps in the shelf. Expected only Chrome: [0x2f76930 0x2f76960] -- Original change's description: > Reland "CrOS: Add Files app to default shelf pins in second position" > > This is a reland of 5d6ecbfb > > The failing Tast test (ui.ShelfLaunchedApps) has been updated to > ensure it continues passing after this CL is landed. > > This is the second of a chain of 3 CLs: > > 1. crrev.com/c/2538305: Allow Files app to be pinned by default in > ui.ShelfLaunchedApps > 2. crrev.com/c/2538857: Add Files app to default shelf pins in second > position > 3. crrev.com/c/2538307: Update ui.ShelfLaunchedApps to ensure Chrome and > Files are always pinned > > Original change's description: > > CrOS: Add Files app to default shelf pins in second position > > > > This adds the Files app to the spot after the Chrome icon, for new users > > only. There's also some variations of the default pin layout controlled > > by a Finch experiment, I've moved the Files app up in those layouts for > > consistency. > > > > This change was requested for M88 and will be merged back. > > > > Bug: 1148519 > > Change-Id: Iae54561fec599b813ba97e82a5678fa834a02db2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537214 > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > > Auto-Submit: Tim Sergeant <tsergeant@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827272} > > Bug: 1148519 > Change-Id: I9186b43a651dea4c4de9e46f849d35da9cc6062c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538857 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Tim Sergeant <tsergeant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827981} TBR=xiyuan@chromium.org,tsergeant@chromium.org Change-Id: I36e3778d368973d250824541c422d68b1679babd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543883Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#828095}
-
Melissa Zhang authored
This CL updates browser tests to accommodate for motion when the |sharesheet_bubble_view| appears and disappears. Bug: 1148692 Change-Id: I5ca2eafc2bc5bc2392657d21c39998e532b1a7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543529 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828094}
-
Swapnil authored
We check the list of enabled and disabled extensions in ExtensionPolicyTest.ExtensionRecommendedInstallationMode browsertest. In Windows, the extension is disabled by default as the user is prompted before enabling the extension. On other platforms, the extension is enabled by default. This CL overrides the prompting flag to false. Bug: 1006342 Change-Id: I1d783a8fc381b50e84e5ba85b5c9f37e58b7a986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537641Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#828093}
-
Melissa Zhang authored
This reverts commit ebc8ccab. Reason for revert: Enabling flag for M89 Original change's description: > Revert "[Sharesheet] Turn on flags to enable sharesheet by default." > > This reverts commit 2374eacf. > > Reason for revert: Punting sharesheet to 89 so flags need to be disabled. > > Original change's description: > > [Sharesheet] Turn on flags to enable sharesheet by default. > > > > This CL turns on the kIntentHandlingSharing and kSharesheet flags to > > enable sharesheet feature by default. > > > > BUG=1097623 > > > > Change-Id: Idff4e37934fb730b7f83b86206d555a8c049f12e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460206 > > Commit-Queue: Maggie Cai <mxcai@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816071} > > TBR=dominickn@chromium.org,mxcai@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1097623 > Change-Id: I4d4914ad4ec363c2a63fdaaf7c55163dd1205f99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501161 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821103} TBR=dominickn@chromium.org,mxcai@chromium.org,melzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097623 Change-Id: I47b8cbcc1f05a6092db13b0fe645aad6f06c0325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543530Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828092}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I55a92613e86231ee5c0e67873c8ee45160de4d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542581Reviewed-by:
-
Philipp Hancke authored
BUG=webrtc:12181 Change-Id: Ifaa94e2ac7124a7c275093059c7f67790009aacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542382 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#828090}
-
Takashi Sakamoto authored
This reverts commit 86556051. Reason for revert: suspect causing "generate_build_files" failure on builder "win-chrome" and "win64-chrome" First detected build: https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/10142 https://ci.chromium.org/p/chrome/builders/ci/win-chrome/17094 Sample log: --- ERROR at //chrome/browser/win/conflicts/incompatible_applications_browsertest.cc:21:11: Can't include this header from here. #include "chrome/browser/browser_process.h" ^------------------------------- The target: //chrome/browser/win/conflicts:browser_tests is including a file from the target: //chrome/browser:browser_process --- Original change's description: > Extract browser_process.h/cc into own gn target > > This CL pulls out browser_process.h and browser_process.cc into their > own gn target so that other gn targets can depend on it without creating > cyclic dependencies with //chrome/browser:browser. > > This is required for CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2528519 > > Bug: 1147410, 883570, 925153 > Change-Id: I17ef1f0b1683c4abb7588a6ef24ec89f15647545 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529309 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828077} TBR=fgorski@chromium.org,alancutter@chromium.org,glenrob@chromium.org Change-Id: Idbbe592586e2469f59b9d7b51bf584bd94aa86e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147410 Bug: 883570 Bug: 925153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543169Reviewed-by:
-
Keishi Hattori authored
Use nullptr instead of NULL for places that gives errors when we do the MiraclePtr rewrite. The error is error: conversion from 'int' to 'CheckedPtr<>' is ambiguous Bug: 1073933 Change-Id: Idcdbf9cc986bd03080d0d00ad0556ee80fc4fcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537451 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828088}
-
Melissa Zhang authored
This reverts commit f878d2a2. Reason for revert: Re-enabling flag for M89 Original change's description: > Revert "[Sharesheet] Run file manager browser tests with sharesheet enable." > > This reverts commit efbf947b. > > Reason for revert: Reverting because we are disabling sharesheet flags by default. > Original change's description: > > [Sharesheet] Run file manager browser tests with sharesheet enable. > > > > This CL updates the option.enable_sharesheet default value to be true to > > run all tests with sharesheet enabled. This is because we turn on the > > sharesheet flags by default. > > > > BUG=1097623 > > > > Change-Id: I8714da4bffa30992ca0caf40a34b5237423c34b3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461666 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Commit-Queue: Maggie Cai <mxcai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816074} > > TBR=lucmult@chromium.org,mxcai@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1097623 > Change-Id: I48580601e1287ae27b3c8be32e199963b8cdc713 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501164 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821095} TBR=noel@chromium.org,lucmult@chromium.org,mxcai@chromium.org,melzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097623 Change-Id: I58c0f13790f66cf337058864eec850078a7ecfa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543862Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89e3ceea..15247228 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42812930272783c750b5448cc2318e2d9f1d869b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543316Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828086}
-
Ryan Keane authored
This CL adds DEPS for CmaBackendProxy: - Protobuf is needed for processing of messages sent to/from gRPC (in a future CL) - Openscreen is needed for proto files Change-Id: I376015023915d4ba96a77fee6604726d3b450a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537231Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#828085}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605538580-6a865849c18026af9e6bfd8c91f845d03275941b.profdata to chrome-win64-master-1605560272-77c0d8d0117a28bac6ffdb0ad2fa6b677cbad6f9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3ed12a38b3649cf90286526a677f16b760a01765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543446Reviewed-by:
-
Anand K Mistry authored
In OpenDecoderOnMediaThread(), the error callback to media::BlockingUrlProtocol is being bound to a stack variable. However, the BlockingUrlProtocol (and callback) outlives the function. So any read error that occurs later, such as in AssistantAudioDecoder::Decode(), will cause a write to the out-of-scope variable, causing stack corruption. Bug: None Change-Id: I1149e48416c1a6ca2d8ddd9d9f124cf3bb6d5f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542930Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828083}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2c5b040b5c2a..f2bc3b3edd6f 2020-11-16 enga@chromium.org Print warning if errors occur and no error callback has been set 2020-11-16 cwallez@chromium.org Metal: Wrap NS classes and protocols in NSRef. 2020-11-16 enga@chromium.org Remove --skip-validation test flag from Dawn tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: If1b833528e879683bb77019c693892a54b2c8769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543200Reviewed-by:
-
Mitsuru Oshima authored
This is cleaner tha altering opacity. Bug: 1147187 Change-Id: I7b547b570f06280b6dfccb8ac62afe160151f0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525363Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#828081}
-
Patrick Monette authored
Bug: 971272 Change-Id: I56b43e5119db30fae638be3503a2c990241e5430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530215 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828080}
-
Michael Hansen authored
This sets initial focus to the device name input on the onboarding page. Focus is set manually because the page is initially hidden when the dialog loads, preventing the 'autofocus' attribute from working. Fixed: 1148529 Change-Id: I57a0a7a092591c0b29fe64be60adfdd635e0e141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541644 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#828079}
-
Yu-Hsuan Hsu authored
Create a virtual device when two nodes share the same device because a pinned stream only can pin to a device not a node. The code are modified from ProcessVirtualDeviceName in audio_manager_chromeos.cc. BUG=b:173113548 Change-Id: Ie0d2ecd8c405aebb94e947c8150b2c47346411b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534994Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828078}
-
Alan Cutter authored
This CL pulls out browser_process.h and browser_process.cc into their own gn target so that other gn targets can depend on it without creating cyclic dependencies with //chrome/browser:browser. This is required for CL: https://chromium-review.googlesource.com/c/chromium/src/+/2528519 Bug: 1147410, 883570, 925153 Change-Id: I17ef1f0b1683c4abb7588a6ef24ec89f15647545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529309 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#828077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/598b98fe2b9b..b7e7aba113f5 2020-11-16 michael.liao@microsoft.com [Data Grid]: Fix narrator support for Data Grid tables If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146241 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id7a1cd5905fccc87cf9d9229642c6375155c0418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543304Reviewed-by:
-
David Bienvenu authored
This is the list of directories excluded from presubmit checks for base::Bind, base::Closure, and base::Callback. Bug: 1007807 Change-Id: I3709ef9dff97beabc02c9cc4d90763bfe557b39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543445Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ide7aa804b5ddea0fffdb80c57a6285e20ed1fe07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543310Reviewed-by:
-
Nancy Wang authored
BUG=1083331 Change-Id: I281b0673b84c3ddcf518a42790defeb489554e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542929 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Jacob Kopczynski authored
Move its builders into official.chrome.continuous, remove them, or move them into the new group chromeos.continuous Bug: chromium:1127088 Change-Id: Id6b6449237fd1c384cb716f2b72c837cfddcfe0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543322Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Cr-Commit-Position: refs/heads/master@{#828072}
-
Joey Arhar authored
If you call AbortSignal.abort() and then pass that AbortSignal to addEventListener, it shouldn't add the event listener. It currently adds the event listener and still runs the handler, and this patch stops it from adding the listener in that case. Fixed: 1149553 Change-Id: I7aee86d3fb2901947054c66d50e2aef1bb9467bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541503 Auto-Submit: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#828071}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: Ia1de93b4a1f628fd0598d81e6f969ae569faa3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543368Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828070}
-
Lukasz Anforowicz authored
Bug: 888079 Change-Id: Ia471fbadb864570f5aa48e0ca032ea5d889a0d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533280 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#828069}
-
Noel Gordon authored
Initialize this.backgroundPage_ with new BackgroundWindowSWA() fake if Files app is running in the SWA container. window.BackgroundWindowSWA || null is used to pass Closure compile for current Files app (there are no extern defines for the SWA fakes). No change in Files app behavior. Test: browser_tests --gtest_filter="*launchFilesAppSwa*" Bug: 1113981 Change-Id: Ia079ea266583afd5a2ea67412758a77939327c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542931Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#828068}
-
Jesse McKenna authored
This change migrates uses of base::Bind to BindOnce/BindRepeating, and uses of base::Callback to OnceCallback/RepeatingCallback, in c/b/chromeos/base/locale_util*. Please see crbug.com/714018 for full details about the migration. Bug: 1148570 Change-Id: If16174080f643fddcd5c2d1c1ca86417c5b0b913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536473Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#828067}
-
Harry Cutts authored
This CL adds a new setting for pointing stick sensitivity, with a corresponding slider on the pointers subpage. If the flag is disabled, changes to the mouse sensitivity are copied to the pointing stick setting as well. See go/cros-pointing-stick-settings (Googlers only, sorry) for the design doc. Bug: 1114828 Test: check the new slider changes pointer speed Change-Id: I76d49f66f259276bb90427b4b32e00b415e328f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487253 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
