- 10 Aug, 2020 40 commits
-
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.48-1596451266-benchmark-86.0.4221.0-r1 to 86-4183.57-1597053344-benchmark-86.0.4228.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id2ef8c1d1300cd08e8df855ff9a4ea48afa1b9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796477}
-
Ilia Samsonov authored
This cl removes blinkpy support for Mac10.10, Mac10.11, and Mac Retina. blink web tests for these versions has been removed from waterfall. Bug: 1077312, 1107003, 1114680 Change-Id: I819d0bf7316119b2f5bc127f6eda1deaba7e0cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343548 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796476}
-
Orin Jaworski authored
To aid in smoke testing Pedal concept matching data for all the new languages, a unit test is added that ensures each locale's data set can be loaded and used. Bug: 893183 Change-Id: Ic4686e5cf85dd0f1734fa1a2129f9b4ac3c72da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337107 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796475}
-
Lei Zhang authored
The The is a band, but the the is not. Change-Id: I8c0dc1d4984cf90fe6d83449415e0799f0ec8024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345713Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796474}
-
Liquan (Max) Gu authored
Change: * Move JourneyLogger into ComponentPRImpl to facilitate the moving of PRImpl#close() into ComponentPRImpl. * Move the PRImpl.Delegate.isOffTheRecord interface method into PRFactory. The value of isOffTheRecord will be set according to the merchant page's state at PRFactory#createImpl(). Bug: 1102522 Change-Id: I46de04bdde95e48d8ecdf1c31cf2685fef213001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341948 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796473}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.48-1596448621-benchmark-86.0.4221.0-r1 to 86-4183.57-1597055597-benchmark-86.0.4228.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1104aeba79d1853d9318c7c1df33df9329dc78c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346880Reviewed-by:
-
Patrick Noland authored
This starts the process of hiding the MenuButton view behind the coordinator. Primarily, ToolbarAppMenuManager (renamed to MenuButtonCoordinator) now directly manipulates the MenuButton instead of doing so through TopToolbarCoordinator. MenuButton related functionality is removed from the Toolbar interface, with a few mechanical adjustments to match. Bug: 1086676 Change-Id: I9d8e63e320feec671df5cbd82aed9e330b543865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327315Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#796471}
-
Yicheng Li authored
This enables reusing LoginPasswordView and LoginPinView with custom colors, e.g. for in-session auth dialog and dark mode in the future. Bug: b:156258540 Test: deploy to Nami device, looks the same as without the change. Change-Id: Ic7ec4be3327fa4a94571543d41ba5030807389b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333823Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796470}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.39-1596449559-benchmark-86.0.4221.0-r1 to 86-4183.48-1597052523-benchmark-86.0.4228.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iac91130f7397a64d750169081560d49e33ec3e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346879Reviewed-by:
-
James Zern authored
-O2 is ~11-17% faster than -Os on a pixel 3a using a ndk build of the decoder (r21d) Bug: 1047051 Change-Id: Ifa67bcd7352f535a71f726c32320d6c0353263d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340497Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#796468}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: CrComponentsCrPolicyNetworkIndicatorMojoTestV3.All Change-Id: I6cabdf0cda77044e2a2e77c07ef174531d6f1852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345520Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#796467}
-
liberato@chromium.org authored
Change-Id: I151f491c0e3729cff3a20c4b8ec9fd628ce5898b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343630 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Koji Ishii authored
|NGLineBreaker::RewindOverflow| assumes that |Rewind| rewinds the current |item_index_| to the specified value. However, at some point |Rewind| was changed to not to rewind positioned floats. The DCHECK was to ensure the assumption. This sometimes hits when the line width saturates |LayoutUnit|, and it was considered not too harmful. But crbug.com/1114324 suggested that it may create unexpected internal states which can lead to crashes. This patch removes the assumption from |RewindOverflow|. Bug: 1114324, 1020101, 1029599 Change-Id: I221e87d4ed089ae97aa21a99c2be73dc555f6d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344431Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#796465}
-
Adam Ettenberger authored
This CL addresses a bug where Role::kButton, and possibly other roles that derive their name from descendant contents, were not firing Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. ax_object_cache_impl.cc : - When firing a text changed event, also fire a text changed event for the first ancestor that derives its name from descendant contents. This ensures the nodes are invalidated, send appropriate text changed events, and the changes are serialized to the browser process AXTree. browser_accessibility_manager_win.cc : - FireUiaTextContainerEvent made it possible to fire text events more than once for a given text provider so it has been removed. - Instead, populate a set |text_changed_events_| which contains the text providers via |GetUiaTextPatternProvider| and fire the UIA text events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents - |text_selection_changed_events_| could also potentially end up with the same double-event problem, so it uses GetUiaTextPatternProvider now as well. - Removing usage of std::unordered_set based on the guidance in base/containers/README.md. In general these sets shouldn't grow large enough to benefit from being unordered. AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. Bug: 1105262 Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#796464}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/db0253c93b9b..13ebfa60c3f2 $ git log db0253c93..13ebfa60c --date=short --no-merges --format='%ad %ae %s' 2020-08-10 wub Deprecate --gfe2_reloadable_flag_quic_save_user_agent_in_quic_session. 2020-08-07 nharper Expose ProofSource::Details on QuicCryptoServerStream 2020-08-07 renjietang Add version DCHECKS in GOAWAY handling. 2020-08-07 nharper Tighten content-length header parsing in shared spdy code, not flag protected Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src remove deprecated flag R=dschinazi@chromium.org Change-Id: Ia065ee167b59261845f652258cbeb47584cd8a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346909 Auto-Submit: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796463}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008100800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/IVemt3pOQOKoaDEDMgqmUBfRju4WJsHWYff7SymNScAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159394333,b/159394534,b/159964708,b/160646592,b/160930327,b/161170553,b/161179660,b/162901119,b/163099117 Tbr: help-app@grotations.appspotmail.com Change-Id: I6879e2d711d88064544f2f94459621a93305a18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796462}
-
Ben Pastene authored
It's green now: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-arc-r-chrome/2555 But keep the sanity test experimental. Bug: 1092973 Change-Id: I18085bf954fd512a1a4d0099a292f864a0ea02c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346946 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#796461}
-
Ella Ge authored
The non-virtual one also times out on Linux Leak bot Tbr: hiroshige@chromium.org No-try: true Bug: 1068175 Change-Id: I3b7be7d8d067449f6a811241bbf863a59b8d43ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346851Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#796460}
-
OlivierLi authored
This scope object can be used to disable hang watching when it is known an operation can run in unbounded time. HangWatchScope is renamed to HangWatchScopeEnabled as part of this change also for symmetry. This is done through the introduction of a new persistent flag kHasActiveHangWatchScopeDisabled that can ensure that new HangWatchScopeEnabled instances do not count towards hang watching. Bug: 1034046 Change-Id: I9d8d8b2812a31fe29ba7980d64567798ada3b432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288195Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796459}
-
Elly Fong-Jones authored
Bug: None Change-Id: If52c1528ba8cd0f6f3461bf6bb20ba7d3b5b605b Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346791Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796458}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/577cc158d1e2..01e0ccdc9b8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1f31db9279c9b7e848ccefc510aec1001074f43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346985Reviewed-by:
-
Andrew Grieve authored
This reverts commit 67fc091c. Reason for reland: Writing both build_vars.json & build_vars.txt Original change's description: > Revert "build_vars.txt: Changed to build_vars.json" > > This reverts commit 6e002e1f. > > Reason for revert: Official build failure crbug.com/1114609 > > Original change's description: > > build_vars.txt: Changed to build_vars.json > > > > And moved helper function into gn_helpers.py > > > > It was only ever in .properties format so that it > > could be easily parsed by bash, but we no longer need > > that. > > > > Also fixes default_android_sdk_version to be a string. > > -next builds need it to be a string. > > > > Bug: None > > Change-Id: I99541f18510de93dae4c0d68b734638564f74ee2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340673 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#796020} > > TBR=dpranke@google.com,agrieve@chromium.org,mheikal@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: None > Change-Id: Iad8597f6af00c534245fd1a40d1809d952758f47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344626 > Reviewed-by: Ben Mason <benmason@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796387} Bug: 1114750 Change-Id: I1019351a294e54701c093911f67a1fb6b7bd34d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346965Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#796456}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0fa91d0f3563..03b15131d393 2020-08-10 saagarsanghavi@google.com [Backward Compatible] Timing and RDB for Lower-level checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106943 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: If67abb7c3a127bd417e95fee9d44904c2b6baa2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346870Reviewed-by:
-
Chris Harrelson authored
This is replaced with CompositingInputs + CompositingAssignments. Bug: 1112350 Change-Id: I3dfc709ddf7826c7a9b49950d25509c1e22efe70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343537 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#796454}
-
Gary Tong authored
Bug: 1106950 Change-Id: I620b2e38047f9f5ea89afc9cd764d908b8ad677f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343486Reviewed-by:
-
Dan Harrington authored
- If the surface is hidden, close FeedStreamSurface. This frees resources, and corrects metrics logging done in components/feed - Fixed problem where toggling the feed back on might 'open' a feed surface even though it's not shown. And a couple tangential changes: - Added DVLOGing of load latencies, for debugging. - Fixed a crash where GetSliceIndexFromSliceId was called with a null model_. Bug: 1044139 Change-Id: I2838eb925ef47e8bbdba82ae9875ee1bf6b15a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343640Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#796452}
-
Katie Dillon authored
Removing two full updatePolicy calls as they aren't necessary when only changing the compositor priority. We DCHECK that there is only one compositor task queue so directly changing the policy and computing the new priority for just the compositor task queue is sufficient and avoids the extra steps of a full policy update. Change-Id: I7f8226e01b42032ea893a5347a1a0fdad2bf5c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302971 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#796451}
-
Fergus Dall authored
This is a reland of 6d67f881 Original change's description: > Start setting StartVmRequest.vm > > This is currently ignored by concierge when starting termina, but > since termina can now be installed in multiple different locations we > need concierge to start taking the value that chrome sets. > > Bug: 953544 > Change-Id: I51b1ea50a5ae056d6af6baa0743a3cb0c8f8f5e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329126 > Commit-Queue: Fergus Dall <sidereal@google.com> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Cr-Commit-Position: refs/heads/master@{#795346} Bug: 953544 Change-Id: Ib741759a5b61dc810d66c9d182131766247a5a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341224 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#796450}
-
Mohamed Heikal authored
AGSA queries an apps icon by name and thus fails on collapsed names. The fix is to not collapse mipmaps (application icons). This also fixes an old layering bug where chrome only resources were listed under android_webview by allowing multiple config files for use by Monochrome and Trichrome. Additionally the directive no_obfuscate has been deprecated with no_collapse as its replacement. TBR=boliu@chromium.org # noop change to webview config file. Bug: b/161564466 Change-Id: Idb735cd07e9e95ab572297c8dc4848451d8d52bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343755Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#796449}
-
Xianzhu Wang authored
This makes it clear to callers that it is never null to avoid unnecessary null checks. Change-Id: Ia21728e2931b9147041581b94337e00ffa2d495c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343586 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796448}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/32d36b08379e..12bc13e26d28 2020-08-10 jacktfranklin@chromium.org Add enum parsing support to component bridges If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I05ab898798c3ef8a05004b088b56ec17458aca4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346866Reviewed-by:
-
Fergus Dall authored
This is a reland of d539d683 The previous attempt broke a couple of browser tests which used RunUntilIdle to wait for the uninstall to finish. This worked fine as long as the uninstall process ran entirely on the UI thread, but it now posts a blocking task to the thread pool. This causes the UI thread to become idle while waiting for the response, causing the test to continue prematurely. This patch replaces this with explicit usage of QuitClosure. Original change's description: > Allow termina to be installed via dlc > > Also refactor the current installer code out of CrostiniManager > > Bug: 953544 > Change-Id: Iad0850ffba616ac3f45adff63a5e21d57d3b5e7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330111 > Commit-Queue: Fergus Dall <sidereal@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795336} Bug: 953544 Change-Id: I1e53391eef80fada087d7bd22ee16ff01aaccf20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341223Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Nate Fischer authored
This lets java_cpp_enum and java_cpp_strings treat "WebView" like one word. This also fixes an existing test in java_cpp_strings_tests.py. Fixed: 1112005 Test: vpython build/android/gyp/java_cpp_strings_tests.py Change-Id: Id9f1ca904b4d6c90ccc1a810033c5614a0514492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337735Reviewed-by:
-
Scott Violet authored
it's flaky. BUG=1114752 TEST=test only change Change-Id: Ie28ea8bc048d3286d748bace5b0c560bd866b440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347046 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#796444}
-
Scott Violet authored
In WebLayer incognito profiles are not backed by a real profile. This means there is no FaviconService to use in this case. This makes FaviconHandler/Driver work with a null service so that WebLayer can still offer favicons in incognito mode. BUG=1076463 TEST=none Change-Id: Idc049f37c469576720847ed817453b17ec519aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339550Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796443}
-
Miguel Casas authored
Many moons ago, DisplayConfigurator::SetColorMatrix() / SetGammaCorrection() were only called once after parsing a hypothetical ICC file -- those days CrOS didn't manipulate the display's color characteristics, so we configured either / both, and cleared the ColorSpace to avoid overwriting those two DRM tables unnecessarily. Note that the matrix/de/gamma tables were loaded after every wake up. Time after that came Night Light and other color mgmt projects, and this code path started being used when coming out of sleep/hibernate etc, with the caveat that after applying their matrix/de/gamma tables, the cached colorspaces was/were still cleared and lost. The fix is then simple: since we need the |color_space| to stick around, this CL avoids clearing it. RunColorCorrectionClosureSync() is then superfluous and can be removed, making evident that searching for |display_id| in |cached_displays_| is only for verification purposes: Bug: b:159224397, 1091552 Change-Id: I553646217c1012221844242c96148b8526657217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342583Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796442}
-
Nela Kaczmarek authored
Bug: 1108279 Change-Id: I0d50e041c78f871fa9167ff157aa301559c6ff91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341646 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#796441}
-
Wan-Teh Chang authored
For the tests that iterate over multiple image formats, swap the loop so that instead of one test that loops over image file extensions, it creates multiple tests that each test one image file extension. Stephen McGruer outlined this change in https://crrev.com/c/2304961. Test: third_party/blink/tools/run_web_tests.py -t Default \ external/wpt/html/canvas/element/manual/wide-gamut-canvas/canvas-createImageBitmap-e_srgb.html Bug: 1099028 Change-Id: Iac122b5aee4fecd66962e75ed4bd7ddca55b0add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346828Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fb57bbd19358..a1d5ae72b241 2020-08-10 teddy.wang@siliconmotions.corp-partner.google.com usergroup_baseline: Add smdisplay user to video group 2020-08-09 manojgupta@google.com chromeos_config: Only keep base/test images for sanitizers 2020-08-08 andrewlassalle@chromium.org dlc_lib: Add allowlist for test boards 2020-08-08 andrewlassalle@chromium.org dlc_lib: Check for lsb-release file before opening it 2020-08-08 tcwang@google.com afdo: Fix breakage due to renaming of Chrome debug binary 2020-08-08 lamontjones@chromium.org SysrootService: use package_indexes list when present. 2020-08-08 saklein@chromium.org service/test: Fix ebuild test metrics. 2020-08-08 vapier@chromium.org gerrit: add a help-all subcommand 2020-08-07 saklein@chromium.org service/sdk: Change argument from proto to string. 2020-08-07 erikchen@chromium.org Add lacros support to deploy_chrome.py 2020-08-07 lamontjones@chromium.org api: freshen python bindings. 2020-08-07 sanikak@chromium.org auto_updater_transfer: remove fallback devserver calls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Id47fb717106272df57d047f3106d159b96764c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346885Reviewed-by:
-
Avi Drissman authored
It is undefined behavior in C++ to access memory of one type with a pointer of another type. Use bit_cast to safely do it. Bug: none Change-Id: I170c81e0cc7dc5b7bcf63b0776758c4c65a748bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340180 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796438}
-
