- 22 Mar, 2014 10 commits
-
-
jrummell@chromium.org authored
Audio stream KeyId: "1234567890123456" Key: 0x303062F16814D27B68EF122AFCE4AE0A Video stream KeyId: "0123456789012345" Key: 0x7A7A62F16814D27B68EF122AFCE4AE0A BUG=308704 NOTRY=true Review URL: https://codereview.chromium.org/208623009 git-svn-id: svn://svn.chromium.org/blink/trunk@169781 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rob.buis@samsung.com authored
Avoid using getPresentationAttribute in ReferenceFilterBuilder because it is deprecated, instead use getPropertyValue. This is the last internal use of getPresentationAttribute so a follow-up patch can remove it. Review URL: https://codereview.chromium.org/201463003 git-svn-id: svn://svn.chromium.org/blink/trunk@169780 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eae@chromium.org authored
Now that we no longer have HFONT references in FontPlatformDataWin we can remove a bunch of defines and includes. R=schenney@chromium.org Review URL: https://codereview.chromium.org/200693004 git-svn-id: svn://svn.chromium.org/blink/trunk@169779 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jbroman@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/204353005 git-svn-id: svn://svn.chromium.org/blink/trunk@169778 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rego@igalia.com authored
When we use checkLayout() on a grid item, the results (PASS or FAIL messages) are added as new auto-placed items in the grid. This causes that the grid is marked as dirty which could hide bugs in the tests. Modify the related layout tests to use a different container for the test results. Updated expectations accordingly. There is one test missing "grid-item-addition-auto-placement-update.html". Which will be modified in the patch to fix the bug in RenderGrid::addChild() (see https://codereview.chromium.org/198703004/). Review URL: https://codereview.chromium.org/208133003 git-svn-id: svn://svn.chromium.org/blink/trunk@169777 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vollick@chromium.org authored
Currently, we only set a scroll parent for "localRootForOwningLayer".I.e., the highest GraphicsLayer in the CLM-managed hierarchy, excluding the squashing containment layer. But for "scroll buddies", we need the scroll child to be the very top of the hierarchy. We also need to ensure that scroll buddies are not prevented from squashing together because of the additional "I've got a scroll parent" compositing reason. This cl also disables chicken-egg asserts that trip w/ universal accelerated overflow scroll and changes how we compute composited bounds for squashed layers (we currently pull the bounds from the clipper, but it picks the wrong "clipping root" in this case). With this CL, universal accelerated overflow scrolling and squashing work nearly perfectly modulo known hit testing bugs (which can prevent touch scrolling) and repaint issues (separate issue reported here https://code.google.com/p/chromium/issues/detail?id=351790). BUG=328156 Review URL: https://codereview.chromium.org/131543013 git-svn-id: svn://svn.chromium.org/blink/trunk@169776 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
alancutter@chromium.org authored
The animate() method on Element is severely under tested. This patch makes use of the existing animation interpolation tests to also test element.animate(). Just over 50% of the tests pass, the failures are being checked in as expected failures for now as it is representative of the current state of element.animate(). BUG=352472 Review URL: https://codereview.chromium.org/203723005 git-svn-id: svn://svn.chromium.org/blink/trunk@169775 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tasak@google.com authored
- added HashSet holding SVGFontFaceElement and cleared after document's style recalc is finished, and - made widthIterator return default value when SVGFontFaceElement is not in document. BUG=352178 TEST=fast/dom/remove-svg-font-face-element-crash.xhtml Review URL: https://codereview.chromium.org/198783006 git-svn-id: svn://svn.chromium.org/blink/trunk@169774 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
acolwell@chromium.org authored
This patch adds logic to SourceBuffer::setTimestampOffset() to reject invalid values. A LayoutTest to verify proper behavior for a variety of values was also added. BUG=353245 TEST=LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html Review URL: https://codereview.chromium.org/202423002 git-svn-id: svn://svn.chromium.org/blink/trunk@169773 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eae@chromium.org authored
This reverts r258671 (commit 04d85dfa329176dc489bdcf9d2654f38e72a484e) as it broke android. BUG=355167 TBR=pdr@chromium.org Review URL: https://codereview.chromium.org/209303002 git-svn-id: svn://svn.chromium.org/blink/trunk@169771 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 21 Mar, 2014 30 commits
-
-
rafaelw@chromium.org authored
This maintains the invariant that microtask work (e.g. Mutation Observer callbacks) always occur on an empty page script stack. Previously, it was possible for a microtask to fire before the outer script had exited on document.write('<script>') or showModalDialog, etc.. R=adamk@chromium.org, adamk BUG=352181 Review URL: https://codereview.chromium.org/184043002 git-svn-id: svn://svn.chromium.org/blink/trunk@169770 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
morrita@chromium.org authored
This is a speculative revert to address reported crashes in the wild. > [HTML Import] Let script block by pending resources created by lifecycle callback > > This change tells the HTML parser know that lifecycle callbacks, > that is triggered through Microtask checkpoint, can create resources that > blocks scripts. > > It also streamlines the unblock notification from Document to the parser > into didLoadAllScriptBlockingResources(). Now both didRemoveAllPendingStylesheets() > and didLoadAllImports() checks resource readiness and invokes the unified notification. > > TEST=custom-element-style-block.html > BUG=346408 > R=dglazkov@chromium.org, dominicc@chromium.org > > Review URL: https://codereview.chromium.org/202813002 TBR=morrita@chromium.org Review URL: https://codereview.chromium.org/201673005 git-svn-id: svn://svn.chromium.org/blink/trunk@169769 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rob.buis@samsung.com authored
Verify that a very large shape-margin value combined with a very small shape-outside image defines a shape that matches the shape-outside element's margin-box. This is a merge of http://trac.webkit.org/changeset/166019 by Hans Muller <hmuller@adobe.com>. BUG=354917 Review URL: https://codereview.chromium.org/208423003 git-svn-id: svn://svn.chromium.org/blink/trunk@169768 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
There's no need to constantly recompute this data. It's already determined by the style information, so we might as well just compute it once during style recalc. Note: We're still computing all the direct compositing reasons during style recalc (via updateLayerCompositingState in RenderLayer::styleChanged), but now we skip recomputing the style determined reasons again when updating layout and compositing. ASSERTs verify that we get the same answer as before. This CL reduces the amount of time spent in the compositing update for dragging the drawer in the Polymer calculator by 3%. Review URL: https://codereview.chromium.org/207513002 git-svn-id: svn://svn.chromium.org/blink/trunk@169766 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
chrishtr@chromium.org authored
The feature has been at status=experimental for over a month, and all known bugs have been fixed. BUG=335247 Review URL: https://codereview.chromium.org/208153007 git-svn-id: svn://svn.chromium.org/blink/trunk@169765 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
japhet@chromium.org authored
Currently, it only guarantees no two siblings have the same unique name. This patch tries much harder to guarantee that no two frames in the same page have the same unique name. BUG=352651 TEST=http/tests/history/frameset-repeated-name.html Review URL: https://codereview.chromium.org/207143002 git-svn-id: svn://svn.chromium.org/blink/trunk@169764 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
This CL teaches CompositedLayerMapping::updateCompositedBounds about the m_needToUpdateGeometry dirty bit. Now we only update the composited bounds if they could have possibly changed. This CL saves 14% of the compositing update in Polymer's calculator sample app. R=ojan@chromium.org Review URL: https://codereview.chromium.org/208643002 git-svn-id: svn://svn.chromium.org/blink/trunk@169762 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fs@opera.com authored
It's trivial to replace the local AnimationClock in SMILTimeContainer with the one from Document after making the observation that the only current manipulations (updateTime/unfreeze) are already performed by PageAnimator (DocumentAnimations::updateAnimationTimingForAnimationFrame) and RenderLayerCompositor (DocumentAnimations::startPendingAnimations). With this change it become possible to push the DiscardScope into updateAnimationsAndScheduleFrameIfNeeded - so do that to simplify the code (by reducing the number of places that instantiate a DiscardScope.) BUG=231576 Review URL: https://codereview.chromium.org/198723005 git-svn-id: svn://svn.chromium.org/blink/trunk@169761 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eae@chromium.org authored
Revert r169675 (commit aca3f9e60c129c49e4e48cc9097f80d7f697c417) as it might have caused the Mac ASAN bot to fail. R=vandebo@chromium.org BUG= Review URL: https://codereview.chromium.org/208073005 git-svn-id: svn://svn.chromium.org/blink/trunk@169760 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
leviw@chromium.org authored
Step 1 of refactoring LayoutState to be a more general quick-lookup while walking the tree. No behavior change, just better encapsulation. BUG=343896 Review URL: https://codereview.chromium.org/207223003 git-svn-id: svn://svn.chromium.org/blink/trunk@169759 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
scherkus@chromium.org authored
The existing compositing/video-frame-size-change.html layout test provides the coverage for the compositing path. BUG=354168 R=enne@chromium.org Review URL: https://codereview.chromium.org/208703002 git-svn-id: svn://svn.chromium.org/blink/trunk@169758 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fmalita@chromium.org authored
Unreviewed gardening. BUG=344497,352628 TBR=jcgregorio@chromium.org Review URL: https://codereview.chromium.org/208373002 git-svn-id: svn://svn.chromium.org/blink/trunk@169756 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fs@opera.com authored
The null-attribute and 'indefinite' cases were not cached, which made this method do some unnecessary work for each animation update. BUG=354520 Review URL: https://codereview.chromium.org/206013003 git-svn-id: svn://svn.chromium.org/blink/trunk@169755 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
reed@google.com authored
BUG= Review URL: https://codereview.chromium.org/203443004 git-svn-id: svn://svn.chromium.org/blink/trunk@169754 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
NavigationAction class before this patch had a RefPtr<Event> as its member. The event retained the previous document longer than necessary, resulting in a soft leak. This patch removes the member from the NavigationAction class and replaces it with DOMTimeStamp of the event which is the only information may be retrieved afterward. BUG=None Review URL: https://codereview.chromium.org/206453010 git-svn-id: svn://svn.chromium.org/blink/trunk@169753 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vollick@chromium.org authored
Contrary to the assertions on the bug, the current code is correct. As the user changes the selection, there will naturally be a visual affordance to indicate the selection changes. By the time we scroll, RL::hasBlockSelectionGapsBounds will be current and correct. That said, the hope is that in the future paint will have no side effects at all, nor do we want layout tests to require repaints during their execution. So even if this is technically correct it's undesirable on a number of levels. This cl replaces the use of hasBlockSelectionGapsBounds with non-paint related code (in fact, that function could be removed entirely). R=abarth@chromium.org BUG=353827 Review URL: https://codereview.chromium.org/208203002 git-svn-id: svn://svn.chromium.org/blink/trunk@169752 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fs@opera.com authored
Add a helper function 'svgRootElement' and use that where appropriate. Review URL: https://codereview.chromium.org/208503002 git-svn-id: svn://svn.chromium.org/blink/trunk@169751 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mikhail.pozdnyakov@intel.com authored
SSIA. Considering the memory sensitiveness of strings in Blink we should make sure that no change can accidentally increase their size. Review URL: https://codereview.chromium.org/205583005 git-svn-id: svn://svn.chromium.org/blink/trunk@169750 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mlamouri@chromium.org authored
BUG=353997 Review URL: https://codereview.chromium.org/203193015 git-svn-id: svn://svn.chromium.org/blink/trunk@169749 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
japhet@chromium.org authored
Changes to the LRU lists are hidden behind a call to MemoryCache::update(), which adjusts sizes, access count, and LRU list position as appropriate. All of these are to some degree interrelated, since we keep multiple LRU lists and select one to use based access count and resource size. Also, remove the Resource::inCache() bit in favor of a MemoryCache::contains() BUG=none Review URL: https://codereview.chromium.org/164333008 git-svn-id: svn://svn.chromium.org/blink/trunk@169748 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mikhail.pozdnyakov@intel.com authored
Simplify VectorMover<true, T>::swap() - use std::swap_ranges instead of creating the loop ourselves, plus the patch removes a "FIXME" comment - compiler already produces the most efficient code for POD types swap, so there is no need to introduce compex algorithms for that (checked with GCC 4.7.2). Review URL: https://codereview.chromium.org/208253003 git-svn-id: svn://svn.chromium.org/blink/trunk@169747 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
{,un}setPendingActivity relies on RefCounted, which is going to be deprecated in oilpan. This CL removes usage of these methods in SpeechRecognition.cpp, and provide hasPendingActivity() implementation as replacement BUG=354845 TEST=fast/speech Review URL: https://codereview.chromium.org/208273002 git-svn-id: svn://svn.chromium.org/blink/trunk@169746 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dgozman@chromium.org authored
BUG=353090 Review URL: https://codereview.chromium.org/203683005 git-svn-id: svn://svn.chromium.org/blink/trunk@169745 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
Make this EventTarget-derived object a garbage collected object. R=haraken@chromium.org BUG=340522 Review URL: https://codereview.chromium.org/208083003 git-svn-id: svn://svn.chromium.org/blink/trunk@169744 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
apavlov@chromium.org authored
As a drive-by, shadow DOM editing tests have been extracted into a new HTML R=aandrey, pfeldman, vsevik BUG=353910 NOTRY=true Review URL: https://codereview.chromium.org/206503002 git-svn-id: svn://svn.chromium.org/blink/trunk@169743 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vollick@chromium.org authored
This CL uses some memoization to avoid unnecessary tree walking when computing scroll parent. Why memoization and not just passing down the values? Because sad. It turns out that we recur on the stacking tree (we have to - squashing demands processing stuff in paint order), but we walk up the render tree asking questions. Different tree topologies; we could very easily visit a RenderLayer before its great great grandparent. No functionality change -- covered by existing tests. BUG=None Review URL: https://codereview.chromium.org/206283003 git-svn-id: svn://svn.chromium.org/blink/trunk@169741 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
BUG=354791 TBR=vsevik Review URL: https://codereview.chromium.org/208053005 git-svn-id: svn://svn.chromium.org/blink/trunk@169740 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
BUG=354849 TBR=alancutter Review URL: https://codereview.chromium.org/207613006 git-svn-id: svn://svn.chromium.org/blink/trunk@169739 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
HeapSnapshotView should be unsubscribed from events it has been subscribed to, otherwise it will leak when corresponding profile is removed. BUG=None Review URL: https://codereview.chromium.org/208053003 git-svn-id: svn://svn.chromium.org/blink/trunk@169738 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
All old SVGProperties implementations are now all removed. The "New" prefix for distinguishing two implementations are no longer needed. Changes automatically generated from: sed -i 's/NewSVG/SVG/g' `find . -name \*.cpp -or -name \*.h` BUG=349370 Review URL: https://codereview.chromium.org/208133002 git-svn-id: svn://svn.chromium.org/blink/trunk@169737 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-