- 13 Mar, 2018 40 commits
-
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib5331f5a51027443effa4115fec652d0b678176c Reviewed-on: https://chromium-review.googlesource.com/961448 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542903}
-
Vlad Tsyrklevich authored
Change-Id: I7717f832c3aeb005b5258fd4206c14dccc13aba1 Reviewed-on: https://chromium-review.googlesource.com/961250Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#542902}
-
Nate Fischer authored
This is a follow-up to http://crrev/c/958229. This moves the implementation of getSafeBrowsingPrivacyPolicyUrl() to the UI thread, and adds a DCHECK to assert this. This was done under boliu@'s recommendation, since AwBrowserContext seems like it should be used mainly on the UI thread only (based on how content::BrowserContext is used). We still permit apps to call WebView#getSafeBrowsingPrivacyPolicyUrl() on any thread, since it is a static method. We accommodate this by blocking and running on the UI thread. Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testGetSafeBrowsingPrivacyPolicyUrl Change-Id: I275825d6a49e08247e2839ec4a93272ce4204c98 Reviewed-on: https://chromium-review.googlesource.com/958040Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542901}
-
jonross authored
A few tests had been flaking on viz configs. Some have since shown themselves to be flaking everywhere. Others have been triaged to have been caused by now fixed issues. This change updates the filter to re-enable one on viz_browser_tests. While only re-enabling some on the FYI bot for viz_content_browsertests. TBR=kylerchar@chromium.org TEST=viz_browser_tests, viz_content_browsertests Bug: 760181 Change-Id: I08e643dd8074ab3b7a4d6bbbe72063da81d21b04 Reviewed-on: https://chromium-review.googlesource.com/961262Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#542900}
-
Bailey Berro authored
This change creates the SmbTaskQueue class for queueing FileSystem operations that will be sent over D-Bus to the Smb Daemon. BUG=chromium:757625 Change-Id: Id48b8b4abbc5841f42ae1b52dca2e142f2ba6706 Reviewed-on: https://chromium-review.googlesource.com/953134 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#542899}
-
Koji Ishii authored
This patch fixes VisualRect for flipped block (vertical-rl) writing-mode. LayoutObject::LocalVisualRect should be in flipped physical coordinate system, but was not flipped in LayoutNG. This patch fixed it to be flipped physical coordinate system. In addition: * LocalVisualRectFor() is moved to NGPaintFragment, by using NGPaintFragment::InlineFragmentsFor(). * PaintInvalidator::UpdateVisualRect() applies the same mapping to fragments as the LayoutObject. Before this patch computed the mapping from local and backing rect, but this method does not work in flipped writing-mode. 11 tests turn to pass. More tests were expected to pass, but it turned out that there are more fixes needed for vertical-rl in paint and a few others. Bug: 636993 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3176a89bd96afa75ef024b1441d85fec5d30d75a Reviewed-on: https://chromium-review.googlesource.com/960403Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#542898}
-
Lukasz Anforowicz authored
//services/network won't be able to directly use ContentBrowserClient, so this CL refactors CORB-related parts of ContentBrowserClient in such a way that the data they return in a browser-process can be easily passed to the network service process. Specifically, this CL changes the following ContentBrowserClient API: virtual bool ShouldBypassDocumentBlocking(const url::Origin& initiator, const GURL& url, ResourceType resource_type); into: virtual const char* GetInitatorSchemeBypassingDocumentBlocking(); Bug: 792546 Change-Id: I39d88a97ff24d776319b2687837838fa594054c5 Tbr: rdevlin.cronin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/958041 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#542897}
-
https://skia.googlesource.com/skia.git/+log/98ad5b7a4bca..296de50b4c2e $ git log 98ad5b7a4..296de50b4 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 bsalomon Fix possible overflows in hair line path renderer vertex counts Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Idcc466699d243620f27c969eb3c3dff3440f1482 Reviewed-on: https://chromium-review.googlesource.com/961142Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542896}
-
Pedro Amaral authored
This change removes three methods from BottomSheet.java Bug: 814528 Change-Id: Ib03a1ce24e41a69dd8124daabe8355196e82d072 Reviewed-on: https://chromium-review.googlesource.com/956264Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#542895}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e733c104. With Chromium commits locally applied on WPT: ad9cc156 "Add WPT tests for feature policy frame policy" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13833 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=leon.han@intel.com No-Export: true Change-Id: I1f09ffbc549ad1d3962e476f3a77d8d2701fce79 Reviewed-on: https://chromium-review.googlesource.com/961104 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542894}
-
Scott Chen authored
Bug: 819862 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I67b2d99c2efa25749764bc8cc524c472d57a0c67 Reviewed-on: https://chromium-review.googlesource.com/955952 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#542893}
-
Luna Lu authored
Bug: 821547 Change-Id: Idd4bd103a12935599a811a3d02b6f0071637543d Reviewed-on: https://chromium-review.googlesource.com/961443 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542892}
-
Daniel Vogelheim authored
HTMLPreloadScanner is written to be simple and fast. SubresourceIntegrity::ParseIntegrtiyAttribute assumes that the caller does error checking, and won't call it twice for the same element. Reconcile the two by adding a relaxed version, TryParseIntegrityAttribute. Bug: 818385 Change-Id: I722fb80c283249941e8db14a8efc9af392bc1cbc Reviewed-on: https://chromium-review.googlesource.com/948848 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#542891}
-
Saman Sami authored
We thought embedding_render_widget_ would outlive the BrowserPlugin, but apparently not, so use weak pointers to ensure we don't access embedding_render_widget_ once it's gone. Bug: 812966 Change-Id: I7f374a63bd34db3cb616fa961d7c504570c5ef2d Reviewed-on: https://chromium-review.googlesource.com/959239Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#542890}
-
Jun Choi authored
Move U2fApduCommand::Create{Version, Sign, Register}() to U2fRequest interface. This is a preliminary work for migrating APDU to src/components. Bug: 807836 Change-Id: I2db9f503d9925c891f789fa9abb06f26a9fe98f8 Reviewed-on: https://chromium-review.googlesource.com/923417 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542889}
-
David Bienvenu authored
Change-Id: Ia674d6e5cae68b3a60f67f655ba6353e31be053a Reviewed-on: https://chromium-review.googlesource.com/957475Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542888}
-
Anita Woodruff authored
- Display() Part 3: Attribute notification correctly by looking up service worker scope from the service worker registration ID. - Note the mojo pathway is guarded behind the NotificationsWithMojo flag as development continues. R=peter@chromium.org Bug: 796991 Change-Id: I7fb7b9402cb44ee6810b29c8ed472771842fc5ed Reviewed-on: https://chromium-review.googlesource.com/929082 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#542887}
-
Matt Reynolds authored
On OSX, opening a device with USBDeviceOpen may fail with kIOReturnExclusiveAccess if the device has already been opened by another process. This CL checks for the exclusive access error and waits for a signal from the OS that the device is available. BUG=811480 Change-Id: I8ed3cd25e52e80ca1d6086e151a63b9df0e99e0c Reviewed-on: https://chromium-review.googlesource.com/915018Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#542886}
-
Yury Khmel authored
REQUIRED type is deprecated and FORCE_INSTALLED should be used. Since Friday app install log stopped working due not supporting FORCE_INSTALLED. TBR=bartfab@chromium.org Bug: b/73277923 Test: Manual + unit test Change-Id: Id1fa5ef4f8eb591188bf91e57f9367326e33dd8c Reviewed-on: https://chromium-review.googlesource.com/957829 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#542885}
-
Evan Stade authored
also, - use native notifications any time Mash is enabled - get rid of ScopedKeepAlive in ProfileNotification for Chrome OS and the call to clear ScopedKeepAlives in HandleAppExitingForPlatform. This should have no effect on a normal run of Chrome, where the browser process is kept alive regardless of how many browser windows are left, but it's necessary to do this for browser tests to terminate cleanly without jumping through the hoops of manually destroying existing ProfileNotification objects. Change-Id: I510ec4e774965159ee03209791f6bd1c43c3c042 Reviewed-on: https://chromium-review.googlesource.com/940186Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#542884}
-
Qiang Xu authored
changes: This CL relies on android CL: ag/3691606. This CL introduces the framework of chrome side changes and also did initial UI changes (circular 40px avatar icon) of contacts search result. Bug: 818902 Test: tested on device with android changes patched Change-Id: Id9bb1e2a9c1a1c179f6ceef3abe7249fdad83a7c Reviewed-on: https://chromium-review.googlesource.com/957421Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#542883}
-
Elly Fong-Jones authored
This fixes UsbChooserBrowserTest.* in both polychrome modes. Bug: 817408 Change-Id: If739ffdb6084fc55af38932dff09c2b2b3c4ce38 Reviewed-on: https://chromium-review.googlesource.com/961162Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542882}
-
Sadrul Habib Chowdhury authored
The MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated test is very flaky, and disabled on most platforms. We can remove it from the filter for viz. When the test is fixed, it should be done in a way so that it works with viz. BUG=791557 Change-Id: I2e08fd9f8d14133021a733f01c79d3cca157a2c9 Reviewed-on: https://chromium-review.googlesource.com/961089Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#542881}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5018e7b8..53c448db Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ied8c4c460192d1343c28ef7bea35ce8cddf36676 Reviewed-on: https://chromium-review.googlesource.com/960983Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542880}
-
Tom Sepez authored
This reverts commit abc55490. This cl had to be reverted to allow the revert of its predecessor. Now that the predecessor is relanded, it can be re-applied. Original CL at https://chromium-review.googlesource.com/c/chromium/src/+/956488 TBR=jam@chromium.org Bug: 809614 Change-Id: I7a4eceed9d8a7df5e7a60ae79b226eab8a0dd9ad Reviewed-on: https://chromium-review.googlesource.com/961105Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542879}
-
Boris Sazonov authored
This CL fixes FirstRunIntegrationTest.testAbortFirstRun flakiness on Android M+. testAbortFirstRun has been setting up ActivityMonitor for ChromeLauncherActivity after starting FRE and checked that the activity was finishing. But ChromeLauncherActivity is actually started before FirstRunActivity, so waitForMonitorWithTimeout was returning null in some runs on Android M+. This CL captures ChromeLauncherActivity before starting FRE and checks that both FirstRunActivity and ChromeLauncherActivity are finishing after FRE is aborted. Bug: 758751 Change-Id: I03fe5b973faf02d63eb528e90ba1e6efb839f0f8 Reviewed-on: https://chromium-review.googlesource.com/956182Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#542878}
-
Kristian H. Kristensen authored
In preparation for hardware plane underlay support in ChromeOS, we need to allow for RGBA primary framebuffers. When using an underlay, we cut out a transparent rectangle in the primary framebuffer to allow the underlay to show through, while still allowing for RGBA content on top of the underlay (for example, video controls or annotations). When not using an underlay, the primary framebuffer will be displayed as RGBX (opaque) to avoid unnecessary blending in the display controller. Bug: 789288 Change-Id: I2fc94e524e250ec9b7e11cd6801e1c8308046a10 Reviewed-on: https://chromium-review.googlesource.com/801974Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542877}
-
Chong Zhang authored
We want to move |SharedURLLoaderFactory| to make it available to consumers that doesn't depend on content/. This CL is mostly mechanical changes and doesn't affect behaviors. TBR=jam@chromium.org (for fairly mechanical changes of callsites in chrome/). Bug: 796425 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Icdaccce5323c7585e26f742e9d0433f0fa1aea4b Reviewed-on: https://chromium-review.googlesource.com/959617Reviewed-by:
Chong Zhang <chongz@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#542876}
-
Tao Bai authored
Bug: 821225 Change-Id: Ifc2d019efb48beb31a3db7fd474e619f33559e82 Reviewed-on: https://chromium-review.googlesource.com/959577Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#542875}
-
Harald Alvestrand authored
This is in turn fed (in a few cases) from the RTCError passed back in callbacks from the WebRTC layer. This is a first step towards getting proper error codes passed up from WebRTC to Blink. Bug: 589455 Change-Id: I4ae2412ce238c5e17ba14fb1aa9b4eab2ccd7659 Reviewed-on: https://chromium-review.googlesource.com/956122Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#542874}
-
Elly Fong-Jones authored
Before, this was trying to use the Cocoa TaskManager for these Views-specific tests, which is wrong. This change also makes polychrome always use the Views task manager window when in Views browser mode. Bug: 817408 Change-Id: Ie3ab2e5fd6ca1752aff4f601e2cf920a3762fefe Reviewed-on: https://chromium-review.googlesource.com/961161Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542873}
-
Ramin Halavati authored
Network traffic annotation is passed from HttpRequestInfo to Websocket HTTP2 Handshake. Bug: 656607 Change-Id: Ib8c40a734ec598346457a32d75f3e2caeb8cbad0 Reviewed-on: https://chromium-review.googlesource.com/959008 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#542872}
-
https://chromium.googlesource.com/catapult.git/+log/c6434b02c577..3b4e1d958fac $ git log c6434b02c..3b4e1d958 --date=short --no-merges --format='%ad %ae %s' 2018-03-09 perezju [Telemetry] --browser android-chrome should use Monochrome.apk in N+ Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I775a50bd41d5ec3f95ea25a82f2afa49bed357ad Reviewed-on: https://chromium-review.googlesource.com/960881Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542871}
-
Kim Paulhamus authored
Adds the tighter restrictions detailed in https://fidoalliance.org/specs/fido-v2.0-ps-20170927/fido-client-to-authenticator-protocol-v2.0-ps-20170927.html#using-the-ctap2-authenticatormakecredential-command-with-ctap1-u2f-authenticators where: 1) a create() call must not require user verification or resident keys 2) a get() call must not require user verification in order to dispatch to u2f authenticators. Bug: 803832 Change-Id: Ib9cf9d3bcf0b71f0d32fec76f1aaf175278a02ef Reviewed-on: https://chromium-review.googlesource.com/949453Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#542870}
-
Marijn Kruisselbrink authored
These factories don't support download_to_file anyway, so make sure nobody is trying to call them with download_to_file set to true. Also fix the one place where download_to_file was set to true despite the code not actually expecting the callbacks that that should result in, if download_to_file would have been implemented. Bug: 791702 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2f31d2a45c59ba4b15e92cfe18718ed4eb69847b Reviewed-on: https://chromium-review.googlesource.com/957708Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#542869}
-
Elly Fong-Jones authored
These tests just need to use a Cocoa profile chooser when in Cocoa mode or they crash. This change also disables one test in polychrome: NoProfileChooserOnOutsideUserDataDirProfiles, which is documented to be broken on Mac. Three other tests fail with ViewsBrowserWindows enabled, which are the three LockProfile tests. I don't yet know why. Bug: 817408 Change-Id: I753fa8cdcbcfa6da254b835db4b9c801ed539131 Reviewed-on: https://chromium-review.googlesource.com/960441Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542868}
-
Dominic Mazzoni authored
Bug: 816529 Tbr: tsepez@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I89646a49d23a5591b5f564412450832893bb3cb3 Reviewed-on: https://chromium-review.googlesource.com/936454Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542867}
-
Derek Cheng authored
This fuzzer test will cover CastFramer, which consumes bytes received from cast devices over the network and converting it into protobuf. Added 3 corpuses which are generated MessageFramer::Serialize() and dummy messages. (See cast_framer_unittest.cc) Bug: 796717 Change-Id: I4a9feae3f1451d101387943517594d89d2cf0473 Reviewed-on: https://chromium-review.googlesource.com/950410 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Adam Michalik <xyzzyz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542866}
-
Nick Carter authored
Write a test of mouse_lock_widget_ cleanup. Fix WebContentsImpl so that it passes. Bug: 820593, 821187 Change-Id: I99cd6b8c728f7e4501205574db8d17b206f2856e Reviewed-on: https://chromium-review.googlesource.com/957479 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542865}
-
Henrique Nakashima authored
Bug: 821301 Change-Id: I573f5f90fa896f92f91ca63bfda2588469ab5aab Reviewed-on: https://chromium-review.googlesource.com/960594Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#542864}
-