GitLab

Today, WebContents::GetVisibility() returns HIDDEN for a tab that is in
a minimized window shown in the Alt-Tab view on ChromeOS. This is
because content::WebContents::GetVisibility() indicates the visibility
of the aura::Window, and isn't affected by the mirroring functionnality
used by the Alt-Tab view.

Unfortunately, the fact that WebContents::GetVisibility() returns
HIDDEN makes TabManager think that the tab is eligible for freezing and
discarding (freezing or discarding a tab in Alt-Tab breaks the live
view functionnality). TabManager could check by itself whether the
WebContents IsBeingCaptured(), but instead of requiring that every
call to WebContents::GetVisibility() be accompanied to a check to
IsBeingCaptured(), we believe it's better to return VISIBLE from
GetVisibility() when a tab is displayed in Alt-Tab view.

Bug: 876103
Change-Id: I01c07858bcae3038577bac1408c67eb72fe08e0c
Reviewed-on: https://chromium-review.googlesource.com/1191862Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587711}

The new quarantine feature for chrome cleanup tool needs a finch switch to control it.
It adds "--quarantine" into the command line when launching the cleaner if the switch is enabled.
It will be only enabled on the cleaner. So only adds switch to the cleaner, but not to the reporter.
Default is disabled.

Bug: crbug.com/878794
Change-Id: Ibb6f7bf76c36fbaf6106ede1ee9b6049cb2c5d2e
Reviewed-on: https://chromium-review.googlesource.com/1194404Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Che-yu Wu <cheyuw@google.com>
Cr-Commit-Position: refs/heads/master@{#587710}

Switches all the waterfalls using Mac Retina devices on Chrome-GPU to
only trigger tests on devices with 10.13.6 instead of both 10.13.6 and
10.13.5 now that all devices have been upgraded to the newer OS vesion.

Bug: 868032
Change-Id: I58448310621430fae7cec763acedc190a6c29b17
Reviewed-on: https://chromium-review.googlesource.com/1197329Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587709}

Bug: 867518
Change-Id: I9749e8932758a893225368b0042cd4439ee11de1
Reviewed-on: https://chromium-review.googlesource.com/1195673
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587708}

This reverts commit b81f63ce.

Reason for revert: retrace bug now fixed

Original change's description:
> android: disable deobfuscation in tests.
>
> Deobfuscation appears to be hanging in ways that cause it to peg
> bots' CPUs and kill test runs. This CL temporarily disables it as
> a mitigation.
>
> Bug: 876539
> Change-Id: I6dced1a4c80e630bb701a17eaa8322450661adc5
> Reviewed-on: https://chromium-review.googlesource.com/1185294
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585190}

Bug: 876539
Change-Id: If6c19b7345e769d51d1580980aca8e3967319a97
Reviewed-on: https://chromium-review.googlesource.com/1195432Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587707}

Now that Media Licenses are included with cookies and other site data on the
basic tab, move Media Licenses up to just below cookies on the advanced tab.
This is for Android only.

BUG=877999
TEST=tested locally

Change-Id: I55223d51178610125ce83ce357c539ed93656050
Reviewed-on: https://chromium-review.googlesource.com/1196040Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587706}

Previously, browser test binaries (e.g. browser_tests, interactive_ui_tests,
etc.) set up paths so that child processes would use Chromium Helper.app, which
matches the production process launching path. However this prevents the child
process from linking in test-only code, because it is a distinct binary from
the main test executable that acts as the browser process.

This change makes it so that the child process binary is the same as the main
test binary, which matches how other platforms behave.

Bug: 877992
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic04f0d47726be89d953ea227b8a104dc7bb88c0f
Reviewed-on: https://chromium-review.googlesource.com/1193969
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587705}

FindBar on iPhone has swithced to autolayout. This CL lets FindBar on iPad
use autolayout as well so that the FindBar won't be dismissed and reshowed
when iPad rotates.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie5ef497c711e2cdfed1721c2468579ecb1eec17a
Reviewed-on: https://chromium-review.googlesource.com/1193954Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587704}

We're doing some clean up and would like to retract SkColorSpaceXform
from Skia's public API.  It's obsolete now that you can either,

   1) just use Skia's drawing pipeline or readPixels()/writePixels()
      for most of its functionality; or
   2) use the much more flexible skcms interface for fancy features.

In the case of ui/gfx/color_transform, I decided to go with skcms
because it can naturally consume and produce the 3-float TriStim format
this code wants to use.  The old SkColorSpaceXform required two extra
transformations and an allocation, where skcms can do everything in
place natively.

Using draws or readPixels()/writePixels() would have required us to keep
those extra transforms, as they don't (yet?) support RGB_fff pixels.

Change-Id: I70f64c3ad72ebe227ed7a2a1dd7391863a8737e3
Reviewed-on: https://chromium-review.googlesource.com/1196375Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587703}

Add a feature that controls whether scrypt key derivation should be used
when a user sets a new custom passphrase. If the feature is disabled,
PBKDF2 will be used (i.e. old behavior).

Bug: 877933
Change-Id: I2009c8d8cfc7cef57743fbf8f3c9a6ec48ef07a4
Reviewed-on: https://chromium-review.googlesource.com/1193855
Commit-Queue: David Davidović <davidovic@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587702}

Before this CL, the (non-horizontal) tab switcher would initiate the tab
switching before emitting an event that the scene is changing.
For the keyboard accessory, this meant that changes to the old scene
are not applied anymore. Most importantly, hiding the keyboard-replacing
sheet would restore the layout size too late and the tab would appear
cropped.

This CL notifies a scene as soon as it is detached to give it the time
to clean up. Now, the keyboard accessory can restore the layout and the
transition into a full-sized tab is restored again.

Bug: 876254
Change-Id: I8f17a51ce3f4b7de4ee41483f79240323ec9acea
Reviewed-on: https://chromium-review.googlesource.com/1196406
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587701}

Get changes from the internal repo since last branch point:
- chrome_utils now uses the sandboxed JsonParser to parse extension install methods
- add JsonParser sandbox to crash client and process information logging
- get internal API keys for official build, dummy API keys for public build
- Add FOUND_IN_PROGRAMFILES trace location

R=csharp

Bug: 830892
Change-Id: I33944eaaf31be836ac4c91041fd7e4e0d25278d2
Reviewed-on: https://chromium-review.googlesource.com/1195798Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587700}

This CL adds two new heap profiling modes: "utility-sampling" and
"utility-and-browser". The former mode will profile all utility processes at
startup, with 1/3 probability. The latter will profile all utility processes and
the browser process [currently just useful for tests].

In addition to some small plumbing and tests, this CL modifies
UtilityThreadImpl::Init to call
"GetContentClient()->OnServiceManagerConnected(connection);". The callback
OnServiceManagerConnected() was not getting propagated to the
ChromeContentClient in the utility process [this was a bug].

The profiling process itself is a utility process and must never be profiled --
that will cause deadlock. This is avoided by adding an early out to
Client::StartProfiling for the utility process. The newly added tests confirm
that we don't deadlock even when attempting to profile all utility processes.

Change-Id: I74e2921d7ceff6150080c182db756be9ac0d076b
Bug: 878431
Reviewed-on: https://chromium-review.googlesource.com/1195836Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587699}

This code only ever waits not at all (equivalent to doing nothing) or forever
(equivalent to using Wait), so drop TimedWait. This both makes the code simpler
and clearer, and drops the only usage of the WTF::Mutex "absolute time" semantics.
This helps clear the path for adopting base-style semantics for TimedWait instead.

Bug: 856641
Change-Id: I912b01b475173b965c7990cb4d3476c2eb21fae5
Reviewed-on: https://chromium-review.googlesource.com/1183592Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587698}

The script to compare deterministic builds was recently fixed to actually
generate .isolated files. Unfortunately, there are many .isolated files which
are not deterministic. This CL adds them to the whitelist.

Bug: 879249
Change-Id: I4368e776baac80a66976e399b4eb0b94ed44b2ed
Reviewed-on: https://chromium-review.googlesource.com/1196866Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587697}

GetExtraHitTestShapeRects() is called solely from
WindowTargeter::EventLocationInsideBounds(). As CustomTargeter completely
overrides EventLocationInsideBounds() there is no need to also override
GetExtraHitTestShapeRects(). This removes the unnecessary override.

I'm also removing the implementation of Surface::GetHitTestShapeRects() to
the test, as that is now the only place that needs to call it.

BUG=878836
TEST=covered by tests

Change-Id: I75569904bdfe5bd4d4384436488e4cc0b224ee3d
Reviewed-on: https://chromium-review.googlesource.com/1196913Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587696}

GL_COMMANDS_ISSUED_CHROMIUM is sufficient for shared memory
GpuMemoryBuffers because they're uploaded using glTexImage2D (see
GLImageMemory::CopyTexImage).

This should reduce the number of idle wakeups in the GPU process, and
reduce the CPU time spent on such queries which is quite high on
Windows.

Bug: 830084, 622491
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8111b3d7f12abbf900383d45e2a74394848e83fd
Reviewed-on: https://chromium-review.googlesource.com/1189126
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587695}

This reverts commit 34141782.

Reason for revert: Caused Finch seed freshness regression, see http://crbug.com/879252 and
http://crbug.com/879115

Original change's description:
> Reland "Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker""
>
> This is a reland of e00fddec
>
> Needed to initialize variables in ChromeBrowserMainBrowserTest for asan/msan.
> Verified this works with msan build.
>
> Original change's description:
> > Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker"
> >
> > This is a reland of a9ed46b7
> >
> > ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange
> > was flaky in the original change. Added logic in the test to wait for the
> > connection type change.
> >
> > Only diffs from original are in chrome/browser/chrome_browser_main_browsertest.cc
> >
> > Original change's description:
> > > Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker
> > >
> > > A getter is used for NetworkConnectionTracker because some services that
> > > use ResourceRequestAllowedNotifier are initialized early in browser
> > > startup (e.g. VariationsService), and only perform the initialization
> > > of ResourceRequestAllowedNotifier later on the UI thread. The getter
> > > allows us to run get the connection tracker at that point so we don't get
> > > DCHECKs about being on the UI thread when running
> > > content::GetNetworkConnectionTracker().
> > >
> > > This also moves the NetworkConnectionTracker in ios/ from BrowserState to
> > > ApplicationContext, which is available everywhere. It also matches non-IOS
> > > usage more closely, since we have it as a global there.
> > >
> > > Bug: 868021
> > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> > > Change-Id: I130c6b47feb90f0f7f0776ccc65666414a1ae802
> > > Reviewed-on: https://chromium-review.googlesource.com/1180360
> > > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
> > > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#584849}
> >
> > TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org
> >
> > Bug: 868021
> > Change-Id: I5941b72474657159f0d4a1e6667fd77a3c475887
> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> > Reviewed-on: https://chromium-review.googlesource.com/1185602
> > Reviewed-by: Clark DuVall <cduvall@chromium.org>
> > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#585387}
>
> TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org
>
> Bug: 868021, 876861
> Change-Id: I46fccf072d0b3080603e97c73ff055ac7c45e723
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Reviewed-on: https://chromium-review.googlesource.com/1187081
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585565}

TBR=jam@chromium.org,eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,cduvall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 868021, 876861, 879252, 879115
Change-Id: If0417f53386a94de0ec3b64c283df123c673ec03
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1197325
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587694}

This reverts commit ac880b3a.

Reason for revert: Causing crash after audit in incognito window: http://crbug.com/879060

Original change's description:
> Convert tcp_device_provider.cc to mojo host resolver
>
> Bug: 874653
> Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> Reviewed-on: https://chromium-review.googlesource.com/1185626
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586738}

TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 874653, 879060
Change-Id: I72e7268a8b208a2f91e53f84601d5e89a3c66a41
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1197109
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587693}

Get changes from the internal repo since last branch point:
- Replace hardcoded company name with COMPANY_SHORTNAME_STRING
- Add more paths to PreFetchedPaths
- Replace some VLOG statements with LOG(INFO)
- Enforce that RegKeyPath takes only predefined keys in rootkey
- Add chrome-cleanup-tool-test to keys in registry unit tests
- Add Chrome policy key constants to registry_util.h
- Replace StringPrintf with StrCat

R=csharp

Bug: 830892
Change-Id: I71c0c3f03ce852c4af4738056187512cfea9f82e
Reviewed-on: https://chromium-review.googlesource.com/1195802Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587692}

Bug: 874615
Change-Id: Ieeb98e2fedf2958259f7e06e65eadc31ad6b8aaf
Reviewed-on: https://chromium-review.googlesource.com/1197323Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587691}

Field text was changed in a previous CL which increased the width of the text,
but the field width wasn't adjusted for this thereby creating a visual artifact.

Screenshot before adjusting: https://screenshot.googleplex.com/cEJmBzFpvJO.png

Screenshot after adjusting: https://screenshot.googleplex.com/Pbe9mXmp1RK.png

Bug: 865947
Change-Id: Ia12ad95bc0c96e540e0aa7ee1fa9949803efe97c
Reviewed-on: https://chromium-review.googlesource.com/1196583Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587690}

Add scrypt as a key derivation method to the proto and also to the
client-side KeyDerivationMethod enum. Add feature which, when disabled,
effectively treats scrypt as an unknown key derivation method
altogether.

Wire up scrypt key derivation in Nigori, so that it is exposed
externally.

Add tests to ensure that Nigori correctly derives scrypt keys, that
SyncEncryptionHandlerImpl passes the new key derivation method correctly
to observers and that, when the feature is disabled, scrypt code paths
are not triggered. This is beneficial in mitigating risk related to the
introduction of scrypt, as it can be completely disabled via Finch if
need be.

Bug: 877933
Change-Id: Icf940a02ef03b172c84d828d96b264c574151f7c
Reviewed-on: https://chromium-review.googlesource.com/1194006Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: David Davidović <davidovic@google.com>
Cr-Commit-Position: refs/heads/master@{#587689}

Also remove chrome/browser/usb/DEPS which is completely redundant.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4080d3f68745030420b196fefc28d3010e9d1c3a
Reviewed-on: https://chromium-review.googlesource.com/1195738
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587688}

This cl converts all tests in fast/scrolling that are using event sender
other than the following two keyboard tests:
keyboard-scroll-before-layout.html
keyboard-scroll-page-scale.html

Bug: 846424
Change-Id: Id6c10046d591724c347bf931ae877e1cb8b7d3c2
Reviewed-on: https://chromium-review.googlesource.com/1196826
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587687}

This plumbing provides activation and focusing of the WindowTreeHost's
child windows, enabling full use of the mouse and keyboard in
content views.

Also fixed some IWYU linter errors.

Bug: 878439
Change-Id: I0fc344b69edf78ca3aff39f615951cfa016718b2
Reviewed-on: https://chromium-review.googlesource.com/1194868
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587686}

Bug: 876689
Change-Id: I999a7cdfaf703e898365b5838d06fc2d8615abe7
Reviewed-on: https://chromium-review.googlesource.com/1194075
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587685}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/web_applications.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=dominickn@chromium.org

Bug: 874080
Change-Id: I82b1024084057eebf5425a8e42c5ee6b677f6b46
Reviewed-on: https://chromium-review.googlesource.com/1191788
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587684}

Original CL intention was:
This CL uses ScopedBlockingCall to mark blocking calls in /extensions/browser/api/system_storage.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=ningxin.hu@intel.com

Bug: 874080
Change-Id: Ia8cf19506aa212d07e8dad54a07940f6e878799c
Reviewed-on: https://chromium-review.googlesource.com/1191195
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587683}

This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome/browser/snapshots.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=justincohen@chromium.org

Bug: 874080
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5df9b85d1914370ea2ada752c18bc5861f1591fc
Reviewed-on: https://chromium-review.googlesource.com/1191408Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587682}

This is needed to ensure that callbacks installed on
translate.js can be registered before element.js executes.

Change-Id: Idefe034e77879169b57185bcad88066d1917de82
Bug: 877706
Reviewed-on: https://chromium-review.googlesource.com/1189060
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587681}

This CL add the scroll snap data to ScrollNode for BGPT.

I manually tested scroll snap.

TEST=fast/scroll-snap/snap-scrolls-visual-viewport.html still flaky.

Bug: 877106
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4199e4a7474c08e1b27b5d54528b1b371164fd62
Reviewed-on: https://chromium-review.googlesource.com/1195106Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587680}

This is a reland of 025bf217

Original change's description:
> Remove Windows debug bots from consoles
> 
> They've been a bit flaky, and I don't want to bother sheriffs with them
> yet.
> 
> Bug: 878915
> Change-Id: Ia37db9742e3bf7e58a2efba8ab4032f7b121620e
> Reviewed-on: https://chromium-review.googlesource.com/1195926
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587409}

Bug: 878915
Change-Id: I65ea5aa215a235cdfc2b93c4804f69a93a953e95
Reviewed-on: https://chromium-review.googlesource.com/1196919Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587679}

Report the number of tabs/windows at regular interval, this'll be useful
to help measure if a given change affects how users use tabs.

Change-Id: Ic08861825c064afa736ecaeac98cc9855890f109
Reviewed-on: https://chromium-review.googlesource.com/1194871
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587678}

Fix lint errors as well.

BUG=537099

Change-Id: Ie36f7530d574229495f24119e74f15e0a1fb2d71
Reviewed-on: https://chromium-review.googlesource.com/1188640
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587677}

Move the media session and audio focus related switches to
the media session service.

BUG=875004

Change-Id: I54dad1eb47ac6288895ea3cac3824b181080f3e3
Reviewed-on: https://chromium-review.googlesource.com/1188747Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587676}

These tests are timing out periodically. Match the removal of
browser_tests, since the behavior is expected to be the same.

Bug: 876224
Change-Id: I76183e78fde8f10a1feae67db51ca4336a4c652e
Reviewed-on: https://chromium-review.googlesource.com/1197322Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587675}

This CL updates blink and chromium to support persistent-usage-record
session, which is behind a flag.

To enable the support, use the following command line flag:

--enable-blink-features=EncryptedMediaPersistentUsageRecordSession

ExternalClearKey key system is also updated to declare support
for this session type, even though in the implementation it doesn't do
anything special.

No other CDMs support this session type yet, which will be done later.

TBR=foolip@chromium.org

Bug: 856925
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: Iff38bc79f43e375144f045564e045a830d86699a
Reviewed-on: https://chromium-review.googlesource.com/1119565
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587674}

This way, callers that have a base::StringPiece[16] can avoid copying
the data into an {std::string, base::String16} just to call
GURL::Resolve().

Change-Id: I0c7d73ac55d102bc0bc39afe36efccc33e938e14
Reviewed-on: https://chromium-review.googlesource.com/1195740Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587673}

We are adjusting these based on user feedback.  Many users found that
10 minutes was not enough time to complete common tasks which requried
assistance.  Based on usage data, 30 minutes should be enough for
the majority of sessions.  Also increasing the timeout for the
continue window to give the person being helped more time to find and
click the continue button.

Change-Id: I9a55568363e2bf79d6a82523c1a520364fbd3507
Reviewed-on: https://chromium-review.googlesource.com/1183539
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587672}