- 28 Dec, 2016 40 commits
-
-
avi authored
BUG=579229 Review-Url: https://codereview.chromium.org/2604913002 Cr-Commit-Position: refs/heads/master@{#440872}
-
bnc authored
* Add |http2_settings| field trial parameter to HTTP/2 trial group. * Set max header table size, max concurrent pushed streams, and max receiving window size values in |http2_settings| in HttpNetworkSession. * Pass |http2_settings| from HttpNetworkSession to SpdySessionPool to SpdySession. Remove |stream_max_recv_window_size| from this path. * Extract max header table size, max concurrent pushed streams, and max receiving window size values from |http2_settings| in SpdySession. * Move max header table size and max concurrent pushed streams default value from SpdySession to HttpNetworkSession. * Add |http2_settings| to SpdySessionDependencies; remove |stream_max_recv_window_size|. BUG=622737 Review-Url: https://codereview.chromium.org/2600973002 Cr-Commit-Position: refs/heads/master@{#440871}
-
bnc authored
This lands server side change 130276296 by jamessynge. BUG=488484 Review-Url: https://codereview.chromium.org/2600273002 Cr-Commit-Position: refs/heads/master@{#440870}
-
msw authored
BUG=676746 TBR=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2606943002 Cr-Commit-Position: refs/heads/master@{#440869}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ea41bdf0..d689ef2e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2600423002 Cr-Commit-Position: refs/heads/master@{#440868}
-
olivierrobin authored
List of import -> include +#include "base/logging.h" +#include "base/memory/ref_counted.h" +#include "ios/testing/earl_grey/disabled_test_macros.h" +#include "ios/web/history_state_util.h" +#include "ios/web/navigation/navigation_manager_facade_delegate.h" +#include "ios/web/public/active_state_manager.h" +#include "ios/web/public/interstitials/web_interstitial.h" +#include "ios/web/public/web_state/js/credential_util.h" +#include "ios/web/public/web_state/url_verification_constants.h" +#include "ios/web/public/web_state/web_state_delegate.h" +#include "ios/web/public/web_state/web_state_observer.h" +#include "ios/web/webui/web_ui_ios_controller_factory_registry.h" +#include "ios/web/webui/web_ui_ios_impl.h" +#include "mojo/public/cpp/system/watcher.h" List of include -> import +#import "base/ios/block_types.h" +#import "base/ios/weak_nsobject.h" +#import "base/mac/bind_objc_block.h" +#import "base/mac/objc_property_releaser.h" +#import "base/mac/scoped_nsobject.h" +#import "base/test/ios/wait_util.h" +#import "ios/net/clients/crn_forwarding_network_client.h" +#import "ios/net/cookies/cookie_store_ios.h" +#import "ios/net/request_tracker.h" +#import "ios/testing/wait_util.h" +#import "ios/web/interstitials/native_web_interstitial_impl.h" +#import "ios/web/interstitials/web_interstitial_impl.h" +#import "ios/web/navigation/crw_session_controller.h" +#import "ios/web/navigation/crw_session_entry.h" +#import "ios/web/navigation/navigation_item_impl.h" +#import "ios/web/navigation/navigation_manager_delegate.h" +#import "ios/web/navigation/navigation_manager_impl.h" +#import "ios/web/navigation/nscoder_util.h" +#import "ios/web/net/clients/crw_js_injection_network_client.h" +#import "ios/web/net/clients/crw_redirect_network_client.h" +#import "ios/web/net/clients/crw_redirect_network_client_factory.h" +#import "ios/web/net/cookie_notification_bridge.h" +#import "ios/web/net/crw_cert_verification_controller.h" +#import "ios/web/net/request_group_util.h" +#import "ios/web/net/request_tracker_factory_impl.h" +#import "ios/web/net/request_tracker_impl.h" +#import "ios/web/net/web_http_protocol_handler_delegate.h" +#import "ios/web/public/block_types.h" +#import "ios/web/public/image_fetcher/webp_decoder.h" +#import "ios/web/public/interstitials/web_interstitial_delegate.h" +#import "ios/web/public/navigation_item.h" +#import "ios/web/public/test/response_providers/data_response_provider.h" +#import "ios/web/public/test/response_providers/delayed_response_provider.h" +#import "ios/web/public/test/response_providers/error_page_response_provider.h" +#import "ios/web/public/test/response_providers/file_based_response_provider.h" +#import "ios/web/public/test/response_providers/file_based_response_provider_impl.h" +#import "ios/web/public/test/response_providers/html_response_provider.h" +#import "ios/web/public/test/response_providers/html_response_provider_impl.h" +#import "ios/web/public/test/response_providers/response_provider.h" +#import "ios/web/public/test/response_providers/string_response_provider.h" +#import "ios/web/public/test/test_native_content.h" +#import "ios/web/public/test/test_native_content_provider.h" +#import "ios/web/public/test/test_navigation_manager.h" +#import "ios/web/public/test/test_web_state.h" +#import "ios/web/public/test/test_web_view_content_view.h" +#import "ios/web/public/web_client.h" +#import "ios/web/public/web_state/context_menu_params.h" +#import "ios/web/public/web_state/crw_web_view_proxy.h" +#import "ios/web/public/web_state/ui/crw_content_view.h" +#import "ios/web/public/web_state/ui/crw_web_view_content_view.h" +#import "ios/web/public/web_state/web_state.h" +#import "ios/web/public/web_state/web_state_policy_decider.h" +#import "ios/web/public/web_state/web_state_user_data.h" +#import "ios/web/public/web_view_creation_util.h" +#import "ios/web/shell/shell_web_client.h" +#import "ios/web/web_state/blocked_popup_info.h" +#import "ios/web/web_state/web_state_impl.h" +#import "ios/web/webui/crw_web_ui_page_builder.h" +#import "ios/web/webui/url_fetcher_block_adapter.h" +#import "testing/gtest_mac.h" +#import "ui/base/test/ios/ui_view_test_utils.h" BUG=None Review-Url: https://codereview.chromium.org/2605913002 Cr-Commit-Position: refs/heads/master@{#440867}
-
fayang authored
Merge internal change 143035999. BUG= Review-Url: https://codereview.chromium.org/2603843002 Cr-Commit-Position: refs/heads/master@{#440866}
-
dvadym authored
This CL includes: 1.Creating, initializing and updating PasswordReuseDetector instance as a member of PasswordStore. 2.Introducing all flows for checking password reuse with CheckReuse() of ChromePasswordManagerClient and receiving response. ChromePasswordManagerClient.CheckReuse() is not called now, it will be implemented in next CLs. BUG=657041 Review-Url: https://codereview.chromium.org/2585253002 Cr-Commit-Position: refs/heads/master@{#440865}
-
braveyao authored
There are reports of random Chrome crash due to HW encode accelerator on Android. Possible reason may be: currently we'll reset client factory at encoding error and notify client. But before client stops encoding (calling Destroy() here), if there is any pending frame delivered to encoder, it will fail to get the pointer of client factory. Here we try to leave the client factory life managment to client and only notify the encoding error to client in error handling. BUG=676987 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2601003002 Cr-Commit-Position: refs/heads/master@{#440864}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/29437eb5c782..e2d414167980 $ git log 29437eb5c..e2d414167 --date=short --no-merges --format='%ad %ae %s' 2016-12-28 kjlubick Update Nexus 5 to M4B30Z Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=liyuqian@google.com Review-Url: https://codereview.chromium.org/2606883003 Cr-Commit-Position: refs/heads/master@{#440863}
-
japhet authored
Historically, we have dropped these when navigations are interleaved. BUG=656919 Review-Url: https://codereview.chromium.org/2563423004 Cr-Commit-Position: refs/heads/master@{#440862}
-
mek authored
Initially this callback is used to delay writing the schema version until data actually gets committed. In follow-up CLs this will also be used to store per-origin metadata. BUG=586194 Review-Url: https://codereview.chromium.org/2597353002 Cr-Commit-Position: refs/heads/master@{#440861}
-
jialiul authored
(And add a TODO for PPAPI download attribution) BUG=676691 Review-Url: https://codereview.chromium.org/2606843002 Cr-Commit-Position: refs/heads/master@{#440860}
-
olivierrobin authored
If the static HTML contains iframes, a call to decidePolicyForNavigationAction is done with a navigationType other. This should not trigger a navigation to URLLoader. BUG=676575 Review-Url: https://codereview.chromium.org/2597133002 Cr-Commit-Position: refs/heads/master@{#440859}
-
mek authored
BUG=None Review-Url: https://codereview.chromium.org/2604843002 Cr-Commit-Position: refs/heads/master@{#440858}
-
mek authored
Currently an invalid version just results in not using a backing store, but in the future that will result in upgrading and/or recreating the database. BUG=586194 Review-Url: https://codereview.chromium.org/2607493003 Cr-Commit-Position: refs/heads/master@{#440857}
-
qiangchen authored
After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled. BUG=314516 Review-Url: https://codereview.chromium.org/2606783002 Cr-Commit-Position: refs/heads/master@{#440856}
-
dvadym authored
In PasswordFormManager provisionally_saved_form is actually submitted form and it's very unclear from variable name. BUG=None Review-Url: https://codereview.chromium.org/2605003003 Cr-Commit-Position: refs/heads/master@{#440855}
-
eugenebut authored
New code uses web::NavigationManager which is the same program flow. Old code would tolerate nil CRWWebController, while the new code will crash (which should not happen in practice). BUG=616288 Review-Url: https://codereview.chromium.org/2600963002 Cr-Commit-Position: refs/heads/master@{#440854}
-
edchin authored
The simple strip container is WIP and this CL has only minimal functionality. This CL also showcases this strip container in Showcase. BUG=none. Review-Url: https://codereview.chromium.org/2594023002 Cr-Commit-Position: refs/heads/master@{#440853}
-
dmazzoni authored
This patch adds implementation for aria-col-index, aria-col-count, aria- col-span, aria-row-index, aria-row-count, aria-row-span from ARIA 1.1, https://rawgit.com/w3c/aria/master/aria/aria.html. For windows, aria-col-count, aria-col-index, aria-row-count, aria-row- index, aria-col-span and aria-row-span are exposed as object attributes. Based on http://codereview.chromium.org/1547643002 by je_julie, which was in turn based on wkrev.com/190833 by n_wang. BUG=543050,644766 Review-Url: https://codereview.chromium.org/2539503003 Cr-Commit-Position: refs/heads/master@{#440852}
-
eugenebut authored
In UIWebView world CookieStoreIOS could dynamically change its state and either be synchronized with NSHTTPCookieStorage or unsynchronized. In WKWebView world CookieStoreIOS never changes its state. It is either always synchronized (for sign in) or always unsynchronized (for regular browsing). Notable changes: - updated comments to reflect that sync state is not dynamic - removed RoundTripTest which tested non-existing dynamic synchronization flow - removed other tests which tests dynamic synchronization BUG=676144 Review-Url: https://codereview.chromium.org/2604763003 Cr-Commit-Position: refs/heads/master@{#440851}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d17870c6..ea41bdf0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2600393002 Cr-Commit-Position: refs/heads/master@{#440850}
-
pkalinnikov authored
Add a new message (SubresourceFilterHostMsg_DocumentLoadStatistics) that is sent to a RenderFrameHost in the browser when a document load is finished, just before the DidFinishLoad message, if performance measurements were enabled for the load. Contains the total time spent on evaluating subresource loads in DocumentSubresourceFilter::allowLoad() for a frame. Measurements are aggregated in SubresourceFilterDriverFactory and recorded to "SubresourceFilter.PageLoad.SubresourceEvaluation.*Duration" histograms when DidFinishLoad is called for the main frame. BUG=609747,672519 Review-Url: https://codereview.chromium.org/2581043003 Cr-Commit-Position: refs/heads/master@{#440849}
-
olivierrobin authored
The Objective-C frameworks must be imported and not included. List of Objective-C Frameworks that have been checked: AVFoundation AVKit Accounts AdSupport AddressBookUI AssetsLibrary CallKit CloudKit Contacts ContactsUI CoreAudioKit CoreBluetooth CoreData CoreImage CoreLocation CoreMIDI CoreMotion CoreSpotlight EventKit EventKitUI ExternalAccessory Foundation GLKit GameController GameKit GameplayKit HealthKit HealthKitUI HomeKit Intents IntentsUI JavaScriptCore LocalAuthentication MapKit MediaPlayer MessageUI Messages Metal MetalKit MetalPerformanceShaders ModelIO MultipeerConnectivity NetworkExtension NewsstandKit NotificationCenter PassKit Photos PhotosUI PushKit QuickLook ReplayKit SafariServices SceneKit Social Speech SpriteKit StoreKit Twitter UIKit UserNotifications UserNotificationsUI VideoSubscriberAccount WatchConnectivity WatchKit WebKit iAd BUG= Review-Url: https://codereview.chromium.org/2603973002 Cr-Commit-Position: refs/heads/master@{#440848}
-
henrika authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/3d4706c..24348df $ git log 3d4706c..24348df --date=short --no-merges --format=%ad %ae %s 2016-12-28 minyue@webrtc.org Fixing init time error in smoothing filter. 2016-12-27 minyue@webrtc.org Fixing name of a unittest for AudioEncoderOpus. 2016-12-27 terelius@webrtc.org Remove OverUseDetectorOptions from OveruseDetector since it isn't used. 2016-12-27 michaelt@webrtc.org Make a the decisions of ANA optional for the opus encoder. 2016-12-27 minyue@webrtc.org Reducing calling to SmoothingFilter in Fec Controller. 2016-12-27 mbonadei@webrtc.org Reland "Refactor webrtc/modules/video_processing for GN check" 2016-12-27 mbonadei@webrtc.org Refactor webrtc/modules/utility for gn check 2016-12-27 kjellander@webrtc.org Remove WebRTC-specific test runner script for Android 2016-12-24 deadbeef@webrtc.org Revert of Adding error output param to SetConfiguration, using new RTCError type. (patchset #4 id:60001 of https://codereview.webrtc.org/2587133004/ ) 2016-12-24 deadbeef@webrtc.org Adding error output param to SetConfiguration, using new RTCError type. TBR=kjellander CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2605013002 Cr-Commit-Position: refs/heads/master@{#440847}
-
kjellander authored
BUG=657315 TBR=phajdan.jr@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/2601053002 Cr-Commit-Position: refs/heads/master@{#440846}
-
tnagel authored
Also switch from std::string to AccountId argument for RefreshUserPolicy(). BUG=655971 Review-Url: https://codereview.chromium.org/2607593002 Cr-Commit-Position: refs/heads/master@{#440845}
-
dvadym authored
This CL introduced a checking of |provisionally_saved_credentials| for sync credentials, instead of |pending_credentials|. That's more correct, since |provisionally_saved_credentials| is the submitted form, on other hand |pending_credentials| is a combination of already saved and submitted form. In case of saving both these forms are the same, but for updating they are different. BUG=663896 Review-Url: https://codereview.chromium.org/2604783002 Cr-Commit-Position: refs/heads/master@{#440844}
-
kjellander authored
This will significantly reduce the wasted bandwidth consumed when these bots are no longer archiving 13 GB for every build. Add a new Android Builder that will build 'all' in Release mode, but not archive the build. This is a prerequisite for https://chromium-review.googlesource.com/423051 BUG=657315 NOTRY=True Review-Url: https://codereview.chromium.org/2605873002 Cr-Commit-Position: refs/heads/master@{#440843}
-
haraken authored
Context states transit from Uninitialized to Initialized, and then to Detached. - isGlobalInitialized() returns true when the context state is Initialized or Detached. - isContextInitialized() returns true when the context state is Initialized. Thus !isContextInitialized() is stronger than !isGlobalInitialized(). Hence we can remove if(!isGlobalInitialized()) from WindowProxy::updateDocument(). BUG=677253 Review-Url: https://codereview.chromium.org/2603953002 Cr-Commit-Position: refs/heads/master@{#440842}
-
haraken authored
By checking scriptState->contextIsValid(), we don't need to check isContextInitialized(). BUG=677253 Review-Url: https://codereview.chromium.org/2605853002 Cr-Commit-Position: refs/heads/master@{#440841}
-
haraken authored
The only call site of existingWindowProxy() is V8Initializer::messageHandlerInMainThread(). However, as commented in the code, that code should not be needed because if the context is during initialization it should already have bailed out at the if(!scriptState->contextIsValid()) check at the very beginning of V8Initializer::messageHandlerInMainThread(). If the reasoning is correct, we can simply remove all code around existingWindowProxy(). BUG=677253 Review-Url: https://codereview.chromium.org/2607743002 Cr-Commit-Position: refs/heads/master@{#440840}
-
haraken authored
We don't need to check isContextInitialized() in clearForClose() and clearForNavigation() because it is already checked in WindowProxy::disposeContext(). Also this CL moves the ScriptState::Scope into disposeContext() Though we don't need to enter ScriptState::Scope in case of clearForClose() by accident, it looks safer to enter the scope always. BUG=677253 Review-Url: https://codereview.chromium.org/2601033002 Cr-Commit-Position: refs/heads/master@{#440839}
-
apisarev authored
In RuleData we have array field, which is not initialized at construction of the object. And after object constructed, we iterate through this array by pointer. This code look dangerous and MSan detect this problem. To be safe during this iteration need initialize this array. It was done. R=skobes BUG=None Review-Url: https://codereview.chromium.org/2600123002 Cr-Commit-Position: refs/heads/master@{#440838}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#440837} -
yabinh authored
A lot of IME tests were flaky and marked with @RetryOnFailure. Now they are (almost) all deflaked, so we don't need @RetryOnFailure any more. BUG=628964,603991 Review-Url: https://codereview.chromium.org/2607723002 Cr-Commit-Position: refs/heads/master@{#440836}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cf7481bd..d17870c6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2607703002 Cr-Commit-Position: refs/heads/master@{#440835}
-
haraken authored
It's already guaranteed that WindowProxy::initialize never returns null. This CL just does some refactoring to make the fact clearer. BUG= Review-Url: https://codereview.chromium.org/2601773002 Cr-Commit-Position: refs/heads/master@{#440834}
-
tsergeant authored
The clang-format Javascript style changed in crrev.com/440558 to prevent single-line functions. This CL updates the Javascript in MD History to follow this change. BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2607653002 Cr-Commit-Position: refs/heads/master@{#440833}
-
