- 25 Mar, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I00767e6e2df81b9ec3fe674cc2d31c0f0dca9bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753156}
-
Finnur Thorarinsson authored
The order of decoding is determined by a few things, which (if all else is equal) falls back on creation time (Date() timestamp) to enforce FIFO decoding. However, the granularity of that is milliseconds, so back to back requests occasionally have the same timestamp and then the decoding order is no longer deterministic, which messes up the tests. This CL removes the timestamp and replaces it with an ordinal, to ensure FIFO order for identical requests. Bug: 1054520, 1054502, 656015 Change-Id: Ia745548619f866b53dc7e9071c191eea6d4d1fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116055 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#753155}
-
dpapad authored
Given that JS Modules based tests no longer use |extraLibraries| to pull in dependencies the definition of most tests classes looks identical and can be automated with a for loop. Tests that are still defined individually are either - enabled/disabled conditionally on some platforms - make use of |featureList|, runMochaSuite() or mocha.grep() Bug: 1026426 Change-Id: Id13f2ba71487ca3031310db21a2b0f6bea9fb0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116929 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#753154}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a65af2905412..2ffc95da474e Created with: gclient setdep -r src-internal@2ffc95da474e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9c75bb469c05fdf623d8ca8ca0d0f30ceb8350bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119919Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753153}
-
Simon Que authored
This builder was accidentally migrated in crrev.com/2117552. It was added between the original CL and the reland, and hence was silently included in the migration because the try builder def function set goma_backend=RBE_PROD by default. This will be properly migrated at a later time. Bug: 950413 Change-Id: Ib955db5dfae5e15a1bef466f703ea9ca7e5c6b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120120Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#753152}
-
Mark Cogan authored
Removes the unused RelaxedBoundsConstraintsHitTestSupport protocol and references to it in OverscrollActionsController. Change-Id: If4fb0ea6ad8a01ee82af2f91b4b75aa1dac728c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117115Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753151}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1012975 Change-Id: Id5ad8e66deda9819e54b656a1b27b1906c849052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114397Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ec90f4c93f6..9686528ac8c7 git log 8ec90f4c93f6..9686528ac8c7 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 6af71a8d..772d2084 (401 commits) 2020-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6fead3754375..107e4e989e94 (7 commits) Created with: gclient setdep -r src/third_party/skia@9686528ac8c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I164cd4b498deda038f30a85c77f3c286036c6c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119918Reviewed-by:
-
Minoru Chikamune authored
Bug: 1049056 Change-Id: Ibe54904d5e4bb688eb3d67ce13aa4291a737fb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119458Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#753148}
-
Miriam Polzer authored
Previously, get ChannelInfo() was obtaining the version of the current channel and was checking from policy/profile whether the user can modify the channel. Sometimes, when the update daemon was slow, the ui will not receive the data if the user can modify the channel, leading to it being shown by default and then, disabled. Old CL: https://crrev.com/c/1831769 Bug: 848750 Change-Id: Ia0aa6d3353e2e6c310642865f4dc437c9d449c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106852 Auto-Submit: Miriam Polzer <mpolzer@google.com> Commit-Queue: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#753147}
-
Noel Gordon authored
If the pointer is down anywhere in the app, hovering over the splitter bar or its child button shows their :hover effect even though they are not active and a resize-cursor as well. Block their hover and resize-cursor effect if the splitter is inactive (files-ng) so the splitter looks inert (aka non-interactive). Bug: 1062902, 1002790 Change-Id: I3fa170ea27682f52cc49ffe5d57bd2038c17d0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119463Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753146}
-
Anastasiia Nikolaienko authored
Bug: 1043108 Change-Id: Icdcd8d35a5fa1b0452d29ab666e3983ad46a006a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100939Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#753145}
-
tby authored
We've got a lot of dead code in search_result_ranker* from now-disabled experiments. I'm going to go through and clean it up, starting with the category and query-based mixed-types models. Bug: 1028447 Change-Id: I93f5d050df33d72ee4a1ce6362db87d8ee8ad1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117915Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#753144}
-
Alex Danilo authored
Sets the end margin for the clear icon in the search box to 6px to align the end of the search box wrapper with the touch target. Increases the width calculation for the search wrapper to allow for the changed margin end change and keep the search wrapper width at 288px. Increases the width of the cr-input for the same reason as above. Bug: 1064514 Change-Id: Ic1e0ba7f31adef6f9b2230455ac8edd3bd5e54d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120111Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#753143}
-
Ken Rockot authored
These were disabled across the board due to TSAN failures. They were also previously disabled specifically in low-end Android test environments. The low-end test bot that originally produced failures is no more. The TSAN failures also appear to be gone according to local testing. This attempts to turn the tests back on so we can see what happens. Bug: 626299,769903 Change-Id: Id75acf5948e45b72c714af31af74507987f2078f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119110 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#753142}
-
tby authored
Currently we have presubmits that check the structured metrics XML file is well-formatted (doesn't have duplicated metric names etc), but these only run when you `git cl upload`. It would be better if an invalid structured.xml file caused a compilation failure, because it will lead to confusing bugs when testing locally. This CL expands the compile-time validations to cover the cases currently checked only via presubmit. Bug: 1016655 Change-Id: Iec71eb7db629e566c10c7c997e509a5824373fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120070Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#753141}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d588fbe8cd72..a65af2905412 Created with: gclient setdep -r src-internal@a65af2905412 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033098 Tbr: jbudorick@google.com Change-Id: I62e48f21ead9a3a7ba894892bb7efcf030b656a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119915Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81c8f4b8027e..8ec90f4c93f6 git log 81c8f4b8027e..8ec90f4c93f6 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6c11cf2ad9ca..540bdf92531d (2 commits) Created with: gclient setdep -r src/third_party/skia@8ec90f4c93f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I03864795c66ce29a32c0edf23a5412ef9571ac76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119916Reviewed-by:
-
Bugs Nash authored
The Media App (currently behind a flag) requires FileHandling to be enabled to work. This patch removes the need for users to explicitly enable the FileHandling flag as well when enabling the MediaApp flag Bug: 1030935 Change-Id: I088466129a68b455e4b05793a98cbf2849a6cd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108242Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#753138}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1f151e19. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2b6c0e69a544d73fddc100e7663f3f7ca4f6dcdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119552Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753137}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d0800d29473f..107e4e989e94 git log d0800d29473f..107e4e989e94 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 ynovikov@chromium.org Lift SwANGLE dEQP-GLES3.functional.fbo.blit.conversion.* suppression Created with: gclient setdep -r src/third_party/angle@107e4e989e94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I7ee95b29b7cb444f9f2336a3be50897dbeebb5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119912Reviewed-by:
-
Brian Sheedy authored
Re-enables the BrowserMinidumpTest tests on Linux and the CrOS amd64 emulator, as the flakiness that caused them to be disabled should be properly attributed to the correct test now that pre/post test minidump checking has been enabled. Also fixes the test failing locally under certain GN arg configurations that caused the crash signature to change a bit. Bug: 1056235 Change-Id: I74c7407e8ded26652cf8fa833c5e11bd2dca9f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118576 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#753135}
-
Yuzu Saijo authored
This CL filters out RenderFrameHostImplBrowserTest.CheckIsCurrentBefore AndAfterUnload, which is failing deterministically. Bug: 1062923 Change-Id: Id016e1f79c8eb63fb8b977862f38d18d2d08d2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109513Reviewed-by:
-
Luciano Pacheco authored
Bug: 1064504 Change-Id: I1233f791280d3b7aa56b7ee6713ebb2886fa6048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119348 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
nancy authored
Move LaunchManager's two functions to launch utils: GetLaunchFilesFromCommandLine CreateNewTabBrowser Follow up: 1. Move ExtensionAppLaunchManager's function to extensions, and remove ExtensionAppLaunchManager 2. Modify web_app::WebAppLaunchManager to remove the dependency on LaunchManager. 3. Remove LaunchManager. BUG=1061843 Change-Id: I29e333a4ef686ab76edee846cf35228ac55e5074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117930Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753132}
-
Maggie Cai authored
This CL adds the functionality to delete all entries with the given app id from the preferred app list. This CL also migrates the unit tests from the original preferred app tests. BUG=853604 Change-Id: I475c0c2776c7c2723b7cfdcdfb4a9dccd2ddcbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117141Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#753131}
-
Luciano Pacheco authored
Reduce the size of the input inside the <cr-input> to avoid long text to run over the "clear button". Bug: 1061311 Change-Id: I281d2388eeadb5001ac35b1b6dca14c301f437fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119340Reviewed-by:
-
Peter Kasting authored
StartMonitoring() starts the thread asynchronously, which it must do since it happens on the UI thread and cannot block. However, the test checks that the tid() is set immediately, which is only valid once the thread starts up. This race leads to test flakiness. We could busy-loop waiting for the thread to start, or use a condition variable, or do various other fixes to ensure that we don't access the tid() until it's really there; but since the test is basically trying to ensure that a second call to StartMonitoring() is a no-op, this just checks that the thread* is non-null and unchanged between the two calls. This is sufficient and should work consistently. Bug: none Change-Id: I672e229ce07d84d04a7cd0aa2eb498a9d903d5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117053 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#753129}
-
Jeff Yoon authored
Forward a --release flag to indicate a release run for iOS test runners when is_debug=false. Bug: 1056887 Change-Id: Ic9941745084376b85938b1b98e1afb01cc254384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105070 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#753128}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cdbe45e832f2..8c53b6f52b29 git log cdbe45e832f2..8c53b6f52b29 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@8c53b6f52b29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6bde32ac1f22533a17032d09153a372c99b0d164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119911Reviewed-by:
-
Moe Ahmadi authored
NTP realbox matches support different icons for different match types: "loupe" for search suggestions, "clock" for historical search suggestions, "page" for navigation suggestions, "drive icons" for Google Drive, etc. Currently only the "loupe" and "clock" are supported by hardcoding in CSS. This CL changes that by sending the appropriate icon information along with the matches form C++ to JS allowing for a 1:1 mapping between the icons in the NTP realbox and the Omnibox. A followup CL will complete this mapping and add tests to avoid regression in the future. NTP realbox input has a "loupe" icon by default. When a match with a different icon or favicon is selected, the realbox input also gets that icon/favicon. This CL refactors the way these icons/favicons are displayed for the realbox input as well as the matches: Icons are rendered via webkit-mask-image and background-color and favicons are rendered via background-image set on the element's style property in JS. Also instead of requesting favicons for *every* navigation match which results in display the default "page" favicon for matches without one, favicons are now requested in C++ and sent to JS only if one is available; taking advantage of high res SVG icon for matches without a favicon as well as Google Drive matches, calculator matches, etc. Bug: 1039357,1061221 Change-Id: I90e17aa573ba7ef211e3f1423fa7de511cb7e053 Tbr: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106655 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#753126}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I8cff5fc0261595f5c33f34eb578e9000b921dcb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119874Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753125}
-
Nate Fischer authored
This switches Dev UI from Activities to Fragments. The immediate user benefit is smoother transitions when switching between tools, but this opens up for opportunities for other navigation methods (ex. bottom nav bar or nav drawer). Bug: 1017532 Test: Tested system_webview_apk on L+, monochrome on N+, Trichrome on Q Test: Click flag UI notification, verify it opens the flags UI fragment Change-Id: I32eb7a9b2ada6395bad21488e6bd15c802131b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108919 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#753124}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7fdb9a49a600..d588fbe8cd72 Created with: gclient setdep -r src-internal@d588fbe8cd72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053589 Tbr: jbudorick@google.com Change-Id: I2e1eb8b074ca79a9d30762063fb6f442232007f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119812Reviewed-by:
-
Minoru Chikamune authored
Add a mode which doesn't reset the mojo connection when the associated ExecutionContext is detached. If the original code doesn't have `ContextDestroyed()`, then HeapMojoWrapperMode::kWithoutContextObserver should be used. Bug: 1058076 Change-Id: I6ea02f1b663b968d70e7b3b475ce40f183592f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114020Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Demetrios Papadopoulos authored
Specifically porting: - sync_encryption_options.js - people_page_test.js (split CrOS tests to people_page_test_cros.js) - people_page_sync_controls_test.js - people_page_sync_page_test.js The remaining people_page_sync_page_interactive_test.js will be ported in a separate CL. Bug: 1026426 Change-Id: I8c3446ad645a492e12cc0d6f7df5cf2d0463f3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113708 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
zhaoyangli authored
xcodebuild_runner can detect a list of test names in EG2 and Release build target since this change. - Introduced a |release| arg to indicate if this is running on a release build and used the arg in |SimulatorParallelTestRunner|. - Changed functions in shard_util to return a list of test names. - Fixed minor bugs in shard_util finding app path logics. - Updated affected tests. This is tested locally that a correct list of test names can be detected for {Debug, Release} builds * {EG1, EG2} tests. Bug: 1054651 Change-Id: I0d6fbe794c81df9d128e6bc2ca77ceede549ec87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079612 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753120}
-
Takashi Sakamoto authored
Bug: 1056839 Change-Id: I0aa5ac3a20fc5a5cd1a8584e05c07baf59d2fe08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106980 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#753119}
-
Khushal authored
SurfaceControl relies on transaction acks from the framework to manage pipelining/backpressure for frames sent by display compositor to SurfaceFlinger. These are not getting dispatched when Chrome is rendering on an external samsung dex display due to a platform bug which stalls the rendering pipeline. This change adds a workaround to disable SurfaceControl while the Chrome activity is associated with a samsung dex display. R=boliu@chromium.org Bug: 1042581 Change-Id: I38c067f6f7f48cf04c192cc59efe95a4c21fa4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099602 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753118}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ccb5f29c. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If7bb23043d037fa4e57429cbd8c979041d39083d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119551Reviewed-by:
-
