- 05 Nov, 2020 40 commits
-
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: I2575821084d0ec431b92a2bc6d10f3ddcf640a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517212 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#824283}
-
Anupam Snigdha authored
Due to frequently querying the overlaycontent flag through jni calls, there was a performance hit in blink_perf.parser perf test. Added few helper methods to cache the overlaycontent flag and update it during TextInputState updates as this data structure is also used to control the IME which in turn affects WebContent size due to overlaycontent flag. Bug: 1144404 Change-Id: Ia814845cad5c5108cf6bdaf135388c6fa31a3cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515841Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#824282}
-
Peter Kotwicz authored
This CL rolls: androidx.asynclayoutinflater:asynclayoutinflater androidx.cardview:cardview androidx.concurrent:concurrent-futures androidx.coordinatorlayout:coordinatorlayout androidx.localbroadcastmanager:localbroadcastmanager androidx.swiperefreshlayout:swiperefreshlayout androidx.tvprovider:tvprovider androidx.exifinterface:exifinterface androidx.annotation:annotation-experimental androidx.transition:transition com.android.support:localbroadcastmanager BUG=1064277 Change-Id: I978f6c0b664067b6cb16390d3decb5112266d868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493304Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824281}
-
minch authored
Live update for auto click menu, media controls in the system tray menu, magnified device info etc. Bug: 1131543 Change-Id: Ic5791723636fd9014bff021126b715ed703eba8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506836 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#824280}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604458456-6d8a68b0c784483d981d5c288d37192b762edfa5.profdata to chrome-win32-master-1604512659-59b458f9b5eb8bc1f5597aad6c07c5aa05c0c8cd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id9f52d8177dbae1b21652abccbd89871b361cab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520038Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824279}
-
Bettina Dea authored
Disable the ENHANCED_PROTECTION_PROMO_CARD feature for them. Bug: 1143974,1143781 Change-Id: I7f1a41cbf6d78e8a93bddbd0ad113a679d90faf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515205 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#824278}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84e62ab4804c..422eb910890c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jshikaram@google.com,xhwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1134178 Tbr: jshikaram@google.com,xhwang@google.com Change-Id: I79153133b8f6143aae7c4dd26c4b24699d9b4781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518622Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824277}
-
Ben Kelly authored
This CL translates the path-to-regexp lexer from typescript to c++. Its based on the code here: https://github.com/pillarjs/path-to-regexp/blob/125c43e6481f68cc771a5af22b914acdb8c5ba1f/src/index.ts#L1-L124 We deviate from path-to-regexp here in only how we refer to "(foo)" groups in the pattern. Upstream these are referred to as `PATTERN` type tokens. This CL uses the term `kRegex` instead to avoid confusion with the overall urlpattern name. This CL also includes extensive unit tests for the lexer output. Bug: 1141510 Change-Id: Ifdc0fb0ea2454b7df8cd72785b72629ee6f204b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506453 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824276}
-
Xing Liu authored
This CL adds a divider view holder type to bookmark main UI. Currently it only applies to top level folders when reading list feature is enabled. The "Move up"/"Move download" functionalities don't need to change, type assertion is added to these functions. Notices top level folders and the reading list page both don't support these functionalities. Bug: 1139070 Change-Id: I69528cfaa7f14539763fdbd85187390d8a8f8794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485848Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824275}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for: - LayoutRubyBase - LayoutRubyRun - LayoutRubyText This CL has no behavior changes. Bug: 891908 Change-Id: Ief62bdc7806e6cf46d79018cbb5a86f9334acb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519340 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824274}
-
Kent Tamura authored
Bug: 1040826 Change-Id: I337144ba609644cdff93d00c788ed8853290786d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519176 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824273}
-
Alexander Surkov authored
Bug: 1133330 Change-Id: Id111731b1e5274f41e044fdbded9a2b4a5f10918 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508552 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824272}
-
Evan Stade authored
with missing artwork. Bug: 1137625 Change-Id: I04cee23e9e05be07f4d3691246f5f74778cc5d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504275Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#824271}
-
James Vecore authored
Bug: b:171980625 Change-Id: I8967a5123187dbd615a59522ee709a7128bbbcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518877 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#824270}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. In order to have consistent unittest design, we unify the existing fake set up for `CreateCertificateRequestRequest()`. BUG=b:158955123 TEST=chromeos_unittest , unit_tests, and browser_tests. Change-Id: I64cf5a4db9553e075e2f015262c6702cee8efadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517160 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#824269}
-
Leo Lai authored
It is just a stale object after migrating to AttestationClient. BUG=b:158955123 TEST=browser_tests. Change-Id: If8ff2ba690e93674d46b63e0858cd28d7eb25e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517235 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824268}
-
Mei Liang authored
This CL requests focus on the Reopen closed tab button after a tab has been closed. This can provide more feedback for user and able to undo the closed tab more easily. Bug: 526259 Change-Id: I41719ea41b21300ad499f9d4ec487fd60c94929e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520336Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#824267}
-
Minggang Wang authored
ChildURLLoaderFactoryBundle/ChildPendingURLLoaderFactoryBundle into blink As part of the OnionSoup project, this patch moves classes ChildURLLoaderFactoryBundle and ChildPendingURLLoaderFactoryBundle into blink. Bug: 1110026 Change-Id: I8539d893b10a2ca600ce971e4b6b32b781039e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509351Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#824266}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604480374-c14bff331808fa9a4e787bbbdb6a7c4b82678afd.profdata to chrome-win64-master-1604512659-d9763b7a65f794f5c7fc74561c1fa38d29e0d735.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0606f281e9296338ab3d37ba4c1b162a3a4b5bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824265}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4989667a9c4c..658ede5d8c5c 2020-11-05 m.maiya@samsung.com LuminanceWorkaroundTextureSwizzleBug test bug fix 2020-11-04 jdarpinian@chromium.org Reland "ANGLE_platform_angle_device_context_volatile_* extensions" 2020-11-04 geofflang@google.com Mark uniform samplers in an array unused per element 2020-11-04 syoussefi@chromium.org Vulkan: Don't break the render pass on scissor change 2020-11-04 m.maiya@samsung.com Vulkan: Enable GL_EXT_buffer_storage extension 2020-11-04 ianelliott@google.com Vulkan: Suppress VUID-VkImageViewCreateInfo-usage-02652 2020-11-04 jmadill@chromium.org Gold trace tests: Add logging for filter misses. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I98c7b73937f8fa500573b88910a7a21ebb4bea0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518705Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824264}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/57154998a866..68dcf542b79f 2020-11-04 johnstiles@google.com Migrate CrbugOssfuzz21688 to a golden-output test. 2020-11-04 brianosman@google.com Runtime Effects: Support 'uniform shader' (vs. 'in shader') 2020-11-04 johnstiles@google.com Fix crash when comparing against a negated constant vector. 2020-11-04 johnstiles@google.com Create unit test for comparison against a negated constant vector. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I08cdf96bb59af147798b545ba96d5ba3ff15433c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824263}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604512659-4b84fe5629f68a4167b75a88f505e98c0dbfa654.profdata to chrome-linux-master-1604534391-5a78416253c14f884fd91b82681793eb4590bf60.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I319085fefee01889c463e9bff68e55f9c592c7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824262}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I4a81f8fc705a6cf3497ead7c5a6cfe7c7d3b8d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520217Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#824261}
-
Takumi Fujimoto authored
When a DIAL device is incompatible with a website, change the message shown to "Available for specific video sites" to make it clearer why it's disabled. Bug: 1112609, b/162794109 Change-Id: I68df407f276a2fdb2eb8c215e73eefbbfde711c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486560 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#824260}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604512659-45eb42cef0308750e2a844fa6affa8130c8ae0d0.profdata to chrome-mac-master-1604534391-0b66c67528d135f745546f739dea18f4b7b0777d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If3c93388fd0bf418102b13d72c164f4d5e1b0876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824259}
-
Darwin Huang authored
Put the data consistently first, as that's generally the most relevant argument when reading code. Also, this makes this consistent with argument ordering in ClipboardReader. Refactoring change only. No functional changes expected. Change-Id: I3a5b6994cfa613811730a1e44a9ed9648ba5207d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406660 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824258}
-
Shakti Sahu authored
This test started failing recently. Disabling it till it gets fixed. TBR=aliceywang@chromium.org Bug: 1145573 Change-Id: Iabd539ef7321fbfd33be9fd742b55a8e4bead928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520322Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824257}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 87.0.4280.49 R=rmhasan@google.com Bug: 1041619 Change-Id: I34fbcbf9877b31c3bd2769eb9afc9f4cbc0ac776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518256 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#824256}
-
Shakti Sahu authored
This test was recently added and started failing. Disabling till it gets fixed. TBR=mahmoudi@chromium.org Bug: 1145783 Change-Id: I34e0ddd68287697223219b89de5b624c93cf0a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518452 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824255}
-
Adam Rice authored
Some NAT devices examine traffic on port 5060 to look for a valid SIP message. If they find one, they will forward a port back to the origin host. A carefully crafted HTTP request can trick these NAT devices into forwarding an arbitrary port. See https://samy.pl/slipstream for more details on the attack and sample code. Block port 5060 for HTTP. Out of an abundance of caution, and to match the Fetch standard (https://github.com/whatwg/fetch/pull/1109), also block port 5061 (SIP over TLS). Also reduce the whitespace before protocol description comments. This was insisted on by clang-format and is not worth fighting. BUG=1145680 Change-Id: I3a556fbbb4dc6099caa4418addaf1e89bf254ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519174Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#824254}
-
Keishi Hattori authored
Add mini_installer and chrome_elf to rewrite_raw_ptr_fields to ignore list because gn gen --check give errors when including a file from base. Bug: 1080832 Change-Id: I41850950f62cc1e9951971ff93c9053fd3cc414d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518301Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824253}
-
Keishi Hattori authored
Treat CheckedPtr specially in FindBadConstructsConsumer for now as discussed in: https://groups.google.com/a/google.com/g/chrome-memory-safety/c/kw3i_zd3FW4/m/40FkyrLtAQAJ This CL helps to avoid "Complex constructor has an inlined body" and similar errors during go/miracleptr experiments. Bug: 1080832 Change-Id: Ibfb6b3b418f36e2c6868b0fbd579d1bf18226ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487023 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#824252}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/deff57f9b2c8..8ca189d4e5b8 2020-11-05 vapier@chromium.org pylint-2.6: use newer pyquotes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1123433 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I10c2957b319f15b799c4c23f3f56e341cc5bb9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519886Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824251}
-
Peter Kasting authored
Missed a few on the first couple passes... Bug: 772945 Change-Id: Ib3e87c2de54c74557113176d0c4f316ef2db4739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519880 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#824250}
-
Daniel Rubery authored
Increase threshold for hash distance in ClientSideDetectionHostBrowserTest.VerifyVisualFeatureCollection This test appears to be a little flaky. It's possible that a slight rendering difference has pushed the hash distance over the threshold, so we increase the threshold. Bug: 1141342 Change-Id: I329eb40ab85340958e592717572ca80733e13632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519727Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#824249}
-
Peter Boström authored
Bug: 1002162 Change-Id: I133e2c55b8f6e2a627f7cce9eeced8f3bbb2c18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499173 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#824248}
-
Jinsuk Kim authored
Usage: $ chrome/tools/modularization-loc-stat.py --date 2020-01-01 2020-10-06 Processing complete # of lines added in modularized files: 189069 # of lines added in legacy files: 357268 % of lines landing in modularized files: 34.61% Top contributors: No lines % author 1 36886 19.5 estade 2 12486 6.6 shaktisahu 3 11460 6.1 blundell 4 10986 5.8 twellington 5 10022 5.3 rmcelrath 6 6923 3.7 hnakashima ,,, Change-Id: I3f77e6c43a753eda1ad41760a64c38b3c3f4a187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362361 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#824247}
-
Austin Eng authored
This adds replays of some Unity Tiny/Classic games to rendering.desktop and rendering.mobile page sets: - Skelebuddies wasm - Tiny Racing wasm - Microgame FPS - Lost Crypt These test different major rendering paths in Unity. Bug: 1142904 Change-Id: I42d5da9ae7090db74b2bff6e6c605d1d2983041b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512367Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#824246}
-
Scott Lee authored
In crbug.com/1141606, it was reported that blink_web_tests ran significantly longer on certain versions of Windows, if resultdb enabled. Until a fix is made, this CL disables the integration, so that the results will be parsed and uploaded via result_adapter. R=chanli@chromium.org,dpranke@google.com CC=robertma@chromium.org,bpastene@chromium.org,nodir@chromium.org Bug: 1141606 Change-Id: I21cdf6ab0a948696b68c69c5550d22a33174ed95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519885 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824245}
-
John Palmer authored
BUG=1111135 Change-Id: I9474ee3d796e263869b4ab12cf072ec851407b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517226 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#824244}
-