GitLab

Review URL: http://codereview.chromium.org/8836001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113482 0039d316-1c4b-4281-b951-d872f2087c98

I had fixed it in r111201

R=dennisjeffrey@chromium.org
BUG=104886
TEST=

Review URL: http://codereview.chromium.org/8866001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113481 0039d316-1c4b-4281-b951-d872f2087c98

The old ProfileManagerObserver was hard to use since it required a new class or subclassing. Using callbacks is easier.

BUG=100461
TEST=

Review URL: http://codereview.chromium.org/8840003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113480 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit bd45bd25.

TEST=ran webkit tests in DRT and webgl tests in chrome
BUG=103989

Review URL: http://codereview.chromium.org/8758026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113479 0039d316-1c4b-4281-b951-d872f2087c98

I think that r113138 and r113167 combined made it too light

BUG=106669
TEST=manual

Review URL: http://codereview.chromium.org/8833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=none


Review URL: http://codereview.chromium.org/8834003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113477 0039d316-1c4b-4281-b951-d872f2087c98

Change did not help.

TBR=dtseng

BUG=
TEST=

Review URL: http://codereview.chromium.org/8824009

TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/8863001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113476 0039d316-1c4b-4281-b951-d872f2087c98

to be as wide as possible to cover all variants of this leak.

Remove the suppression for the leak of bug 95718 because it is a
variant of the above leak.

R=cbentzel@chromium.org
BUG=77990
TEST=none

Review URL: http://codereview.chromium.org/8823019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113474 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8803022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113473 0039d316-1c4b-4281-b951-d872f2087c98

The first bit is designed to ensure that the correctness of callback_forward.h is tested by the callback unittests. The second bit is designed to increase the likelihood of developers actually using callback_forward.h as intended.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8846003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113472 0039d316-1c4b-4281-b951-d872f2087c98

These were fixed by my earlier r112315

BUG=102767
TEST=None

R=dennisjeffrey@chromium.org

Review URL: http://codereview.chromium.org/8856008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113471 0039d316-1c4b-4281-b951-d872f2087c98

Makes tests either use mock compositor or mock WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots.

BUG=104360
TEST=none

Review URL: http://codereview.chromium.org/8805033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113470 0039d316-1c4b-4281-b951-d872f2087c98

HTMLConstructionSite::insertText changed its signature.

BUG=105961
TBR=mikelawther@chromium.org

Review URL: http://codereview.chromium.org/8852010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113469 0039d316-1c4b-4281-b951-d872f2087c98

Also move NTPPromoShown to notification_promo.cc

BUG=106743
TEST=NONE.

Review URL: http://codereview.chromium.org/8833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113468 0039d316-1c4b-4281-b951-d872f2087c98

Return buffers that are in flight during shutdown and make sure to issue 
defered stop.

BUG=106369
Review URL: http://codereview.chromium.org/8819010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113467 0039d316-1c4b-4281-b951-d872f2087c98

these tests to using manifest_version 2, but it looks like more effort than
it's worth.

BUG=62897
Review URL: http://codereview.chromium.org/8825015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113466 0039d316-1c4b-4281-b951-d872f2087c98

Don't attempt to forward declare StringPiece. #include the declaration, or remove the forward declaration where it was not actually used.

1) Forward declaring StringPiece is generally discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

This particular CL would be one of the rare ones where a forward declaration would be 'appropriate', but it does not warrant forward-declaring both the template and the typedef, and the number of similar cases does not justify creating a _forward.h header.

BUG=87634
R=tony@chromium.org

Review URL: http://codereview.chromium.org/8819022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=43460
R=mirandac@chromium.org

Review URL: http://codereview.chromium.org/8848003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113464 0039d316-1c4b-4281-b951-d872f2087c98

This is cleaner and won't cause spurious crash reports.


BUG=
TEST=


Review URL: http://codereview.chromium.org/8823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104783
TBR=acolwell

Review URL: http://codereview.chromium.org/8849009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82717
TBR=ananta@chromium.org

Review URL: http://codereview.chromium.org/8849008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113459 0039d316-1c4b-4281-b951-d872f2087c98

Fixing background mode manager to correctly display the name of the profile in the status icon. Previously it was not being updated when Chrome first started up and it was also using the incorrect name. Now it gets the correct name from the profile info cache and also updates based on changes to the profile info cache.

BUG=101837
TEST=start chrome with background apps and the status icon will have names populated correctly, also BackgroundModeManagerTest::ProfileInfoCacheObserver

Review URL: http://codereview.chromium.org/8802013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113458 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes Hunspell-related options from the spelling context menu on the Mac and tries to bring the menu more inline with the native platform menu.

Notably:
* Spelling submenu observer is split into Hunspell and Mac implementation files.
* strings are split into mac/non-mac variants (saving a bit of space on non-mac platforms?) and the titles are brought more in line with OS X (probably need more work to make this match on all OS X versions).
* Menu is reordered on Mac to more closely match the Cocoa spelling submenu. 

BUG=69944
TEST=Spelling submenu should continue to work on non-Mac platforms. On Mac it should contain 3 items - "Show Spelling and Grammar", "Check Spelling while you Type" and "Language Settings..."


Review URL: http://codereview.chromium.org/8823009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113457 0039d316-1c4b-4281-b951-d872f2087c98

Set mask after sending modifier keys.
Print unknown keysym in hex and add warning for unknown keycode.

BUG=106630
TEST=All BrowserKeyEventsTest except for AccessKey will pass


Review URL: http://codereview.chromium.org/8836007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113456 0039d316-1c4b-4281-b951-d872f2087c98

The largest sources of flake should now be fixed or supressed.

BUG= none
TEST= none

Review URL: http://codereview.chromium.org/8823014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113455 0039d316-1c4b-4281-b951-d872f2087c98

When diff-ing two snapshots, do the merge *before* doing the diff. In practice this doesn't usually yield different results, but it is possible. Merging before diffing makes more sense though, and avoids some duplicated work.

BUG=105301
Review URL: http://codereview.chromium.org/8676023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113454 0039d316-1c4b-4281-b951-d872f2087c98

Older gcc versions apparently do not support this when used with STL.

Review URL: http://codereview.chromium.org/8771061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23871
TEST=None

Review URL: http://codereview.chromium.org/8858001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:21845
TEST=Shut down option should be present at the bottom of the wrench menu on any cros device.

Review URL: http://codereview.chromium.org/8834006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63670,87461
TBR=sail@chromium.org

Review URL: http://codereview.chromium.org/8851011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113446 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106305
TEST=manually

Review URL: http://codereview.chromium.org/8793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113441 0039d316-1c4b-4281-b951-d872f2087c98

Move windows implementation to pimpl idiom
  http://c2.com/cgi/wiki?PimplIdiom

There should be no behavior change.

BUG=none
TEST=ConditionVariableTest in base_unittests suffice
Review URL: http://codereview.chromium.org/8823012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113439 0039d316-1c4b-4281-b951-d872f2087c98

MessagePumpMac wants NSApp to be initialized before the UI MessageLoop
is created.

BUG=102224


Review URL: http://codereview.chromium.org/8844001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113437 0039d316-1c4b-4281-b951-d872f2087c98

This change adds the apple software renderer as an option on Chrome/Mac.  It's enabled by passing --use-gl=apple on the command line.  It also removes the default pbuffer creation on Mac since it's not required to create GL contexts and is incompatible with the generic float renderer.

BUG=106584
TEST=--use-gl=apple on chrome/mac cmdline
Review URL: http://codereview.chromium.org/8698008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113436 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8832001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99524
TEST=compositor_unittests, views_unittests, aura_unittests...


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112641

Review URL: http://codereview.chromium.org/8565019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96010
TEST=trybots

Review URL: http://codereview.chromium.org/8831005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113429 0039d316-1c4b-4281-b951-d872f2087c98

[ Reland of 113290 http://codereview.chromium.org/8790004 ]

I keep getting confused between things like AudioImpl and PPB_Audio_Impl. This uses _shared for the names, so now we have _impl, _proxy, and _shared which makes more sense.

I also removed the ppb_opengles2_impl file since it was just a forward to the shared version.
Review URL: http://codereview.chromium.org/8849003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106716
TEST=On Chrome OS, manually test typing and autocompleting in the omnibox with accessibility turned on.

Review URL: http://codereview.chromium.org/8850001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113427 0039d316-1c4b-4281-b951-d872f2087c98

Looks like they're the same and only one of them is being reported now.

BUG=101781
TEST=none


Review URL: http://codereview.chromium.org/8824011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113426 0039d316-1c4b-4281-b951-d872f2087c98