- 23 Dec, 2020 40 commits
-
-
Ella Ge authored
Bug: 1152282 Change-Id: If950c0bcb76c5dbd280ca984a8955076764daadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601060Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839072}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/407251b8..5af8c738 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4512858ec5376ef09e0c19d40fbd09953d228f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601845Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839071}
-
Henrique Ferreiro authored
Allowed values for dropEffect[0] are "none", "copy", "link" and "move". "uninitialized" was used to fix an issue when the value wasn't initialized (see https://bugs.webkit.org/show_bug.cgi?id=36095) but shouldn't be exposed. This CL replaces it with the null String. [0]: https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-dropeffect Bug: 1093536 Change-Id: I923e34fd19bcc0764a4659bb0b026378e01b4c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590446Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#839070}
-
David Jean authored
Network Activity indicator is deprecated starting with iOS 13. Bug: 1125908, 1115004 Change-Id: I52488502cc79b780e4c707c1f2f27eb82d0b52d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600129Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#839069}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ec8371fe0222..5a7dee84857b 2020-12-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5f001fbb440914494a6d0246682023881ef6c9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601760Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839068}
-
Satoshi Niwa authored
Context : http://ag/c/device/google/bertha/+/13240391/3/init.bertha.rc#77 BUG=b:13240391 TEST=manually test android-sh Change-Id: I99f367d95b24ed7c2c752ecb393ff619e5d1c87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597525Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#839067}
-
David Maunder authored
This was introduced when fields were being migrated from TabImpl to CriticalPersistedTabData via the UserData interface such that the in-memory storage of Tab fields were moved from CriticalPersistedTabData but persistence wasn't turned on yet. In addition, capability for turning PersistedTabData saving on and off via ObservableSupplierImpl so if the need to turn off tab saving arsies, it can simply be done using that. Bug: 1160923 Change-Id: I4351e592825af163e0a9ec38fded2d834f1473aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599883Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#839066}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3624aba91f44..fa711c4c756a 2020-12-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c35f468e to 9e53f70c (266 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I0dbf31533198896659ef5cbfae522adbd4e8969c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601806Reviewed-by:
-
Jeremy Roman authored
Bug: 1007635 Change-Id: I723f26ca65c9c05bd2375dac1f3f61ef0e405d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601336 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839064}
-
Theo Johnson-kanu authored
- Before this CL, when rename fails the user is not shown any meaningful message, this CL shows the user a meaningful message. Screenshot - https://screenshot.googleplex.com/4hCHuSsvU3fdHL9.png Bug: 1154787 Change-Id: I82a164b062affa5fad686b72fdd56c2ea17b48f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600236 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#839063}
-
Alex Danilo authored
When files transfer progress details was managed by a feature flag, there was a run-time support function called isTransferDetailsEnabled(). Remove the utility function and all references to it. Remove the now obsolete function generateDestinationString_(). Bug: 953308 Change-Id: Ia011cba72621187d3c5e74af25ec5cb32789482f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600427 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#839062}
-
Harvey Yang authored
This commit simplifies the logic of AccelerometerProviderMojo by limiting the usages on the UI thread. BUG=b:175355860 TEST=unit tests and run on kohaku(hatch) Change-Id: Ic43439a70b544848dcd3a948f996f81a9032687d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586172Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839061}
-
Daniel Clark authored
This is the first in a series of changes that will implement import assertions integration in Blink and tie the assertions into the existing JSON and CSS module prototypes. See the import assertions spec [1], the HTML integration PR [2], and the I2P [3]. This change retrieves the import assertions from V8 in ModuleRequest::ModuleRequests and in the ResolveModuleCallback. The code to unpack them is moved inside blink::ModuleRequest to avoid code duplication across those two places. ModuleRequest is upgraded from a struct to a class now that its constructors are no longer trivial. ModuleRequest is passed to ModuleRecordResolver::Resolve in place of the specifier, where the import assertions will eventually be used alongside the specifier to resolve the module. IsolateHolder now passes "type" as a supported assertion via V8 Isolate::CreateParams so that Blink will start receiving module "type" assertions. Subsequent changes will add the assertions to the module map key and require the correct assertion to be present before a JSON or CSS module can be successfully loaded. [1] https://tc39.es/proposal-import-assertions [2] https://github.com/whatwg/html/pull/5883 [3] https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/Xft04J07Oh0/m/RLPMXVEiAAAJ Bug: 1132413 Change-Id: Id41e9e470d3c4ed1988d8dfa1ef8fa26cd9d23a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597778 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#839060}
-
adafang@google.com authored
Scores from providers have different distributions and ranges, this makes them difficult to compare. Here we have implemented a basic way to normalize ChromeSearchResults by subtracting the mean of the learned distribution. After experimentation with more complex normalization methods we will then update this normalization method. Further details at go/cros-launcher-normalization In this CL we have 1. Written a simple normalization (subtracting the mean). 2. Written test cases for this. 3. Implemented prefs to save the distribution. Bug: 1156930 Change-Id: I38ce9b78956245edecc4ed166ad567e20c2e749f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584490Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Ada Fang <adafang@google.com> Cr-Commit-Position: refs/heads/master@{#839059}
-
Alex Danilo authored
Files transfer details has shipped and no longer requires a feature flag to disable/enable it. Remove the feature flag. Stub the util function isTransferDetailsEnabled() to return true as prerequisite work for removal of that function. Bug: 953308 Change-Id: If973fa2af0bcfdb9325070861eee3d12de0d2016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596583Reviewed-by:
-
Harvey Yang authored
This commit simplifies the logic and puts only the blocking code in the created USER_VISIBLE sequenced task runner. In this way, most of the tasks are run on the UI thread. BUG=b:175355860 TEST=run on octopus Change-Id: I50b9380c5d0667513430f4f3b685317687be844d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586288 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
-
Ella Ge authored
make ReadCallback and WriteCallback use base::OnceCallback Bug: 1152282 Change-Id: Ie7c52a762e04c368fbecd0ed1dcec3c0ae8ab1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600384Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839056}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/74788951af42..5c0ba5437be0 2020-12-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 54509765b18d to b29bf0434c16 (15 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: If4f32c0e2b4ac7e1b7b98c02319d8a41d8553b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601613Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0af374b04bee..ec8371fe0222 2020-12-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5eb6144f77ebd3abf7cad5bc166c29d8d3611b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601838Reviewed-by:
-
Xianzhu Wang authored
The crash happened when we committed from the main thread and the high res tiling was dropped because its scale was out of the range of min and max scales. To avoid the crash, remove SanityCheckTilingState() from CleanUpTilingsOnActiveLayer() to avoid the DCHECK failure at the beginning of UpdateTiles(), and call SanityCheckTilingState() from the original callsites after updating the tilings. Bug: 1160003 Change-Id: Id9cfb65158dc6c540e2316e4f062fe6299cd1842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599471Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839053}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I968023e15a7cce8e2a4b8b612d4224bbdc5fd5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601520Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839052}
-
Josh Simmons authored
As we intend to merge this into 88, this check is controllable via the VoiceSearchAudioCapturePolicy feature. To keep this change small, hiding the mic is best-effort. There are cases where the user's profile is not yet available when layout decisions are being made. In those cases, we will continue to show the voice search mics, but will not initiate a voice search when the mics are pressed. Future CLs will add observers so the mic surfaces can be hidden as soon as the profile is available. Bug: 1161022 Change-Id: I772788288dc41b610f996c0b631e83e5cba117ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598008 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#839051}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608649072-95a4cf9b59101d6f6ea631f49afe5baa9a8b257b.profdata to chrome-win64-master-1608669833-81935a5ef3eac5be8a1967fe04891c8cf8108546.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0af25cd5790276938575405efb3d5316a2395767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596894Reviewed-by:
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I784f58acb01fd54cc3efadf526ae0df5a5e9865f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600418 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#839049}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I40255c5e8f4329fdf2fd7d2cb659890a0b9c308f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599569 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Adds examples of creating a WebUIConfig and an UntrustedWebUIController for chrome-untrusted:// WebUIs. Bug: 1080384 Change-Id: I8927c134ecdf015524b34a5cb5c88f1c03bccde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596900Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#839047}
-
Andrey Kosyakov authored
Bug: v8:11268, 1101897 Change-Id: I39bca561c0cf3daaf900648bf45c6d7989a36242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600273Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#839046}
-
Pavel Yatsuk authored
This CL introduces a logic to block trigering future Save Password messages for the current site. This logic is similar to "Never button" in Save Password infobar. For M88 Save Password message shows a menu with a single "Never" item. In the future we will introduce a modal dialog with other options. BUG=1160393 R=twellington@chromium.org Change-Id: Idecfb30827b123197a5ad5af06433e6a96dfad2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599118 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#839045}
-
Michael Hansen authored
This just updates the return value of registerForegroundReceiveSurface() to return an enum. The result is not currently used in any tests, but this change brings FakeReceiveManager inline with the mojo definition. Fixed: 1159672 Change-Id: I3e9e8925f7dd497e5590b75e4cdf308c4fb88838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601645Reviewed-by:
-
Frank Liberato authored
Tries to match existing behavior: - "ExternalDecoder" for hardware decode - "libvpx" or similar for software decode Bug: 1157225 Change-Id: If265a1d2b1036fa4d54cf64d31c4bf94c794ed46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596437Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Johannes Kron <kron@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#839043}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.60. R=jam@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: If768786e3f80263d1cc2647c82a5cb87daa25270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601211 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#839042}
-
Noel Gordon authored
The ui/file_manager/file_manager/foreground/images directory contains the files app icons, including icons used by {Audio,Video} player and the Gallery extension. Update the local generate_image_html.sh script to look for SVG in the root sub-directories only: not the 2x sub-directories since they only contain "2x" PNG images. SVG images do not need / have "2x" variants. No-try: true Bug: files-app-icon-health Change-Id: I278d34cb5c2a7208b02f3fbd84248bbae028f584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599575Reviewed-by:Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#839041}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: If189e6aadc19fac405cd3eb08fc997902b0d3080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600322Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#839040}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: Ifdff40cd0fc2a03e01c48accac9b452c55ff3ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600421Reviewed-by:
-
Findit authored
This reverts commit dbfed21f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 838974 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RiZmVkMjFmOTQ4ODFhMjkxODIyMzc5MmViZGUzNDc2YjhmZDY5ZTYM Sample Failed Build: https://ci.chromium.org/b/8860163671563368608 Sample Failed Step: webkit_unit_tests Original change's description: > Fix several crashes when nested slots are removed from a ShadowRoot > > There were some crashes caused by nested slots (e.g. > <slot><slot>Content</slot></slot>) being removed from the tree. > These crashes were triggered by [1], which removed Shadow DOM v0, but > my theory is that due to the old V0 shadow root code, more calls were > being made to SlotAssignment::RecalcAssignment(). Now that the V0 code > is gone, it has exposed some missing code. > > Three issues are being fixed here: > 1. In Node::CheckSlotChange(), while removing the inner nested slot, > the parent_slot will have already been removed from the tree, so we > only need to call DidSlotChange if not. This used to be a DCHECK. > 2. In TreeOrderedMap::Get(), while removing a key that previously had > more than one element, we may walk the tree and find that none of > the pre-existing elements are present. I.e. we're in a RemoveScope. > In this case, the key should be removed from the map. > 3. In SlotAssignment::DidRemoveSlotInternal(), given #2 above, we can > just early-out if the slot isn't present in the map. > > I added a test for the crash conditions (variations on removing nested > named and unnamed slots), plus I added a test for the TreeOrderedMap > class, since there was none previously. The last test in the set > documents the new Get() behavior. I also tried to improve some of the > comments along the way. Finally, this CL rolls back a mitigation [2] > previously landed for this crash. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/2595967 > > Bug: 1159328, 1159727 > Change-Id: I47fbf33b2313b9ae2efe229443af6e8c9a1920a9 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597040 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Yu Han <yuzhehan@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838974} Change-Id: I97202c545f74df090124e82775fe79ce978d3d63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159328, 1159727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601758 Cr-Commit-Position: refs/heads/master@{#839038}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608659974-90bda9b569e2cfcf8d7da1dcfbdd3d98c384729b.profdata to chrome-mac-master-1608681510-8927c83b5ccd266ea3bc0bb5c167b260db8cc2a2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib2c6fdcdb2522c78e158ba000ddf0ec96e23505a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601648Reviewed-by:
-
Sammie Quon authored
Fixed: 1158004 Test: manual Change-Id: I0254d28ff9a545cadb80d42b487b7f0e3514082f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599246Reviewed-by:
-
Sammie Quon authored
It was double counting because it recorded one visible desk change per root window. This CL keeps the same logic, but moves it to DeskActivationAnimation, so that the metric is only counted once. Also, extend the time fast forward in a flaky test. Bug: 1151856 Test: manual Change-Id: Ica101a25df867ce5b37bfce08699c2d4715a9230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587974Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608659974-f24a1edbf2ebfb03ebc2935c99ccb8534f3f4c71.profdata to chrome-linux-master-1608681510-4320e883495a51de0d4ab86a576926e78aba732a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic3708045761951d11ad6a2210b50d71540d1f980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601649Reviewed-by:
-
Ella Ge authored
Bug: 1152282 Change-Id: Ic60eb67049d49e55f07314d1728a50b54d99115e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601221Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839033}
-
