GitLab

Due to an issue with the spreadsheet, some rows were not handling
negative enum values correctly so these values are corrected in this
CL.

In addition, the following names were also added based on metrics seen
on Canary:

util_win
chrome_printing
cdm
profile_import
file_util
patch_service
pdf_compositor

BUG=767906

Change-Id: I8b599a38f7728d35d150efb06c9d9d47a6a6685b
Reviewed-on: https://chromium-review.googlesource.com/1099366Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567012}

Add the following screens:
1. ShowErrorScreen
2. ShowSigninUI

Bug: 828058
Change-Id: Id632fd49b4e1575ad5443b5f315067bdbe08efd9
Reviewed-on: https://chromium-review.googlesource.com/1098457Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567011}

It turns out that UiDevice.getCurrentPackageName can return null, so
handle that case to avoid NullPointerExceptions.

TBR=mthiesse@chromium.org

Change-Id: I8cb220d5df1d0f110b2bded7473f20ba7d859872
Reviewed-on: https://chromium-review.googlesource.com/1099838Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567010}

Changes:
In old position system, dragging an item outside folder to a full page
or dragging an item from another page to a full page will push last item
on that page to next page. This is not allowed when apps grid gap is
enabled to avoid breaking the next page's layout.

Bug: 851563
Test: AppsGridGapTest.MoveItemToPreviousFullPageNotAllowed
Change-Id: I2630436fe6c3aba9e2332668b5ab972b6dfec9ec
Reviewed-on: https://chromium-review.googlesource.com/1095688Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567009}

https://chromium.googlesource.com/angle/angle.git/+log/f462ac1be283..9327981248e7


git log f462ac1be283..9327981248e7 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 oetuaho@nvidia.com Remove unnecessary checks when traversing nodes


Created with:
  gclient setdep -r src/third_party/angle@9327981248e7

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I97184ca916426fa98cb62f34853e4b243e4005b5
Reviewed-on: https://chromium-review.googlesource.com/1098944Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567008}

BUG=805182

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I56014e0e6db3a8b1439d6306dee0041a3916eb31
Reviewed-on: https://chromium-review.googlesource.com/1086275Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567007}

Padding added in two CL makes the back arrow start padding 2 times as
expected. This CL removes the padding added specifically in search mode.

Bug: 852410
Change-Id: I7194da772de3c8a07648fea1151185c19e93cab1
Reviewed-on: https://chromium-review.googlesource.com/1099770Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567006}

Make it sorted for real. Fixes one source of flakiness.

BUG=848398

Change-Id: I14e40f509e6363e06eeb5ed21bc239b59269bff8
Reviewed-on: https://chromium-review.googlesource.com/1095479Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567005}

Upon posting removing keyframe models events from main we are using the
name compositor_animation_ids_ which is misleading. This is a remaining
issue from the renaming patch we had before.

Bug: 807667
Change-Id: I985fff4d5073b69e8f3637b6273a6c72b7884e83
Reviewed-on: https://chromium-review.googlesource.com/1097582Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567004}

This can only happen on rare cases where the launcher thread is busy.
But there is a large difference between the old and new UMA. So, log
these cases too.

BUG=846871

Change-Id: I2c0d624bf3b60edccd2429e281745a0be86b88bb
Reviewed-on: https://chromium-review.googlesource.com/1092164Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567003}

URLFetcher et al will stop working in the browser process with advent
of Network Service, and SimpleURLLoader is the replacement API
for most clients. CL migrates TranslateURLFetcher to the new API.

Additionally, various unittests were also updated to use the new
TestURLLoaderFactory and EmbeddedTestServer machinery.

As a bonus, the CL allows us to get of URLRequestContextGetter
references throughout the TranslateURLFetcher path, including
TranslateLanguageList, TranslateScript, etc.

Since TestURLFetcherFactory allowed us to retrieve the actual
URLFetcher object (given an known 'id'), and SimpleURLLoader does
not, some helper methods were introduced, in order to verify the
state of the objects at a certain moment of the execution flow,
eg LanguageFetchURLForTesting and HasOngoingLanguageListLoadingForTesting.

Last, in a follow up CL, I will change the nomenclature used
throughout these files, from "fetcher" to "loader".

Bug: 773295,844971
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ica404dded4fab79a0035df825f12d2b1bb06329e
Reviewed-on: https://chromium-review.googlesource.com/1085947Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#567002}

clang-cl learned this flag in https://reviews.llvm.org/rL333761 (which also has
some words on why it's not the default). #566302 was a clang roll containing
that change.

Note that we also need https://reviews.llvm.org/rL334602 for this to have
an effect in practice, and that's not rolled in yet. Once it is, goma should
be able to cache non-symbol .obj files independent of the checkout path.
(See also discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1075947)

Bug: 439949,330260,712796
Change-Id: I4a9bc38e35884be03fd9898e7000938cb4782a54
Reviewed-on: https://chromium-review.googlesource.com/1099638Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567001}

Document the Update() and friends methods.
Document CreateLayerImpl() and PushPropertiesTo().
Document property tree index methods.
Remove unused ToScrollbarLayer().
Rename setters that are non-trivial to CamelCase and move to .cc file.
Remove GetLayerTreeHostForTesting(), there is also layer_tree_host().
Prevent shadowing member variable with local variable in LayerTreeHost.

R=jbroman@chromium.org, weiliangc@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iea580a1ede367659d7fa2bedb21ec37936a9db91
Reviewed-on: https://chromium-review.googlesource.com/1097989
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567000}

Bug: 814439
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibf4b91b1a2486da71acf2286866ec999535af494
Reviewed-on: https://chromium-review.googlesource.com/1095816Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566999}

|InlineLoginHandlerChromeOS| and |ChromeOSOAuth2TokenServiceDelegate|
use the system URL context because they 'know' that AccountManager is
going to use the same. This is a leaky abstraction.

Add a method in AccountManager that returns its URL Request Context.
This request context happens to be the system URL context for now.

Bug: 820046
Change-Id: I668769167893c995f73df63acc575eb410c0f986
Reviewed-on: https://chromium-review.googlesource.com/1088617
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566998}

Bug: 851412
Change-Id: Id9177b63eee4c0d6f1a438c682951f5105f25823
Reviewed-on: https://chromium-review.googlesource.com/1099355Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566997}

This reverts commit 66d17ca7.

Reason for revert: This test fails in official builds:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/86110

Original change's description:
> Make the ThirdPartyModulesBlocking feature work on all Windows versions
> 
> Change-Id: I0118d26fe9b7f11f2608dd66c10418e210393733
> Reviewed-on: https://chromium-review.googlesource.com/1083842
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566516}

TBR=pmonette@chromium.org,grt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ide1a33af76247dd31b82aa3d49916fe2ec1859a4
Reviewed-on: https://chromium-review.googlesource.com/1099698Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566996}

Making the dialog compliant with mocks.

Includes:
- Changing the warning icon from the warning triangle to the warning circle.
- Vertically centering the warning icon.
- Using GetStyle and GetColor to get the appropriate Red color.
- Using appropriate dialog insets.
- Using appropriate distances between items.
- Remove leading margin on New Card link.

See screenshots in the bug.

Bug: 850571
Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_TemporaryError --draw-view-bounds-rects --test-launcher-interactive
Change-Id: I5d28fa8d7bdda4a50ac65def53e49284ad16757c
Reviewed-on: https://chromium-review.googlesource.com/1098694
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566995}

TBR: samans@chromium.org
Change-Id: I503e589e64bd2d3fa9f47462437491f8db1087d4
Reviewed-on: https://chromium-review.googlesource.com/1098078Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566994}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed4c93def9c0..dd1a2724e60e


Created with:
  gclient setdep -r src-internal@dd1a2724e60e

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:852437
TBR=mmoss@chromium.org

Change-Id: Ie33f8ac195830eba2a672247ea77fe528d4eb690
Reviewed-on: https://chromium-review.googlesource.com/1098942Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566993}

Confirmed with the service provider that default image size returned
is 512x512, which is fine to use as-is for tile thumbnails. Options
need to be applied to the same URL to request the image at a higher
resolution when setting as the background image. Using the high res
image for tiles causes a noticeable delay in load time.

Bug: 850314
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic0c758d6326ad34017831bc1340cc292242cfa79
Reviewed-on: https://chromium-review.googlesource.com/1098380
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566992}

This is a reland of 628b2c85

The revision of depot_tools was updated for internal recipes.

Original change's description:
> Use DEPS instead of DEPS.chromium to recurse into ANGLE.
>
> ANGLE's DEPS file knows now what to sync when building with Chromium.
>
> Introduce the 'angle_root' variable that we need to tell ANGLE to sync
> in third_party/angle.
>
> Bug: 782846
> Change-Id: I26c5f48b7e4bc5a3f435d3de64d99bccb49a9555
> Reviewed-on: https://chromium-review.googlesource.com/1083229
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563898}

Bug: 782846
Change-Id: Ie0bfc5e83177944246e26fb788a341e54b784adb
Reviewed-on: https://chromium-review.googlesource.com/1099435Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566991}

Also make some implementation-only constants private while I was
in there.

Change-Id: I6a206a1b7be06cf2a3acc8d8ff512c0f18719fbf
Reviewed-on: https://chromium-review.googlesource.com/1099041
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566990}

Bug: 849694
Change-Id: I624f6a5c6a63a757055ce0616b50ab4bee0ba09d
Reviewed-on: https://chromium-review.googlesource.com/1099690Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566989}

This reverts commit e20ce45a.

Reason for revert: This has exposed a race in NetworkService feature tests.

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLndpbi9XaW4xMCBUZXN0cyB4NjQvMjQ2MDkvbmV0d29ya19zZXJ2aWNlX2Jyb3dzZXJfdGVzdHMgb24gV2luZG93cy0xMC0xNTA2My9WR2gxYldKdVlXbHNWR1Z6ZEM1VGFHOTFiR1JEWVhCMGRYSmxUMjVPWVhacFoyRjBhVzVuUVhkaGVWTnNiM2RRWVdkbFRHOWhaQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Original change's description:
> Update ThumbnailTest Frame Waiting
> 
> ThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad was using a time based
> wait, to simulate awaiting a frame submission. However the timing on viz debug
> builds on Linux64 was leading to incorrect results.
> 
> This updates the test to use RenderFrameSubmissionObserver to wait directly upon
> frame generation.
> 
> TEST=ThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad
> 
> Bug: 843921
> Change-Id: I71cd8acdc528a3b220c8ccbbbece585ed5cf03bd
> Reviewed-on: https://chromium-review.googlesource.com/1097216
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Jonathan Ross <jonross@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566807}

TBR=jonross@chromium.org,treib@chromium.org

Change-Id: If60f494b1a21aaec2ca84572b5734544ec7d786f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843921
Reviewed-on: https://chromium-review.googlesource.com/1099955Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566988}

Bug: 850777
Change-Id: I5dd656d55341ea5cc4db6fcbfcf9a0c196de98bd
Reviewed-on: https://chromium-review.googlesource.com/1098223Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566987}

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.

Bug: 840378
Change-Id: Ie5686493b7f57387c5bbf0086b92f80bfb216c05
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1050465Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566986}

The flakiness was caused by the rotation above the tested transform.
There were tiny errors when mapping back and forth the rotation.
Now change it to a translation. Also change |scale_transform| to a
real scale.

Re-enable it on Android.

Bug: 851417
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I01b81fd47bdc09f6aeee021c4c334d9f06be3413
Reviewed-on: https://chromium-review.googlesource.com/1099595Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566985}

R=amineer@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I853963ca2192f070cd0162a4fae1f43484d84126
Reviewed-on: https://chromium-review.googlesource.com/1099835Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566984}

Duplication of code coverage counters is bad, as the values grow exponentially,
which ends up with the counters being overflown when running large test suites
(e.g. browser_tests). Counter Overflow not only causes incorrect coverage to be
reported, but also affects the global coverage merge process, which leads to
flaky and lower than usual code coverage numbers to be reported.

This CL fixes two issues:

1) __llvm_profile_write_file(), which has been used until now, can duplicate
   code coverage counters when it is called twice or more times. Instead, we
   should call __llvm_profile_dump() which will not dump the same counters more
   than once.

2) even though __llvm_profile_dump() prevents us from possible duplications, it
   is not thread safe, as it is supposed to be called from atexit() handler.
   Since we have to call it ourselves from various places, and we already do
   call it from two different sites at least, we still can get duplicated code
   coverage counters. Thus, we have to ensure thread safety ourselves.

Bug: 851230
Change-Id: Ib3bebc8173a8be9b5622f2449da05afad77d0a11
Reviewed-on: https://chromium-review.googlesource.com/1099336
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566983}

The script pointed to the un-bundled Content Shell Framework, which is
not in the isolated inputs, rather than the Framework bundled in
Content Shell.app.

Bug: 850735
Change-Id: I873a94a0e1c6882704199d918d9f463d4a82a39b
Reviewed-on: https://chromium-review.googlesource.com/1099276Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566982}

This avoids allocating arbitrary large buffers, which could fail or cause
unnecessary fragmentation.

Bug: 844854
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib7f0f14628fdb26c7efad08c26aba77d4b20095c
Reviewed-on: https://chromium-review.googlesource.com/1096296Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566981}

This patch allows base/containers/adapters.h, that contains
base::Reversed(), in platform.

Also includes the use in ShapeResult, which often requires to
iterate in reversed order for RTL.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iebe6b99da81d554562ddbeac4e4421f51333fcfe
Reviewed-on: https://chromium-review.googlesource.com/1094849Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566980}

https://pdfium.googlesource.com/pdfium.git/+log/5f032995b3d7..4c48b107c6d1


git log 5f032995b3d7..4c48b107c6d1 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 npm@chromium.org Add FPDFText_LoadStandardFont to public API
2018-06-13 npm@chromium.org Remove CFX_FixedBufGrow from fx_apple_platform.cpp
2018-06-13 tsepez@chromium.org Guard some non-windows only code in cfx_font with ifdefs.
2018-06-13 tsepez@chromium.org Tidy FFLCommon()
2018-06-13 hnakashima@chromium.org Refactor GetOrCreateDefaultGraphics out of ProcessDefaultGraphics.


Created with:
  gclient setdep -r src/third_party/pdfium@4c48b107c6d1

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idf9656ee72b19b26012dbb0d0aeea9a1daebcbfc
Reviewed-on: https://chromium-review.googlesource.com/1099457Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566979}

Instead of caching the DIP scale at creation, query the scale from the
view.

Bug: 851634
Change-Id: Iaacec8f649fcb0da6aa01ec0859b29f8cf1281b3
Reviewed-on: https://chromium-review.googlesource.com/1099045Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566978}

The chromium.win Windows 10 testers use 'Windows-10-15063' as the
swarming os dimension, not 'Windows-10', as I did for the ASan bots.  It
seems that sbox_integration_tests fails on newer versions of Windows 10,
and some other tests might as well. For now, make sure these bots match
the main waterfall. For every test that this fixes, I'll file a
follow-up bug about that test not passing on recent versions of Windows.

TBR=thakis@chromium.org
BUG=844398

Change-Id: I959f2d19459c722e54da9dd09b5fc169e3b171fd
Reviewed-on: https://chromium-review.googlesource.com/1099567Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566977}

Smooth scrolling makes find-in-page to be artificially slow in
large test results.

find-in-page is very useful when trying to narrow down to a specific
test result in a large set. The smooth scroll is a non-critical UX
which impedes more important functionality.

Change-Id: Iec027eb4abe2ba7ec72b12b8eaabec85f0eeded0
Reviewed-on: https://chromium-review.googlesource.com/1099264Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566976}

This CL adds an empty body for all three observer functions. Upcoming
CLs only need to make use of some of the functions, so requiring that
observers implement all three functions is cumbersome.

Bug: 824568, 752273
Change-Id: I0e9d363afce71aa847ea8619a5e40b18f4a293b6
Reviewed-on: https://chromium-review.googlesource.com/1099678Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566975}

Adds SmbShareFinder which is a high-level class responsible for finding
available shares in a network. Functions are all NOTREACHED and will be
implemented in a future CL.

Bug: 757625
Change-Id: I88ba748df0dafa0a0a2a46d3500b4e057d59163b
Reviewed-on: https://chromium-review.googlesource.com/1089850
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566974}

BUG=848979

Change-Id: I13beb6efc1dbc86541b639661f2550b519982eca
Reviewed-on: https://chromium-review.googlesource.com/1099047Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566973}