GitLab

We're trying to kill off notifications, and this one's no
different.
Also, move the logic for notifying the location bar of
page actions being updated to ExtensionActionAPI.

BUG=406590

Review URL: https://codereview.chromium.org/496403003

Cr-Commit-Position: refs/heads/master@{#291920}

(Also convert the existing convenience constructor to a static factor function.)

This avoids everyone having to know about
LocalMessagePipeEndpoint/RemoteMessagePipeEndpoint.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/505863002

Cr-Commit-Position: refs/heads/master@{#291919}

This patch sets ppi@ as owner of histograms tracking the child process
launch time (important as this is a significant performance factor on
some platforms) and number of renderer processes kept around.

BUG=401821

Review URL: https://codereview.chromium.org/500403002

Cr-Commit-Position: refs/heads/master@{#291918}

Currently only available on android.
BUG=383630
NOTRY=true
R=cjhopman@chromium.org, isherman@chromium.org, nyquist@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/498403002

Cr-Commit-Position: refs/heads/master@{#291917}

Cr-Commit-Position: refs/heads/master@{#291916}

BUG=407292
R=oshima@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/503113002

Cr-Commit-Position: refs/heads/master@{#291915}

This patch should be reverted when it is fixed along with a unittest to
guard against regression.

BUG=402885
NOTRY=True
TBR=epenner@chromium.org

Review URL: https://codereview.chromium.org/504163003

Cr-Commit-Position: refs/heads/master@{#291914}

Revert of Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable. (patchset #1 of https://codereview.chromium.org/492623003/)

Reason for revert:
Causing huge amounts of flake even with retries, see these jobs that failed on the CQ.

Please don't renable without watching the trybots closely to make sure it's not causing a lot of failures: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming?numbuilds=200

http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5716
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5716
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5696
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5688
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5685
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5680
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5678
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5675
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5673
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5671
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5667
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5666
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5665
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5663
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5661
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5661
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5660
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5647
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5644
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5643
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5637
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5639

Original issue's description:
> Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable.
>
> This test was flaky because it modified system properties. Moving it to
> interactive_ui_tests should allow it the system control guarantees it
> needs to complete successfully.
>
> BUG=396344
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4d5d5d700a104f5e6bec47a8891fc5a54a4f242b

TBR=sky@chromium.org,calamity@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=396344

Review URL: https://codereview.chromium.org/504253002

Cr-Commit-Position: refs/heads/master@{#291913}

- Use UrlRequestContext.CreateRequest.
- Expect GIT revision in HttpUrlRequestFactoryTest.
- Prevent getAllHeaders from being removed by proguard.

BUG=390267

Review URL: https://codereview.chromium.org/500193002

Cr-Commit-Position: refs/heads/master@{#291912}

This makes the test pass.

BUG=none

Review URL: https://codereview.chromium.org/500223002

Cr-Commit-Position: refs/heads/master@{#291911}

- Moved RasterBuffer from ResourceProvider to its own file.
It's now the public interface used by raster tasks.
- Added Acquire/ReleaseSkCanvas() interface into
RasterBuffer.
- Bitmap conversion is now done in raster worker thread
through RasterBuffer interface.

BUG=None

Review URL: https://codereview.chromium.org/454843002

Cr-Commit-Position: refs/heads/master@{#291910}

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/503283002

Cr-Commit-Position: refs/heads/master@{#291909}

BUG=405784

Review URL: https://codereview.chromium.org/502103003

Cr-Commit-Position: refs/heads/master@{#291908}

Revert of Suppress an uninitialized value in KeyboardLayoutManager::SetChildBounds. (patchset #1 of https://codereview.chromium.org/502183003/)

Reason for revert:
https://codereview.chromium.org/480723006/ fixed this.

Original issue's description:
> Suppress an uninitialized value in KeyboardLayoutManager::SetChildBounds.
>
> BUG=407467
> TBR=bshe@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/1598e5ab15e3c24f6d17e2214e61185d1098c915

TBR=bshe@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407467

Review URL: https://codereview.chromium.org/506953002

Cr-Commit-Position: refs/heads/master@{#291907}

Creates CacheContext which the CacheStorage uses to keep track of
Cache metadata rather than sticking it in the ServiceWorkerCache where
it doesn't belong.  The CacheContext will be used in a downstream CL
to keep reference count information for each cache.

This CL also changes the CacheMap from an IDMap to a std::map with our own id counting.
This lets us change to int64 from int32 as well as helps the transition to reference counting the caches.

Some other upcoming CLs affecting CacheStorage:
* Reference count CacheContext so that the deletion of javascript objects can delete the ServiceWorkerCache
* Make the callbacks in ServiceWorkerCacheStorage unnamed functions that don't require weak pointers.
* Change the CacheID to int64.

BUG=392621

Review URL: https://codereview.chromium.org/503823002

Cr-Commit-Position: refs/heads/master@{#291906}

Revert of linux: Always use (64bit) gold for linking, even on 32bit. (patchset #3 of https://codereview.chromium.org/503873004/)

Reason for revert:
Tentatively reverting because it made the sizes bot grumpy (http://build.chromium.org/p/chromium/buildstatus?builder=Linux&number=52715)

Original issue's description:
> linux: Always use (64bit) gold for linking, even on 32bit.
>
> All 32bit bots now have 64bit kernels and can run 64bit gold. So always use
> that.  We already require running 64bit binaries for clang, and the official
> bots already used to do this for gold.  This makes linking on 32bit bots faster,
> and simplifies our configurations.
>
> BUG=396333
> TBR=brettw
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c7864673b16236a2ec3cd435bb11608cbb76c1b4

TBR=thestig@chromium.org,brettw@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=396333

Review URL: https://codereview.chromium.org/482173003

Cr-Commit-Position: refs/heads/master@{#291905}

All 32bit bots now have 64bit kernels and can run 64bit gold. So always use
that.  We already require running 64bit binaries for clang, and the official
bots already used to do this for gold.  This makes linking on 32bit bots faster,
and simplifies our configurations.

BUG=396333
TBR=brettw

Review URL: https://codereview.chromium.org/503873004

Cr-Commit-Position: refs/heads/master@{#291904}

together in crypto.gyp

"msvs_disabled_warnings" code definition present in two place in the same 'target_name': 'crypto'.

Review URL: https://codereview.chromium.org/492963004

Cr-Commit-Position: refs/heads/master@{#291903}

BUG=328847

Review URL: https://codereview.chromium.org/450643003

Cr-Commit-Position: refs/heads/master@{#291902}

Each Node no longer creates an aura::Window. Instead RootViewManager
creates a single aura::Window that is responsible for drawing the
entire scene. RootViewManager is told when to redraw certain
areas. When RootViewManager needs to paint is paints the whole
tree.

At some point RootViewManager won't creat an aura::Window at all,
instead it'll take to the surface manager and create the frame data
for the scene.

BUG=none
TEST=none
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/507563002

Cr-Commit-Position: refs/heads/master@{#291901}

I'll file separate bugs for the additional cleanup this enables.

BUG=332418

Review URL: https://codereview.chromium.org/458363002

Cr-Commit-Position: refs/heads/master@{#291900}

BUG=352290

Review URL: https://codereview.chromium.org/499383002

Cr-Commit-Position: refs/heads/master@{#291899}

BUG=407137

Review URL: https://codereview.chromium.org/503763002

Cr-Commit-Position: refs/heads/master@{#291898}

r1970 android: Support host multilib builds.
r1969 Makes analyzer output names of all executable target types
r1968 android: Make buildbot able to use a custom manifest.

BUG=

Review URL: https://codereview.chromium.org/502393002

Cr-Commit-Position: refs/heads/master@{#291897}

BUG=335086
TEST=Ensure new-profile-management and account-consistency are not
enabled. Then sign in a profile. Then enable new-profile-management.
The "lock" button of the avatar menu should be present but disabled.

Review URL: https://codereview.chromium.org/497783002

Cr-Commit-Position: refs/heads/master@{#291896}

Chrome OS doesn't treat value of "login-profile" as a name
for user's profile dir anymore, however ProfileManager used its
value to let some old tests keep working. After removal
"login-profile" from ProfileManager these tests were fixed.

The significant change is that
TestingProfileManager::CreateTestingProfile treats its
|profile_name| argument as an user's id on CrOS, and creates
profile with a correct path ("u-" +
user_id_hash(profile_name)). This makes testing environment
closer to real, so communication between ProfileManager <-->
chromeos::ProfileHelper <--> chromeos::UserManager works
without additional set up in tests.

BUG=294628
TEST=all browser_tests and unit_tests are passing

Review URL: https://codereview.chromium.org/442043002

Cr-Commit-Position: refs/heads/master@{#291895}

BUG=263848
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/506743002

Cr-Commit-Position: refs/heads/master@{#291894}

BUG=none
TEST=run browser_tests

Review URL: https://codereview.chromium.org/483673004

Cr-Commit-Position: refs/heads/master@{#291893}

List of users admitted for multi-profile should include user with NOT_ALLOWED_PRIMARY_POLICY_CERT_TAINTED

Value NOT_ALLOWED_PRIMARY_POLICY_CERT_TAINTED was not check in the list of know
problem when user cannot be added to the session. To avoid this types of errors
removed list complete because the only vale that checked separate NOT_ALLOWED_PRIMARY_USER_POLICY_FORBIDS.

BUG=406278
TEST=manual

Review URL: https://codereview.chromium.org/501963002

Cr-Commit-Position: refs/heads/master@{#291892}

The new class manages device states and dispatch device events property instead
of EventRouter, MountedDiskMonitor, and JavaScript side's DeviceHandler.

BUG=360946,396258

Review URL: https://codereview.chromium.org/490643005

Cr-Commit-Position: refs/heads/master@{#291891}

URL suggestion popup was not dismissing when page was navigating
in back direction. Added code to handle this.

BUG=407070

Review URL: https://codereview.chromium.org/500043002

Cr-Commit-Position: refs/heads/master@{#291890}

BUG=328847

Review URL: https://codereview.chromium.org/462563002

Cr-Commit-Position: refs/heads/master@{#291889}

Was trying to parse a Git commit hash as an int.

getos --check-version no longer compares exact revision numbers, only
major version numbers (because the Git hashes can't directly be
compared, unlike SVN numbers). Added a TODO to compare
Cr-Commit-Position when it becomes available.

BUG=406993

Review URL: https://codereview.chromium.org/502883002

Cr-Commit-Position: refs/heads/master@{#291888}

Added dataChannel.id text field to make it easier to test that Chrome/WebRTC reuses the dataChannel id on the same
peerConnection.

Feature added in issue:
https://code.google.com/p/webrtc/issues/detail?id=2646

BUG=NONE
TEST=Manual P2P call, dataChannel.id is only displayed when
dataChannel.readyState = 'open'.
NOTRY=TRUE

Review URL: https://codereview.chromium.org/405093004

Cr-Commit-Position: refs/heads/master@{#291887}

The requestAnimationFrame test which simulates a large jank in the
first rAF callback (raf.html?heavy_first_frame) was actually adding
the delay to every callback. This patch fixes the synthetic delay
to use the correct one-shot mode.

BUG=391005

Review URL: https://codereview.chromium.org/497173002

Cr-Commit-Position: refs/heads/master@{#291886}

Cleaning up weak_ptr_factory destruction order.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/479183002

Cr-Commit-Position: refs/heads/master@{#291885}

The purpose of the CL is to simplify DeviceSettingsProvider API, as Set() path should be moved out.

BUG=230018
TEST=none

Review URL: https://codereview.chromium.org/502993003

Cr-Commit-Position: refs/heads/master@{#291884}

BUG=405709

Review URL: https://codereview.chromium.org/495843003

Cr-Commit-Position: refs/heads/master@{#291883}

Before this patch, ServiceWorkerRegistration had a constant
script URL.
The spec has a different model: .installing, .waiting, and .active
workers for the same registration can be from different script URLs.

This patch removes script_url from SWRegistration, in preparation
for implementing the spec steps for same-scope, new-script-url
registration.

BUG=398355

Review URL: https://codereview.chromium.org/501453002

Cr-Commit-Position: refs/heads/master@{#291882}

Cr-Commit-Position: refs/heads/master@{#291881}