- 26 May, 2020 40 commits
-
-
Harley Li authored
Originally the condition check catches the case where 'sources' is absent in the invoking target, but doesn't catch the case where the list is empty. The comment given in the code says we need to ensure the list contains at least one source to avoid building an empty static lib. Change-Id: Iaafda906bf177d95d8908498b042f15c28cbd271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215581Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Harley Li <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772003}
-
Ender authored
This reverts commit 74affe26. Reason for revert: we're now ready to enable this feature by default. Original change's description: > Revert "Disable Instant Extended limit by default for Android." > > This reverts commit 3b71610c. > > Reason for revert: we will be doing staged rollout. this cl would go live may 19, which is too early. > > Original change's description: > > Disable Instant Extended limit by default for Android. > > > > This change effectively increases number of search results > > on Android devices from default (3). > > > > Bug: 964049 > > Change-Id: I46887f88e3f76801d24f7dfdf928397e6a3ae66f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132858 > > Reviewed-by: Tommy Li <tommycli@chromium.org> > > Commit-Queue: Ender <ender@google.com> > > Cr-Commit-Position: refs/heads/master@{#755543} > > TBR=tommycli@chromium.org,ender@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 964049 > Change-Id: I9102a3849018f366b98044921ae711eb8321bbb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176653 > Reviewed-by: Ender <ender@google.com> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Ender <ender@google.com> > Cr-Commit-Position: refs/heads/master@{#764863} TBR=tommycli@chromium.org,jdonnelly@chromium.org,ender@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 964049 Change-Id: I4d8bf3f3a879d7a040a37aa72bf7d2c82c9106e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216790Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#772002}
-
Sigurdur Asgeirsson authored
Bug: 1080672 Change-Id: I2e7bc7428ff0448844517862751ced5cc250d902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204438 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#772001}
-
Brian Sheedy authored
Shuffles around some GPU expectations that are expected to be permanent to target the GPU instead of the board. TBR=ynovikov@chromium.org Bug: 1080401, 1080408, 1080411, 1080360 Change-Id: Id89e1df197db93b8600c4dc10e45cc8447de5e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216631 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#772000}
-
Kurt Horimoto authored
This is required to test overlay functionality during a dismissal animation. Bug: 1065564 Change-Id: I39aac0fe2f21a45524300fce5cf8d4c6e2bbb2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213728 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#771999}
-
Kelvin Jiang authored
For one of the subtests, an xhr request which matches a rule was sent before the event listener for OnRuleMatchedDebug was registered. The fix involves waiting for a round trip between the extension and browser to complete after the listener has been added for the request to be sent, which prevents the race condition causing the flake. Bug: 1029233 Change-Id: I1e1c011159dfa9c463612b4f837ce9ce4316a234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209601Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771998}
-
Rune Lillesveen authored
We use a preferred color-scheme of light for screens. When we decided to not use dark for printing we chose no-preference, but content depends on color-scheme to either be light or dark since that is the case for screen media. This matches what both Firefox and Safari does. Bug: 1086441 Change-Id: I1b10c76068ca9cfebf0d991c342b15f99185698e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216770Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#771997}
-
Sasha McIntosh authored
In cases where a single character in a display name is non-printable, we use an empty string for the display name. This change instead replaces a non-printable char with a space. Added test case for a string with non-printable char. Note that the display_id is generated from the display name, so this is also updated in the test. Change-Id: I8092bf10bdf5c93b450a0bf84b18c5aaae157452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212701 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#771996}
-
Becca Hughes authored
Adds a fix so that Media History does not record background or muted watchtime since they are not useful to us (we only want foreground unmuted). BUG=1086511 Change-Id: I175c20ad88c136f291b72ae021b3cc22729bc5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216375 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771995}
-
John Abd-El-Malek authored
Currently they were using URLLoaderInterceptor to serve the data. In case of cors-exempt headers this doesn't go through the networking logic to merge them if that's allowed. This also brings the tests closer to production. Bug: 1085309 Change-Id: Idc09d2d0d398d98c8a1fcaacecfdeac40c9116e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216594Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#771994}
-
Akihiro Ota authored
options page. Bug: 1009897 Change-Id: I32a2cda728933bf4e4e5d475a7f6b84dfe7b312b AX-Relnotes: Add a link to the TTS settings page in the ChromeVox Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213888Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#771993}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af27e58ea40a..1a97f7367f83 2020-05-26 primiano@google.com Merge "Site: fix typo in home page" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iab4f44125ddd5ed0acf99948e5d01ad78de5be7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216614Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771992}
-
Sam Bowen authored
Bug: 1081515 Change-Id: Id60a43f4a9d3093992670676627a05baac258b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210795 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771991}
-
David Tseng authored
R=akihiroota@chromium.org AX-Relnotes: n/a Change-Id: I6c8fbed7b56365a55be0acd76fda586aee272c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212820Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771990}
-
Vladimir Levin authored
This patch changes the behavior of computed style z-index to comply with spec: it reports the value as specified instead of changing it to auto if the style does not induce a stacking context. Note that since z-index only applies on positioned elements, and grid and flex children, this patch introduces an EffectiveZIndex() which is set to 0 if the z-index does not apply. This is so that code relying on z-index will behave as it did before. However, ZIndex() now reflects the value that was specified. R=futhark@chromium.org, pdr@chromium.org Fixed: 1023232, 375982 Change-Id: Ib11467a9818b746c72bebbb167223f1bb41a5f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212391 Auto-Submit: vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771989}
-
Bo Liu authored
Some N bots are also causing failures from Activities not being destroyed, just more flakily than on L. Expand the check in LifetimeAssertRule to all versions. Bug: 1081250 Change-Id: I3d8330988b8aca47b66084d9bc43b82d0a53b240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216535Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771988}
-
Anders Hartvoll Ruud authored
Bug: 1085994 Change-Id: Ied0e00fa9e67850860ed0126269533396834b66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215814Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#771987}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b302be3..79156e7a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5034b3968ecdddfee6f04a194ba578bfbc5aecb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216730Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771986}
-
Ken Rockot authored
Implements a test for backward-compatibility between any two versions of a mojom enum definition. This will be used to enforce stability checks once a [Stable] attribute is introduced. Bug: 1070663 Change-Id: I84c3051337adeb10a8cef0eadd0708548215d0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212890Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#771985}
-
Oriol Brufau authored
GridTemplateAreas::ApplyInherit wasn't setting ImplicitNamedGridRowLines nor ImplicitNamedGridColumnLines inherited from the parent, so grid items referencing these lines were placed into the implicid grid. The patch also makes sure to set them in GridTemplateAreas::ApplyInitial and GridTemplateAreas::ApplyValue for a 'none' keyword. It seems these weren't causing noticeable problems, though. BUG=1085853 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-008.html Change-Id: If92e771d51450dea3f7fa12deaec6ce9dd7639d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214960Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#771984}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2be61a1df411..f203902ee8b7 2020-05-26 iannucci@chromium.org [lucicfg] Update to 1.14.3. 2020-05-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-05-26 vadimsh@chromium.org [luci-auth] Update to the latest version. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1015181,chromium:1082960 Tbr: agable@chromium.org Change-Id: I62037de04c61d66cedc22e52155a1cb0dce5aaa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771983}
-
Avi Drissman authored
If the clipboard contains data that has been marked by its originator as confidential, don't offer it for "Paste and Search" and don't offer it as a zero-prefix search suggestion. This directly wires into the iOS zero-prefix search code, and adds an expandable function to ui::Clipboard, implementing it for the Mac. If there is a convention for other platforms, it can be implemented via this mechanism. Bug: 1067542, 1084244, 1071828 Change-Id: I064a0629c35b686e14772cec123a3fc1eec5487c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213286Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771982}
-
Raphael Kubo da Costa authored
Its implementation is identical to that of Sensor::activated(), so stick to the latter. Change-Id: I598e889fa91ec8deca3ac2a16203e0343b5b9c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214386 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771981}
-
Mark Schillaci authored
This CL adds the indices of a user's text selection start and end positions to the AccessibilityNodeInfo object for that node on Android. Until now this information has only been conveyed through the ToIndex and FromIndex indices of AccessibilityRecord. As per ARC++ request, we will now communicate the indices in both the AccessibilityRecord and the AccessibilityNodeInfo object for the given node. This CL also cleans up some of the native code implementation of building the AccessibilityNodeInfo objects. We have refactored the code to no longer have KitKat specific methods since we have dropped support for that OS. Bug: 1059680 AX-Relnotes: N/A Change-Id: I3ce1629271e976a9ef323097ee0bf86233d44aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101306Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#771980}
-
Matt Mueller authored
This was used by NSS cert verifier OCSP requests (which are no longer a thing) and DNS over HTTPS requests (which now use the the same context as the request). Bug: 1044698 Change-Id: I3b5472f60d3fd0d2ba6037184718d3c030c43419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204678Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#771979}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/06266f79ede7..a33a68071b63 2020-05-26 herb@google.com generate vertex data in onPrepare 2020-05-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-05-26 key.draw@gmail.com [canvaskit] add a gm for testing all blendmodes 2020-05-26 fcz@google.com Remove FIDL C bindings usages 2020-05-26 reed@google.com Avoid malloc calls for these two temp arrays on the stack. 2020-05-26 nifong@google.com Clean up promises in example.html and extra.html 2020-05-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from da218e6af725 to 5404be4a2703 (1 revision) 2020-05-26 robertphillips@google.com [docs] Fix file path in blink.md 2020-05-26 reed@google.com use floats (and multiplies) for littleRound 2020-05-26 johnstiles@google.com Add 'strict_constraint_batch_no_red_allowed' GM image. 2020-05-26 michaelludwig@google.com Revert "Simplify GrRTC::clean APIs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:943852 Tbr: westont@google.com Change-Id: I9595526ace0b2806ff8009290a0c27bc789d14d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771978}
-
David Tseng authored
Mostly speculative to fix crash (enclosed in bug). Could not reproduce. From the stack, it looks like TtsHandler::HandlePreviewTtsVoice gets called. This results in sending an utterance, with TtsHandler as a delegate. TtsHandler never removes itself as a delegate, if the utterance is alive, but TtsHandler gets destroyed. Any calls to TtsUtterance::OnTtsEvent would deref a deallocated TtsHandler (uaf). It's not quite what occurs in the stack, but the above seems like an issue. R=katie@chromium.org Fixed: 1038277 Change-Id: Iffda2304c9d2f88f58af51accebf738bfbc39181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210004Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Auto-Submit: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771977}
-
Bo Liu authored
WebLayer forked ContentView for expediency, and now we are unforking it. Features that are added to ContentView in components: * support for using EventOffsetHandler with ContentView * ability to set and change WebContents later * setIsObscuredForAccessibility to disable accessibility Features kept in weblayer: * autofill Note also ContentView is now a FrameLayout, which does not matter to weblayer since weblayer does not add child views to ContentView anymore. Change-Id: I995aad7a3cd9c4a6d8f819d9fd9080548e14cd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213064Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771976}
-
Michael Chang authored
initWithSuiteName for NSUserDefaults should not use its own app bundle identifier. initWithSuiteName should use a suite that is distinct from the apps own main bundle identifier. Reference: https://developer.apple.com/documentation/foundation/nsuserdefaults/1409957-initwithsuitename?language=objc Bug: 1086669 Change-Id: Iea3316ac8c6752bab3fa0644fd18b7dbdd018390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213787 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#771975}
-
Olivier Li authored
Flakes were caused by a race between the first thread registering and the first iteration of loop in HangWatcher::Run(). Problem is fixed by always performing the Wait->Check->Possible Monitor cycle even if there are no registered threads. The only caveat is that this means a HangWatcher with zero registered threads will still wakeup on a heartbeat to attempt monitoring. This is never the case post-startup in practice. HangWatcher::Start() now has to be invoked manually so it can be done safely after invoking *ForTesting functions. Bug: 1078828, 1081654 Change-Id: I52f2ea6bb66e6e05b36c52dbc3d8108e756055ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196831Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Oliver Li <olivierli@google.com> Cr-Commit-Position: refs/heads/master@{#771974}
-
Abigail Klein authored
This reverts commit a1ac2a1a. Reason for revert: Broke aria-atomic=false (crbug.com/910669), which is the default behavior of live regions. This breakage is worse than the original bug this change was trying to fix. Original change's description: > A11y: Read entire live region with NVDA/Jaws > > This change forces NVDA/Jaws to read the entire live-region whenever it > is updated, regardless of whether the text is actually different. These > ATs perform synchronous, in-proc callbacks to get_newText, so the end > result is accomplished by forcing get_newText to return the entire text > chunk. > > This change has no effect on Narrator, which isn't hosted in-proc. > Narrator *does* listen for the LIVE_REGION_CHANGED message (via the > MSAA->UIA bridge), but it appears to be doing its own change-detection > internally to prevent repeated messages from being read. > > Bug: 863375 > Change-Id: I073f06c2b514cf3332f8cf141229130fe223d60e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817215 > Commit-Queue: Ian Prest <iapres@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#721159} TBR=aleventhal@chromium.org,iapres@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863375, 1067257, 910669 Change-Id: Ibba3689365066a231def41f195113a524ef65151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212965 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#771973}
-
Allen Bauer authored
Bug: 1044687 Change-Id: Ifa558915f308912e5bc49d147cbd8afa084e4e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213895Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#771972}
-
Hongbo Song authored
Steps: 1. From `cc` to `blink`: `cc//layer_tree_host_impl` =>`cc//proxy_impl` => `cc//proxy_main` => `cc//layer_tree_host` => `blink//layer_tree_view` 2. From `blink` to `content`: `blink//layer_tree_view` => `blink//widget_base` => `blink//web_frame_widget_base` => `content//render_frame_impl`. The next CL is for plumbing FSD from `content` to `page_load_metrics/observers/ukm_page_load_metrics_observer.cc` Change-Id: I572dc463ff9d3db36f5063746cc539f255a62d27 Bug: 922980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175117 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771971}
-
Wan-Teh Chang authored
Officially document the two special cases of gfx::ColorTransform::NewColorTransform(): the source color space is invalid, or the target color space is invalid. I discovered them while reading the source code, and found that they are enforced by unit tests. I am interested in relying on the second special case for YUV to RGB color conversion. So I'd like to document the special cases officially. Also some minor test cleanup. Tested: gfx_unittests --gtest_filter=SimpleColorSpace.ToUndefined Change-Id: Ie80948dc8bf1677d7f7fbd69e78790d3e45df76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211127Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#771970}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/adef79808a7d..b41316cd4c22 2020-05-26 philipp.hancke@googlemail.com test: fix typo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If67dc5c2defe2ff1ceb8592b56c118fb97fcb9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771969}
-
Henrique Ferreiro authored
This is a precursor CL needed before adding Mojo traits for WebDragOperation and WebDragOperationsMask, so that the new dependencies don't introduce cycles. Bug: 1039255 Change-Id: I7ab4fb9df4c509bde86570413a6a7174ef878616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213561Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#771968}
-
Scott Violet authored
This renames BottomControlsTest to BrowserControlsTest and adds the top-control ones. Given how finicky these are it seems best to conslidate them and share as much code as possible. BUG=1074438,1077825 TEST=test only changes Change-Id: I4f6544e93921688da78028e212c9ed3f530082b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216383Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771967}
-
Eugene Zemtsov authored
Ignore presentation feedbacks that don't have kHWCompletion or kVSync flags. Bug: 1042111 Change-Id: Ic0378f7e95050caa817973daf7248bd692ccd737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209643Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#771966}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590508570-56b410f167fcfdeb6392e467837742983549ce30.profdata to chrome-win64-master-1590522742-b76e1162c3da480ee6f6075020dc3e74b538d7b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie09b95c7fba0cc8c13615cd70f5b684f4a221fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771965}
-
David Benjamin authored
Bug: 1082304 Change-Id: Ie8acbf67b4304dc67f7c8883b2a418c383b046d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216596 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771964}
-