- 25 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/5abd252a0a26..3facafa44e2a 2020-11-25 wl@gnu.org .mailmap: Updated and sorted. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I276bc96f2affc540afe7a101dd8c7d44599c80f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#830972}
-
Pavol Marko authored
This reverts commit 2d0cae27. Reason for revert: The CL caused test failures on PDFExtensionTestWithParam.PdfAccessibilityTextRunCrash Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/10202 The test is only enabled with gn arg is_chrome_branded = true which explains why it got missed in CQ. (when reproing locally, I also ran into crbug.com/1152752 , so if you want to repro make sure to turn dchecks off :-D ) Original change's description: > Reload the PDF accessibility tree on layout changes > > Currently, any layout changes applied to the PDF document (i.e. page > rotation or two-up view) after the accessibility tree has loaded does > not update the page bounds. > > Because the accessiblity tree has read-only nodes, the only way to > resolve the issue is to reload all the nodes of the tree on each layout > change. > > Note: This CL only fixes page bounds and positions. The bounds of page > content such as text or annotations still do not rotate with the rest > of the document. Those issues will be fixed in a follow-up. > > Bug: 1150665 > Change-Id: I2fbf2cb26f38ee3fed076333c0b224a8ede7947e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553217 > Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> > Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830918} TBR=raymes@chromium.org,dmazzoni@chromium.org,tsepez@chromium.org,dhoss@chromium.org,ankk@microsoft.com Change-Id: I6c2946592cfcb496c6ed2cd3de6610e2d7c64902 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560263Reviewed-by:Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830971}
-
Silin Liu authored
Reuse Polymer tags used in other parts of the OOBE for consistency. Bug: b:172390062 Change-Id: I8e9e4d522104890fc29536e07989a728d8835bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534290 Commit-Queue: Silin Liu <silinliu@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#830970}
-
Ewann authored
This CL adds a method to UI Util to identify small devices. A device is considered as a small if its logical width is less than or equal to 375. Bug: 922511 Change-Id: I3308d770f2ef502a088743ede9e81dcd0cb698ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554997 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#830969}
-
Gauthier Ambard authored
This reverts commit 99a42e2d. Reason for revert: Potential culprit for crbug.com/1152712, reverting to check the bot. Original change's description: > [iOS][Thumb Strip] Keep BVC's position fixed when switching to Incognito > > Before, when switching to incognito using the Thumb Strip, the BVC ended > up having a frame.y = 36 (or some other non-zero constant). It looks > like the BVC is currently positioned by frame, and my guess is that > somehow, the position of some other element + constraints caused the > BVC's frame to change after it was set. However, the BVC's frame could > be set by constraint, as it should always be that value. > > Bug: 1094335 > Change-Id: Iedeedadf7ac7c7e842ebe4af02d8e62ed3b6a7c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549947 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830146} TBR=marq@chromium.org,rkgibson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1094335 Change-Id: I6fd0c59f79f9ac8bbc3cad70476ca3327b0c02e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560116Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#830968}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4ae6730677..5d8fc91922 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4ae6730677..5d8fc91922 Bug: None Change-Id: I1d6cc77b91278d72f4fb2686ee2818bb0f5bad67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560503 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#830967}
-
Liquan (Max) Gu authored
This CL moved shouldSkipShowingPaymentRequestUi() from PaymentUiService to PRService so that WebLayer and Chrome can share the logic. Bug: 1025619 Change-Id: If69054ad42b29541e5892998113c7174b0c45bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555560Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830966}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3cb4a09389a5..eaf49c6587ad 2020-11-25 yiorsi@gmail.com Add “Duplicate element” context menu in Element panel 2020-11-25 alexrudenko@chromium.org Fix issues in CSS Overview 2020-11-25 jacktfranklin@chromium.org [TS] CodeMirrorTextEditor.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1150797 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I51bcbb2d7ef022a59aedccde7252ac2b77c62a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560046Reviewed-by:
-
Yang Guo authored
Change-Id: Id4a2a9b4b20d6f6c243340159925474eacc5fe6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558404Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#830964}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/33f29ea9b251..a66263753a9f 2020-11-25 cwallez@chromium.org dawn_native: Make CreateView's descriptor default to nullptr 2020-11-25 cwallez@chromium.org Improve the dynamic binding OOB error message when binding.size is defaulted. 2020-11-25 cwallez@chromium.org Remove deprecated BindGroupLayout options. 2020-11-25 cwallez@chromium.org Remove deprecated SetIndexBuffer (without format). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ie24e21acbf1c840914b68c6fba5391e263aba35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560045Reviewed-by:
-
Danila Kuzmin authored
Sometimes there is no status area shown on the screen and we need to check it during tab traversal. Bug: 1008817 Change-Id: If6099f8c020818de62a3bc2bccbe07f077817d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551120Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#830962}
-
Alexander Bolodurin authored
Move ResolveToContentUrlOn{IO,UI}Thread into a separate utils file and reuse in both ArcDocumentsProviderStream{Reader,Writer}. Change-Id: I40dd5f345dee50db1d4e9d605175f78920adef67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535965 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#830961}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d894cbc80206..dd56c5490710 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmarko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmarko@google.com Change-Id: Ieb8221c4d9162e855c275d4aa2decc579f0fb833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560041Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830960}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0536e3a35b34b5a3f3733acf8a68b11666a8690e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560395Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830959}
-
Yunke Zhou authored
Bug: 1145679 Change-Id: If4128d19c6bc6fe9b4c3960a22a521997d9c2d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558792Reviewed-by:
-
Eric Seckler authored
Currently, the spinner used in feed will only stop() its animation if the spinner view itself is hidden through setVisibility(). However, in reality, one of its ancestor views is hidden instead. This causes a continuous invisible animation to tick at the display's refresh rate (usually 60fps) if the spinner was ever shown, until it is destroyed (when the NTP views are eventually evicted). Instead, stop the animation also when any of the spinner's ancestors become hidden by listening for visibility changes and window attachment state changes. Bug: 1151391 Change-Id: Ib7b7a8e56f083619420fd58f4340991253402535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552781Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#830957}
-
Jit Yao Yap authored
Change-Id: I96738f9f9f70d56f8527a57358114078610b3284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560115 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#830956}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8820ab859bea..a3762a907c02 2020-11-25 tandrii@google.com git cl comments: shorten long URLs if possible. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I617a151365206610d6e5f4f64a5f7483c7f08982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560042Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55a2b8681802..3cb4a09389a5 2020-11-25 kahinds@microsoft.com [Loc] Avoid module-instantiation-time calls that rely on `i18n` locales 2020-11-25 kahinds@microsoft.com [Loc] Migrate performance_monitor to Localization V2 2020-11-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I103afc5ac5489b7d776b881e7a38015c63060411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560036Reviewed-by:
-
Fredrik Söderqvist authored
This moves all the mutation of the underlying document into SVGImage::PaintRecordForCurrentFrame, making the single point where container/viewport size is set. The rounded container size is now passed via DrawInfo which allows eliminating the round-tripping of the container size via the LayoutSVGRoot. This now also means that all the rounded sizes are easily visible in one spot. This also makes painting directly via SVGImage (which should be very rare) deterministic by (re)setting the "intrinsic size" just as when painting via SVGImageForContainer. Also move the null-check of |SVGImage::page_| into PaintRecordForCurrentFrame. This should be a rare enough occurrence that it isn't worth having as an early-out - and the first access to the underlying Page/Document is now in said method. Rename the |src_rect| argument to SVGImage::DrawInternal to |unzoomed_src_rect| to reflect that it should no longer contain any zoom from a container. Bug: 1070583, 1123047 Change-Id: I0c950f5474fac957c53b908c1405736ec9d09393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555079Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#830953}
-
Ramin Halavati authored
Updates a comment on why request is not handled when browser cannot be initialized. Bug: 1141608 Change-Id: If6e79905e7242902bebe3b1918c15a9b913bf27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560502Reviewed-by:
-
Koji Ishii authored
These are changed to `status: "stable"` in `runtime_enabled_features.json5`, but `base:Feature`s were not updated. This patch changes them to `FEATURE_ENABLED_BY_DEFAULT`. Bug: 707656, 982194 Change-Id: I026a6b7f4b13390ce9fe4f5d2afe4d0c820d4580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560075Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#830951}
-
Daniel Cheng authored
At this point, only there is only one test that passes a value other than blink::mojom::CommitResult::Aborted into this helper. Refactor the test to use a regular navigation + CommitCallbackInterceptor instead, and inline the abort logic in OnCrossDocumentCommitProcessed() directly into RFHI::NavigationRequestCancelled(). Bug: 1020175 Change-Id: I5fcfe69020625b4dd40a0846f1c00a73573ac3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537597 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#830950}
-
Aya ElAttar authored
- Refactored DataTransferDlpController:: IsDataReadAllowed so it'd be easier to identify which types are supported and which aren't. - ClipboardHistory endpoint should have given a privilege access as a destination but it was handled as source instead by mistake. - Allowed data of any source to be read except URLs given that it's the only type supported now as a source. - Disabled notification for Files app. Bug: 1139835, 1136656 Change-Id: If10d3962e9f2ac7cc4353f4d133b043ad05abbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556639Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#830949}
-
Gauthier Ambard authored
Those tests are failing on ios. TBR: mahmadi@chromium.org Bug: 1151909 Change-Id: I14352880508aebb0a2b4ace675d45c7f6e61e52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560096 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830948}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/130597e10299..7c0b4a32c773 2020-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 013c962f to 4b04564d (410 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: Id4bd5ac9477736f0f3e46fce80313b6d5ed92271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559922Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606251063-26a76a6b25625f68800c8ab3d3043b315be73544.profdata to chrome-win64-master-1606262372-c93aa4463db3b18479db12ddf45a2403c2ea87d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I513c4e5d93b1893276af908d0aba52e0b7824524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559045Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bafeede2b523..8d87e6d1de73 2020-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 10f56916..8f4e430a (830729:830890) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie4f71c1f6fdc60846b65c33aa6ca4dc6726ea340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560039Reviewed-by:
-
Jiahe Zhang authored
On ChromeOS, PowerMonitorDeviceSource::GetCurrentThermalState will always return PowerObserver::DeviceThermalState::kUnknown now, because PowerManagerClientImpl will miss the first thermal event sent by the Thermal Hinting API when constructed and there isn't a cache of the last state. In this CL, the GetCurrentThermalState is implemented for ChromeOS using GetThermalState API added by https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2495080 BUG=chromium:1081959 TEST=Manually test in chrome://device-log to see if there's "GetThermalState" response after startup. Change-Id: I9bbf5416b0ba76a015a08d2d4c91ea732704a541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498240 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830944}
-
Illia Klimov authored
This reverts commit 27e577ee. Reason for revert: As part of the Flash deprecation, this logic is no longer needed. Original change's description: > Display discarded patterns in settings > > Discarded or ignored patterns will be displayed in the site settings page with a strike through > > Bug: 1073883 > Change-Id: If4229555acfac5fb0ed454161aec8db60f772368 > TBR: dpapad@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232370 > Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782554} TBR=finnur@chromium.org,engedy@chromium.org,dpapad@chromium.org,sauski@google.com,ravjit@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140428 Change-Id: I1d41f82290669887c64d897a89fb3301c3503e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497160Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Illia Klimov <elklm@chromium.org> Cr-Commit-Position: refs/heads/master@{#830943}
-
Guido Urdaneta authored
This CL adds a new feature flag that allows controlling how max frame rates are enforced for MediaStreamTracks. With the flag disabled (default), enforcement relies on system configuration. With the flag enabled, enforcement relies on frame-rate adjustments by the track. Bug: 1152307 Change-Id: Idd158aa17a9c03215b59c68b89c8a0e74a7a2ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557497Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1bcd6ec94d1..d894cbc80206 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmarko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmarko@google.com Change-Id: I864d9aa93b48177329385dc51428f9340c094fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559975Reviewed-by:
-
Daniel Hosseinian authored
Because the <viewer-pdf-toolbar-new> element has a hardcoded height equal to its #toolbar child element, the PDF content does not get resized around the extended toolbar that contains the <viewer-annotations-bar> when annotation mode is toggled on. Remove that height, and let the size of <viewer-pdf-toolbar-new> be determined by its child elements. Bug: 1152605 Change-Id: I4f58640bc1a3f8eb210785217f80ac9b71848247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559553 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL adds a metric when user has completed the account addition flow triggered from the web sign-in bottom sheet. Bug: 1152454 Change-Id: I4c1645d98c3df26893d24f1f721d15a30b8f58db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557635 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#830939}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I7745b2c9de52183da785901cd278a844fb139f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539258 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#830938}
-
Pavol Marko authored
The test is flaky on this builder, see ${BUG}. TBR=jarhar@chromium.org Bug: 1152088 Change-Id: I4e2178655685994a20a258321703e362530914ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560295Reviewed-by: -
Daniel Cheng authored
This eliminates the need to crack a mojo::Receiver/mojo::Remote into a message pipe and a handle to convert between Blink and non-Blink variants. This CL also includes a cleanup pass for the remaining uses of PassPipe() and PassHandle(), migrating them to either std::move() directly if possible, or use the new ToCrossVariantMojoType helper if applicable. Bug: 1059157 Change-Id: Id389d69ba32c17ce76942f16ca2b5b4fd26aab18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556565 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#830936}
-
Markus Handell authored
This change adds a default-on flag controlling the coercion of REC709 to SRGB added in crrev/c/2550554. Bug: 1151957, b:173124811 Change-Id: I39d91c2cd5fc047e8a67c649a862753fe8daa47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556962 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#830935}
-
Morten Stenshorne authored
There's some special logic for handling inert (that's INERT, not INNER) nodes. Fixes the following tests when LayoutNGFullPositionForPoint is enabled: external/wpt/inert/inert-inlines.tentative.html fast/dom/inert/inert-inlines.html Bug: 1150362 Change-Id: I8ce278168555b1f4b53b6a5abf121637f4bd58bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554557 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes EditingNG to stable from experimental for releasing on M89. Bug: 707656 Change-Id: I1af3e5d9b0d0b7e5b2bc5a434936ed0eb927bd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557944 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
