GitLab

These tests currently crash.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/637953009

Cr-Commit-Position: refs/heads/master@{#300328}

BUG=399090

Review URL: https://codereview.chromium.org/661653002

Cr-Commit-Position: refs/heads/master@{#300327}

Note: This change is a prerequisite for an upcoming change that will add
extensive interactive UI testing around Flash fullscreen, including the
Fullscreen-Within-Tab UI.

For all interactive_ui_tests, the UI widget being referenced by
VIEW_ID_TAB_CONTAINER was wrong whenever Flash fullscreen mode was
engaged.  This change tags the correct NSView with the identifier, and
gives it some simple focus-passing behavior, similar to
ui::views::WebView, to ensure that tests checking focus and/or
simulating a click on the tab container get the desired behavior.

Because the code changes to TabContentsContainerView are pretty much the
same, this change also addresses bug 421728, which makes clicking in the
"gray area" during Fullscreen-Within-Tab mode a request to give the tab
contents the focus.

BUG=403641,421728

Review URL: https://codereview.chromium.org/642143004

Cr-Commit-Position: refs/heads/master@{#300326}

NOTRY=true

Review URL: https://codereview.chromium.org/663823004

Cr-Commit-Position: refs/heads/master@{#300325}

In r298580, I added a bug where jumps to the very beginning of the data (bit
offset zero) would be rejected. This was found by fuzzing.

BUG=none

Review URL: https://codereview.chromium.org/663903002

Cr-Commit-Position: refs/heads/master@{#300324}

When the number of font files exceeds 1750, we fallback to this list.
Include Verdana, Georgia, and Trebuchet MS in this list until font
loading is properly fixed.

R=shrikant@chromium.org,ananta@chromium.org
BUG=421305

Review URL: https://codereview.chromium.org/668743002

Cr-Commit-Position: refs/heads/master@{#300323}

This is a reland of https://codereview.chromium.org/659533002/

Previous CL broke telemetry unittests and perf unittests because it
didn't handle properly shell commands which may end with a newline
character when check_rc is not None.

This revised patch strips any whitespace at the end of shell commands
to prevent this.

BUG=267773

Review URL: https://codereview.chromium.org/669573003

Cr-Commit-Position: refs/heads/master@{#300322}

I stumbled on this while working on the dff change.  It looks
like the only place this function is used is in the test.

I removed the test as well, since its only purpose was to check
that calling leak would indeed leak.

Review URL: https://codereview.chromium.org/652583002

Cr-Commit-Position: refs/heads/master@{#300321}

At that occasion, make it owned by rvargas@.

BUG=none

Review URL: https://codereview.chromium.org/662273003

Cr-Commit-Position: refs/heads/master@{#300320}

We will be using that function.

BUG=424244

Review URL: https://codereview.chromium.org/669753002

Cr-Commit-Position: refs/heads/master@{#300319}

changes to disk every 500ms instead of 5secs. We are hoping if QUIC is
used as an alternate protocol, we will persist that information to disk
quicker. Hopefully, this would improve the QUIC winning the alternate
protocol race.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/667473003

Cr-Commit-Position: refs/heads/master@{#300318}

The old way involved start-up code reading a value and setting a global
in template_url_prepopulate_data. Since the value can be computed
on-demand from device-information, just fetch it as needed instead.

BUG=169106
TBR=thakis

Review URL: https://codereview.chromium.org/628263004

Cr-Commit-Position: refs/heads/master@{#300317}

When it retried uploads using Channels, it would restart the upload with
data from the middle of the file, since Channels can't be rewound.  It
now just fails those requests instead.

Also, it was impossible to set the method for uploads - the default
value (POST) would overwrite any method set by the embedder.

Adds a new set of upload tests using the embedded test server, as
uploads were basically untested before.  Chunked uploads are still not
being tested, as the test server doesn't support them yet.

BUG=424712

Review URL: https://codereview.chromium.org/640593004

Cr-Commit-Position: refs/heads/master@{#300316}

Review URL: https://codereview.chromium.org/660493002

Cr-Commit-Position: refs/heads/master@{#300315}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7541f2d..83506e0

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/667003002

Cr-Commit-Position: refs/heads/master@{#300314}

It was previously failing with EISDIR. This is because
utime() internally acquires the node as O_WRONLY in
order to call the Futimens method.  This was failing
because the check for opening a directory for write
was done in Open() rather than CanOpen().

Review URL: https://codereview.chromium.org/660353003

Cr-Commit-Position: refs/heads/master@{#300313}

In Yosemite, the owner of a nib file is retain/autoreleased during the
initialization of the nib. I wrapped the constructor of the
BookmarkBarController in an @autoreleasepool block to allow the test to control
the destruction timing of the BookmarkBarController.

BUG=390276

Review URL: https://codereview.chromium.org/660063004

Cr-Commit-Position: refs/heads/master@{#300312}

This might-maybe-hope-not crash, and so has debugging statements.

BUG=407376
TEST=no crashing, we hope
TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/669613005

Cr-Commit-Position: refs/heads/master@{#300311}

Recently class was refactored https://codereview.chromium.org/651253002 ,
and there was an unexpected functional change.

BUG=424816

Review URL: https://codereview.chromium.org/669443002

Cr-Commit-Position: refs/heads/master@{#300310}

This makes some sense, since as we potentially output more and more files
(instead of a single results.html), we want to store them all in the same
location.

SHERIFFS: If error "This flag is deprecated. Please use --output-dir instead."
arises, this patch can be safely reverted.

Original discussion at https://codereview.chromium.org/616063004/

BUG=

Review URL: https://codereview.chromium.org/651383002

Cr-Commit-Position: refs/heads/master@{#300309}

Servers do not reliably send close_notify. This regressed in
https://codereview.chromium.org/367963007 which had a side effect of making us
sensitive to this.

BUG=422246

Review URL: https://codereview.chromium.org/655813003

Cr-Commit-Position: refs/heads/master@{#300308}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a71aee6..33e6466

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/667013002

Cr-Commit-Position: refs/heads/master@{#300307}

Also move some extension headers to ENABLE_EXTENSIONS sections.

BUG=424746

Review URL: https://codereview.chromium.org/662783002

Cr-Commit-Position: refs/heads/master@{#300306}

Settings overlays are generally cancel/OK, donottrack was OK/cancel.

BUG=425141
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/665113003

Cr-Commit-Position: refs/heads/master@{#300305}

Navigation transitions (web to native app): Get names and rects of transition elements (Chrome side)

Web to native app navigation transition uses Activity Transitions APIs in Android L. It requires the names and rects of transition elements. This CL gets the names and rects and pass them to TransitionRequestManager.

This is the Chrome side of the CL. Blink side will be done after this CL is landed. https://codereview.chromium.org/654953002/

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit#
Demo video: https://drive.google.com/a/google.com/file/d/0B3hetueIc91Gd01DU25uT2hWU2M/view?usp=sharing
Activity Transitions in Android L: https://developer.android.com/preview/material/animations.html#transitions

BUG=370696

Review URL: https://codereview.chromium.org/652283002

Cr-Commit-Position: refs/heads/master@{#300304}

This was the 2nd breaking mistake in that one CL. Note: oth mistakes were not caught by unit tests or by running a bisect try job once before submitting.

BUG=425173

Review URL: https://codereview.chromium.org/662403003

Cr-Commit-Position: refs/heads/master@{#300303}

BUG=397984

Review URL: https://codereview.chromium.org/658973003

Cr-Commit-Position: refs/heads/master@{#300302}

This depends on https://codereview.chromium.org/662763002/

BUG=424750

Review URL: https://codereview.chromium.org/651773003

Cr-Commit-Position: refs/heads/master@{#300301}

This cleans up the the interface to BrowserCompositorViewMac to
prepare for moving it closer to ui::views.

BUG=424058

Review URL: https://codereview.chromium.org/638123003

Cr-Commit-Position: refs/heads/master@{#300300}

BUG=424973
TEST=chromeos=1 compile,
TEST=out_chromeos/Debug/sandbox_linux_unittests --gtest_filter=*SIGSYS_InvalidSyscall*
...
0 tests run

R=mdempsky@chromium.org

Review URL: https://codereview.chromium.org/646853005

Cr-Commit-Position: refs/heads/master@{#300299}

BUG=224786

Review URL: https://codereview.chromium.org/611383004

Cr-Commit-Position: refs/heads/master@{#300298}

BVR::DidDestroyCompositor can be called at any point, which resets
the compositor pointer. Which means each use of the pointer
should be checked or DCHECKed. In particular, DidDestroyCompositor
can happen before tearing down hardware mode.

This can happen when javascript calls window.close, which closes the
RenderView before WebContents.

BUG=424614

Review URL: https://codereview.chromium.org/654623002

Cr-Commit-Position: refs/heads/master@{#300297}

This is a preparation for media code to call into content code to create the CDMs, so that we could have EME support without depending on content code.

BUG=422730

Review URL: https://codereview.chromium.org/660673002

Cr-Commit-Position: refs/heads/master@{#300296}

New tests:
- Added new ChromeProxyExplicitBypass integration tests that test "bypass=0", "bypass=<X>", "block=0", and "block=<X>" Chrome-Proxy directives using the test server
- Added new ChromeProxyFallback integration test that gets a "bypass=0" directive from the real data reduction proxy

Cleanup:
- Rewrote the VerifyBadProxies logic, adding support for per-proxy retry times
- Also changed VerifyBadProxies to raise an exception instead of returning false when the actual and expected bad proxy lists were different, which was causing all the existing bypass tests to pass in cases when they should have failed
- Fixed typo in ChromeProxyCorsBypass test, it passes now
- Some general python style cleanup

BUG=374397

Review URL: https://codereview.chromium.org/659333004

Cr-Commit-Position: refs/heads/master@{#300295}

Revert of Temporarily suppress Android API deprecation warnings. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/615163002/)

Reason for revert:
We have switched to L sdk.

Original issue's description:
> Temporarily suppress Android API deprecation warnings.
>
> We will remove this suppression once all of the builders support the L SDK.
>
> BUG=405174,398669,411361,411366,411367,411376,416041
>
> Committed: https://crrev.com/c26c106e7724c400fed9980ce371a1c81d1af849
> Cr-Commit-Position: refs/heads/master@{#297505}

TBR=dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405174,398669,411361,411366,411367,411376,416041

Review URL: https://codereview.chromium.org/649653004

Cr-Commit-Position: refs/heads/master@{#300294}

Revert of Roll src/third_party/skia a71aee6:958e962 (patchset #1 id:1 of https://codereview.chromium.org/663133002/)

Reason for revert:
Broke all Mac GPU debug bots.

0   libbase.dylib                       0x0cc6b4bf base::debug::StackTrace::StackTrace() + 63
1   libbase.dylib                       0x0cc6b51b base::debug::StackTrace::StackTrace() + 43
2   libbase.dylib                       0x0cd197b2 logging::LogMessage::~LogMessage() + 82
3   libbase.dylib                       0x0cd1852b logging::LogMessage::~LogMessage() + 43
4   libskia.dylib                       0x24256d1b SkDebugf_FileLine(char const*, int, bool, char const*, ...) + 283
5   libskia.dylib                       0x24069f85 Sk4x<float>::store(float*) const + 213
6   libskia.dylib                       0x24068ea0 SkTileGrid::intersectsGrid(Sk4x<float> const&) const + 64
7   libskia.dylib                       0x24069099 SkTileGrid::insert(unsigned int, SkRect const&, bool) + 425
8   libskia.dylib                       0x23fe75a1 SkRecords::FillBounds::FillBounds(SkRecord const&, SkBBoxHierarchy*) + 753
9   libskia.dylib                       0x23fe42d7 SkRecords::FillBounds::FillBounds(SkRecord const&, SkBBoxHierarchy*) + 71
10  libskia.dylib                       0x23fe3ad1 SkRecordFillBounds(SkRecord const&, SkBBoxHierarchy*) + 65
11  libskia.dylib                       0x23faeb86 SkPicture::SkPicture(float, float, SkRecord*, SkBBoxHierarchy*) + 390
12  libskia.dylib                       0x23fadcc1 SkPicture::SkPicture(float, float, SkRecord*, SkBBoxHierarchy*) + 113
13  libskia.dylib                       0x23fd4d12 SkPictureRecorder::endRecording() + 162
14  libcc.dylib                         0x22402cbc cc::Picture::Record(cc::ContentLayerClient*, SkTileGridFactory::TileGridInfo const&, cc::Picture::RecordingMode) + 2188
15  libcc.dylib                         0x2240235e cc::Picture::Create(gfx::Rect const&, cc::ContentLayerClient*, SkTileGridFactory::TileGridInfo const&, bool, cc::Picture::RecordingMode) + 174
16  libcc.dylib                         0x2242bc3f cc::PicturePile::UpdateAndExpandInvalidation(cc::ContentLayerClient*, cc::Region*, unsigned int, bool, bool, gfx::Size const&, gfx::Rect const&, int, cc::Picture::RecordingMode, cc::RenderingStatsInstrumentation*) + 7391
17  libcc.dylib                         0x222e101f cc::PictureLayer::Update(cc::ResourceUpdateQueue*, cc::OcclusionTracker<cc::Layer> const*) + 1887
18  libcc.dylib                         0x22556174 cc::LayerTreeHost::PaintLayerContents(cc::RenderSurfaceLayerList const&, cc::ResourceUpdateQueue*, bool*, bool*) + 820
19  libcc.dylib                         0x225556c9 cc::LayerTreeHost::UpdateLayers(cc::Layer*, cc::ResourceUpdateQueue*) + 2665
20  libcc.dylib                         0x22554bc8 cc::LayerTreeHost::UpdateLayers(cc::ResourceUpdateQueue*) + 648
21  libcc.dylib                         0x225fce07 cc::ThreadProxy::BeginMainFrame(scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >) + 2919
22  libcc.dylib                         0x2260e923 base::internal::RunnableAdapter<void (cc::ThreadProxy::*)(scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >)>::Run(cc::ThreadProxy*, scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >) + 179
23  libcc.dylib                         0x2260e7c7 base::internal::InvokeHelper<true, void, base::internal::RunnableAdapter<void (cc::ThreadProxy::*)(scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >)>, void (base::WeakPtr<cc::ThreadProxy> const&, scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >)>::MakeItSo(base::internal::RunnableAdapter<void (cc::ThreadProxy::*)(scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >)>, base::WeakPtr<cc::ThreadProxy> const&, scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >) + 151
24  libcc.dylib                         0x2260e607 base::internal::Invoker<2, base::internal::BindState<base::internal::RunnableAdapter<void (cc::ThreadProxy::*)(scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >)>, void (cc::ThreadProxy*, scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >), void (base::WeakPtr<cc::ThreadProxy>, base::internal::PassedWrapper<scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> > >)>, void (cc::ThreadProxy*, scoped_ptr<cc::ThreadProxy::BeginMainFrameAndCommitState, base::DefaultDeleter<cc::ThreadProxy::BeginMainFrameAndCommitState> >)>::Run(base::internal::BindStateBase*) + 215
25  libbase.dylib                       0x0cc5474f base::Callback<void ()>::Run() const + 63
26  libbase.dylib                       0x0cc6d9bc base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) + 1084
27  libbase.dylib                       0x0cd5a999 base::MessageLoop::RunTask(base::PendingTask const&) + 793
28  libbase.dylib                       0x0cd5ab42 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) + 98
29  libbase.dylib                       0x0cd5ae11 base::MessageLoop::DoWork() + 321
30  libbase.dylib                       0x0cc2c715 base::MessagePumpCFRunLoopBase::RunWork() + 101
31  libbase.dylib                       0x0cc2bb31 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 49
32  CoreFoundation                      0x9bbd3b5f __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 15
33  CoreFoundation                      0x9bbc495b __CFRunLoopDoSources0 + 235
34  CoreFoundation                      0x9bbc405e __CFRunLoopRun + 1022
35  CoreFoundation                      0x9bbc39ea CFRunLoopRunSpecific + 394
36  CoreFoundation                      0x9bbc384b CFRunLoopRunInMode + 123
37  Foundation                          0x902b85b9 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
38  libbase.dylib                       0x0cc2d242 base::MessagePumpNSRunLoop::DoRun(base::MessagePump::Delegate*) + 162
39  libbase.dylib                       0x0cc2c328 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 104
40  libbase.dylib                       0x0cd5a30c base::MessageLoop::RunHandler() + 300
41  libbase.dylib                       0x0cdcc5f3 base::RunLoop::Run() + 83
42  libbase.dylib                       0x0cd59617 base::MessageLoop::Run() + 55
43  libcontent.dylib                    0x1d021a35 content::RendererMain(content::MainFunctionParams const&) + 1925
44  libcontent.dylib                    0x1b9782ac content::RunNamedProcessTypeMain(std::string const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 268
45  libcontent.dylib                    0x1b97999b content::ContentMainRunnerImpl::Run() + 779
46  libcontent.dylib                    0x1b977745 content::ContentMain(content::ContentMainParams const&) + 133
47  libchrome_main_dll.dylib            0x0004155c ChromeMain + 92
48  Chromium Helper                     0x00038f7b main + 43
49  Chromium Helper                     0x00038f45 start + 53

Original issue's description:
> Roll src/third_party/skia a71aee6:958e962
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/a71aee6..958e962
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
> TBR=mtklein@google.com
>
> Committed: https://crrev.com/fbf0dae317434cf09510db0da0e5b9126b5dfa9b
> Cr-Commit-Position: refs/heads/master@{#300273}

TBR=mtklein@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/669743002

Cr-Commit-Position: refs/heads/master@{#300293}

As a part of migrating away from NSS, CrOS is going to start
generating the device Owner keypair using Chaps, which is
exposed to the browser via the TPM-backed PK11 token that gets
loaded into each user's private NSS PK11 slot. To support the
current mode of operation as well as the new, make
OwnerSettingsServiceChromeOS check both slots for the key.

BUG=422036
TEST=unit test, ownership autotests
R=stevenjb

Review URL: https://codereview.chromium.org/660343002

Cr-Commit-Position: refs/heads/master@{#300292}

Review URL: https://codereview.chromium.org/667483003

Cr-Commit-Position: refs/heads/master@{#300291}

nacl_helper_nonsfi is actually NOT the untrusted code, but this is built by
the PNaCl toolchain, which is native_client untrusted toolchain in the
context of common.gypi. In order to keep the other _nacl.gyp files simple,
this CL adds disable_nacl_untrusted==0 guard to the nacl_helper_nonsfi
creating condition, so that it does not cause the gyp error due to depending
on missing targets when disable_nacl_untrusted is set to 1.

BUG=358465
TEST=Ran trybots.

Review URL: https://codereview.chromium.org/664153002

Cr-Commit-Position: refs/heads/master@{#300290}

BUG=423699, 390618

Review URL: https://codereview.chromium.org/643923004

Cr-Commit-Position: refs/heads/master@{#300289}