GitLab

We were posting display rAF for magic window when there was no reason
to, which was making comparing window rAF and display rAF performance
difficult. This CL fixes that, and adds a test to make sure display
rAF is equivalent to window rAF in terms of scheduling.

This exposes the same race in getFrameData_oneframeupdate.html that was
found in WebVrTabTest#testPoseDataUnfocusedTab, namely that the pose
can start off being null, racily. The previous behavior of posting the
vrDisplay rAF was hiding this.

Bug: 734747, 734208, 787196
Change-Id: Ib6b657b1966359683b3c7aca16be26be9c3c54dd
Reviewed-on: https://chromium-review.googlesource.com/788240
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519501}

This probably "regressed" in r503368, which fixed a use case for
accelerator handling. But that meant that accelerator handling happened
before Textfield::OnKeyEvent() handling, resulting in a stray edit
command because Textfield::AcceleratorPressed() doesn't clear it.
However, Textfield::AcceleratorPressed() doesn't do the right thing on
Mac anyway.

On Mac, these always dispatch via the responder chain and the `Edit`
menu in the main menu bar. This ensures they obey custom key mappings
that a user may have set up in System Preferences via string matching
on the specific menu items.

Bug: 773565
Change-Id: Ic09db94866b6bd37791517505b24211c6c1105c4
Reviewed-on: https://chromium-review.googlesource.com/788632
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519500}

Fixes the issue of CCT/WAA NFC tests getting stuck in the DOFF flow.
This was somehow caused by the webpage listening for vrdisplayactivate,
but not actually presenting with it.

Also adds a sleep at the end of the test to prevent a possible race
condition with VrCore's 2 second NFC debounce timeout.

Bug: 787878
Change-Id: Ic5f16258cfa94ce3fac63781c1e225b8b2749f4e
Reviewed-on: https://chromium-review.googlesource.com/791938
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519499}

Records the time since last main frame navigation when a renderer OOM is
detected. On Android record only foreground OOMs.

BUG=736892

Change-Id: I71424844a7bfc9528a6ec865249b046e65275e07
Reviewed-on: https://chromium-review.googlesource.com/769234
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519498}

//ios/web_view has unittests for autofill which use TestWebState.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If6abe86f6bfb7bb3ab718aa1d5cc4e8fb180812a
Reviewed-on: https://chromium-review.googlesource.com/791816Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519497}

Using wpt-import in Chromium 87a4dbb1.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6423

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=rbyers

No-Export: true
Change-Id: I1fe90dda18eda2775a5eac729db7bb35165c2b39
Reviewed-on: https://chromium-review.googlesource.com/792070
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519496}

In various [d-z]* directories.

Change-Id: Ia434e9935a4c03a710f58627fd470de309f91f3e
Reviewed-on: https://chromium-review.googlesource.com/786532Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519495}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a6639fb9..5784f65c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I5ef4fc23a864000d3b54702ede806495d8287340
Reviewed-on: https://chromium-review.googlesource.com/792211Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519494}

gfx: :Point(gfx_rect.x(), gfx_rect.y()) is the same as gfx_rect.origin().
Change-Id: I092ce75a52a9dc73b303396398963091af8b265d
Reviewed-on: https://chromium-review.googlesource.com/784394Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519493}

This is a follow up to the first CL that enables TrustedWebActivities.

- Adds an OriginVerifier on Activity level and falls back to showing the
toolbar if verification fails.

- Moves the WebApk side offline dialog handling in the splashscreen
controller to WebappSplashScreenController, plumbing through the app
package name and using the tab's Activity to show. This way both
TrustedWebActivity and WebAPK's could use it.

BUG= 782905

Change-Id: I9314ac846cdf237ecc1a3d0104e18d967285017e
Reviewed-on: https://chromium-review.googlesource.com/773482
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519492}

Currently Launcher dismiss animation is using SetBounds, which will call
SetBoundsFromAnimation on each OnProgress. This will generate additional
overhead with a whole commit every frame. This cl converts it to use
ThreadedTransformTransition, which will let compositor optimize and
accelerate the animation.

Eve with DCHECK build, improved average smoothness from 84% to 99%.

Bug: 788928
Test: 
Change-Id: I10a3fcb8c2895d71bf262b30c72b9f67fd0634ea
Reviewed-on: https://chromium-review.googlesource.com/792001Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519491}

NPAPI plugin support has been removed from chrome and the "plugins" extension
manifest key is effectively deprecated. This CL deprecates the internal plugin
permission, which an extension gets on non ChromeOS platforms, when it specifes
plugins in its manifest. This is safe since r518752 should ensure that we are
not using the plugins specified in the manifest. Also the concept of
"implies_full_access" for API permissions is removed.

Behavior changes this introduces:
- On non ChromeOS platforms, extensions which specify plugins in their manifest
  would no longer get the IDS_EXTENSION_PROMPT_WARNING_FULL_ACCESS permission
  message.
- Since the plugins permisison is deprecated, it is no longer considered while
  determining if an extension's priveleges have increased.

BUG=732590

Change-Id: Ic9c8c1c27815cafff18c792da887aec9066eb655
Reviewed-on: https://chromium-review.googlesource.com/784557
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519490}

Tests were dependent upon this accessibility ID, but no longer are,
so now removing the ID.

Bug: 695077
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I603bf02322717dc0ef210b04208689ad4d375ced
Reviewed-on: https://chromium-review.googlesource.com/791892Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519489}

Test video:
https://drive.google.com/file/d/1oUUkOqj5EJU9XiXUp9fz1FxC6S6knNqW/view?usp=sharing

Bug: 785309
Change-Id: I14f7ae6b879bea7f805d7a9de8320231447e9a81
Reviewed-on: https://chromium-review.googlesource.com/788250
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519488}

Registry keys removed or changed by the cleaner will be shown to the
user on the Settings page card and need to be provided by the cleaner
via the Mojo IPC. Those keys are only used for visualization (no
validation will be done by Chrome) and we don't intend to add any
sophisticated visualization support (such as expandable trees); because
of that, we decided to go with the simplest approach and only transmit
lists of strings instead of more structured data.

This CL only propagates registry keys to the places they may be used,
so most files in this CL are simply adding a new parameter to
functions. A follow-up CL will actually use the new parameter in UI
code.

Bug: 776538
Change-Id: Ifd9faf79eea070d17452356c45ae37482bf77864
Reviewed-on: https://chromium-review.googlesource.com/780287
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519487}

This avoids crash on unexpected null TotalPropertyTreeStateForContents()
in https://chromium-review.googlesource.com/c/chromium/src/+/786130
for SPv175/non-RootLayerScrolling. This is separated from that CL which
is a pure SPv175 refactor.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5ad8db400838f4e9a5a5f87847e62858c6460759
Reviewed-on: https://chromium-review.googlesource.com/791935
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519486}

This way, if one of the CHECK_PAGE_IN_CORE fails, we get a more accurate message
with a useful line number, and not just a line number within the (now removed)
local function CheckPageInCore.

Also fixed the way mincore is used. According to mincore's documentation:

int mincore(void *addr, size_t length, unsigned char *vec);

The vec argument must point to an array containing at least (length+PAGE_SIZE-1)
/ PAGE_SIZE bytes. On return, the least significant bit of each byte will be set
if the corresponding page is currently resident in memory, and be clear
otherwise. The settings of the other bits in each byte are undefined; these bits
are reserved for possible later use.

Change-Id: I47f11e896a21944033314a84c6775d3d2ff70a24
Bug: 788240
Reviewed-on: https://chromium-review.googlesource.com/788473
Commit-Queue: François Degros <fdegros@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519485}

https://chromium.googlesource.com/webm/libvpx.git/+log/ea14a1a965c5..cbe62b9c2d2b

$ git log ea14a1a96..cbe62b9c2 --date=short --no-merges --format='%ad %ae %s'
2017-11-21 marpan vp9-svc: Fix to the layer buffer settings.
2017-11-20 vtsyrklevich [CFI] Remove function pointer casts
2017-11-20 jianj vp8 simulcast: fix compile warnings.
2017-11-17 marpan vp9-svc: Enbale scale partition reference frames.
2017-11-17 jianj vp9 svc: fix a few compile warnings.
2017-11-17 kylesiefring Optimize AVX2 get16x16var and get32x16var functions
2017-11-16 paulwilkins Disable allow_partition_search_skip for speed 2.
2017-11-15 paulwilkins Code cleanup.
2017-11-15 paulwilkins Remove decay_accumulator clause from alt ref breakout.
2017-11-15 paulwilkins Add clause to alt ref group breakout.

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Bug: 
Change-Id: Ie6724cbc3e03f47bf6151e60029bf954d958018d
Reviewed-on: https://chromium-review.googlesource.com/792112Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#519484}

This reverts commit ba355778.

Reason for revert: This change causes QUIC to be marked as broken if it happens ip change happens during a handshake, which may be causing QUIC usage to go down.

Original change's description:
> Default enables option to close QUIC sessions on an IP address change,
> when QUIC connection migration is not enabled.
> 
> Bug: 544156
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
> Change-Id: I6440c4833e798b61d2d83dcef2f1bf24869719be
> Reviewed-on: https://chromium-review.googlesource.com/655767
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Commit-Queue: Jana Iyengar <jri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503577}

TBR=pauljensen@chromium.org,rch@chromium.org,jri@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 544156
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I619b6201d33cd4f97bb8be8f1674e319fa9196fe
Reviewed-on: https://chromium-review.googlesource.com/759356
Commit-Queue: Jana Iyengar <jri@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Jana Iyengar <jri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519483}

The autorelease pool released the mock objects so that nothing was actually being tested.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I90c575bd82e6662d264c377b7d30a23cfc100e90
Reviewed-on: https://chromium-review.googlesource.com/792006Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519482}

TBR=hans

Change-Id: Ib55a96609180af705988496d879cf525804e78bc
Reviewed-on: https://chromium-review.googlesource.com/792336Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519481}

Following up from https://codereview.chromium.org/2905733003/
Replace with DLOG(INFO) instead.

BUG=638849

Change-Id: I773fba7a2b0c09d5e55e645096eb3c3cad698324
Reviewed-on: https://chromium-review.googlesource.com/678056Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com>
Cr-Commit-Position: refs/heads/master@{#519480}

Reason for reversion
  https://bugs.chromium.org/p/chromium/issues/detail?id=788778

The functionality isn't required -- yet -- and breaks some tests. Try
to get the tests working again.

Bug: 788778
Change-Id: I1caea69411c3210409b66e083c10221bb3244881
Reviewed-on: https://chromium-review.googlesource.com/790933
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519479}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/46a672bafa21..77ce4bdc7d9c

$ git log 46a672baf..77ce4bdc7 --date=short --no-merges --format='%ad %ae %s'
2017-11-27 tandrii gclient on bots: don't cleanup lock files.
2017-11-27 myjang [depot_tools] Fix timestamp issues related to local auth

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I07dc7dae1b42b3102ab5ec2eeb60966a5661fa26
Reviewed-on: https://chromium-review.googlesource.com/791939Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519478}

In CompositedLayerMapping::UpdateShouldFlattenTransform() we apply
different values on the same layer multiple times for different layer
configuration. This resulted in unnecessary redraw in the compositor.

This CL collapsed the logic so that each layer will be programmed
exactly one time.

BUG=783614

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id2551e6e49d2555359da9d954b44555cb1f41a63
Reviewed-on: https://chromium-review.googlesource.com/780803
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519477}

Its possible for the PaintImage for a BitmapImage to be null, if the
decode failed for instance. Don't create a StaticBitmapImage with this
null PaintImage in these cases.

R=pdr@chromium.org

Bug: 787708
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaa5378e0ccd533f2140db295d1af1b52c37c75e1
Reviewed-on: https://chromium-review.googlesource.com/791852Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519476}

This should help with EarlyPageScriptPerfTest.BareWebViewInjection
failure debugging.

Bug: 788116
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7d983d9335b800fa0d576322f7bd3f811107ce3e
Reviewed-on: https://chromium-review.googlesource.com/790631Reviewed-by: Menglu Huang <huangml@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519475}

Undistributed shadow DOM v0 light tree nodes don't seem to enforce
style calculation.

Prior to https://chromium-review.googlesource.com/c/chromium/src/+/767708,
this condition was being caught by checking for null style.

Add back the style check to handle this case gracefully.

BUG=788206

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I859a78206ca61fa58a6f24c6afd84b98004ed757
Reviewed-on: https://chromium-review.googlesource.com/791213Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519474}

Also, just use the kPropProbably expectation which already sets
this up correctly.

BUG=787514
TEST=none

Change-Id: I44f16049ac94f574f272a2e4d9a1061c24181b59
Reviewed-on: https://chromium-review.googlesource.com/792097Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519473}

In order to maximize parallelism, we immediately update a parent's
SurfaceLayer when a synchronization event happens (e.g. Resize).
However, the Chrome renderer throttles itself (for good reason), and
will not always accept resize requests. For example, suppose the
following sequence of resizes is issued:

300x300, 400x400, 500x500.

Suppose the renderer is busy with 300x300 when 400x400 is requested. The
request will not be sent to the renderer until it ACKs the previous
resize, 300x300. By the time the 300x300 resize is ACKed, the requested
size is now 500x500 and so the renderer picks up that request
(RenderWidgetHostImpl::WasResized) and processes the 500x500 request.
Thus, the 400x400 request will never complete.

However, the parent layer compositor may submit a CompositorFrame
depending on 400x400 which will cause Viz to block that frame for the
full duration until a deadline fires. This is perceived by the user as
jank. The higher the deadline, the more the jank. This CL addresses the
jank by immediately dropping the dependency in Viz once Viz knows the
intermediate dependency will never arrive.

Each resize corresponds to a new LocalSurfaceId allocation. Now that
LocalSuraceId allocations are monotonically increasing, Viz can detect
when a CompositorFrame arrives for a Surface *newer* than the one a
parent is blocking on and immediately remove that dependency. At
aggregation time, the latest in-flight surface *older* than the
unresolved activation dependency will be used. Thus, gutter will be
seen for a frame, but it should be very minor.

Bug: 672962
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ida7bde8881ced8d10d1154bea48696ee7db11923
Reviewed-on: https://chromium-review.googlesource.com/789420
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519472}

Made windows-only typemap for LOGFONT using the existing
IPC ParamTraits.

The next CL will remove child_process_messages.h

Bug: 775817
Change-Id: Id42bf3df88ab067e1bc440757a70e6821e4f40e8
Reviewed-on: https://chromium-review.googlesource.com/783912
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519471}

Bug: 622897
Change-Id: I1f19ad0b63a0cf864cde12ceed79e54bb4d1d164
Reviewed-on: https://chromium-review.googlesource.com/780805
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519470}

OnNotificationUpdated could have a notification removed while
iterating through |blocked|. Move the iteration lock up to
protect the |blocked| iteration to fix the UAF.

And fix a remnant naming in notification_list.h.

Bug: 788078
Change-Id: Ic6e73fb35682def871f527806b2dee66700f576b
Reviewed-on: https://chromium-review.googlesource.com/792011Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519469}

Bug: 
Change-Id: I9a6474effacd48e3f4e4230b61960b691335d99b
Reviewed-on: https://chromium-review.googlesource.com/792118
Commit-Queue: Andrew Whalley <awhalley@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519468}

This histogram will be used to gather active use of
chrome.app.window.create with type = panel.

Bug: 788033
Change-Id: I7a5703567a18b550275cf12a4b574141c53ff42e
Reviewed-on: https://chromium-review.googlesource.com/786785Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519467}

is smaller than the minimum bounds.

Bug: 787150
Change-Id: Ib4596276467a62f8b25c192dece808079460b808
Reviewed-on: https://chromium-review.googlesource.com/780660
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519466}

Enabling the feature by default so that TOT builds will have it enabled as well.
The feature is already enabled for all official builds via Finch.

Bug: 684642
Change-Id: Ieff6b68115b19bacb655a3a1a63b0311bc9fe79d
Reviewed-on: https://chromium-review.googlesource.com/792035Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519465}

Revert commit a62756b1 and reland
3294249d with fix.

Original CL description:

- DIR_COMPONENT_WIDEVINE_CDM is not used anymore.
- Update WidevineCdmComponentInstallerPolicy::GetRelativeInstallDir()
  to use kWidevineCdmBaseDirectory instead of hardcoded string.

TBR=waffles@chromium.org,thestig@chromium.org

Change-Id: I802a9575076e4f93e9ac302d40197117108de4d6
Reviewed-on: https://chromium-review.googlesource.com/791934Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519464}

This CL adds the throttling logic for navigation interception with Network service enabled.
This matches the same logic used by DownloadResourceThrottle.
It will prompt user for storage permission, and limiting the number of download requests per tab.

BUG=715630

Change-Id: I88ad091972739e204ebf9b9720589bc10779eed4
Reviewed-on: https://chromium-review.googlesource.com/773483
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519463}

This should be the final CL for moving to nullptr in WebKit/Source/*

I followed the instructions to run clang tidy at
https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md.

I then ran the modernize-use-nullptr check on WebKit/Source/modules using the
following command:

$LLVM_HOME/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
-p ../.. \
-clang-tidy-binary $LLVM_BUILD/bin/clang-tidy \
-clang-apply-replacements-binary $LLVM_BUILD/bin/clang-apply-replacements \
-checks=-*,modernize-use-nullptr \
-header-filter=third_party/WebKit/Source/* \
-fix \
third_party/WebKit/Source

Then ran "git cl format" on the result.

Bug: 778942
Change-Id: I31f0cba131523034a7811bf46f8ef68110d11a3f
Reviewed-on: https://chromium-review.googlesource.com/791410Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519462}