- 21 Apr, 2020 40 commits
-
-
John Smith authored
This creates the initial set and additionally partially fixes an issue where the NativeThemeRedirectedEquivalenceTest.NativeUiGetSystemColor tests weren't doing the correct thing around the Mac system overrides. On light mode, anything overridden wasn't actually getting to the color pipeline code because of the other returns. In dark mode, the check intended for checking if you were in an incognito window was passing and pushing the code through NativeTheme::GetSystem color without getting the overrides in either mode. This is only a partial fix because there is a broader issue with how the Mac handles light/dark with the NSAppearance. This gets applied at the app or window level so anything that gets a named NSColor actually is still getting a color based on that NSAppearance, not the passed in ColorScheme. This is a bigger architectural question on how/if it can be resolved which will need to be done in a later change. This also moves NSSystemColorToSkColor to skia_utils_mac so it can be used by both the old and new color systems without code duplication. Bug: 1003612 Change-Id: Ifb5166166dafda83f0a97fbb1c2a3b407927b68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147925 Commit-Queue: John Smith <johnsm@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#761148}
-
Stephen McGruer authored
The removals were generated by stripping 'external/wpt' from the start of each entry, then running 'ls' for the file or directory from the root of a fresh WPT checkout. Cases where ls failed were then removed. Bug: None Change-Id: I4bd605f105da5cb3bcf87f2d653e7a530124419a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159623Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#761147}
-
Ryan Sturm authored
Since protocols can only be added via script, this behavior can't occur during NoStatePrefetch. Using the inherited functionality is also safe, since it is a no-op. Bug: 1038068 Change-Id: Ie633f94580ae5618fe42b7b017592d3a284071e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158407 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#761146}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d304d90ecc17..b599fb88f59e git log d304d90ecc17..b599fb88f59e --date=short --first-parent --format='%ad %ae %s' 2020-04-21 thakis@chromium.org Disable a warning in generated code. Created with: gclient setdep -r src/native_client@b599fb88f59e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066980 Tbr: mseaborn@chromium.org Change-Id: Ifb9b13ade3992e76605c2b3071289acc38ef7612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159827Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761145}
-
Stephen McGruer authored
Bug: None Change-Id: Ie8254ad39fc5c97fb5d9cf3c009e175304c1d294 TBR=chrishtr@chromium.org Change-Id: Ie8254ad39fc5c97fb5d9cf3c009e175304c1d294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159617Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#761144}
-
Dongheun Kang authored
Bug: None Change-Id: I39f6341e4deecb17ee137674f2548f2151ec6cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154353Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#761143}
-
rbpotter authored
Note: Also deleting closure target for safety_check_page Polymer 2, as it relies on a Polymer 2 target from autofill_page that no longer exists. Will check in safety_check_page/ in a follow up. Bug: 1069258 Change-Id: I323003062e10deb207ecd11d7a430de838dff5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158166 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#761142}
-
Kevin McNee authored
When a portal contents is activated, we swap it with its predecessor, so to the user it appears that the tab has navigated. However, we did not notify the history service about this, so the page the user is now viewing does not appear in chrome://history/. Now upon portal activation, we have the history service add a page visit for the portal's last committed entry. Bug: 944198 Change-Id: Iebb0c66a2afddefc5172c84158ea2d01511c8309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080832 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#761141}
-
Bailey Berro authored
This change introduces a new ash::features to enable indicators when a user has difficulty moving their mouse between displays and when a user moves displays around in display layouts. Continuation of CL: crrev.com/c/2145792 Bug: 1070122 Change-Id: I85c52c42abc03f96600efa3877a758ef0d1cf853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158033Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#761140}
-
rajendrant authored
Fixed: 1034802 Change-Id: I57945f21f93cc6d3ec2dbedead340104f0775f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159768Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#761139}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05c794377143..79e315d604ba Created with: gclient setdep -r src-internal@79e315d604ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com,pmarko@google.com,ellyjones@google.com,collinbaker@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071977 Tbr: rakina@google.com,pmarko@google.com,ellyjones@google.com,collinbaker@google.com Change-Id: I2b0f1a5d34de70648802f1acda390af5363b212b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159282Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761138}
-
Andrei Salavei authored
Fix typo in |IdentityManager::HasPrimaryAccount| method comment Change-Id: Id773ea65383ce6bfb6727d35ce0b65980321979f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157050Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Andrei Salavei <solovey@google.com> Cr-Commit-Position: refs/heads/master@{#761137}
-
Aaron Colwell authored
This change prevents a CHECK fail caused by renderer debug URLs making their way deep into the navigation code and triggering a process lock mismatch. There are several DCHECKs that indicate these types of URLs should not make it into NavigationRequest code or lower layers, but these are not enforced in release builds. This change adds a renderer debug URL check to the set of other checks that run after the view-source: URL rewriting logic has run. This prevents the navigation from proceeding and prevents the URLs from getting down into the lower levels of the navigation code. Bug: 1070543 Change-Id: I6f2b54730164ae299c74bd80b77e9dbc15a87ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157604Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#761136}
-
Trevor Perrier authored
This CL adds the sr-Latn translations to resource packs for Android bundle builds. The sr-Latn translations were added in [1]. This CL introduces a small binary size increase from adding a new locale. The SuperSize diff tool reports an increase or 10.68KB in resources.arsc. [1] https://crrev.com/c/2121076 Binary-Size: Size increase is unavoidable (see above). Bug: 1053811 Change-Id: I5a04ff69ade3818ee8ce6c84dd1760c985c1de1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132600Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#761135}
-
Peng Huang authored
Make the interface to accept null UnsafeSharedMemoryRegion since both client and server sides can handle it. Bug: 1071826 Change-Id: I649a6467b447477f09d8936d1424c07e7adfb495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159417 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#761134}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/fee2783cb0b7..f204cf2c4fde git log fee2783cb0b7..f204cf2c4fde --date=short --first-parent --format='%ad %ae %s' 2020-04-21 rafael.cintron@microsoft.com Add Ref<T> specialization for Result Created with: gclient setdep -r src/third_party/dawn@f204cf2c4fde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia1db679c8a77aaba5a4cedf98ed0985432c73d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159269Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761133}
-
Scott Little authored
The flags that control native lazy loading behavior are still useful for easily testing how a site works with vs. without lazy loading, so this CL extends the expiry milestones of these flags. Change-Id: Ic6b23ca568028cb71dfbfa3e2f34737dfda91f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159532Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Auto-Submit: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#761132}
-
danakj authored
When a frame accesses window.testRunner and a task is posted, it used to go to the local main frame to get a TaskRunner, through BlinkTestRunner. If there was no local main frame, it would fall back to a global object. This makes for inconsistent behaviour in a frame in the same tree as the local main frame vs a frame outside (an OOPIF). We pass WebLocalFrame as needed to use the task runner for each specific frame. The SpellCheckClient needs to be passed to the TestRunnerBindings, which are installed from WebFrameTestClient (previously via WebViewTestProxy). But it also needs to be set on the WebLocalFrame as a pointer, which was being done in WebTestRenderFrameObserver. These two objects live far apart from each other. Thus we move ownership of SpellCheckClient to a per-frame location on WebFrameTestClient, and pass it to TestRunnerBindings directly from there. The PostTask methods and GetTaskRunner on BlinkTestRunner can be removed and all callers are changed to use their local frame, with one exception. The TestRunner itself needs to post tasks and it is not associated with a frame, so it uses the global TaskRunner unconditionally. The spellcheck tests were relying on the testRunner's spell checker to be a global object within the process. This meant that you could not write a spellcheck test with OOPIFs. We modify the JS harness to install the test spell checker on the inner frame, and postmessage from the inner frame out to the test harness to make progress. The execCommand() still requires the test frame to be in process but this detaches the SpellCheckClient from the main frame process requirement. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I326e2b830362ced3aabe555c0a07215aaa27ecfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159143 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#761131}
-
David Bertoni authored
The ExecuteScriptApiTest.NavigationRaceExecuteScript was disabled long ago on Windows. It should only have been disabled for Debug builds, rather than all configurations. The related bug indicates these tests should now be enabled. Bug: 177163 Change-Id: Icd3aace4da8627ccc72787e57a36131b7264b603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158981Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#761130}
-
Kurt Horimoto authored
The previous implementation returned whether or not the active request was set to a non-null value. However, this is not always correct because there is a brief period between the overlay UI's dismissal and the resetting of OverlayPresentationContextImpl state during which the request is non-null, but its overlay UI is dismissed. This caused breakage for queued OverlayRequests, as OverlayPresenterImpl only attempted to present UI for a subsequent request if the context returned false from this function. Since the context reported that it was still showing overlay UI, the next request was not presented and the context cleaned its state up by resetting its presentation capabilities to kNone. If the prior request required UIViewController presentation, this resulted in the dismissal of the presentation context view controller. When the OverlayPresenterImpl is notified of the updated kNone presentation capabilities, it then attempted to present the next request. If the next request also required UIViewController presentation, this attempted to re-present the presentation context view controller and this presentation would no- op since the previous view controller was not finished being dismissed. This CL updates IsShowingOverlayUI() to return false if the dismissal callback for the active request has already been executed, which prevents the early return in OverlayPresenterImpl's PresentOverlayForActiveRequest(). As an implementation detail, this CL updates GetRequestUIState() to use const std::map APIs so that it can be called from IsShowingOverlayUI(), which is also const. Bug: none Change-Id: Id3b519f6129838f78d3fdcf0d65436ee4bf74cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159689Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#761129}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ff772a7bcc98..ceb6258ae101 git log ff772a7bcc98..ceb6258ae101 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 amaiorano@google.com CMake: fix astc code not being enabled correctly Created with: gclient setdep -r src/third_party/swiftshader@ceb6258ae101 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib6d74cde9f454a21c14fb7e02c7ba3f1c7196edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761128}
-
Elly Fong-Jones authored
Bug: 1071877 Change-Id: I3b56e8d59a5383d599105c3d80595222093af460 Tbr: jdonnelly@chromium.org Cc: ender@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159538Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#761127}
-
Toby Huang authored
If an extensions developer pushes an update that requires additional permissions, and the extension was previously approved by the parent, and the parent has set the "Permissions for sites, apps and extensions" toggle to on, then the supervised user should be able to approve the additional permissions and re-enable the extension by themselves without parent approval. Currently, supervised users are not able to accept extension updates requiring additional permissions at all. This CL fixes that behavior. Bug: 1068660,1070760 Change-Id: Icc6af9a8a05f3782a12c2f4e001d7d6470cacefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140596 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#761126}
-
Ana Salazar authored
The new feature will enable the new app dragging functionality in the launcher. When the user drags an app within the launcher, the apps grid pages will be scaled down to 84% and will show a background card to show them in a more modular way. Bug: 996822 Change-Id: I993693f7ada613760384c981792b57e08ac8f3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159756Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#761125}
-
Bettina authored
This updates the InterstitialAction and PasswordAlertModeOutcome histograms. Bug: 1070243,1070260 Change-Id: I3ac38a9dab9c76c99ee997480c5eca5f498a3746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157684Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#761124}
-
Navid Zolghadr authored
pointerevents/touch-pointercancel.html test verifies the touch and pointer events interaction in single and multi touch point cases when scrolling happens or not. The single touch point portion is already tested as part of wpt/pointerevents/pointerevent_pointercancel_touch.html The two finger interaction is not very well specified and is tested as part of wpt/pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html and that only is missing the pointerid checks that this CL adds as well. Change-Id: I3ee27866dddc02cb87b1082b5a4fe2f9e8ba9220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159577Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#761123}
-
Oksana Zhuravlova authored
Since ReportValidationError() already logs the description from its |context| parameter, there is no need to pass the description separately. Test: temporarily triggered the deserialization error and confirmed the error message has only one instance of interface name and method number Change-Id: I813052bbaf4485d1fd269174b3a645535f548c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157721 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#761122}
-
David Grogan authored
An item that stretches to a flexbox's previously-indefinite height should use cached results when its sibling item changes the flexbox's height. NG is slower than legacy but there's a fix at https://chromium-review.googlesource.com/c/chromium/src/+/2154489 Bug: 845235 Change-Id: I4687742c20cae6aaa97bf34933c458f4308b8837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158490Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#761121}
-
Eugene But authored
This CL extends expiration dates for the following histograms, which are still useful: - Download.IOSPresentAddPassesDialogResult - Download.IOSDownloadReplaced Bug: 1072568 Change-Id: I5341bf921aa65004d6462221ae2398d48b15a17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157898 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#761120}
-
Dominic Mazzoni authored
This change moves some of the code from BlinkAXTreeSource::SerializeNode to AXObject::Serialize. That will allow us to get rid of a lot of interfaces in WebAXObject. Bug: 1068668 Change-Id: Ic4b9a81ea4b79e25119ac7582429476971606103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140593 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#761119}
-
Robert Ogden authored
Allows the connection listener to take ownership of a connection's socket once a response has finished being written. This is being exposed to allow the EmbeddedTestServer to act as a CONNECT proxy tunnel for testing the IsolatedPrerender feature (see chained CL). Bug: 1067300 Change-Id: I47d627262f96a50b09f90a82d140456a797901c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148038 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#761118}
-
Sean Gilhuly authored
Change-Id: I4dfa1a776b17d767708d893fc2c18be9b21ce3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159367Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#761117}
-
Jeroen Dhollander authored
This code was meant to handle volume related queries in ChromeOS, but these queries are actually handled inside LibAssistant. The code I removed expects to handles of the volume through a |device.MODIFY_SETTING| request. Instead, LibAssistant gets a |device.UPDATE_VOLUME| request which it handles here: https://cs.corp.google.com/libassistant/libassistant/internal/assistant/action/device/device_control_module.cc?type=cs&q=libassistant/internal/assistant/action/device/device_control_module.cc+package:%5Elibassistant$&g=0&l=339 After discussing this with the Assistant Device Actions team, I learned that the server can either send device.MODIFY_SETTING or device.UPDATE_VOLUME, based on the client preference. Given that LibAssistant expresses a preference for device.UPDATE_VOLUME, we can safely assume we will never receive a device.MODIFY_SETTING request. Test: queries "increase volume", "set volume to 20%", "increase volume by 5". Bug: b/154040671 Change-Id: I763f4d1d1ace0924f81faf7f33eb7cc364e99d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157585 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#761116}
-
Joshua Pawlicki authored
This callback can be called more than once, for example once for a differential update and then (if that fails) again for a full update. Bug: 1071475 Change-Id: I6d5ebce996aa13ece5b5d1d088eb1a9fff31d2c0 Fixed: 1071475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159534 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#761115}
-
Oystein Eftevaag authored
These calls were already being done in ChromeMainDelegate::BasicStartupComplete() resulting in the Renderer/GPU main threads to be sampled twice. R=avi@chromium.org Bug: 1067416 Change-Id: I5e7f57989fde11224c905f092483185ab5be54e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154402Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#761114}
-
Nasko Oskov authored
This test was disabled on some bots due to flakiness. I am updating the test to explicitly wait for process crash, which will likely eliminate the source of flakiness and updating some of the code to take advantage of newer test methods instead of using base::StringPrintf. Bug: 974787 Change-Id: I68182c88905f187b972d93da3504e701a82b96d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159318Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#761113}
-
chrome://flagsKatie D authored
This will help us test the feature in Canary! Bug: 1055150 Change-Id: I02a5deb241dfd26ddf4dc58a84f04a79b1c3d227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158008Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#761112}
-
Dana Fried authored
Much more reliable capture based on a state machine. Now thumbnail capture walks through the following steps: - Navigating to new page - Navigation complete - Capture requested - Frame capture - Cooldown* - Capture complete** * Cooldown allows us to continue capturing for a short period of time after a page indicates it's loaded; this gives the renderer time to actually draw the final version of the page ** Once we've captured a background page, there's no further need to try to capture it again unless it navigates, or the user makes it active, interacts, and then leaves again (a case we handle separately). Typically these states move forward. However, there are potential issues with trying to frame capture a visible/active tab, so we pause video capture while a page is active and then return to capturing it after the user switches away. Since we do not show preview images for the current tab in desktop mode, it's not a problem. For tablet mode (Mohnstrudel), if the tabstrip is observing the thumbnail image for the current tab, the tab will be captured. This complex behavior of stepping forward and backwards based on whether a tab is visible, being observed, etc. is all handled by ThumbnailTabHelper::ThumbnailTabHelperState::UpdateCaptureState(). Still to do: - Create a queue of thumbnails to be captured that prioritizes thumbnails for pages that are being or have recently been observed, to actively limit the number of thumbnails we are trying to observe at once in order to save memory. In-flight thumbnails are uncompressed, which can have a significant impact on RAM usage. Bug: 1057713, 1059862, 1068459 Fixes: 1068459 Change-Id: If81798c0d3df26a5c309e834483042a5b5f24857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145161 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#761111}
-
Collin Baker authored
TBR=ellyjones@chromium.org Bug: 956191 Change-Id: I335e377a40aa937917f95a799e6609c0b2489afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159422Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#761110}
-
Brandon Wylie authored
Change-Id: I4c02e2326922ff76fdbc3a4a9a4dcd053bcf0e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158930Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#761109}
-